On Friday, March 15, 2013 12:52 AM Tom Lane wrote:
> I wrote:
> > ... So I think this patch is missing a bet by not
> > accepting equal() expressions.
>
> I've committed this with that logic, a comment explaining exactly why
> this is the way to do it, and some other cosmetic improvements.
Thank
On Thursday, March 14, 2013 8:35 PM Tom Lane wrote:
> I'm starting to review this patch now, and I'm having a hard time with
> this particular design decision:
>
> Amit Kapila writes:
> > We cannot directly compare expressions in target list as even if
> expressions
> > are equal, below node (ex.
On Mon, Mar 11, 2013 at 3:06 PM, Tom Lane wrote:
> Greg Stark writes:
>> It feels a bit like unpredictable magic to have "DEFAULT" mean one
>> thing and omitted columns mean something else.
>
> Agreed. The current code behaves that way, but I think that's
> indisputably a bug not behavior we wan
Daniel Farina writes:
> On Tue, Mar 12, 2013 at 11:51 AM, Tom Lane wrote:
>> Yeah, watching the remote side's datestyle and intervalstyle and
>> matching them (for both input and output) would probably work.
> Alright, so I've been whacking at this and there's one interesting
> thing to ask abou
Kyotaro HORIGUCHI writes:
> [ format-width-20130305.patch ]
Applied with some mostly-cosmetic adjustments. I also took the liberty
of changing some of the error message texts to line up more closely
with the expanded documentation (eg, use "format specifier" not
"conversion specifier" because th
Hi,
When trying to *promote* a slave as master by removing recovery.conf and
restarting node, I found an assertion failure on master branch:
LOG: database system was shut down in recovery at 2013-03-15 10:22:27 JST
TRAP: FailedAssertion("!(ControlFile->minRecoveryPointTLI != 1)", File:
"xlog.c",
On 03/13/2013 04:16 PM, Dimitri Fontaine wrote:
> Joe Conway writes:
>> I think it should dump the user data portion, especially since that
>> matches what pg_dump would do if you did not specify the table or schema.
>
> +1
>
> If you don't have time slots to fix that by then, I will have a look
2013-03-13 21:28 keltezéssel, Boszormenyi Zoltan írta:
2013-03-13 13:45 keltezéssel, Andres Freund írta:
On 2013-03-13 09:09:24 +0100, Boszormenyi Zoltan wrote:
2013-03-13 07:42 keltezéssel, Craig Ringer írta:
On 03/12/2013 06:27 AM, Craig Ringer wrote:
Think also about the case where someone
On Tue, Mar 12, 2013 at 11:51 AM, Tom Lane wrote:
> Daniel Farina writes:
>> Okay, I see. So inverting the thinking I wrote earlier: how about
>> hearkening carefully to any ParameterStatus messages on the local side
>> before entering the inner loop of dblink.c:materializeResult as to set
>> th
On 14 March 2013 20:32, Josh Berkus wrote:
>
>> But I don't really want to disallow chains of foreign tables, so it's
>> hard to see how to prevent it without breaking possibly-useful cases.
>
> As long as we can prevent such a loop from crashing Postgres.
It won't, or at least it really shouldn'
> But I don't really want to disallow chains of foreign tables, so it's
> hard to see how to prevent it without breaking possibly-useful cases.
As long as we can prevent such a loop from crashing Postgres.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
--
Sent via pgsql-hackers m
I wrote:
> ... So I think this patch is missing a bet by not
> accepting equal() expressions.
I've committed this with that logic, a comment explaining exactly why
this is the way to do it, and some other cosmetic improvements.
regards, tom lane
--
Sent via pgsql-hacker
Kevin Grittner wrote:
> Tom Lane wrote:
>
>> diff --git a/src/backend/rewrite/rewriteDefine.c
>> b/src/backend/rewrite/rewriteDefine.c
>> index
>> a1a9808e5d94959218b415ed34c46579c478c177..896326615753f2344b466eb180080174ddeda31d
>> 100644
>> *** a/src/backend/rewrite/rewriteDefine.c
>> --- b/s
Tom Lane wrote:
> "Erikjan Rijkers" writes:
>> With 9.3devel, I can't seem to join a matview to a view; surely
>> that should be allowed?
>
> Fixed, thanks for the report.
Thanks for the fix while I was away.
Regression test for this case added.
--
Kevin Grittner
EnterpriseDB: http://www.enter
On Wed, Jan 23, 2013 at 7:29 PM, Tom Lane wrote:
> Heikki Linnakangas writes:
> > On 23.01.2013 09:36, Alexander Korotkov wrote:
> >> On Wed, Jan 23, 2013 at 6:08 AM, Tom Lane wrote:
> >>> The biggest problem is that I really don't care for the idea of
> >>> contrib/pg_trgm being this cozy with
Heikki Linnakangas writes:
> I hear no objection, so committed. (after fixing some small bugs in the
> patch, and adding some comments)
Please keep psqlscan.l in sync with scan.l.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
On 13.03.2013 10:50, Simon Riggs wrote:
On 2 March 2013 18:47, Heikki Linnakangas wrote:
Interestingly, the yy_transition array generated by flex used to be much
smaller:
8.3: 22072 elements
8.4: 62623 elements
master: 64535 elements
The big jump between 8.3 and 8.4 was caused by introduction
I'm starting to review this patch now, and I'm having a hard time with
this particular design decision:
Amit Kapila writes:
> We cannot directly compare expressions in target list as even if expressions
> are equal, below node (ex. APPEND) will
> not do projection, and hence expr will not be eval
Thom Brown writes:
> Is there a way to ensure we don't end up with a foreign table feedback loop?
Yeah, I've run into that too :-(. I'm not sure how big a deal it is for
real-world use, but certainly the "loopback" server the postgres_fdw
regression test sets up is rather risky.
But I don't rea
Hi all,
Is there a way to ensure we don't end up with a foreign table feedback loop?
For example:
CREATE SERVER pgserver
FOREIGN DATA WRAPPER postgres_fdw
OPTIONS (dbname 'postgres');
-- note how I've forgotten to specify host or port
CREATE USER MAPPING FOR PUBLIC
SERVER pgserver;
CREA
On 01.03.2013 16:22, Alexander Korotkov wrote:
On Wed, Mar 13, 2013 at 11:10 PM, Heikki Linnakangas<
hlinnakan...@vmware.com> wrote:
On 01.03.2013 16:22, Alexander Korotkov wrote:
frac = area / (length2 - length1);
you can get NaN result. I've especially adjusted the code to get more of
le
On Wednesday, March 13, 2013 8:06 PM Andres Freund wrote:
> On 2013-03-13 18:52:48 +0530, Amit Kapila wrote:
> > On Wednesday, March 13, 2013 6:44 PM Andres Freund wrote:
> > > On 2013-03-13 18:38:12 +0530, Amit Kapila wrote:
> > > > On Wednesday, March 13, 2013 6:10 PM Andres Freund wrote:
> > > >
22 matches
Mail list logo
