Re: [HACKERS] Report search_path value back to the client.

2015-02-20 Thread Alexey Klyukin
it be possible to review it as a part of the current commitfest? Kind regards, -- Alexey Klyukin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-09-15 Thread Alexey Klyukin
behaviors, so sticking to RFC makes sense here Sincerely, -- Alexey Klyukin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-09-15 Thread Alexey Klyukin
On Mon, Sep 15, 2014 at 10:23 AM, Alexey Klyukin al...@hintbits.com wrote: On Fri, Sep 12, 2014 at 4:20 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Hmm. If that's what the browsers do, I think we should also err on the side of caution here. Ignoring the CN is highly unlikely

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-09-11 Thread Alexey Klyukin
On Mon, Sep 8, 2014 at 8:04 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 09/05/2014 07:30 PM, Alexey Klyukin wrote: The error does not state whether the names comes from the CN or from the SAN section. I'd reword that slightly, to: psql: server certificate for example.com

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-09-05 Thread Alexey Klyukin
, -- Alexey Klyukin diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/libpq/fe-secure-openssl.c new file mode 100644 index f950fc3..a4ad305 *** a/src/interfaces/libpq/fe-secure-openssl.c --- b/src/interfaces/libpq/fe-secure-openssl.c *** *** 60,68 --- 60,73 #ifdef

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-09-04 Thread Alexey Klyukin
names, that's what I've chosen to be the most consistent. Regards, -- Alexey Klyukin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Enable WAL archiving even in standby

2014-09-03 Thread Alexey Klyukin
things there? There was a single hunk when applying this against the latest master: Hunk #4 succeeded at 4789 (offset -1 lines). -- Regards, Alexey Klyukin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-09-01 Thread Alexey Klyukin
On Fri, Aug 29, 2014 at 11:22 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 08/28/2014 07:28 PM, Alexey Klyukin wrote: On Mon, Aug 25, 2014 at 12:02 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 08/24/2014 03:11 PM, Alexey Klyukin wrote: On Wed, Aug 20, 2014 at 11

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-09-01 Thread Alexey Klyukin
On Mon, Sep 1, 2014 at 10:39 AM, Alexey Klyukin al...@hintbits.com wrote: On Fri, Aug 29, 2014 at 11:22 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Yeah, I think a certificate without CN should be supported. See also RFC 6125, section 4.1. Rules [for issuers of certificates]: 5

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-08-28 Thread Alexey Klyukin
On Mon, Aug 25, 2014 at 12:02 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 08/24/2014 03:11 PM, Alexey Klyukin wrote: On Wed, Aug 20, 2014 at 11:53 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: The patch doesn't seem to support wildcards in alternative names

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-08-28 Thread Alexey Klyukin
at all, and let the SSL library vendor deal with the bugs and CVEs. Sounds reasonable. I guess we'll go ahead with this patch for now, but keep this in mind if someone wants to complicate the rules further in the future. +1 -- Regards, Alexey Klyukin

[HACKERS] re-reading SSL certificates during server reload

2014-08-27 Thread Alexey Klyukin
will be unable to restart, but this are the sort of problems that also happen with reload of pg_hba.conf as well, so these alone does not sound like a significant showstopper. -- Regards, Alexey Klyukin

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-08-24 Thread Alexey Klyukin
On Wed, Aug 20, 2014 at 11:53 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 07/25/2014 07:10 PM, Alexey Klyukin wrote: Greetings, I'd like to propose a patch for checking subject alternative names entry in the SSL certificate for DNS names during SSL authentication. Thanks

[HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Alexey Klyukin
and Mac clients). I don't have either Windows or old versions of OpenSSL, it's not tested against those systems. I'd appreciate your feedback. Sincerely, -- Alexey Klyukin diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c new file mode 100644 index 9ba3567..64eab27

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Alexey Klyukin
a match between the given dNSName and the name supplied by the client. Please add it to the next CF - this was just a very quick review, and it needs a proper one along with openssl version testing :) Done. Sincerely, -- Alexey Klyukin

Re: [HACKERS] Could not open file pg_multixact/offsets/ ERROR on 9.3.4

2014-06-05 Thread Alexey Klyukin
won't be there in the first place. Cheers, -- Alexey Klyukin

[HACKERS] Could not open file pg_multixact/offsets/ ERROR on 9.3.4

2014-06-04 Thread Alexey Klyukin
is a possibility)? Cheers, -- Alexey Klyukin

Re: [HACKERS] Wildcard usage enhancements in .pgpass

2013-11-17 Thread Alexey Klyukin
Hi Martijn, On Sun, Nov 17, 2013 at 7:56 PM, Martijn van Oosterhout klep...@svana.orgwrote: On Sat, Nov 16, 2013 at 09:26:33PM +0100, Alexey Klyukin wrote: Hi, Attached is the patch that improves usage of '*' wildcard in .pgpass, particularly in the host part. The use case is below

[HACKERS] Wildcard usage enhancements in .pgpass

2013-11-16 Thread Alexey Klyukin
is greatly appreciated. -- Regards, Alexey Klyukin diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c new file mode 100644 index 18fcb0c..003739f *** a/src/interfaces/libpq/fe-connect.c --- b/src/interfaces/libpq/fe-connect.c *** static int

Re: [HACKERS] Notes on implementing URI syntax for libpq

2011-11-24 Thread Alexey Klyukin
a nice way of handling non-default socket options. Another idea is to use local:/dir/name for UNIX domain socket instead of hostname:port, like it's displayed in the psql prompt. -- Alexey Klyukinhttp://www.commandprompt.com The PostgreSQL Company – Command Prompt, Inc. -- Sent via

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread Alexey Klyukin
? Looks good at first sight and passes all regression tests for me. -- Alexey Klyukinhttp://www.commandprompt.com The PostgreSQL Company – Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread Alexey Klyukin
? No objections here. -- Alexey Klyukinhttp://www.commandprompt.com The PostgreSQL Company – Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] ALTER TABLE ONLY ...DROP CONSTRAINT is broken in HEAD.

2011-09-12 Thread Alexey Klyukin
of the child table. It seems that the pg_constraint scan at ATExecDropConstraint (tablecmds.c:6751) is re-reading those tuples that were updated in the previous iterations of this scan, at least that's what I've observed in gdb. I'm not sure how to fix this yet. -- Alexey Klyukinhttp

Re: [HACKERS] REVIEW proposal: a validator for configuration files

2011-09-12 Thread Alexey Klyukin
on this level. I think exactly this argument has already been discussed earlier in this thread: http://archives.postgresql.org/message-id/21310d95-eb8d-4b15-a8bc-0f05505c6...@phlo.org -- Alexey Klyukinhttp://www.commandprompt.com The PostgreSQL Company – Command Prompt, Inc. -- Sent via

Re: [HACKERS] REVIEW proposal: a validator for configuration files

2011-09-10 Thread Alexey Klyukin
this by removing the first, verification call and final 'errors were detected' warning to avoid 'false positives' on that (i.e. the WARNING you saw with the previous version for the valid .conf). I'd appreciate your further comments and suggestions. Thank you. -- Alexey Klyukinhttp

Re: [HACKERS] REVIEW proposal: a validator for configuration files

2011-09-09 Thread Alexey Klyukin
emitted during reload even for a pristine configuration file right after the installation. I'm looking into why the server gets killed during reload if there is a parse error, it might be as well related to the problem above. -- Alexey Klyukinhttp://www.commandprompt.com The PostgreSQL

Re: [HACKERS] plperl crash with Debian 6 (64 bit), pl/perlu, libwww and https

2011-08-04 Thread Alexey Klyukin
On Aug 4, 2011, at 5:25 PM, Alvaro Herrera wrote: Excerpts from Hannu Krosing's message of jue ago 04 09:53:40 -0400 2011: On Thu, 2011-08-04 at 09:42 -0400, Andrew Dunstan wrote: On 08/04/2011 09:07 AM, Hannu Krosing wrote: I have been helping some people to debug a SIGALARM related

Re: [HACKERS] proposal: a validator for configuration files

2011-07-25 Thread Alexey Klyukin
On Jul 16, 2011, at 9:55 PM, Tom Lane wrote: I wrote: I think that it might be sensible to have the following behavior: 1. Parse the file, where parse means collect all the name = value pairs. Bail out if we find any syntax errors at that level of detail. (With this patch, we could

Re: [HACKERS] proposal: a validator for configuration files

2011-07-14 Thread Alexey Klyukin
On Jul 14, 2011, at 4:38 AM, Alvaro Herrera wrote: Excerpts from Florian Pflug's message of mié jul 13 20:12:28 -0400 2011: On Jul14, 2011, at 01:38 , Alvaro Herrera wrote: One strange thing here is that you could get two such messages; say if a file has 100 parse errors and there are also

Re: [HACKERS] storing TZ along timestamps

2011-07-06 Thread Alexey Klyukin
Hi, On May 27, 2011, at 11:43 PM, Alvaro Herrera wrote: One of our customers is interested in being able to store original timezone along with a certain timestamp. It is currently possible to store a TZ in a separate column, but this is a bit wasteful and not very convenient anyway.

Re: [HACKERS] proposal: a validator for configuration files

2011-06-21 Thread Alexey Klyukin
On Jun 20, 2011, at 6:22 PM, Florian Pflug wrote: On Jun20, 2011, at 17:02 , Alexey Klyukin wrote: I don't think it has changed at all. Previously, we did goto cleanup_list (or cleanup_exit in ParseConfigFp) right after the first error, no matter whether that was a postmaster or its child

Re: [HACKERS] Identifying no-op length coercions

2011-06-21 Thread Alexey Klyukin
Hi, On Jun 19, 2011, at 2:10 PM, Noah Misch wrote: On Sat, Jun 18, 2011 at 11:32:20PM -0400, Robert Haas wrote: On Sat, Jun 18, 2011 at 11:12 PM, Robert Haas robertmh...@gmail.com wrote: On Sat, Jun 18, 2011 at 11:06 PM, Noah Misch n...@leadboat.com wrote: On Sat, Jun 18, 2011 at 10:57:13PM

Re: [HACKERS] Identifying no-op length coercions

2011-06-21 Thread Alexey Klyukin
On Jun 21, 2011, at 9:58 PM, Noah Misch wrote: A pg_regress test needs stable output, so we would do it roughly like this: CREATE TEMP TABLE relstorage AS SELECT 0::regclass AS oldnode; ... UPDATE relstorage SET oldnode = (SELECT relfilenode FROM pg_class

Re: [HACKERS] proposal: a validator for configuration files

2011-06-20 Thread Alexey Klyukin
Florian, On Jun 18, 2011, at 5:40 PM, Florian Pflug wrote: On Jun16, 2011, at 22:34 , Alexey Klyukin wrote: Attached is the v2 of the patch to show all parse errors at postgresql.conf. Changes (per review and suggestions from Florian): - do not stop on the first error during postmaster's

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Alexey Klyukin
Florian, On Jun 16, 2011, at 2:34 PM, Florian Pflug wrote: Hi On May14, 2011, at 00:49 , Alexey Klyukin wrote: The patch forces the parser to report all errors (max 100) from the ProcessConfigFile/ParseConfigFp. Currently, only the first parse error or an invalid directive is reported

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Alexey Klyukin
On Jun 16, 2011, at 6:49 PM, Florian Pflug wrote: On Jun16, 2011, at 17:23 , Alexey Klyukin wrote: On Jun 16, 2011, at 2:34 PM, Florian Pflug wrote: The first problem I ran into when I tried to test this is that it *only* reports multiple errors during config file reload on SIHUP, not during

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Alexey Klyukin
On Jun 16, 2011, at 8:01 PM, Florian Pflug wrote: On Jun16, 2011, at 18:46 , Alexey Klyukin wrote: On Jun 16, 2011, at 6:49 PM, Florian Pflug wrote: Hm, wouldn't a test for context == PGC_POSTMASTER be more appropriate? In such a case the errors caused by command-line arguments won't stop

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Alexey Klyukin
Hi, On Jun 16, 2011, at 9:18 PM, Florian Pflug wrote: On Jun16, 2011, at 20:14 , Alexey Klyukin wrote: Well, while thinking about this I decided to leave the counter for the ParseConfigFp, but drop it in ProcessConfigFile. The case we are protecting against is a single file full

Re: [HACKERS] Operator families vs. casts

2011-06-10 Thread Alexey Klyukin
Noah, Providing my thoughts on the 'mundane' question first. On Tue, May 24, 2011 at 1:40 PM, Noah Misch n...@leadboat.com wrote: I also had a more mundane design question in the second paragraph of [2].  It can probably wait for the review of the next version of the patch.  However, given

Re: [HACKERS] Identifying no-op length coercions

2011-06-03 Thread Alexey Klyukin
Hi, On Jun 2, 2011, at 10:22 PM, Noah Misch wrote: Hi Alexey, ... Is your interest in cheap varchar(N)-varchar(N+M) conversions specifically, or in some broader application of this facility? Exactly varchar conversions. Thanks for volunteering to review; that will be a big help.

Re: [HACKERS] Estimating total amount of shared memory required by postmaster

2011-06-03 Thread Alexey Klyukin
On Jun 2, 2011, at 10:49 PM, Tom Lane wrote: Alexey Klyukin al...@commandprompt.com writes: We've recently come across the task of estimating the size of shared memory required for PostgreSQL to start. ... - Try to actually allocate the shared memory in a way postmaster does

Re: [HACKERS] Identifying no-op length coercions

2011-06-02 Thread Alexey Klyukin
out. Is there an agreement on the syntax and implementation part? We (CMD) have a customer, who is interested in pushing this through, so, if we have a patch, I'd be happy to assist in reviewing it. -- Alexey Klyukin The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers

[HACKERS] Estimating total amount of shared memory required by postmaster

2011-06-02 Thread Alexey Klyukin
Hello, We've recently come across the task of estimating the size of shared memory required for PostgreSQL to start. This comes from the problem of validating postgresql.conf files (http://archives.postgresql.org/pgsql-hackers/2011-03/msg01831.php), i.e. checking that the server will be able to

Re: [HACKERS] proposal: a validator for configuration files

2011-05-13 Thread Alexey Klyukin
Hi, On Apr 14, 2011, at 9:50 PM, Robert Haas wrote: On Mon, Apr 4, 2011 at 2:03 PM, Alexey Klyukin al...@commandprompt.com wrote: Here's the update of Selena's patch, which also shows all errors in configuration parameters (as well as parser errors) during reload. You should add

Re: [HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-13 Thread Alexey Klyukin
On May 13, 2011, at 2:07 AM, Alexey Klyukin wrote: On May 13, 2011, at 1:28 AM, Tom Lane wrote: We're not likely to do that, first because it's randomly different from the handling of every other system catalog update, and second because it would serialize all updates on this catalog

[HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Alexey Klyukin
the lock in question with ShareUpdateExclusiveLock, the problem disappeared. Attached is the simple patch with these changes. Regards, -- Alexey Klyukin The PostgreSQL Company - Command Prompt, Inc. db_role_setting.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Alexey Klyukin
On May 13, 2011, at 1:28 AM, Tom Lane wrote: Alexey Klyukin al...@commandprompt.com writes: After digging in the code I've found that a RowExclusiveLock is acquired on a pg_db_role_setting table in AlterSetting(). While the name of the locks suggests that it should conflict with itself

Re: [HACKERS] proposal: a validator for configuration files

2011-04-04 Thread Alexey Klyukin
On Apr 1, 2011, at 12:08 AM, Alexey Klyukin wrote: Hi Selena, On Mar 30, 2011, at 11:42 PM, Selena Deckelmann wrote: Hi! On Wed, Mar 30, 2011 at 8:40 AM, Alexey Klyukin al...@commandprompt.com wrote: I did a little bit of work on this, and we discussed it here: http

Re: [HACKERS] proposal: a validator for configuration files

2011-03-31 Thread Alexey Klyukin
Hi Selena, On Mar 30, 2011, at 11:42 PM, Selena Deckelmann wrote: Hi! On Wed, Mar 30, 2011 at 8:40 AM, Alexey Klyukin al...@commandprompt.com wrote: I did a little bit of work on this, and we discussed it here: http://archives.postgresql.org/pgsql-hackers/2009-03/msg00345.php http

[HACKERS] proposal: a validator for configuration files

2011-03-30 Thread Alexey Klyukin
. It's possible to address these shortcomings in the future. Ideas, suggestions are welcome. -- Alexey Klyukin The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-15 Thread Alexey Klyukin
On Feb 12, 2011, at 9:53 AM, Alex Hunsaker wrote: On Fri, Feb 11, 2011 at 17:17, Alexey Klyukin al...@commandprompt.com wrote: Anyway in playing with this patch a bit more I found another bug return [[]]; would segfault. So find attached a v9 that: - fixes above segfault - made

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-15 Thread Alexey Klyukin
On Feb 15, 2011, at 7:45 PM, David E. Wheeler wrote: On Feb 15, 2011, at 6:39 AM, Alexey Klyukin wrote: After I re-added the closing /para in plperl.sgml:235 these errors disappeared, and the resulting html looks fine too. v10 with just this single change is attached. So is this ready

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-11 Thread Alexey Klyukin
On Feb 10, 2011, at 11:26 PM, Alexey Klyukin wrote: On Feb 10, 2011, at 9:44 PM, Andrew Dunstan wrote: On 02/10/2011 08:15 AM, Alexey Klyukin wrote: Let me try implementing that as an XS interface to plperl_array_to_datum. Are you intending this as a completion of the current patch

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-10 Thread Alexey Klyukin
On Feb 9, 2011, at 9:28 PM, Alex Hunsaker wrote: On Wed, Feb 9, 2011 at 08:24, Alexey Klyukin al...@commandprompt.com wrote: What was actually broken in encode_array_literal support of composite types (it converted perl hashes to the literal composite-type constants, expanding nested

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-10 Thread Alexey Klyukin
On Feb 10, 2011, at 9:44 PM, Andrew Dunstan wrote: On 02/10/2011 08:15 AM, Alexey Klyukin wrote: On Feb 9, 2011, at 9:28 PM, Alex Hunsaker wrote: On Wed, Feb 9, 2011 at 08:24, Alexey Klyukinal...@commandprompt.com wrote: What was actually broken in encode_array_literal support

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-09 Thread Alexey Klyukin
encode_array_literal. /A -- Alexey Klyukin The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-08 Thread Alexey Klyukin
On Feb 6, 2011, at 9:43 AM, Alex Hunsaker wrote: On Thu, Feb 3, 2011 at 18:29, Alex Hunsaker bada...@gmail.com wrote: On Mon, Jan 31, 2011 at 01:34, Alexey Klyukin al...@commandprompt.com wrote: I've looked at the patch and added a test for arrays exceeding or equal maximum dimensions

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-03 Thread Alexey Klyukin
be a big help. Converting it to string is already lazy, and, per the argumens above, I don't see a real benefit of lazy conversion to the perl reference (as comparing to the hurdles of implementing that). /A -- Alexey Klyukin The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql

[HACKERS] off-by-one mistake in array code error reporting

2011-01-31 Thread Alexey Klyukin
for that. /A -- Alexey Klyukin The PostgreSQL Company - Command Prompt, Inc. array_error_msg_fix.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-31 Thread Alexey Klyukin
On Jan 29, 2011, at 12:27 AM, Alex Hunsaker wrote: On Thu, Jan 27, 2011 at 03:38, Alexey Klyukin al...@commandprompt.com wrote: Hi, On Jan 27, 2011, at 9:31 AM, Alex Hunsaker wrote: Find attached v3 of the patch. changes include: - fix deep recursion due to accidental reversal of check

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-27 Thread Alexey Klyukin
a minor suggestion, I think is_array is worth mentioning in the utility functions chapter of the pl/perl documentation, it would be also more clear to use it in regression tests as opposed to manually checking whether the ref is equal to 'PostgreSQL::InServer::ARRAY'. /A -- Alexey Klyukin

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-26 Thread Alexey Klyukin
Hi, On Jan 26, 2011, at 8:45 PM, Alex Hunsaker wrote: On Sat, Jan 15, 2011 at 15:48, Alex Hunsaker bada...@gmail.com wrote: On Wed, Jan 12, 2011 at 13:04, Alexey Klyukin al...@commandprompt.com wrote: On Jan 12, 2011, at 8:52 PM, David E. Wheeler wrote: On Jan 12, 2011, at 5:14 AM

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-26 Thread Alexey Klyukin
On Jan 26, 2011, at 10:08 PM, Alex Hunsaker wrote: On Wed, Jan 26, 2011 at 12:44, Alexey Klyukin al...@commandprompt.com wrote: Hi, On Jan 26, 2011, at 8:45 PM, Alex Hunsaker wrote: On Sat, Jan 15, 2011 at 15:48, Alex Hunsaker bada...@gmail.com wrote: On Wed, Jan 12, 2011 at 13:04

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-12 Thread Alexey Klyukin
On Jan 12, 2011, at 1:07 AM, David E. Wheeler wrote: On Jan 11, 2011, at 2:25 PM, Alexey Klyukin wrote: Hello, Here's the patch that improves handling of arrays as pl/perl function input arguments, converting postgres arrays of arbitrary dimensions into perl array references. Awesome

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-12 Thread Alexey Klyukin
would be the same whenever we set the new or the old behavior by default. I decided to default to the the old behavior since it won't break the existing code as opposed to just hiding the good stuff, although it would slower the adoption of the new behavior. /A -- Alexey Klyukin

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-12 Thread Alexey Klyukin
On Jan 12, 2011, at 8:52 PM, David E. Wheeler wrote: On Jan 12, 2011, at 5:14 AM, Alexey Klyukin wrote: You mean packing both a string representation and a reference to a single SV * value? Dunno, I'm not a guts guy. Well, neither me (I haven't used much of the guts api there). I

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-12 Thread Alexey Klyukin
for people to upgrade to 9.1, let's not force them to rewrite their Perl code if they were not planning to do that. /A -- Alexey Klyukin The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] arrays as pl/perl input arguments [PATCH]

2011-01-11 Thread Alexey Klyukin
handled in plperl_hash_from_tuple. /A -- Alexey Klyukin The PostgreSQL Company - Command Prompt, Inc. pg_to_perl_arrays.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Optimize PL/Perl function argument passing [PATCH]

2010-12-13 Thread Alexey Klyukin
accidentally) and post it for review. /A -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Another proposal for table synonyms

2010-12-03 Thread Alexey Klyukin
resolution code slower, and I don't see any situation where they make sense. The original proposal didn't mention them, but limited the list of initially supported objects to those to tables, views and sequences, implicitly excluding synonyms referring to another synonyms. -- Alexey Klyukin

Re: [HACKERS] Another proposal for table synonyms

2010-12-01 Thread Alexey Klyukin
is a TODO item in wiki. BTW, I have a specific use case for *column* synonyms which isn't currently covered by our existing tools. Is this the feature the community would benefit from? We can consider adding column synonyms if we won't hardwire synonyms to pg_class objects. -- Alexey Klyukin

[HACKERS] Another proposal for table synonyms

2010-11-30 Thread Alexey Klyukin
a referenced object without removing the synonym first (without using CASCADE). On DROP SYNONYM the related dependency will be removed. -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Another proposal for table synonyms

2010-11-30 Thread Alexey Klyukin
On Nov 30, 2010, at 6:28 PM, Tom Lane wrote: Alexey Klyukin al...@commandprompt.com writes: To support addition of new database objects types that can be referenced by synonyms a new system catalog, pg_synonym, is to be added, with an oid to support comments on synonym, and the following

[HACKERS] ps buffer is incorrectly padded on the (latest) OS X

2010-09-03 Thread Alexey Klyukin
, -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Specification for Trusted PLs?

2010-05-22 Thread Alexey Klyukin
definition. It's then up to the implementation step to figure out how to represent that in the form of tests. Yes, PL/Perl is following this approach. For a whitelist see plperl_opmask.h (generated by plperl_opmask.pl at build phase). -- Alexey Klyukin www.CommandPrompt.com The PostgreSQL Company

[HACKERS] missing file in git repo

2010-04-30 Thread Alexey Klyukin
, there is one in CVS: http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/port/sprompt.c?only_with_tag=REL7_4 This looks like the initial synchronization issue, since this file is there for really long time and appears not to be touched by any commit since 2003. -- Alexey Klyukin

[HACKERS] inlining SQL functions

2010-04-02 Thread Alexey Klyukin
Hi, Is there a reason why only a table free SQL functions are allowed to be inlined ? I wonder why a simple SQL function containing only a SELECT * FROM table can't be expanded inline ? Is there an interest in expanding the class of SQL functions that can be inlined ? Thanks, -- Alexey

[HACKERS] a common place for pl/perlu modules

2010-02-11 Thread Alexey Klyukin
a user to specify such location by adding a new custom GUC variable. -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] a common place for pl/perlu modules

2010-02-11 Thread Alexey Klyukin
On Feb 11, 2010, at 6:24 PM, Andrew Dunstan wrote: Alexey Klyukin wrote: Hello, When developing pl/perlu functions common definitions and methods are often stored in external .pm modules. During deployment the modules should be installed somewhere in @INC to be reachable by the perl

Re: [HACKERS] a common place for pl/perlu modules

2010-02-11 Thread Alexey Klyukin
On Feb 11, 2010, at 7:07 PM, Andrew Dunstan wrote: Alexey Klyukin wrote: On Feb 11, 2010, at 6:24 PM, Andrew Dunstan wrote: Alexey Klyukin wrote: Hello, When developing pl/perlu functions common definitions and methods are often stored in external .pm modules. During

[HACKERS] plperl db access documentation enhancement

2010-01-29 Thread Alexey Klyukin
-- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] warn in plperl logs as... NOTICE??

2010-01-22 Thread Alexey Klyukin
users out there. I think elog(WARNING) is less surprising for the end-user, unless there's an objection strong enough to include it into the documentation :) -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via

Re: [HACKERS] warn in plperl logs as... NOTICE??

2010-01-22 Thread Alexey Klyukin
On Jan 22, 2010, at 4:38 PM, Robert Haas wrote: On Fri, Jan 22, 2010 at 9:13 AM, Alexey Klyukin al...@waki.ru wrote: I think elog(WARNING) is less surprising for the end-user, unless there's an objection strong enough to include it into the documentation :) I think the main possible

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-29 Thread Alexey Klyukin
On Nov 29, 2009, at 4:40 AM, Tom Lane wrote: Alexey Klyukin al...@commandprompt.com writes: Isn't it also the case with the existing plperl code ? I've noticed that free(prodesc) is called when it's no longer used (i.e. in plperl_compile_callback:1636), but refcount of desc-reference

[HACKERS] arrays as input parameters in plperl

2009-11-23 Thread Alexey Klyukin
is attached. Anybody interested in this feature ? Ideas, improvements, suggestions ? Regards, -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc plperl_array.diff Description: Binary data -- Sent via pgsql-hackers mailing list

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-20 Thread Alexey Klyukin
On Nov 20, 2009, at 2:04 AM, Joshua Tolley wrote: On Wed, Nov 18, 2009 at 12:38:00PM +0200, Alexey Klyukin wrote: Yes, current_call_data can't be allocate in the SPI memory context, since it's used to extract the result after SPI_finish is called, although it doesn't lead to problems here

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-20 Thread Alexey Klyukin
(i.e. in plperl_compile_callback:1636), but refcount of desc-reference is never decremented. -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-18 Thread Alexey Klyukin
it is - here is the patch: inline_callback.diff Description: Binary data -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-17 Thread Alexey Klyukin
(query=0x1007ecb60 select 1, limit=0) at plperl.c:1895 Also, a call to to plperl_call_perl_func should be cast to void to avoid a possible compiler warning (although It doesn't emit one on my system): (void) plperl_call_perl_func(desc, fake_fcinfo); -- Alexey Klyukin

Re: [HACKERS] PL/Perl backed crashed during spi_exec_query

2009-11-02 Thread Alexey Klyukin
On Oct 31, 2009, at 7:30 PM, Tom Lane wrote: Alexey Klyukin al...@commandprompt.com writes: One of our customers is running 8.2.14 and use a couple of pl/perl and pl/perlu functions written by CMD. Everything worked normally until they tried to call one particular pl/perl function from pl

[HACKERS] PL/Perl backed crashed during spi_exec_query

2009-10-30 Thread Alexey Klyukin
(argc=3, argv=0x100500470) at main.c:188 (gdb) s Program exited with code 0377. -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] PL/Perl crash when using threaded perl

2009-08-10 Thread Alexey Klyukin
= (MemoryContext) Cannot access memory at address 0x0 Thanks, -- Alexey Klyukin http://www.CommandPrompt.com The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] PL/Perl crash when using threaded perl

2009-08-10 Thread Alexey Klyukin
/plperl/plperl.c.diff?r1=1.136;r2=1.136.2.2 We haven't put out an 8.3 release that includes that patch yet. Thanks, Andrew, this patch solved the problem. -- Alexey Klyukin .commandprompt.com The PostgreSQL Company - Command Prompt, Inc

[HACKERS] errcontext support in PL/Perl

2009-07-21 Thread Alexey Klyukin
and updates regression tests. I'll appreciate any suggestions on how to improve it. plperl_error_callback.diff Description: Binary data -- Alexey Klyukin http://www.CommandPrompt.com The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] errcontext support in PL/Perl

2009-07-21 Thread Alexey Klyukin
On Jul 21, 2009, at 6:39 PM, Alvaro Herrera wrote: Alexey Klyukin wrote: Attached is a patch (HEAD) that sets errcontext with PL/Perl function name, making a distinction between compilation and execution stages, fixes error messages where function name was already included in the message

Re: [HACKERS] errcontext support in PL/Perl

2009-07-21 Thread Alexey Klyukin
On Jul 21, 2009, at 7:20 PM, Alvaro Herrera wrote: Alexey Klyukin wrote: NOTICE: Test from function one CONTEXT: PL/Perl function perl_log1 SQL statement SELECT * FROM perl_log1() PL/Perl function perl_log1 Shouldn't the second PL/Perl function line say perl_log2 instead? Hm, yeah

Re: [HACKERS] errcontext support in PL/Perl

2009-07-21 Thread Alexey Klyukin
On Jul 21, 2009, at 7:47 PM, Alexey Klyukin wrote: On Jul 21, 2009, at 7:20 PM, Alvaro Herrera wrote: Alexey Klyukin wrote: NOTICE: Test from function one CONTEXT: PL/Perl function perl_log1 SQL statement SELECT * FROM perl_log1() PL/Perl function perl_log1 Shouldn't the second PL

Re: [HACKERS] Postgres-R: internal messaging

2008-07-23 Thread Alexey Klyukin
a correct ordering of queue messages an additional shared memory queue of pid_t can be maintained, containing one pid per each message. -- Alexey Klyukin http://www.commandprompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Permanent settings

2008-02-21 Thread Alexey Klyukin
will be a tmp+rename, not a trunc+write) don't change anything, return ERROR. 6) Do we want to distinguish between restart only settings, and reloadable settings, and if so, how? I think now, since we don't digstinguish between them when writing the config file manually. -- Alexey Klyukin

Re: [HACKERS] Debugger

2007-10-19 Thread Alexey Klyukin
index.c for example? Thank, -- Pedro Belmino. # Ciência da Computação - UNIFOR # [EMAIL PROTECTED] -- Alexey Klyukin http

  1   2   >