Re: [HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-12-06 Thread Bruce Momjian
Abhijit Menon-Sen wrote: At 2008-09-22 12:54:34 -0500, [EMAIL PROTECTED] wrote: can we tell there is consensus in create a new has_sequence_privilege()? Abhijit will you make it? if not i can make a try... Yes, I'll do it. This hasn't been done so I added it to the TODO list. --

Re: [HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-09-26 Thread Abhijit Menon-Sen
At 2008-09-22 12:54:34 -0500, [EMAIL PROTECTED] wrote: can we tell there is consensus in create a new has_sequence_privilege()? Abhijit will you make it? if not i can make a try... Yes, I'll do it. -- ams -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-09-22 Thread Jaime Casanova
On Sun, Sep 7, 2008 at 10:55 PM, Tom Lane [EMAIL PROTECTED] wrote: Abhijit Menon-Sen [EMAIL PROTECTED] writes: (I can't help but think that the USAGE privilege is a bit unfortunate. If granting SELECT rights allowed currval(), INSERT allowed nextval(), and UPDATE allowed nextval() and

Re: [HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-09-07 Thread Robert Haas
Maybe we want a new function has_sequence_privilege() instead? +1 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-09-07 Thread Abhijit Menon-Sen
At 2008-09-06 19:59:55 -0400, [EMAIL PROTECTED] wrote: So I'm thinking it would be better to invent a has_sequence_privilege family of functions. Perhaps. I certainly wouldn't object to that approach. If there had been such a function, I would have used it; and, since has_table_privilege

Re: [HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-09-07 Thread Tom Lane
Abhijit Menon-Sen [EMAIL PROTECTED] writes: (I can't help but think that the USAGE privilege is a bit unfortunate. If granting SELECT rights allowed currval(), INSERT allowed nextval(), and UPDATE allowed nextval() and setval(), then has_table_privilege() would have been sufficient and there

Re: [HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-09-06 Thread Tom Lane
Jaime Casanova [EMAIL PROTECTED] writes: On Thu, Aug 7, 2008 at 3:08 AM, Abhijit Menon-Sen [EMAIL PROTECTED] wrote: I just noticed, to my dismay, that has_table_privilege() does not allow me to check for usage privileges on sequences. Maybe we want a new function has_sequence_privilege()

Re: [HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-09-01 Thread Jaime Casanova
On Thu, Aug 7, 2008 at 3:08 AM, Abhijit Menon-Sen [EMAIL PROTECTED] wrote: I just noticed, to my dismay, that has_table_privilege() does not allow me to check for usage privileges on sequences. Maybe we want a new function has_sequence_privilege() instead? -- regards, Jaime Casanova Soporte

[HACKERS] [PATCH] allow has_table_privilege(..., 'usage') on sequences

2008-08-07 Thread Abhijit Menon-Sen
I just noticed, to my dismay, that has_table_privilege() does not allow me to check for usage privileges on sequences. I suspect this may have been an oversight. If so, the attached patch fixes it for me. -- ams *** a/src/backend/utils/adt/acl.c --- b/src/backend/utils/adt/acl.c ***