Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Guillaume Lelarge
Le 30/06/2010 06:53, Guillaume Lelarge a écrit : Le 30/06/2010 05:25, Tom Lane a écrit : Robert Haas robertmh...@gmail.com writes: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Robert Haas
On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest page yet. Finally, I added it

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Robert Haas
On Thu, Jul 1, 2010 at 10:18 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something we want fixed for 9.0, as indicated by

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Guillaume Lelarge
Le 01/07/2010 17:54, Robert Haas a écrit : On Thu, Jul 1, 2010 at 10:18 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Robert Haas
On Thu, Jul 1, 2010 at 12:11 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 01/07/2010 17:54, Robert Haas a écrit : On Thu, Jul 1, 2010 at 10:18 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, Jun 29,

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Guillaume Lelarge
Le 01/07/2010 22:13, Robert Haas a écrit : On Thu, Jul 1, 2010 at 12:11 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 01/07/2010 17:54, Robert Haas a écrit : On Thu, Jul 1, 2010 at 10:18 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-30 Thread Robert Haas
On Tue, Jun 29, 2010 at 11:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Guillaume Lelarge
Le 23/06/2010 23:29, Guillaume Lelarge a écrit : Le 23/06/2010 22:54, Tom Lane a écrit : Robert Haas robertmh...@gmail.com writes: On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge guilla...@lelarge.info wrote: I added a CHECK_FOR_INTERRUPTS call in the copy_relation_data(), copy_dir(),

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Tom Lane
Guillaume Lelarge guilla...@lelarge.info writes: Still not sure what to do right now for this patch :) Put it on the commitfest list, if you didn't already. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Bruce Momjian
Tom Lane wrote: Guillaume Lelarge guilla...@lelarge.info writes: Still not sure what to do right now for this patch :) Put it on the commitfest list, if you didn't already. So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest page

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Guillaume Lelarge guilla...@lelarge.info writes: Still not sure what to do right now for this patch :) Put it on the commitfest list, if you didn't already. So this is not something we want fixed for

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest page yet. I tend to think we should fix it for 9.0, but could be

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Guillaume Lelarge
Le 30/06/2010 05:25, Tom Lane a écrit : Robert Haas robertmh...@gmail.com writes: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest page yet. I tend to think

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-23 Thread Robert Haas
On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Today, I tried to cancel the change of a tablespace for a table (ALTER TABLE ... SET TABLESPACE). I got the Cancel request sent but the query continued and finally succeed. It was a big issue for my customer, and

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-23 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge guilla...@lelarge.info wrote: I added a CHECK_FOR_INTERRUPTS call in the copy_relation_data(), copy_dir(), and copy_file() functions. Works for me on ALTER TABLE ... SET TABLESPACE and ALTER DATABASE

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-23 Thread Guillaume Lelarge
Le 23/06/2010 22:54, Tom Lane a écrit : Robert Haas robertmh...@gmail.com writes: On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge guilla...@lelarge.info wrote: I added a CHECK_FOR_INTERRUPTS call in the copy_relation_data(), copy_dir(), and copy_file() functions. Works for me on ALTER

[HACKERS] Cannot cancel the change of a tablespace

2010-06-21 Thread Guillaume Lelarge
Hi, Today, I tried to cancel the change of a tablespace for a table (ALTER TABLE ... SET TABLESPACE). I got the Cancel request sent but the query continued and finally succeed. It was a big issue for my customer, and I wanted to look more into that issue. So, I got a look at the source code and

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-21 Thread Simon Riggs
On Mon, 2010-06-21 at 18:46 +0200, Guillaume Lelarge wrote: Today, I tried to cancel the change of a tablespace for a table (ALTER TABLE ... SET TABLESPACE). I got the Cancel request sent but the query continued and finally succeed. It was a big issue for my customer, and I wanted to look