Re: [HACKERS] Hard to maintain duplication in contain_volatile_functions_not_nextval_walker

2016-06-10 Thread Robert Haas
On Fri, Jun 10, 2016 at 11:12 AM, Tom Lane wrote: > Andres Freund writes: >> contain_volatile_functions_walker is duplicated, near entirely, in >> contain_volatile_functions_not_nextval_walker. >> Wouldn't it have been better not to duplicate, and keep a

Re: [HACKERS] Hard to maintain duplication in contain_volatile_functions_not_nextval_walker

2016-06-10 Thread Tom Lane
Andres Freund writes: > contain_volatile_functions_walker is duplicated, near entirely, in > contain_volatile_functions_not_nextval_walker. > Wouldn't it have been better not to duplicate, and keep a flag about > ignoring nextval in the context variable? > While at it,

Re: [HACKERS] Hard to maintain duplication in contain_volatile_functions_not_nextval_walker

2016-05-31 Thread Robert Haas
On Fri, May 27, 2016 at 10:36 PM, Amit Kapila wrote: > On Sat, May 28, 2016 at 12:28 AM, Andres Freund wrote: >> contain_volatile_functions_walker is duplicated, near entirely, in >> contain_volatile_functions_not_nextval_walker. > > Previously, I

Re: [HACKERS] Hard to maintain duplication in contain_volatile_functions_not_nextval_walker

2016-05-27 Thread Amit Kapila
On Sat, May 28, 2016 at 12:28 AM, Andres Freund wrote: > > Hi, > > contain_volatile_functions_walker is duplicated, near entirely, in > contain_volatile_functions_not_nextval_walker. > Previously, I also had same observation. > Wouldn't it have been better not to duplicate,

[HACKERS] Hard to maintain duplication in contain_volatile_functions_not_nextval_walker

2016-05-27 Thread Andres Freund
Hi, contain_volatile_functions_walker is duplicated, near entirely, in contain_volatile_functions_not_nextval_walker. Wouldn't it have been better not to duplicate, and keep a flag about ignoring nextval in the context variable? While at it, couldn't we also fold