Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-20 Thread Thomas Hallgren
Fabien COELHO wrote: I guess the magic is explained because you installed *over* the previous test install you did to check my patch? So the header files were there from this previous install. Nope. I removed my previous installation. It's easy enough to check if CVS have some way to check out

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-20 Thread Thomas Hallgren
Fabien COELHO wrote: Dear Thomas, Something that Fabien Coelho fixed recently broke tonight. I can no longer compile PL/Java on win32 using pgxs since the directory pgxs/src/include/port/win32/* is missing (again). AFAICS, the patch is in the queue waiting for a review. Well, the CVS HEAD

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-20 Thread Fabien COELHO
I guess the magic is explained because you installed *over* the previous test install you did to check my patch? So the header files were there from this previous install. Nope. I removed my previous installation. It's easy enough to check if CVS have some way to check out a snapshot based

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-20 Thread Tom Lane
Thomas Hallgren [EMAIL PROTECTED] writes: Nope. I removed my previous installation. It's easy enough to check if CVS have some way to check out a snapshot based on a timestamp. Does it? Yes, -D I think. See the manual. (Note this is sticky, so you probably want to do it in a scratch

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-20 Thread Thomas Hallgren
Tom, Yes, -D I think. See the manual. (Note this is sticky, so you probably want to do it in a scratch checkout rather than overwriting your regular tree.) Something lingered allright, but not in the PostgreSQL installation that I removed. Sigh... Anyway, the patch that was applied tonight

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Thomas Hallgren
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: I submitted a patch to fix this on October 21st, but it has not been applied (in common with several other cleanup patches I sent in about a week ago). Bruce got horribly backlogged recently and didn't get any patches in to speak

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Fabien COELHO
Dear Thomas, Something that Fabien Coelho fixed recently broke tonight. I can no longer compile PL/Java on win32 using pgxs since the directory pgxs/src/include/port/win32/* is missing (again). AFAICS, the patch is in the queue waiting for a review. -- Fabien Coelho - [EMAIL PROTECTED]

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Thomas Hallgren
Thomas Hallgren wrote: Something that Fabien Coelho fixed recently broke tonight. I can no longer compile PL/Java on win32 using pgxs since the directory pgxs/src/include/port/win32/* is missing (again). And in addition to that, the libpostgresql.a is also missing. Regards, Thomas Hallgren

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Fabien COELHO
AFAICS, the patch is in the queue waiting for a review. Well, the CVS HEAD did work as if it indeed had been applied until yesterday evening. I'm quite sure of that since I took a new snapshot yesterday and created a brand new installation. PL/Java compiled fine on win32 (aside from the

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Reini Urban
Thomas Hallgren schrieb: I have a minor issue with Makefile.shlib. Compiling with win32 it spits out these warnings (the same is true for Cygwin) Makefile.shlib:327: warning: overriding commands for target `libpljava.a' Makefile.shlib:262: warning: ignoring old commands for target

[HACKERS] Minor problem with Makefile.shlib

2004-11-16 Thread Thomas Hallgren
I have a minor issue with Makefile.shlib. Compiling with win32 it spits out these warnings (the same is true for Cygwin) Makefile.shlib:327: warning: overriding commands for target `libpljava.a' Makefile.shlib:262: warning: ignoring old commands for target `libpljava.a' As it turns out,

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-16 Thread Andrew Dunstan
I submitted a patch to fix this on October 21st, but it has not been applied (in common with several other cleanup patches I sent in about a week ago). cheers andrew Thomas Hallgren wrote: I have a minor issue with Makefile.shlib. Compiling with win32 it spits out these warnings (the same is

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-16 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: I submitted a patch to fix this on October 21st, but it has not been applied (in common with several other cleanup patches I sent in about a week ago). Bruce got horribly backlogged recently and didn't get any patches in to speak of. Since he's in