Re: [HACKERS] REVIEW: PL/Python validator function

2011-02-01 Thread Peter Eisentraut
On ons, 2011-01-19 at 10:16 +0900, Hitoshi Harada wrote: Thanks. I tested the new version and looks ok. I'll mark it Ready for Commiter. Committed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] REVIEW: PL/Python validator function

2011-01-27 Thread Jan Urbański
On 19/01/11 02:16, Hitoshi Harada wrote: Thanks. I tested the new version and looks ok. I'll mark it Ready for Commiter. Updated version against master. Jan diff --git a/src/include/catalog/pg_pltemplate.h b/src/include/catalog/pg_pltemplate.h index d987ddc..c0578f9 100644 ***

Re: [HACKERS] REVIEW: PL/Python validator function

2011-01-18 Thread Hitoshi Harada
2011/1/18 Jan Urbański wulc...@wulczer.org: On 17/01/11 09:26, Jan Urbański wrote: On 17/01/11 01:02, Hitoshi Harada wrote: This is a review for the patch sent as https://commitfest.postgresql.org/action/patch_view?id=456 It includes adequate amount of test. I found regression test failure

Re: [HACKERS] REVIEW: PL/Python validator function

2011-01-17 Thread Jan Urbański
On 17/01/11 01:02, Hitoshi Harada wrote: This is a review for the patch sent as https://commitfest.postgresql.org/action/patch_view?id=456 Thanks! It includes adequate amount of test. I found regression test failure in plpython_error. My environment is CentOS release 5.4 (Final) with

Re: [HACKERS] REVIEW: PL/Python validator function

2011-01-17 Thread Jan Urbański
On 17/01/11 09:26, Jan Urbański wrote: On 17/01/11 01:02, Hitoshi Harada wrote: This is a review for the patch sent as https://commitfest.postgresql.org/action/patch_view?id=456 It includes adequate amount of test. I found regression test failure in plpython_error. My environment is CentOS

[HACKERS] REVIEW: PL/Python validator function

2011-01-16 Thread Hitoshi Harada
This is a review for the patch sent as https://commitfest.postgresql.org/action/patch_view?id=456 == Submission == The patch applied cleanly atop of plpython refactor patches. The format is git diff (though refactor patches is format-patch). I did patch -p1. It includes adequate amount of test. I