Re: [HACKERS] Running pgindent

2013-06-03 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: On Fri, May 31, 2013 at 03:51:30PM -0400, Andrew Dunstan wrote: I spent quite a lot of time trying to make the tool behave the same as the old script. Yes, and I believe we tested running the Perl version to make sure it was the same, so the

Re: [HACKERS] Running pgindent

2013-06-03 Thread Alvaro Herrera
Stephen Frost escribió: Just to wrap this up- I wanted to say thanks to both you (Bruce) and to Andrew for making pgindent work and the documentation / instructions easy to follow. In the past, pgindent has always seemed to be a black art, where it was difficult to get consistent results

Re: [HACKERS] Running pgindent

2013-06-01 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: OK. Done. Thanks, Stephen signature.asc Description: Digital signature

Re: [HACKERS] Running pgindent

2013-05-31 Thread Andrew Dunstan
On 05/29/2013 11:41 PM, Bruce Momjian wrote: On Wed, May 29, 2013 at 10:08:10PM -0400, Stephen Frost wrote: * Bruce Momjian (br...@momjian.us) wrote: Wow, uh, yeah, I guess we could do that. I will await more feedback. Please don't. I'm already rather concerned by this one. It looks like

Re: [HACKERS] Running pgindent

2013-05-31 Thread Bruce Momjian
On Fri, May 31, 2013 at 03:51:30PM -0400, Andrew Dunstan wrote: On 05/29/2013 11:41 PM, Bruce Momjian wrote: On Wed, May 29, 2013 at 10:08:10PM -0400, Stephen Frost wrote: * Bruce Momjian (br...@momjian.us) wrote: Wow, uh, yeah, I guess we could do that. I will await more feedback. Please

Re: [HACKERS] Running pgindent

2013-05-31 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: On Fri, May 31, 2013 at 03:51:30PM -0400, Andrew Dunstan wrote: I spent quite a lot of time trying to make the tool behave the same as the old script. Yes, and I believe we tested running the Perl version to make sure it was the same, so the

Re: [HACKERS] Running pgindent

2013-05-31 Thread Bruce Momjian
On Fri, May 31, 2013 at 04:57:20PM -0400, Stephen Frost wrote: * Bruce Momjian (br...@momjian.us) wrote: On Fri, May 31, 2013 at 03:51:30PM -0400, Andrew Dunstan wrote: I spent quite a lot of time trying to make the tool behave the same as the old script. Yes, and I believe we tested

Re: [HACKERS] Running pgindent

2013-05-29 Thread Bruce Momjian
On Tue, May 28, 2013 at 09:56:03AM -0400, Bruce Momjian wrote: On Tue, May 28, 2013 at 09:49:32AM -0400, Magnus Hagander wrote: On Tue, May 28, 2013 at 9:48 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, May 28, 2013 at 9:40 AM, Bruce Momjian br...@momjian.us wrote: On Wed, May 22,

Re: [HACKERS] Running pgindent

2013-05-29 Thread Alvaro Herrera
Bruce Momjian escribió: Done. This was the first run of the Perl-based pgindent script. There was a lot of code churn in this run as the paragraphs are slightly wider. Also, I saw some outdenting of long lines, rather than allowing them to go past 80 characters, but it seemed minimal. If

Re: [HACKERS] Running pgindent

2013-05-29 Thread Bruce Momjian
On Wed, May 29, 2013 at 05:56:32PM -0400, Alvaro Herrera wrote: Bruce Momjian escribió: Done. This was the first run of the Perl-based pgindent script. There was a lot of code churn in this run as the paragraphs are slightly wider. Also, I saw some outdenting of long lines, rather than

Re: [HACKERS] Running pgindent

2013-05-29 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: Wow, uh, yeah, I guess we could do that. I will await more feedback. Please don't. I'm already rather concerned by this one. It looks like there's a rule to pull a line in to meet the max-column requirement even when that makes things line up 'funny',

Re: [HACKERS] Running pgindent

2013-05-29 Thread Bruce Momjian
On Wed, May 29, 2013 at 10:08:10PM -0400, Stephen Frost wrote: * Bruce Momjian (br...@momjian.us) wrote: Wow, uh, yeah, I guess we could do that. I will await more feedback. Please don't. I'm already rather concerned by this one. It looks like there's a rule to pull a line in to meet the

Re: [HACKERS] Running pgindent

2013-05-28 Thread Bruce Momjian
On Wed, May 22, 2013 at 01:52:28PM -0400, Bruce Momjian wrote: Do we want to run pgindent soon? OK, should I run it this week? Wednesday, 1800 GMT? -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com + It's

Re: [HACKERS] Running pgindent

2013-05-28 Thread Magnus Hagander
On Tue, May 28, 2013 at 9:48 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, May 28, 2013 at 9:40 AM, Bruce Momjian br...@momjian.us wrote: On Wed, May 22, 2013 at 01:52:28PM -0400, Bruce Momjian wrote: Do we want to run pgindent soon? OK, should I run it this week? Wednesday, 1800 GMT?

Re: [HACKERS] Running pgindent

2013-05-28 Thread Bruce Momjian
On Tue, May 28, 2013 at 09:49:32AM -0400, Magnus Hagander wrote: On Tue, May 28, 2013 at 9:48 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, May 28, 2013 at 9:40 AM, Bruce Momjian br...@momjian.us wrote: On Wed, May 22, 2013 at 01:52:28PM -0400, Bruce Momjian wrote: Do we want to run

Re: [HACKERS] Running pgindent

2013-05-28 Thread Robert Haas
On Tue, May 28, 2013 at 9:40 AM, Bruce Momjian br...@momjian.us wrote: On Wed, May 22, 2013 at 01:52:28PM -0400, Bruce Momjian wrote: Do we want to run pgindent soon? OK, should I run it this week? Wednesday, 1800 GMT? wfm. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The

[HACKERS] Running pgindent

2013-05-22 Thread Bruce Momjian
Do we want to run pgindent soon? -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Running pgindent

2013-05-22 Thread Robert Haas
On Wed, May 22, 2013 at 1:52 PM, Bruce Momjian br...@momjian.us wrote: Do we want to run pgindent soon? +1. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to