Fujii Masao wrote:
On Wed, Dec 3, 2008 at 5:13 AM, Heikki Linnakangas
[EMAIL PROTECTED] wrote:
Agreed, should use XLByteToPrevSeg. But I wonder if we can just replace the
current XLByteToSeg call with XLByteToPrevSeg? That would offset the return
value of the function by one byte as well, as
Hi,
I have looked at the patch and it looks OK to me. BTW I am not too
much familiar with this area of code, so I am not at the position to
argue that patch -:) . I haven't found an easy way to test the patch.
On Wed, Dec 3, 2008 at 1:24 PM, Heikki Linnakangas
[EMAIL PROTECTED] wrote:
Fujii
Fujii Masao wrote:
On Wed, Oct 8, 2008 at 10:23 PM, Simon Riggs [EMAIL PROTECTED] wrote:
Minor bug fix for pg_stop_backup() to prevent it waiting longer than
necessary in certain circumstances.
Why don't you use XLByteToPrevSeg like pg_xlogfile_name?
I think that we should uniform the logic
On Wed, Dec 3, 2008 at 5:13 AM, Heikki Linnakangas
[EMAIL PROTECTED] wrote:
Fujii Masao wrote:
On Wed, Oct 8, 2008 at 10:23 PM, Simon Riggs [EMAIL PROTECTED]
wrote:
Minor bug fix for pg_stop_backup() to prevent it waiting longer than
necessary in certain circumstances.
Why don't you use
Hi,
On Wed, Oct 8, 2008 at 10:23 PM, Simon Riggs [EMAIL PROTECTED] wrote:
Minor bug fix for pg_stop_backup() to prevent it waiting longer than
necessary in certain circumstances.
Why don't you use XLByteToPrevSeg like pg_xlogfile_name?
I think that we should uniform the logic as much as
On Fri, 2008-11-07 at 18:32 -0300, Alvaro Herrera wrote:
Simon Riggs wrote:
Minor bug fix for pg_stop_backup() to prevent it waiting longer than
necessary in certain circumstances.
As far as I can tell, this patch needs to be applied to HEAD, 8.3 and
8.2 (when xlog switch was
Simon Riggs wrote:
Minor bug fix for pg_stop_backup() to prevent it waiting longer than
necessary in certain circumstances.
As far as I can tell, this patch needs to be applied to HEAD, 8.3 and
8.2 (when xlog switch was implemented), and in fact it applies cleanly
to them. Please confirm.
--
Minor bug fix for pg_stop_backup() to prevent it waiting longer than
necessary in certain circumstances.
Was originally part of recovery_infrastructure patch.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
Index: src/backend/access/transam/xlog.c
