Re: [HACKERS] pgrowlocks relkind check

2017-06-21 Thread Amit Langote
On 2017/06/22 12:26, Peter Eisentraut wrote: > On 6/14/17 01:34, Amit Langote wrote: >> How about the attached patch that teaches pgrowlocks() to error out unless >> a meaningful result can be returned? With the patch, it will issue a "%s >> is not a table" message if it is not a

Re: [HACKERS] pgrowlocks relkind check

2017-06-21 Thread Peter Eisentraut
On 6/14/17 01:34, Amit Langote wrote: > How about the attached patch that teaches pgrowlocks() to error out unless > a meaningful result can be returned? With the patch, it will issue a "%s > is not a table" message if it is not a RELKIND_RELATION, except a > different message will be issued for

Re: [HACKERS] pgrowlocks relkind check

2017-06-13 Thread Amit Langote
On 2017/06/13 22:53, Peter Eisentraut wrote: > On 6/12/17 21:10, Amit Langote wrote: >> On 2017/06/13 0:29, Peter Eisentraut wrote: >>> On 4/24/17 21:22, Amit Langote wrote: >> create extension pgrowlocks; >> create view one as select 1; >> select pgrowlocks('one'); >> -- ERROR:

Re: [HACKERS] pgrowlocks relkind check

2017-06-13 Thread Peter Eisentraut
On 6/12/17 21:10, Amit Langote wrote: > On 2017/06/13 0:29, Peter Eisentraut wrote: >> On 4/24/17 21:22, Amit Langote wrote: > create extension pgrowlocks; > create view one as select 1; > select pgrowlocks('one'); > -- ERROR: could not open file "base/68730/68748": No such file

Re: [HACKERS] pgrowlocks relkind check

2017-06-12 Thread Amit Langote
On 2017/06/13 0:29, Peter Eisentraut wrote: > On 4/24/17 21:22, Amit Langote wrote: >> Hi Stephen, >> >> On 2017/04/11 22:17, Stephen Frost wrote: create extension pgrowlocks; create view one as select 1; select pgrowlocks('one'); -- ERROR: could not open file

Re: [HACKERS] pgrowlocks relkind check

2017-06-12 Thread Peter Eisentraut
On 4/24/17 21:22, Amit Langote wrote: > Hi Stephen, > > On 2017/04/11 22:17, Stephen Frost wrote: >>> create extension pgrowlocks; >>> create view one as select 1; >>> select pgrowlocks('one'); >>> -- ERROR: could not open file "base/68730/68748": No such file or directory >>> >>> With the

Re: [HACKERS] pgrowlocks relkind check

2017-04-24 Thread Amit Langote
Hi Stephen, On 2017/04/11 22:17, Stephen Frost wrote: >> create extension pgrowlocks; >> create view one as select 1; >> select pgrowlocks('one'); >> -- ERROR: could not open file "base/68730/68748": No such file or directory >> >> With the attached patch: >> >> select pgrowlocks('one'); >>

Re: [HACKERS] pgrowlocks relkind check

2017-04-11 Thread Stephen Frost
Amit, * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > The following commit added relkind checks to certain contrib modules so > that a more user-friendly error is produced if the wrong kind of relation > is passed to its functions: > > commit c08d82f38ebf763b79bd43ae34b7310ee47aaacd >

[HACKERS] pgrowlocks relkind check

2017-04-11 Thread Amit Langote
The following commit added relkind checks to certain contrib modules so that a more user-friendly error is produced if the wrong kind of relation is passed to its functions: commit c08d82f38ebf763b79bd43ae34b7310ee47aaacd Author: Stephen Frost Date: Thu Mar 9 16:34:25 2017