Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-10-01 Thread Daniel Gustafsson
> On 11 Apr 2017, at 10:55, Etsuro Fujita wrote: > > On 2017/04/07 22:54, Arthur Zakirov wrote: >> Marked the patch as "Ready for Commiter". But the patch should be >> commited only after the patch [1]. > > Thanks for reviewing! I'll continue to work on this for

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-04-11 Thread Etsuro Fujita
On 2017/04/07 22:54, Arthur Zakirov wrote: Marked the patch as "Ready for Commiter". But the patch should be commited only after the patch [1]. Thanks for reviewing! I'll continue to work on this for PG11. Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-04-08 Thread David Steele
On 4/7/17 9:54 AM, Arthur Zakirov wrote: > > Marked the patch as "Ready for Commiter". But the patch should be > commited only after the patch [1]. This submission has been moved to CF 2017-07. -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-04-07 Thread Arthur Zakirov
On 05.04.2017 12:20, Etsuro Fujita wrote: Rebased. Attached is an updated version created on top of the latest patch "epqpath-for-foreignjoin" [1]. Other changes: * Added a bit more regression tests with FOR UPDATE clause to see if CreateLocalJoinPath works well for parameterized foreign join

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-04-05 Thread Etsuro Fujita
Hi Arthur, On 2017/04/05 0:55, Arthur Zakirov wrote: On 23.03.2017 15:45, Etsuro Fujita wrote: I have a few comments. Thank you for the review! * innersortkeys are the sort pathkeys for the inner side of the mergejoin + * req_outer_list is a list of sensible parameterizations for the

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-04-04 Thread Arthur Zakirov
On 23.03.2017 15:45, Etsuro Fujita wrote: Done. Also, I added regression tests and revised code and comments a bit. (As for create_foreignscan_path(), I haven't done anything about that yet.) Please find attached a new version created on top of [1]. Thank you! I didn't notice that it is

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-03-31 Thread Arthur Zakirov
Hello, On 31.03.2017 18:47, David Steele wrote: Hi Arthur. On 3/23/17 8:45 AM, Etsuro Fujita wrote: Done. Also, I added regression tests and revised code and comments a bit. (As for create_foreignscan_path(), I haven't done anything about that yet.) Please find attached a new version

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-03-31 Thread David Steele
Hi Arthur. On 3/23/17 8:45 AM, Etsuro Fujita wrote: On 2017/03/21 18:38, Etsuro Fujita wrote: On 2017/03/16 22:23, Arthur Zakirov wrote: Can you rebase the patch? It is not applied now. Ok, will do. Thanks for the report! Done. Also, I added regression tests and revised code and

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-03-23 Thread Etsuro Fujita
On 2017/03/21 18:38, Etsuro Fujita wrote: On 2017/03/16 22:23, Arthur Zakirov wrote: Can you rebase the patch? It is not applied now. Ok, will do. Thanks for the report! Done. Also, I added regression tests and revised code and comments a bit. (As for create_foreignscan_path(), I

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-03-21 Thread Etsuro Fujita
On 2017/03/16 22:23, Arthur Zakirov wrote: 2017-02-27 12:40 GMT+03:00 Etsuro Fujita : I'd like to propose to support parameterized foreign joins. Attached is a patch for that, which has been created on top of [1]. Can you rebase the patch? It is not applied now.

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-03-16 Thread Arthur Zakirov
Hello, 2017-02-27 12:40 GMT+03:00 Etsuro Fujita : > Hi, > > I'd like to propose to support parameterized foreign joins. Attached is a > patch for that, which has been created on top of [1]. > Can you rebase the patch? It is not applied now. -- Arthur Zakirov

[HACKERS] postgres_fdw: support parameterized foreign joins

2017-02-27 Thread Etsuro Fujita
Hi, I'd like to propose to support parameterized foreign joins. Attached is a patch for that, which has been created on top of [1]. In [2], I said that postgres_fdw could create parameterized paths from joinable combinations of the cheapest-parameterized paths for the inner/outer