Re: [HACKERS] [WIP PATCH] for Performance Improvement in Buffer Management

2012-10-21 Thread Amit kapila
On Saturday, October 20, 2012 11:03 PM Jeff Janes wrote: On Fri, Sep 7, 2012 at 6:14 AM, Amit kapila amit.kap...@huawei.com wrote: On Thursday, September 06, 2012 2:38 PM Amit kapila wrote: On Tuesday, September 04, 2012 6:55 PM Amit kapila wrote: On Tuesday, September 04, 2012 12:42 AM Jeff

Re: [HACKERS] [WIP PATCH] for Performance Improvement in Buffer Management

2012-10-22 Thread Amit Kapila
On Saturday, October 20, 2012 11:07 PM Jeff Janes wrote: On Fri, Oct 19, 2012 at 11:00 PM, Amit kapila amit.kap...@huawei.com wrote: Robert wrote an accounting patch a while ago that tallied how often a buffer was cleaned but then reclaimed for the same page before being evicted

[HACKERS] Re: [WIP] Performance Improvement by reducing WAL for Update Operation

2012-10-23 Thread Amit kapila
Wednesday, October 24, 2012 5:51 AM Noah Misch wrote: Hi Amit, Noah, Thank you for taking the performance data. On Tue, Oct 16, 2012 at 09:22:39AM +, Amit kapila wrote: On Saturday, October 06, 2012 7:34 PM Amit Kapila wrote: Please find the readings of LZ patch along with Xlog-Scale

Re: [HACKERS] Re: [WIP] Performance Improvement by reducing WAL for Update Operation

2012-10-24 Thread Amit kapila
On Wednesday, October 24, 2012 12:15 AM Alvaro Herrera wrote: Amit kapila wrote: Rebased version of patch based on latest code. Uhm, how can this patch change a caller of PageAddItem() by adding one more argument, yet not touch bufpage.c at all? Are you sure this compiles? It compiles

Re: [HACKERS] proposed community service: make coverage

2012-10-25 Thread Amit Kapila
actually looking at the results, much less doing anything about them. Does this sound interesting/useful to hackers? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

[HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-10-29 Thread Amit Kapila
the value of this feature and Implementation Idea? With Regards, Amit Kapila.

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-10-29 Thread Amit Kapila
On Monday, October 29, 2012 7:06 PM Merlin Moncure wrote: On Mon, Oct 29, 2012 at 8:31 AM, Amit Kapila amit.kap...@huawei.com wrote: SYNTAX: ALTER SYSTEM SET configuration_parameter = value COMMENT 'value'; Comments/Suggestions about the value of this feature and Implementation

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-10-29 Thread Amit Kapila
that they will take immediate effect, which isn't the case. The values will take effect after server restart or by SIGHUP. Il giorno 30/ott/2012, alle ore 00:31, Amit Kapila ha scritto: SYNTAX: ALTER SYSTEM SET configuration_parameter = value COMMENT 'value'; DESIGN IDEA

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2012-10-29 Thread Amit Kapila
On Sunday, October 28, 2012 12:28 AM Heikki Linnakangas wrote: On 27.10.2012 14:27, Amit Kapila wrote: On Saturday, October 27, 2012 4:03 AM Noah Misch wrote: In my previous review, I said: Given [not relying on the executor to know which columns changed], why not For this patch

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2012-10-29 Thread Amit Kapila
On Saturday, October 27, 2012 11:34 PM Noah Misch On Sat, Oct 27, 2012 at 04:57:46PM +0530, Amit Kapila wrote: On Saturday, October 27, 2012 4:03 AM Noah Misch wrote: Could you elaborate on your reason for continuing to treat TOAST as a special case? As best I recall, the only reason

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-10-30 Thread Amit Kapila
discrepancy in the proposal I have sent and what have been concluded in previous discussions? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-10-30 Thread Amit Kapila
the exact format of file. The problem can be there if we need to parse postgresql.conf to set/reset values, as for that the format is not fixed. However that is taken care by having 2 files. Please point me, if I misunderstood the difficulty raised by you. With Regards, Amit Kapila. -- Sent via

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-10-30 Thread Amit Kapila
On Wednesday, October 31, 2012 3:32 AM Hannu Krosing wrote: On 10/29/2012 03:14 PM, Amit Kapila wrote: On Monday, October 29, 2012 7:11 PM Chris Corbyn What's the use case of this? It sounds like it will just create a maintenance nightmare where some stuff you expect to lookup

[HACKERS] Problem Observed in behavior of Create Index Concurrently and Hot Update

2012-10-31 Thread Amit Kapila
an entry for C2=5 Let me know if I have misunderstood something? With Regards, Amit Kapila.

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-10-31 Thread Amit Kapila
in postgresql.conf by default. Can you please let me know what is the expectation? Instead of INCLUDE, 1. include-if-exists can be used. 2. In code first read .auto file then .conf and override the values read from .auto by values from .conf. With Regards, Amit Kapila. -- Sent via pgsql-hackers

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-10-31 Thread Amit kapila
doesn't have comments, so user will not be allowed to give comments with new value of config parameter. Is that okay? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] alter table tablename add column - breaks pl/pgsql function returns tablename

2012-10-31 Thread Amit kapila
it is for you that after a DDL, you reconnect sessions which use functions. I know this is not good workaround, but I am sorry nothing else comes to my mind for now. Anybody else can think of any other better workarounds for this problem? With Regards, Amit Kapila. -- Sent via pgsql

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-01 Thread Amit kapila
, Amit Kapila. As this feature -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-11-05 Thread Amit Kapila
message of each old thread here.) My mistake, I am sorry for that and I shall try to take care for future work. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal [modified] for Allow postgresql.conf values to be changed via SQL

2012-11-06 Thread Amit Kapila
concern for both the features. Suggestions/Comments? With Regards, Amit Kapila. On Saturday, November 03, 2012 7:09 AM Josh Berkus wrote: -Add a configuration subdirectory to the default installation. Needs to follow the config file location, so things like the Debian relocation

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-06 Thread Amit Kapila
On Tuesday, November 06, 2012 11:30 PM Robert Haas wrote: On Wed, Oct 31, 2012 at 8:17 AM, Magnus Hagander mag...@hagander.net wrote: I'm not convinced we ever *had* a consensus on this. There were proposals, but I'm not sure a majority ever bought into any one of 'em. I thought there

Re: [HACKERS] WIP patch for hint bit i/o mitigation

2012-11-07 Thread Amit Kapila
be to invalidate it through Vacuum. Though I am not sure what all other things can make cached id as invalid, but I think once we can think what other ways can make cached id invalid, then we can see if there is a solution to address them. With Regards, Amit Kapila. -- Sent via pgsql-hackers

Re: [HACKERS] WIP patch for hint bit i/o mitigation

2012-11-07 Thread Amit Kapila
-Original Message- From: Atri Sharma [mailto:atri.j...@gmail.com] Sent: Wednesday, November 07, 2012 4:02 PM To: Amit Kapila Cc: Merlin Moncure; PostgreSQL-development Subject: Re: [HACKERS] WIP patch for hint bit i/o mitigation On 07-Nov-2012, at 15:46, Amit Kapila amit.kap

Re: [HACKERS] [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-11-08 Thread Amit Kapila
On Thursday, November 08, 2012 2:04 PM Heikki Linnakangas wrote: On 19.10.2012 14:42, Amit kapila wrote: On Thursday, October 18, 2012 8:49 PM Fujii Masao wrote: Before implementing the timeout parameter, I think that it's better to change both pg_basebackup background process

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-08 Thread Amit Kapila
committed. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-08 Thread Amit Kapila
it, otherwise we can go for value-per-file Approach. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-08 Thread Amit Kapila
/postgresql.conf -rw-r--r-- postgres postgres /etc/postgresql/8.4/main/postgresql.conf So is it okay if we have absolute path of config directory in postgresql.conf? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-08 Thread Amit Kapila
On Thursday, November 08, 2012 8:07 PM Alvaro Herrera wrote: Amit Kapila escribió: 3. Two backends trying to write to .auto file we can use .auto.lock as the the lock by trying to create it in exclusive mode as the first step of the command. If it already exists

Re: [HACKERS] Enabling Checksums

2012-11-08 Thread Amit Kapila
during initdb as mentioned by Robert. Allow user to only do CHECKSUM DISABLE after initdb. 2. Do the Checksum only for particular pages (SRLU) or to do for System tables only. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-11-08 Thread Amit Kapila
On Thursday, November 08, 2012 10:42 PM Fujii Masao wrote: On Thu, Nov 8, 2012 at 5:53 PM, Amit Kapila amit.kap...@huawei.com wrote: On Thursday, November 08, 2012 2:04 PM Heikki Linnakangas wrote: On 19.10.2012 14:42, Amit kapila wrote: On Thursday, October 18, 2012 8:49 PM Fujii Masao

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-09 Thread Amit kapila
On Thursday, November 08, 2012 7:56 PM Amit Kapila On Thursday, November 08, 2012 1:45 AM Robert Haas wrote: On Wed, Nov 7, 2012 at 2:50 PM, Josh Berkus j...@agliodbs.com wrote: Well, Magnus' proposed implementation supposed that the existing values *have* been loaded into the current

Re: [HACKERS] [PATCH] Patch to compute Max LSN of Data Pages

2012-11-10 Thread Amit kapila
for option in pg_resetxlog for restore from WAL files (https://commitfest.postgresql.org/action/patch_view?id=897 ) for which Heikki has given some comments. Any suggestions? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-12 Thread Amit kapila
On Monday, November 12, 2012 12:07 PM Greg Smith wrote: On 11/9/12 11:59 PM, Amit kapila wrote: Please let me know if there are any objections or problems in above method of implementation, else I can go ahead to prepare the patch for the coming CF. It may be the case that the locking

[HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-11-12 Thread Amit kapila
On Monday, November 12, 2012 8:23 PM Fujii Masao wrote: On Fri, Nov 9, 2012 at 3:03 PM, Amit Kapila amit.kap...@huawei.com wrote: On Thursday, November 08, 2012 10:42 PM Fujii Masao wrote: On Thu, Nov 8, 2012 at 5:53 PM, Amit Kapila amit.kap...@huawei.com wrote: On Thursday, November 08, 2012

Re: [HACKERS] [PATCH] Patch to compute Max LSN of Data Pages

2012-11-12 Thread Amit kapila
On Monday, November 12, 2012 9:56 PM Alvaro Herrera wrote: Robert Haas escribió: On Tue, Jul 31, 2012 at 8:09 AM, Amit kapila amit.kap...@huawei.com wrote: I think I can see all of those things being potentially useful. There are a couple of pending patches that will revise the WAL format

Re: [HACKERS] Proof of concept: standalone backend with full FE/BE protocol

2012-11-12 Thread Amit kapila
On Monday, November 12, 2012 8:31 PM Merlin Moncure wrote: On Fri, Sep 14, 2012 at 6:42 AM, Amit kapila amit.kap...@huawei.com wrote: On Tuesday, September 11, 2012 7:07 PM Amit Kapila wrote: On Monday, September 10, 2012 8:20 PM Amit Kapila wrote: On Sunday, September 09, 2012 1:37 PM Amit

Re: [HACKERS] Proof of concept: standalone backend with full FE/BE protocol

2012-11-12 Thread Amit kapila
) but can't we think of it as first version and then based on requirements extend it to have other capabilities: a. to have a mechnism for other background processes (autovacuum, checkpoint, ..). b. more needs to be thought of.. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-13 Thread Amit Kapila
On Wednesday, November 14, 2012 12:25 AM Robert Haas wrote: On Mon, Nov 12, 2012 at 10:59 PM, Amit kapila amit.kap...@huawei.com wrote: Is the above opinion about only locking or even on a way to write the changed things in a file as mentioned in point-1 in mail chain upthread. (Point-1: 1

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-13 Thread Amit Kapila
On Tuesday, November 13, 2012 11:43 PM Josh Berkus wrote: On 11/12/12 7:59 PM, Amit kapila wrote: On Monday, November 12, 2012 12:07 PM Greg Smith wrote: On 11/9/12 11:59 PM, Amit kapila wrote: Please let me know if there are any objections or problems in above method of implementation

Re: [HACKERS] [PATCH] Patch to compute Max LSN of Data Pages

2012-11-14 Thread Amit Kapila
On Tuesday, November 13, 2012 10:17 PM Fujii Masao wrote: On Tue, Nov 13, 2012 at 1:23 PM, Amit kapila amit.kap...@huawei.com wrote: On Monday, November 12, 2012 9:56 PM Alvaro Herrera wrote: Robert Haas escribió: On Tue, Jul 31, 2012 at 8:09 AM, Amit kapila amit.kap...@huawei.com wrote

Re: [HACKERS] [BUGS] BUG #6522: PostgreSQL does not start

2012-04-10 Thread Amit Kapila
: Tuesday, April 10, 2012 9:37 AM To: Amit Kapila Subject: Re: [BUGS] BUG #6522: PostgreSQL does not start Thanks, for your help and sorry for the delay, in Puerto Rico, we had some days off. I did the first recommendation you asked. In task manager I see one process: For the second I have

Re: [HACKERS] Improving our clauseless-join heuristics

2012-04-15 Thread Amit Kapila
I want to clarify small doubt in this regard. In function make_rels_by_clause_joins(..), it tries to join the given relation old_rel with other relations if there exist a join between them. What I can understand is, it is because if there exists a join condition its better to join with that

Re: [HACKERS] Improving our clauseless-join heuristics

2012-04-15 Thread Amit Kapila
Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Improving our clauseless-join heuristics Amit Kapila amit.kap...@huawei.com writes: I want to clarify small doubt in this regard. In function make_rels_by_clause_joins(..), it tries to join the given relation old_rel with other

Re: [HACKERS] Improving our clauseless-join heuristics

2012-04-16 Thread Amit Kapila
with each other rel. -Original Message- From: Tom Lane [mailto:t...@sss.pgh.pa.us] Sent: Monday, April 16, 2012 9:57 AM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Improving our clauseless-join heuristics Amit Kapila amit.kap...@huawei.com writes: That case

Re: [HACKERS] Improving our clauseless-join heuristics

2012-04-16 Thread Amit Kapila
17, 2012 2:05 AM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Improving our clauseless-join heuristics Amit Kapila amit.kap...@huawei.com writes: For this kind of query, currently (referring 9.0.3 code) also it considers join of b,c and b,d. As there is no join

Re: [HACKERS] Improving our clauseless-join heuristics

2012-04-17 Thread Amit Kapila
in? I wanted to know the detail about the idea you told to see if what I am proposing has any merit as compare to your idea. -Original Message- From: Tom Lane [mailto:t...@sss.pgh.pa.us] Sent: Wednesday, April 18, 2012 10:36 AM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re

Re: [HACKERS] Improving our clauseless-join heuristics

2012-04-18 Thread Amit Kapila
Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Improving our clauseless-join heuristics Amit Kapila amit.kap...@huawei.com writes: I'm afraid I'm still not following you very well. Perhaps you could submit a proposed patch? Before that can you please explain in little more detail

[HACKERS] clarification for generate join implied equalities

2012-04-18 Thread Amit Kapila
In function generate_join_implied_equalities_normal(), in which kind of query it can have all three outer_members, inner_members, new_members set? There is handling related to that in the same function down which I wanted to understand.

Re: [HACKERS] RANGE type, and its subtype parameter

2012-04-20 Thread Amit Kapila
If I understood correctly the following query should give your answer: Select opcintype from pg_opclass where opcname = 'operator class name'; ---Original Message- From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Guillaume Lelarge Sent: Friday,

[HACKERS] Usage of planner_ctx

2012-04-24 Thread Amit Kapila
PlannerInfo-planner_ctx is assigned with either MessageContext or PortalHeapMemory depending on the flow from which planner is invoked. My doubt is that during whole planning process till the Plan is stored in PlannedStmt, all the memory is from CurrentMemoryContext which is same as

[HACKERS] Readme of Buffer Management seems to have wrong sentence

2012-05-08 Thread Amit Kapila
While going through Readme in backend\storage\buffer, I found some point misleading. Normal Buffer Replacement Strategy -- -- .. .. Each buffer header contains a usage counter, which is incremented (up to a small limit value) whenever the buffer

Re: [HACKERS] Readme of Buffer Management seems to have wrong sentence

2012-05-23 Thread Amit Kapila
, May 22, 2012 7:55 PM To: Robert Haas Cc: Amit Kapila; PostgreSQL-development Subject: Re: [HACKERS] Readme of Buffer Management seems to have wrong sentence Robert Haas robertmh...@gmail.com writes: On Tue, May 22, 2012 at 10:01 AM, Tom Lane t...@sss.pgh.pa.us wrote: Well, keep in mind

Re: [HACKERS] Readme of Buffer Management seems to have wrong sentence

2012-05-23 Thread Amit Kapila
: Greg Smith [mailto:g...@2ndquadrant.com] Sent: Wednesday, May 23, 2012 10:35 PM To: pgsql-hackers@postgresql.org; amit.kap...@huawei.com Subject: Re: [HACKERS] Readme of Buffer Management seems to have wrong sentence On 05/23/2012 11:36 AM, Amit Kapila wrote: Do you feel I can attempt to address

Re: [HACKERS] Readme of Buffer Management seems to have wrong sentence

2012-05-23 Thread Amit Kapila
, 2012 11:39 PM To: Amit Kapila Cc: Greg Smith; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Readme of Buffer Management seems to have wrong sentence On Wed, May 23, 2012 at 10:33 AM, Amit Kapila amit.kap...@huawei.com wrote: I don't think there is a clear picture yet of what benchmark to use

Re: [HACKERS] Readme of Buffer Management seems to have wrong sentence

2012-05-23 Thread Amit Kapila
to generate the scenarios? -Original Message- From: Jeff Janes [mailto:jeff.ja...@gmail.com] Sent: Wednesday, May 23, 2012 11:48 PM To: Amit Kapila Cc: Tom Lane; Robert Haas; PostgreSQL-development Subject: Re: [HACKERS] Readme of Buffer Management seems to have wrong sentence On Wed, May 23

[HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-08 Thread Amit kapila
This patch is to provide support for fallback application name for contrib/pgbench, oid2name, and dblink. Currently I have done the implementation for pgbench. The implementation is same as in psql. Before creating a final patch, I wanted to check whether my direction for creating a patch is

Re: [HACKERS] log_newpage header comment

2012-06-08 Thread Amit kapila
On further review, I think that we ought to make MarkBufferDirty() the caller's job, because sometimes we may need to xlog only if XLogIsNeeded(), but the buffer's got to get marked dirty either way. Incase the place where Xlog is not required, woudn't it fsync the data; So in that case even

Re: [HACKERS] log_newpage header comment

2012-06-10 Thread Amit Kapila
the code consider page with all zero's as uninitialized or the comment is not appropriate. -Original Message- From: Robert Haas [mailto:robertmh...@gmail.com] Sent: Sunday, June 10, 2012 7:14 PM To: Amit kapila Cc: Tom Lane; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] log_newpage

Re: [HACKERS] Resource Owner reassign Locks

2012-06-11 Thread Amit Kapila
I have few doubts regarding logic of ResourceOwnerRememberLock() and ResourceOwnerForgetLock(): 1. In function ResourceOwnerRememberLock(), when lock count is MAX_RESOWNER_LOCKS, it will not add the lock to lock array but increment the count to make it 11. Now in ResourceOwnerForgetLock(), it

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-11 Thread Amit Kapila
it needs to be done for dblink as well. Please suggest if it needs to be done for dblink, if yes then what should be fallback_application_name for it? From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Amit kapila Sent: Friday, June 08, 2012 10:45

Re: [HACKERS] Resource Owner reassign Locks

2012-06-11 Thread Amit Kapila
: Monday, June 11, 2012 8:52 PM To: Amit Kapila Cc: pgsql-hackers Subject: Re: [HACKERS] Resource Owner reassign Locks On Sun, Jun 10, 2012 at 11:28 PM, Amit Kapila amit.kap...@huawei.com wrote: I have few doubts regarding logic of ResourceOwnerRememberLock() and ResourceOwnerForgetLock(): 1

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-12 Thread Amit Kapila
of this option is okay or what is other way to get the program name. -Original Message- From: Robert Haas [mailto:robertmh...@gmail.com] Sent: Wednesday, June 13, 2012 12:13 AM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] WIP patch for Todo Item : Provide

Re: [HACKERS] hint bit i/o reduction

2012-06-13 Thread Amit Kapila
1) Keep track # times the last transaction id was repeatedly seen in tqual.c (resetting as soon as a new xid was touched. We can do this just for xmin, or separately for both xmin and xmax. Will this be done when we see a new xid duricg scan of tuple, if yes then Won't this logic impact

Re: [HACKERS] hint bit i/o reduction

2012-06-13 Thread Amit Kapila
: Merlin Moncure [mailto:mmonc...@gmail.com] Sent: Wednesday, June 13, 2012 6:50 PM To: Amit Kapila Cc: PostgreSQL-development Subject: Re: [HACKERS] hint bit i/o reduction On Wed, Jun 13, 2012 at 3:57 AM, Amit Kapila amit.kap...@huawei.com wrote: 1) Keep track # times the last transaction id

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-13 Thread Amit Kapila
: Wednesday, June 13, 2012 12:13 AM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink On Mon, Jun 11, 2012 at 5:30 AM, Amit Kapila amit.kap...@huawei.com wrote: As per the previous

Re: [HACKERS] hint bit i/o reduction

2012-06-14 Thread Amit Kapila
Moncure [mailto:mmonc...@gmail.com] Sent: Wednesday, June 13, 2012 8:36 PM To: Amit Kapila Cc: PostgreSQL-development Subject: Re: [HACKERS] hint bit i/o reduction On Wed, Jun 13, 2012 at 9:02 AM, Amit Kapila amit.kap...@huawei.com wrote: Yes, but only in the unhinted case -- in oltp workloads

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-14 Thread Amit Kapila
as per your suggestion, I will remove it during handling of other Review comments for patch unless somebody asks to keep it. -Original Message- From: Robert Haas [mailto:robertmh...@gmail.com] Sent: Thursday, June 14, 2012 7:25 PM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re

[HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-14 Thread Amit Kapila
I am planning to work on the below Todo list item for this CommitFest Allow WAL information to recover corrupted pg_controldata http://archives.postgresql.org/pgsql-patches/2006-06/msg00025.php I wanted to confirm my understanding about the work involved for this patch: The existing patch

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-14 Thread Amit Kapila
[mailto:robertmh...@gmail.com] Sent: Friday, June 15, 2012 12:40 AM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata On Thu, Jun 14, 2012 at 11:39 AM, Amit Kapila amit.kap...@huawei.com wrote: I am planning to work on the below

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-16 Thread Amit kapila
file. So that is the reason I felt it will be relevant to do this patch. From: Cédric Villemain [ced...@2ndquadrant.com] Sent: Saturday, June 16, 2012 2:19 AM To: pgsql-hackers@postgresql.org Cc: Amit kapila; 'Robert Haas' Subject: Re: [HACKERS] Allow WAL

Re: [HACKERS] Resource Owner reassign Locks

2012-06-16 Thread Amit kapila
-tag.locktag_field3); This can give more information about erroneous lock. From: Jeff Janes [jeff.ja...@gmail.com] Sent: Saturday, June 16, 2012 3:21 AM To: Amit kapila Cc: pgsql-hackers Subject: Re: [HACKERS] Resource Owner reassign Locks On Mon, Jun 11, 2012 at 9:30 PM

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-16 Thread Amit kapila
. From: Tom Lane [t...@sss.pgh.pa.us] Sent: Saturday, June 16, 2012 12:11 PM To: Amit kapila Cc: Cédric Villemain; pgsql-hackers@postgresql.org; 'Robert Haas' Subject: Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata Amit kapila amit.kap...@huawei.com

Re: [HACKERS] Resource Owner reassign Locks

2012-06-18 Thread Amit Kapila
, June 18, 2012 4:25 PM To: Amit kapila; Jeff Janes Cc: pgsql-hackers Subject: Re: Resource Owner reassign Locks On 16.06.2012 09:04, Amit kapila wrote: I don't think so. C doesn't ref count its pointers. You are right I have misunderstood. I don't think that lock tags have good human readable

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-18 Thread Amit Kapila
worse not better. I believe if WAL files are proper as mentioned in Alvaro's mail, the purposed logic should generate correct values. Do you see any problem in logic purposed in my original mail. Can I resume my work on this feature? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing

[HACKERS] [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc

2012-06-18 Thread Amit Kapila
similar inconsistency. Committer can suggest if these changes are required. With Regards, Amit Kapila.

[HACKERS] [Review] Prevent the specification of conflicting transaction read/write options

2012-06-18 Thread Amit Kapila
to updated. 1. Regression suite should be updated with test cases. 2. Code should be modified for Code Review Comments. So I am marking this as Waiting on Author With Regards, Amit Kapila

Re: [HACKERS] Resource Owner reassign Locks

2012-06-19 Thread Amit Kapila
something. In you previous mail you agreed with level as ERROR for elog message in function ResourceOwnerForgetLock(..) function, but in your modification you have used PANIC, is there any specific reason for it. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-19 Thread Amit Kapila
recent WAL segments. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-19 Thread Amit Kapila
it will be difficult to use PITR in this scenario. -Original Message- From: Fujii Masao [mailto:masao.fu...@gmail.com] Sent: Tuesday, June 19, 2012 7:44 PM To: Amit Kapila Cc: Tom Lane; Alvaro Herrera; Cédric Villemain; Pg Hackers; Robert Haas Subject: Re: [HACKERS] Allow WAL information

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-19 Thread Amit Kapila
to partially-committed transactions. You should immediately dump your data, run initdb, and reload. After reload, check for inconsistencies and repair as needed. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-20 Thread Amit Kapila
. Please correct my understanding if I am wrong. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-20 Thread Amit Kapila
, it can work the way you have explained or even by using Replication solutions where user can recreate the database from slave or other copy. But the tool pg_resetxlog or similar tools are provided to handle situations where user has not taken care enough to be saved from corruption. With Regards, Amit

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-20 Thread Amit Kapila
. -Original Message- From: Aidan Van Dyk [mailto:ai...@highrise.ca] Sent: Wednesday, June 20, 2012 7:13 PM To: Amit Kapila Cc: Pg Hackers Subject: Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata On Wed, Jun 20, 2012 at 9:21 AM, Amit Kapila amit.kap...@huawei.com wrote

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-20 Thread Amit Kapila
from all are most welcome. It can help me to do some useful work for PostgreSQL. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-21 Thread Amit Kapila
should still reset the WAL so that no replay happens. 2. It is to avoid some further disasters. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Catalog/Metadata consistency during changeset extraction from wal

2012-06-22 Thread Amit Kapila
described. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-22 Thread Amit Kapila
for pg_control and proceed. Suggestions? If there is an agreement to do this features, I can send the proposal which kind of options we can keep in existing or new utility for the usage. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata

2012-06-23 Thread Amit Kapila
-Original Message- From: Robert Haas [mailto:robertmh...@gmail.com] Sent: Friday, June 22, 2012 8:59 PM To: Amit Kapila Cc: Tom Lane; Alvaro Herrera; Cédric Villemain; Pg Hackers Subject: Re: [HACKERS] Allow WAL information to recover corrupted pg_controldata On Fri, Jun 22, 2012 at 5

Re: [HACKERS] Catalog/Metadata consistency during changeset extraction from wal

2012-06-24 Thread Amit Kapila
will also get blocked. And If we do this without holding locks and decided to go ahead then there can be other WAL generated by the meantime and can create a problem. Or if there is another way to make DDL's wait? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] WAL format changes

2012-06-25 Thread Amit Kapila
provided by the user for -l Option, if input is greater it will use the input to set in control file. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] new --maintenance-db options

2012-06-26 Thread Amit Kapila
database would be interesting for many people using PG. There is another use case of embedded databases that they allow another remote connections as well to monitor the operations in database. However that can be done in a later version of implementation. With Regards, Amit Kapila. -- Sent via

Re: [HACKERS] new --maintenance-db options

2012-06-27 Thread Amit Kapila
Tom Lane t...@sss.pgh.pa.us writes: Amit Kapila amit.kap...@huawei.com writes: [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Tom Lane The implementation I've wanted to see for some time is that you can start a standalone backend, but it speaks FE/BE protocol to its caller

[HACKERS] Regarding WAL Format Changes

2012-06-27 Thread Amit Kapila
the XLOG. recvFileTLI is the TimeLineID In the above comments, there is still reference to Id/Seg/Off. With Regards, Amit Kapila.

Re: [HACKERS] Regarding WAL Format Changes

2012-06-27 Thread Amit Kapila
From: Heikki Linnakangas [mailto:heikki.linnakan...@enterprisedb.com] Sent: Wednesday, June 27, 2012 8:26 PM On 27.06.2012 17:14, Amit Kapila wrote: 2. @@ -2680,8 +2645,8 @@ InstallXLogFileSegment(uint32 *log, uint32 *seg, char *tmppath, LWLockRelease(ControlFileLock

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-28 Thread Amit Kapila
purpose for them. I understand this is good to have feature, but if it doesn't cost much then according to me it can be done. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

[HACKERS] Patch-2 (2-move-continuation-record-to-page-header.patch) WAL Format Changes

2012-06-28 Thread Amit Kapila
? Sorry for sending the observations in pieces rather than all-together, as I am not sure how much I will be able to complete. So what ever I am able to read, I am sending you my doubts or observations. With Regards, Amit Kapila.

[HACKERS] patch-3 (3-allow-wal-record-header-to-be-split.patch)WAL Format Changes

2012-06-30 Thread Amit kapila
will it release WALInsertLock or end critical section. With Regards, Amit Kapila.

[HACKERS] Re: patch-3 (3-allow-wal-record-header-to-be-split.patch)WAL Format Changes

2012-07-01 Thread Amit kapila
From: Heikki Linnakangas [heikki.linnakan...@enterprisedb.com] Sent: Sunday, July 01, 2012 1:54 AM On 30.06.2012 10:11, Amit kapila wrote: 3. General observation, not related to your changes XLogInsert(RmgrId rmid, uint8 info, XLogRecData *rdata) . . if (freespace == 0

[HACKERS] [WIP] Patch : Change pg_ident.conf parsing to be the same as pg_hba.conf

2012-07-02 Thread Amit Kapila
of pg_ident same as pg_hba I have done the basic testing and test is still in progress. Suggestions? With Regards, Amit Kapila. pg_ident_parsing.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Amit Kapila
commit fest. Shouldn't it be added for next CF. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

<    1   2   3   4   5   6   7   8   9   10   >