Re: [HACKERS] PostgreSQL in the French news

2012-09-24 Thread Michael Paquier
of the document does not seem to make the use of free software mandatory, but to require that it is at least considered for any project in which the administration (i.e. the public sector, not the government as in the USA) is involved. +1. Such news are nice for Postgres. -- Michael Paquier http

Re: [HACKERS] pg_reorg in core?

2012-09-24 Thread Michael Paquier
for concurrent on system tables (not easy for shared catalogs) Doesn't this exclude all the tables that are in the schema catalog? 3. no support for the indexes of exclusion constraints (not hard I think) This just consists in a check of indisready in pg_index. -- Michael Paquier http

Re: [HACKERS] pg_reorg in core?

2012-09-25 Thread Michael Paquier
On Tue, Sep 25, 2012 at 5:55 PM, Andres Freund and...@2ndquadrant.comwrote: On Tuesday, September 25, 2012 04:37:05 AM Michael Paquier wrote: On Tue, Sep 25, 2012 at 8:13 AM, Andres Freund and...@2ndquadrant.com wrote: Could you clarify what do you mean here by cleanup? I am afraid I do

Re: [HACKERS] pg_reorg in core?

2012-09-25 Thread Michael Paquier
would like to work on such features and provide patches for the 2 first. This will of course strongly depend on the time I can spend on in the next couple of months. -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] htup header reorganization breaks many extension modules

2012-09-26 Thread Michael Paquier
htup_details.h, so the correction effort is not that much... -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] pg_reorg in core?

2012-09-26 Thread Michael Paquier
On Wed, Sep 26, 2012 at 8:13 PM, Andres Freund and...@2ndquadrant.comwrote: On Tuesday, September 25, 2012 01:48:34 PM Michael Paquier wrote: On Tue, Sep 25, 2012 at 5:55 PM, Andres Freund and...@2ndquadrant.com wrote: On Tuesday, September 25, 2012 04:37:05 AM Michael Paquier wrote

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-03 Thread Michael Paquier
to implement this and this looks like roughly the right direction... Thanks for spending time on it. -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-03 Thread Michael Paquier
on the same table or index in parallel? -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-03 Thread Michael Paquier
On 2012/10/03, at 23:52, Andres Freund and...@2ndquadrant.com wrote: On Wednesday, October 03, 2012 04:28:59 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Maybe I am missing something here, but reindex concurrently should do 1) BEGIN 2) Lock table in share update exlusive

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-03 Thread Michael Paquier
On 2012/10/04, at 5:41, Andres Freund and...@2ndquadrant.com wrote: On Wednesday, October 03, 2012 10:12:58 PM Michael Paquier wrote: On 2012/10/03, at 23:52, Andres Freund and...@2ndquadrant.com wrote: On Wednesday, October 03, 2012 04:28:59 PM Tom Lane wrote: Andres Freund

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-03 Thread Michael Paquier
are on the same line. -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-03 Thread Michael Paquier
On 2012/10/04, at 10:00, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: On Wed, Oct 3, 2012 at 5:10 PM, Andres Freund and...@2ndquadrant.comwrote: 14) Swap new and old indexes, consisting here in switching their names. I think switching based

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-03 Thread Michael Paquier
this mechanism, so it would be good for consistency. 3) Switch the OIDs of indexes. Looks safe from the system prospective and it will be necessary to invalidate the cache entries for both relations after swap. Any opinions on this one? -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-04 Thread Michael Paquier
visibility issues and have an index switch processing which is more consistent with the existing implementation as it could rely on the same mechanism as normal reindex that switches relfilenode. -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-10-08 Thread Michael Paquier
with if we had support for accessing the catalog with the same snapshot as the main query was using... IIRC that's been discussed in the past for other issues. Yes, it would be better and helpful to have such a mechanism even for other operations. -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] pg_stat_lwlocks view - lwlocks statistics, round 2

2012-10-13 Thread Michael Paquier
the performance debugging. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Global Sequences

2012-10-15 Thread Michael Paquier
provides global sequence values with the GTM. -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] [help] Is it possible to support remote COPY operation on PG?

2012-10-24 Thread Michael Paquier
On Wed, Oct 24, 2012 at 3:54 PM, Xiong He iih...@qq.com wrote: Is it possible to copy some table data from remote client to the PG database server directly without upload the data file to the server side in advance? With a psql client you can use the command ¥copy to perform that. -- Michael

Re: [HACKERS] Creating indexes in the background

2012-10-29 Thread Michael Paquier
it is running on server side. You can still use a batch processing for doing such operations like: psql -c create index concurrently foo on tab(a) -p $port -h $host $dbname But this needs to be done on the client application side that will maintain alive a session on server. -- Michael Paquier http

Re: [HACKERS] Synchronous commit not... synchronous?

2012-10-31 Thread Michael Paquier
information has been flushed on its disk. -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Synchronous commit not... synchronous?

2012-11-01 Thread Michael Paquier
that this is correct behavior, because in Peter's case the manual command gets the priority on the value of synchronous_commit, no? If anybody thinks that I am wrong, feel free to argue on that of course... -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] RFC: Timing Events

2012-11-01 Thread Michael Paquier
what/where it is? pg_statsinfo perhaps? It is used for stat info management: http://pgfoundry.org/projects/pgstatsinfo/ -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Features of Postgresql and Postgres-xc with MySQL

2012-05-02 Thread Michael Paquier
about the project: http://michael.otacoo.com/presentations/conferences/ Hope this helps. Regards, -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] LOCK DATABASE

2011-05-26 Thread Michael Paquier
like pg_hba.conf. SQL approach looks to be better. At this point, perhaps you may be interested in such an approach: http://wiki.postgresql.org/wiki/Lock_database I wrote that after the cluster summit. Regards, -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

2011-06-29 Thread Michael Paquier
that's how we name our branches :P Thanks, +10. This is cool and will avoid for sure future problems. -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Michael Paquier
developers can translate those README files since the words used in the files chosen to be understandable for those who are familiar with PostgreSQL internals. You may be surprised by the quality of translations from non-developers findable in a lot of Open source softwares. -- Michael Paquier http

Re: [HACKERS] Finding tables dropped by DROP TABLE CASCADE

2011-08-16 Thread Michael Paquier
Just a suggestion, but... Why not using an external wrapper function on reportDependentObjects in dependency.c to find the list of Oids for a cascade deletion based on a list of objects? Isn't it possible? Regards, -- Michael Paquier http://michael.otacoo.com

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-02-07 Thread Michael Paquier
On Thu, Feb 7, 2013 at 5:01 PM, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@2ndquadrant.com writes: What about 3) Use reltoastidxid if != InvalidOid and manually build the list (using RelationGetIndexList) otherwise? Do we actually need reltoastidxid at all? I always

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-02-07 Thread Michael Paquier
On Thu, Feb 7, 2013 at 5:15 PM, Andres Freund and...@2ndquadrant.comwrote: On 2013-02-07 03:01:36 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: What about 3) Use reltoastidxid if != InvalidOid and manually build the list (using RelationGetIndexList) otherwise?

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-02-12 Thread Michael Paquier
On Tue, Feb 12, 2013 at 8:47 PM, Andres Freund and...@2ndquadrant.comwrote: On 2013-02-07 17:28:53 +0900, Michael Paquier wrote: On Thu, Feb 7, 2013 at 5:15 PM, Andres Freund and...@2ndquadrant.comwrote: Btw, I think that if this optimization for toast relations is done, it should

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-02-12 Thread Michael Paquier
On Tue, Feb 12, 2013 at 10:04 PM, Andres Freund and...@2ndquadrant.comwrote: On 2013-02-12 21:54:52 +0900, Michael Paquier wrote: Changing only toast_save_datum: [... code ...] Yes, I have spent a little bit of time looking at the code related to retoastindxid and thought about

Re: [HACKERS] 9.2.3 crashes during archive recovery

2013-02-21 Thread Michael Paquier
On Thu, Feb 21, 2013 at 11:09 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 15.02.2013 15:49, Heikki Linnakangas wrote: Attached is a patch for git master. The basic idea is to split InArchiveRecovery into two variables, InArchiveRecovery and ArchiveRecoveryRequested.

[HACKERS] use_remote_explain missing in docs of postgres_fdw

2013-02-21 Thread Michael Paquier
Hi all, While testing a bit this feature, I noticed that use_remote_explain is available in the list of options for FOREIGN TABLE and SERVER but this is not specified in the docs: http://www.postgresql.org/docs/devel/static/postgres-fdw.html postgres=# CREATE FOREIGN TABLE foo (a int, b int)

Re: [HACKERS] use_remote_explain missing in docs of postgres_fdw

2013-02-22 Thread Michael Paquier
On Fri, Feb 22, 2013 at 5:13 PM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: While testing a bit this feature, I noticed that use_remote_explain is available in the list of options for FOREIGN TABLE and SERVER but this is not specified in the docs

[HACKERS] New hooks for snapshot and transaction ID acquisition from external source

2013-02-22 Thread Michael Paquier
Hi, What do you think about adding hooks for transaction ID and snapshot acquisition? Those hooks could be located in AssignTransactionId:xact.c for transaction ID and GetTransactionSnapshot:snapmgr.c for snapshots. This is useful for multi-master applications that use external tools to feed with

Re: [HACKERS] Materialized views WIP patch

2013-02-23 Thread Michael Paquier
On Sat, Feb 23, 2013 at 9:55 PM, Greg Stark st...@mit.edu wrote: On Sat, Feb 23, 2013 at 1:00 AM, Josh Berkus j...@agliodbs.com wrote: I prefer RESET, especially since it could eventually support RESET ALL MATERIALIZED VIEWS if that turns out to be useful. How does the parser like that?

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-02-27 Thread Michael Paquier
Andres, Masao, do you need an extra round or review or do you think this is ready to be marked as committer? On my side I have nothing more to add to the existing patches. Thanks, -- Michael

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-02-28 Thread Michael Paquier
On Thu, Feb 28, 2013 at 4:56 PM, anara...@anarazel.de and...@anarazel.dewrote: Hi, Michael Paquier michael.paqu...@gmail.com schrieb: Andres, Masao, do you need an extra round or review or do you think this is ready to be marked as committer? On my side I have nothing more to add

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-05 Thread Michael Paquier
On Tue, Mar 5, 2013 at 11:22 PM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Mar 5, 2013 at 10:35 PM, Michael Paquier michael.paqu...@gmail.com wrote: Thanks for the review. All your comments are addressed and updated patches are attached. I got the compile warnings: tuptoaster.c

Re: [HACKERS] Writable foreign tables: how to identify rows

2013-03-05 Thread Michael Paquier
On Wed, Mar 6, 2013 at 12:35 PM, Pavan Deolasee pavan.deola...@gmail.comwrote: +1 for adding a new system attribute. We did something similar in Postgres-XC, though problem there was much simpler because we always knew that the remote FDW is a Postgres instance running the same version. So we

Re: [HACKERS] Request for vote to move forward with recovery.conf overhaul

2013-03-05 Thread Michael Paquier
Thanks for taking time in typing a complete summary of the situation. That really helps. On Mon, Mar 4, 2013 at 11:25 AM, Greg Smith g...@2ndquadrant.com wrote: On 1/23/13 6:36 AM, Michael Paquier wrote: The only problem I see is if the same parameter is defined in recovery.conf

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-06 Thread Michael Paquier
On Wed, Mar 6, 2013 at 9:09 PM, Andres Freund and...@2ndquadrant.comwrote: On 2013-03-06 20:59:37 +0900, Michael Paquier wrote: OK. Patches updated... Please see attached. With all the work done on those patches, I suppose this is close to being something clean... Yes, its looking good

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-06 Thread Michael Paquier
On Thu, Mar 7, 2013 at 2:09 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Mar 6, 2013 at 8:59 PM, Michael Paquier michael.paqu...@gmail.com wrote: OK. Patches updated... Please see attached. I found odd behavior. After I made REINDEX CONCURRENTLY fail twice, I found that the index

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-06 Thread Michael Paquier
On Thu, Mar 7, 2013 at 7:19 AM, Andres Freund and...@2ndquadrant.comwrote: On 2013-03-07 05:26:31 +0900, Michael Paquier wrote: On Thu, Mar 7, 2013 at 2:34 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Mar 7, 2013 at 2:17 AM, Andres Freund and...@2ndquadrant.com wrote

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-06 Thread Michael Paquier
On Thu, Mar 7, 2013 at 9:48 AM, Michael Paquier michael.paqu...@gmail.comwrote: On Thu, Mar 7, 2013 at 7:19 AM, Andres Freund and...@2ndquadrant.comwrote: On 2013-03-07 05:26:31 +0900, Michael Paquier wrote: On Thu, Mar 7, 2013 at 2:34 AM, Fujii Masao masao.fu...@gmail.com wrote

[HACKERS] Materialized views and unique indexes

2013-03-07 Thread Michael Paquier
Hi all, While testing materialized views, I found the following behavior with unique indexes: postgres=# create table aa as select generate_series(1,3) as a; SELECT 3 postgres=# create materialized view aam as select * from aa; SELECT 3 postgres=# create unique index aam_ind on aam(a); CREATE

Re: [HACKERS] Materialized views and unique indexes

2013-03-07 Thread Michael Paquier
On Fri, Mar 8, 2013 at 11:33 AM, Josh Berkus j...@agliodbs.com wrote: As expected, the refresh failed, but the error message is not really user-friendly. Shouldn't we output instead something like that? ERROR: could not refresh materialized view because of failure when rebuilding index

Re: [HACKERS] Materialized views and unique indexes

2013-03-07 Thread Michael Paquier
On Fri, Mar 8, 2013 at 12:32 PM, Tom Lane t...@sss.pgh.pa.us wrote: Craig Ringer cr...@2ndquadrant.com writes: On 03/08/2013 10:55 AM, Michael Paquier wrote: Also, as it is not mandatory for a unique index to be a constraint, I think that we should block the creation of unique indexes too

Re: [HACKERS] Request for vote to move forward with recovery.conf overhaul

2013-03-08 Thread Michael Paquier
On Wed, Mar 6, 2013 at 2:08 PM, Michael Paquier michael.paqu...@gmail.comwrote: Thanks for taking time in typing a complete summary of the situation. That really helps. On Mon, Mar 4, 2013 at 11:25 AM, Greg Smith g...@2ndquadrant.com wrote: On 1/23/13 6:36 AM, Michael Paquier wrote

Re: [HACKERS] Request for vote to move forward with recovery.conf overhaul

2013-03-08 Thread Michael Paquier
On Sat, Mar 9, 2013 at 1:20 PM, Greg Smith g...@2ndquadrant.com wrote: There are currently 20 Needs Review and 14 Waiting on Author things left in the queue, so it's not quite that there's no time left. There really isn't very much left to do on this. The rough consensus idea from before

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-09 Thread Michael Paquier
On Sun, Mar 10, 2013 at 4:50 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sun, Mar 10, 2013 at 3:48 AM, Fujii Masao masao.fu...@gmail.com wrote: Thanks for updating the patch! - SELECT reltoastidxid -

[HACKERS] Incorrect handling of timezones with extract

2013-03-12 Thread Michael Paquier
Hi all, When running some QE tests at VMware, we found an error with extract handling timezones. Please see below: postgres=# show timezone; TimeZone Asia/Tokyo (1 row) postgres=# select now(); now --- 2013-03-12 14:54:28.911298+09 (1

Re: [HACKERS] Incorrect handling of timezones with extract

2013-03-12 Thread Michael Paquier
On Tue, Mar 12, 2013 at 3:11 PM, Michael Paquier michael.paqu...@gmail.comwrote: postgres=# select extract(day from ((CAST(-3 || 'day' as interval)+now()) - now())); date_part --- -2 (1 row) Here I believe that the correct result should be -3. Note that it passes

[HACKERS] Assertion failure when promoting node by deleting recovery.conf and restart node

2013-03-14 Thread Michael Paquier
Hi, When trying to *promote* a slave as master by removing recovery.conf and restarting node, I found an assertion failure on master branch: LOG: database system was shut down in recovery at 2013-03-15 10:22:27 JST TRAP: FailedAssertion(!(ControlFile-minRecoveryPointTLI != 1), File: xlog.c,

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-16 Thread Michael Paquier
On 2013/03/17, at 0:35, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier michael.paqu...@gmail.com wrote: I have been working on improving the code of the 2 patches: I found pg_dump dumps even the invalid index. But pg_dump should ignore the invalid

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-17 Thread Michael Paquier
that makes pg_dump not take a dump of invalid indexes. This patch can be backpatched to 9.0. On Sun, Mar 17, 2013 at 3:31 AM, Michael Paquier michael.paqu...@gmail.comwrote: On 2013/03/17, at 0:35, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier I

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-18 Thread Michael Paquier
On Tue, Mar 19, 2013 at 3:03 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sun, Mar 17, 2013 at 9:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: Please find attached the patches wanted: - 20130317_dump_only_valid_index.patch, a 1-line patch that makes pg_dump not take a dump

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-18 Thread Michael Paquier
On Tue, Mar 19, 2013 at 3:24 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier michael.paqu...@gmail.com wrote: I have been working on improving the code of the 2 patches: 1) reltoastidxid removal: snip - Fix a bug with pg_dump and binary

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-18 Thread Michael Paquier
On Tue, Mar 19, 2013 at 8:54 AM, Michael Paquier michael.paqu...@gmail.comwrote: On Tue, Mar 19, 2013 at 3:03 AM, Fujii Masao masao.fu...@gmail.comwrote: On Sun, Mar 17, 2013 at 9:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: Please find attached the patches wanted

[HACKERS] Ignore invalid indexes in pg_dump

2013-03-19 Thread Michael Paquier
Hi, If failures happen with CREATE INDEX CONCURRENTLY, the system will be let with invalid indexes. I don't think that the user would like to see invalid indexes of an existing system being recreated as valid after a restore. So why not removing from a dump invalid indexes with something like the

Re: [HACKERS] Ignore invalid indexes in pg_dump

2013-03-20 Thread Michael Paquier
On Thu, Mar 21, 2013 at 12:58 AM, Tom Lane t...@sss.pgh.pa.us wrote: I had been on the fence about what to do here, but I find Josh's arguments persuasive, particularly the second one. Why shouldn't we consider an in-progress index to be an uncommitted DDL change? (Now admittedly, there

[HACKERS] SIGHUP not received by custom bgworkers if postmaster is notified

2013-03-21 Thread Michael Paquier
Hi all, While playing with custom background workers, I noticed that postmaster does not notify its registered bgworkers if it receives SIGHUP, so you have to send a SIGHUP directly to the bgworker process to notify it. Signal handling is correctly done for SIGQUIT and SIGTERM for shutdown only.

Remove invalid indexes from pg_dump Was: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-21 Thread Michael Paquier
Hi, On Sun, Mar 17, 2013 at 9:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: Please find attached the patches wanted: - 20130317_dump_only_valid_index.patch, a 1-line patch that makes pg_dump not take a dump of invalid indexes. This patch can be backpatched to 9.0. The patch

Re: [HACKERS] SIGHUP not received by custom bgworkers if postmaster is notified

2013-03-21 Thread Michael Paquier
On Fri, Mar 22, 2013 at 12:15 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Euler Taveira escribió: On 21-03-2013 05:06, Michael Paquier wrote: While playing with custom background workers, I noticed that postmaster does not notify its registered bgworkers if it receives SIGHUP

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-21 Thread Michael Paquier
Is someone planning to provide additional feedback about this patch at some point? Thanks, -- Michael

Re: [HACKERS] SIGHUP not received by custom bgworkers if postmaster is notified

2013-03-22 Thread Michael Paquier
Hi all, Please find attached a simple example of bgworker that logs a message each time a SIGTERM or SIGHUP signal is received by it: - hello signal: processed SIGHUP when SIGHUP is handled by my example - hello signal: processed SIGTERM when SIGTERM is handled by my example With the current

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-23 Thread Michael Paquier
On Sat, Mar 23, 2013 at 10:20 PM, Andres Freund and...@2ndquadrant.comwrote: On 2013-03-22 07:38:36 +0900, Michael Paquier wrote: Is someone planning to provide additional feedback about this patch at some point? Yes, now that I have returned from my holidays - or well, am returning from

Re: [HACKERS] Interesting post-mortem on a near disaster with git

2013-03-24 Thread Michael Paquier
On Mon, Mar 25, 2013 at 12:52 AM, Tom Lane t...@sss.pgh.pa.us wrote: Over the weekend, KDE came within a gnat's eyelash of losing *all* their authoritative git repos, despite having seemingly-extensive redundancy. Read about it here: http://jefferai.org/2013/03/24/too-perfect-a-mirror/ It

Re: [HACKERS] Request for vote to move forward with recovery.conf overhaul

2013-03-25 Thread Michael Paquier
On Mon, Mar 25, 2013 at 1:14 PM, Simon Riggs si...@2ndquadrant.com wrote: On 25 March 2013 04:08, Michael Paquier michael.paqu...@gmail.com wrote: Feedback is warmly welcome. I'll look at this in the coming week. Thanks. -- Michael

Re: [HACKERS] Ignore invalid indexes in pg_dump

2013-03-26 Thread Michael Paquier
On Wed, Mar 27, 2013 at 6:47 AM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: On top of checking indisvalid, I think that some additional checks on indislive and indisready are also necessary. Those are not necessary, as an index that is marked

Re: [HACKERS] [COMMITTERS] pgsql: Allow external recovery_config_directory

2013-03-27 Thread Michael Paquier
On Wed, Mar 27, 2013 at 9:12 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 27.03.2013 13:47, Simon Riggs wrote: Allow external recovery_config_directory If required, recovery.conf can now be located outside of the data directory. Server needs read/write permissions on this

Re: [HACKERS] [COMMITTERS] pgsql: Allow external recovery_config_directory

2013-03-27 Thread Michael Paquier
On Wed, Mar 27, 2013 at 9:59 PM, Michael Paquier michael.paqu...@gmail.comwrote: On Wed, Mar 27, 2013 at 9:12 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 27.03.2013 13:47, Simon Riggs wrote: Allow external recovery_config_directory If required, recovery.conf can now

Re: [HACKERS] [COMMITTERS] pgsql: Allow external recovery_config_directory

2013-03-27 Thread Michael Paquier
On Wed, Mar 27, 2013 at 10:11 PM, Simon Riggs si...@2ndquadrant.com wrote: On 27 March 2013 12:59, Michael Paquier michael.paqu...@gmail.com wrote: Also, based on Greg's spec (that Robert and I basically agreed on), if recovery.conf is found at the root of data folder an error is returned

Re: [HACKERS] [COMMITTERS] pgsql: Allow external recovery_config_directory

2013-03-27 Thread Michael Paquier
On Wed, Mar 27, 2013 at 10:43 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: 3. Would it make sense to make the option recovery_config_file, pointing to the file, instead of just the directory? +1 on that. I just sent the same suggestion. -- Michael

Re: [HACKERS] [COMMITTERS] pgsql: Allow external recovery_config_directory

2013-03-27 Thread Michael Paquier
On Wed, Mar 27, 2013 at 11:26 PM, Robert Haas robertmh...@gmail.com wrote: There are also weird edge cases here when the server is promoted. The recovery.conf file won't exist any more, but the GUC settings changes it contains will live on until the next SIGHUP. Yes indeed, I forgot that.

Re: [HACKERS] [COMMITTERS] pgsql: Allow external recovery_config_directory

2013-03-27 Thread Michael Paquier
On Thu, Mar 28, 2013 at 2:58 AM, Simon Riggs si...@2ndquadrant.com wrote: Arguments against? Also the fact that many discussions have been done on recovery.conf between the time this feature has been decided and actually committed (perhaps too promptly just by looking at how this thread is

Re: [HACKERS] [COMMITTERS] pgsql: Allow external recovery_config_directory

2013-03-27 Thread Michael Paquier
On Thu, Mar 28, 2013 at 6:05 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: What exactly was wrong with pg_basebackup -R, without recovery_config_directory? pg_basebackup -R generates automatically recovery.conf inside data folder, so if recovery_config_directory is specified the slave

Re: [HACKERS] Changing recovery.conf parameters into GUCs

2013-03-28 Thread Michael Paquier
Hi, The main argument on which this proposal is based on is to keep backward-compatibility. This has been discussed before many times and the position of each people is well-known, so I am not going back to that... So, based on *only* what I see in this thread... On Fri, Mar 29, 2013 at 12:48

Re: [HACKERS] Changing recovery.conf parameters into GUCs

2013-03-29 Thread Michael Paquier
On Fri, Mar 29, 2013 at 9:59 PM, Simon Riggs si...@2ndquadrant.com wrote: On 29 March 2013 01:17, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Mar 29, 2013 at 12:48 AM, Simon Riggs si...@2ndquadrant.com wrote: Early discussions had difficulties because of the lack of config

Re: [HACKERS] Getting to 9.3 beta

2013-03-29 Thread Michael Paquier
On 2013/03/30, at 2:33, Andres Freund and...@2ndquadrant.com wrote: On 2013-03-29 12:28:59 -0400, Tom Lane - REINDEX CONCURRENTLY: Imo pretty close to being comittable and pretty useful, but it got redesigned pretty late and it mostly had review from me and fujii and it could use a

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-31 Thread Michael Paquier
Hi, I moved this patch to the next commit fest. Thanks, -- Michael

[HACKERS] Typo in documentation for function to_json

2013-04-03 Thread Michael Paquier
Hi all, While reading some documentation about json functions, I found a typo with the example used with function to_json. A bracket was missing. Please find attached the patch correcting that. Regards, -- Michael 20120403_to_json_typo.patch Description: Binary data -- Sent via

Re: [HACKERS] Typo in documentation for function to_json

2013-04-03 Thread Michael Paquier
On Wed, Apr 3, 2013 at 10:32 PM, Andrew Dunstan and...@dunslane.net wrote: I have a patch for this and other docs errors waiting in the wings. I will commit it when the current hiatus is done, some time tomorrow. OK thanks. -- Michael

Re: [HACKERS] bgworker sigusr1 handler

2013-04-10 Thread Michael Paquier
On Wed, Apr 10, 2013 at 12:15 PM, Robert Haas robertmh...@gmail.com wrote: Just for fun, I implemented a toy background worker tonight using the new bgworker framework. Generally, it went well, and I'm pleased with the design of the new facility. However, I did notice one oddity. I

Re: [HACKERS] SIGHUP not received by custom bgworkers if postmaster is notified

2013-04-10 Thread Michael Paquier
Thanks for committing the fix! On Thu, Apr 11, 2013 at 4:11 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Michael Paquier escribió: Hi all, Please find attached a simple example of bgworker that logs a message each time a SIGTERM or SIGHUP signal is received by it: - hello signal

Re: [HACKERS] [GSOC] questions about idea rewrite pg_dump as library

2013-04-11 Thread Michael Paquier
On Fri, Apr 12, 2013 at 1:00 AM, Stephen Frost sfr...@snowman.net wrote: Well, either they want that or they want that output more accessibly, and without all the baggage that pg_dump necessarily brings to the table. pg_dump does a lot of stuff that's basically designed for bulk

Re: [HACKERS] Add SPI_gettypmod() fucntion

2013-04-11 Thread Michael Paquier
On Fri, Apr 12, 2013 at 7:53 AM, Miguel Angel de Blas Burdalo migueldeb...@gmail.com wrote: Hi hackers, My name is Miguel Angel de Blas. I'm newbie and it's my first collaboration so I hope it's correct ;-) I created a function SPI_gettypmod: int32SPI_gettypmod(TupleDesc tupdesc, int

Re: [HACKERS] Add regression tests for COLLATE

2013-04-11 Thread Michael Paquier
On Thu, Apr 11, 2013 at 4:14 PM, Robins Tharakan thara...@gmail.com wrote: Hi, Please find attached a patch to take 'make check' code-coverage of COLLATE (/src/backend/commands/collationcmds) from 0% to 96%. Any feedback is more than welcome. Also posting this to Commitfest-next. Just by

Re: [HACKERS] Recovery target 'immediate'

2013-04-21 Thread Michael Paquier
On Fri, Apr 19, 2013 at 3:11 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: I just found out that if you use continuous archiving and online backups, it's surprisingly difficult to restore a backup, without replaying any more WAL than necessary. If you don't set a recovery target,

Re: [HACKERS] REFRESH MATERIALIZED VIEW command in PL block hitting Assert

2013-04-24 Thread Michael Paquier
On Tue, Apr 23, 2013 at 11:05 PM, Andres Freund and...@2ndquadrant.comwrote: On 2013-04-23 19:33:24 +0530, Jeevan Chalke wrote: On Tue, Apr 23, 2013 at 7:01 PM, Merlin Moncure mmonc...@gmail.com wrote: On Tue, Apr 23, 2013 at 7:18 AM, Jeevan Chalke jeevan.cha...@enterprisedb.com

[HACKERS] \watch stuck on execution of commands returning no tuples

2013-05-01 Thread Michael Paquier
Hi all, When testing \watch, I noticed that process waits indefinitely when executing it with a DDL or a DML. For example: postgres=# CREATE TABLE aa (a int); postgres=# ANALYSE aa \watch 10 -- Process waiting here By referring at do_watch:command.c, the feature is made such as there is no error

Re: [HACKERS] Recovery target 'immediate'

2013-05-01 Thread Michael Paquier
On Thu, May 2, 2013 at 7:40 AM, Bruce Momjian br...@momjian.us wrote: On Fri, Apr 26, 2013 at 09:48:48AM -0400, Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: That said, maybe the easier choice for a *system* (such as v-thingy) would be to simply to the full backup using

Re: [HACKERS] Recovery target 'immediate'

2013-05-02 Thread Michael Paquier
On Fri, May 3, 2013 at 8:56 AM, Bruce Momjian br...@momjian.us wrote: On Thu, May 2, 2013 at 09:31:03AM +0200, Magnus Hagander wrote: Actually, there is - I hear it quite often from people not so experienced in PostgreSQL. Though in fairness, I'm not entirely sure the new syntax would

Re: [HACKERS] \watch stuck on execution of commands returning no tuples

2013-05-02 Thread Michael Paquier
On Thu, May 2, 2013 at 11:01 PM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: Hi all, When testing \watch, I noticed that process waits indefinitely when executing it with a DDL or a DML. For example: postgres=# CREATE TABLE aa (a int

Re: [HACKERS] [PATCH] pgbench --throttle (submission 4)

2013-05-02 Thread Michael Paquier
Hi, It would be better to submit updated versions of a patch on the email thread it is dedicated to and not create a new thread so as people can easily follow the progress you are doing. Thanks, -- Michael

Re: [HACKERS] \watch stuck on execution of commands returning no tuples

2013-05-06 Thread Michael Paquier
On Sun, May 5, 2013 at 5:42 AM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: On Thu, May 2, 2013 at 11:01 PM, Tom Lane t...@sss.pgh.pa.us wrote: Perhaps it'd be a good idea to emit the command tag on receiving a non-tuple-bearing result, just to make

Re: [HACKERS] Proposal to add --single-row to psql

2013-05-09 Thread Michael Paquier
On Thu, May 9, 2013 at 9:12 AM, David Fetter da...@fetter.org wrote: On Wed, May 08, 2013 at 06:08:28PM -0500, Jim Nasby wrote: I believe that makes it significantly harder for them to actually contribute code back that doesn't give them a business advantage, as well as making it harder to

Re: [HACKERS] Add regression tests for COLLATE

2013-05-09 Thread Michael Paquier
On Thu, May 9, 2013 at 4:19 PM, Fabien COELHO coe...@cri.ensmp.fr wrote: However, it is not clear whether these tests run automatically or only if they are explicitely called. The README seems to suggest that it is the later. If so, maybe having them invoked automatically if possible would

Re: [HACKERS] Parallel Sort

2013-05-13 Thread Michael Paquier
On Mon, May 13, 2013 at 11:28 PM, Noah Misch n...@leadboat.com wrote: * Identifying Parallel-Compatible Functions Not all functions can reasonably run on a worker backend. We should not presume that a VOLATILE function can tolerate the unstable execution order imposed by parallelism, though

Re: [HACKERS] Parallel Sort

2013-05-14 Thread Michael Paquier
On Tue, May 14, 2013 at 11:59 PM, Noah Misch n...@leadboat.com wrote: On Tue, May 14, 2013 at 01:51:42PM +0900, Michael Paquier wrote: On Mon, May 13, 2013 at 11:28 PM, Noah Misch n...@leadboat.com wrote: * Identifying Parallel-Compatible Functions Not all functions can reasonably

<    1   2   3   4   5   6   7   8   9   10   >