Re: [HACKERS] Last gasp

2012-04-11 Thread Peter Geoghegan
), and that was, as far as I can tell, a roaring success. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Last gasp

2012-04-12 Thread Peter Geoghegan
lots of opinions on this thread on our processes and so on, some of which, if followed through on, would be quite large departures. I hope that they were received as modest suggestions. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Memory usage during sorting

2012-04-13 Thread Peter Geoghegan
to be optimal to use timsort based on a high statistical correlation between physical row ordering and logical ordering of a key column's values. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Memory usage during sorting

2012-04-13 Thread Peter Geoghegan
On 13 April 2012 17:42, Peter Geoghegan pe...@2ndquadrant.com wrote: One insight that I had at the time was that text comparisons where the c locale isn't used are really rather expensive, and I doubt that there is too much that can be done to address that directly.  However, if we were

Re: [HACKERS] Memory usage during sorting

2012-04-13 Thread Peter Geoghegan
exactly the same interface as a c stdlib qsort. So it'd be fairly easy to produce a timsort_arg() based on this, if anyone cares to. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Patch: add timing of buffer I/O requests

2012-04-13 Thread Peter Geoghegan
. Thanks. I actually thought this myself, but didn't want to mention it because I didn't think that it was up to me to decide, or to attempt to influence that decision. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] Patch: add timing of buffer I/O requests

2012-04-13 Thread Peter Geoghegan
to pay for low-overhead dynamic query statistics . -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Memory usage during sorting

2012-04-14 Thread Peter Geoghegan
On 14 April 2012 13:32, Greg Stark st...@mit.edu wrote: On Fri, Apr 13, 2012 at 7:01 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: Well, timsort is specifically designed to take advantage of pre-sorted data. It does appear to have a lot of traction, as wikipedia points out: I hadn't

Re: [HACKERS] Patch: add timing of buffer I/O requests

2012-04-14 Thread Peter Geoghegan
bytes for this very reason. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch: add timing of buffer I/O requests

2012-04-14 Thread Peter Geoghegan
performance overhead for all queries, particularly if the feature is of minority interest. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Memory usage during sorting

2012-04-16 Thread Peter Geoghegan
On 14 April 2012 14:34, Peter Geoghegan pe...@2ndquadrant.com wrote: FWIW, I started playing with adding timsort to Postgres last night: https://github.com/Peter2ndQuadrant/postgres/tree/timsort I've fixed this feature-branch so that every qsort_arg call site (including the tuplesort

[HACKERS] Timsort performance, quicksort (was: Re: Memory usage during sorting)

2012-04-18 Thread Peter Geoghegan
attempt to patch-up quicksort to prevent this problem. I lean towards no, since the cure may well be worse than the disease. Thoughts? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Timsort performance, quicksort

2012-04-19 Thread Peter Geoghegan
of sorting a single key of non-c collated text for it to be worth it, and that's just too thin for me to sink more time into this right now. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Timsort performance, quicksort (was: Re: Memory usage during sorting)

2012-04-24 Thread Peter Geoghegan
is obviously the really compelling case for optimisation here. This situation is only going to be made worse by the work you've done on SortSupport for text, which, incidentally, I agree is worthwhile. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

[HACKERS] Typo in access/transam/xlog.c

2012-04-30 Thread Peter Geoghegan
Within access/transam/xlog.c , the following comment has an obvious error: * (This should not be called for for synchronous commits.) -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] proposal: additional error fields

2012-05-01 Thread Peter Geoghegan
, associated with each constraint, but I suppose that the details of the API would require a great deal of bike shedding. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] proposal: additional error fields

2012-05-01 Thread Peter Geoghegan
(including very simple ones like grep), so that they can make this very important practical distinction. The hard part is replacing the severity level of many existing elog/ereport call sites, but that's not much of a problem, really. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] proposal: additional error fields

2012-05-01 Thread Peter Geoghegan
to worry about, and errors that are routine. To my mind it's a pity that Postgres doesn't similarly draw this distinction, even if that does imply that there will be a certain amount of grey area. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] proposal: additional error fields

2012-05-01 Thread Peter Geoghegan
-- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] proposal: additional error fields

2012-05-01 Thread Peter Geoghegan
monitoring if it's actually something that there is a reasonable expectation of finding on most or all Postgres production systems in all circumstances. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing

Re: [HACKERS] proposal: additional error fields

2012-05-01 Thread Peter Geoghegan
On 1 May 2012 21:14, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: Maybe no one is convinced by any of this, but the fact is that the SQLSTATE argument falls down when one considers that we aren't using it in many cases of errors that clearly are severe

Re: [HACKERS] proposal: additional error fields

2012-05-01 Thread Peter Geoghegan
still seeing other types of errors. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

[HACKERS] Have we out-grown Flex?

2012-05-01 Thread Peter Geoghegan
thought - Flex/Lex is not the only tool for generating yacc-compatible lexical analysers, and it may not be the best one for our current needs. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] proposal: additional error fields

2012-05-01 Thread Peter Geoghegan
that should never occur as a result of any legitimate user activity.  Like, with grep.  And, without needing to have a PhD in Postgresology. I couldn't agree more. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql

Re: [HACKERS] Have we out-grown Flex?

2012-05-02 Thread Peter Geoghegan
to pursue for 9.3, though it's only about number 3 on that list right now. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Have we out-grown Flex?

2012-05-02 Thread Peter Geoghegan
this, which might encourage more hackers to venture into Windows land. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] Latch for the WAL writer - further reducing idle wake-ups.

2012-05-02 Thread Peter Geoghegan
() is also a very hot code path, and it's where one of the SetLatch() calls goes in the earlier BGWriter patch, besides which I haven't been able to quantify any performance hit as yet. Thoughts? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Have we out-grown Flex?

2012-05-02 Thread Peter Geoghegan
please share your figures and methodology? I've heard of far larger proportions than that. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] remove dead ports?

2012-05-03 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Latch for the WAL writer - further reducing idle wake-ups.

2012-05-03 Thread Peter Geoghegan
included, we roundly beat MySQL in this area, which will be a nice advocacy message for 9.2, though I probably shouldn't be quoted on that until I get the opportunity to go back and make absolutely sure that I've been fair. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] remove dead ports?

2012-05-05 Thread Peter Geoghegan
think that that organisation isn't in any meaningful sense a successor - certainly, they don't produce the IRIX workstations (or any other) that were the main business of SGI for so long. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] remove dead ports?

2012-05-05 Thread Peter Geoghegan
that we're doing them any kind of disservice. Continuing to support these platforms is actually the less conservative option. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Latch for the WAL writer - further reducing idle wake-ups.

2012-05-08 Thread Peter Geoghegan
apologise for making such a basic error. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Latch for the WAL writer - further reducing idle wake-ups.

2012-05-08 Thread Peter Geoghegan
On 9 May 2012 00:21, Peter Geoghegan pe...@2ndquadrant.com wrote: Yes, there is some checking of flags before the potential ResetLatch() call, which may be acted on. The code there is almost identical to that of the extant bgwriter code. I was under the impression that this did not amount

Re: [HACKERS] Draft release notes complete

2012-05-10 Thread Peter Geoghegan
more efficiently during periods of inactivity (Peter Geoghegan, Heikki Linnakangas, Tom Lane)...This reduces CPU wake-ups. I think that there should be mention of why this is a good thing. When fully idle the server reaches less than a single wake-up per second, which I think is a nice, relevant

Re: [HACKERS] Draft release notes complete

2012-05-10 Thread Peter Geoghegan
-author, particularly if they're a committer, but it's a little misleading to add a reviewer after the feature description without qualifying that they are the reviewer. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] WaitLatchOrSocket API needs more thought for socket error conditions

2012-05-13 Thread Peter Geoghegan
implementation in the first place if these subtleties were considered earlier, since IIRC the justification for introducing it was rather weak. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Foreign keys in pgbench

2012-05-13 Thread Peter Geoghegan
this isn't - I personally would have found it very useful recently. pgbench is an expert-level tool, and I find arguments against adding more options along the lines of that will distract beginner users completely unconvincing. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] Draft release notes complete

2012-05-13 Thread Peter Geoghegan
can be said at all for people who don't work for one of the handful of Postgres companies. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

[HACKERS] Why do we still have commit_delay and commit_siblings?

2012-05-13 Thread Peter Geoghegan
synthetic pgbench runs, but I cannot see why the new adaptive implementation wouldn't entirely shadow the old one even in that situation. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Why do we still have commit_delay and commit_siblings?

2012-05-14 Thread Peter Geoghegan
the benefit of the doubt more. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes complete

2012-05-14 Thread Peter Geoghegan
. This is used in XLogFlush(), so    that when the lock is acquired, the backend flushes the WAL, but if it's    not, the backend first checks the current flush location before retrying.    Original patch and benchmarking by Peter Geoghegan and Simon Riggs, although    this patch as committed ended up

Re: [HACKERS] Draft release notes complete

2012-05-15 Thread Peter Geoghegan
-of-view, to call our new group commit group commit in release notes and documentation, and announce it as a new feature. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Exclusion Constraints on Arrays?

2012-05-23 Thread Peter Geoghegan
unfortunate, given that the 9.0 release notes say: Exclusion constraints generalize uniqueness constraints by allowing arbitrary comparison operators, not just equalityThis is useful for time periods and other ranges, as well as arrays. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] pg_stat_statements temporary file

2012-05-24 Thread Peter Geoghegan
values in pg_stat_statements, which, while rather annoying and possibly unacceptable, is hardly the end of the world. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] pg_stat_statements temporary file

2012-05-24 Thread Peter Geoghegan
() call, which actually has more protections against corruption. The window for the saved file to be corrupt seems rather small, though I accept that a better window would be zero. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] shared_preload_libraries path

2012-05-24 Thread Peter Geoghegan
around with the operating system configuration? Or is that too much reimplementing OS functionality? -1, I'm afraid. I found this blog post to be insightful: https://blogs.oracle.com/rie/entry/tt_ld_library_path_tt -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] shared_preload_libraries path

2012-05-24 Thread Peter Geoghegan
On 24 May 2012 13:22, Peter Geoghegan pe...@2ndquadrant.com wrote: I found this blog post to be insightful: https://blogs.oracle.com/rie/entry/tt_ld_library_path_tt This one might be more useful, and itself refers to the aforementioned, earlier post: https://blogs.oracle.com/ali/entry

Re: [HACKERS] pg_stat_statments queryid

2012-05-24 Thread Peter Geoghegan
referred to in the docs anyway. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] pg_stat_statments queryid

2012-05-24 Thread Peter Geoghegan
of the internal value. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_stat_statments queryid

2012-05-24 Thread Peter Geoghegan
it and document it. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Draft release notes complete

2012-05-24 Thread Peter Geoghegan
to be any support for that view. In passing, I noticed this: E.1.3.12.2. pg_stat_statements Improve pg_stat_statements to aggregate similar queries (Peter Geoghegan, Tom Lane) Improve pg_stat_statements' handling of PREPARE/EXECUTE statements (Tom Lane) Add dirtied and written block counts

Re: [HACKERS] Draft release notes complete

2012-05-24 Thread Peter Geoghegan
: http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=5b4f346611431361339253203d486789e4babb02 -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] pg_stat_statements temporary file

2012-05-25 Thread Peter Geoghegan
of this file to not be in the global/ directory, but this is a quick (back-patchable) fix... Where do you suggest the file be written to? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] [PATCH] Make skipped sort explicit in EXPLAIN ANALYZE

2012-05-25 Thread Peter Geoghegan
://en.wikipedia.org/wiki/Quicksort -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-28 Thread Peter Geoghegan
is that it increases the rate of batching at lower client counts, without needlessly delaying each and every follower beyond when their transaction is likely to have committed. A more detailed analysis will have to wait for tomorrow. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-29 Thread Peter Geoghegan
On 29 May 2012 07:16, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 29.05.2012 04:18, Peter Geoghegan wrote: Benchmark results, with and without a delay of 3000ms (commit_siblings is 0 in both cases) are available from: http://leadercommitdelay.staticloud.com Sorry, I do

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-29 Thread Peter Geoghegan
, I was directing your attention towards clients-set.png . I am in the habit of hacking pgbench-tools to output much bigger gnu-plot images. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services move_delay_2012_05_29.v2.patch Description

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-29 Thread Peter Geoghegan
On 29 May 2012 17:58, Robert Haas robertmh...@gmail.com wrote: On Tue, May 29, 2012 at 12:47 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: Why do you think that doing this for all XLogFlush() callsites might be problematic? Well, consider the one in the background writer, for example

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-30 Thread Peter Geoghegan
be totally misnamed - they really ought to be flush_delay and flush_siblings at that point. Seems reasonable. It would also have the advantage of avoiding having the new implementation tarred with the same brush as commit_delay. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-30 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-31 Thread Peter Geoghegan
in the docs, I think that's everything. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-31 Thread Peter Geoghegan
that the patch can sometimes double transaction throughput for an absolutely trivial change, moving 2 lines of code, is also a good reason to not bump this for another year. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-31 Thread Peter Geoghegan
for the batch, and not within each and every backend as it commits. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-31 Thread Peter Geoghegan
On 31 May 2012 16:26, Peter Geoghegan pe...@2ndquadrant.com wrote: On 31 May 2012 16:23, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: In what way is it possibly destabilising? I'm prepared to believe that it only affects performance, but it could

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-05-31 Thread Peter Geoghegan
is the right environment for that to happen. It couldn't possibly be as destabilising to performance as commit_delay was in 9.1. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-06-01 Thread Peter Geoghegan
on that benchmark. This seems to make all the difference. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

2012-06-05 Thread Peter Geoghegan
that an officially blessed repo is essentially equivalent to something somebody privately produces is simply not accurate. If it was, why would you even care? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] New Postgres committer: Kevin Grittner

2012-06-07 Thread Peter Geoghegan
On 7 June 2012 23:15, Tom Lane t...@sss.pgh.pa.us wrote:  Please join me in welcoming him aboard. Congratulations, Kevin. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] New Postgres committer: Kevin Grittner

2012-06-07 Thread Peter Geoghegan
On 7 June 2012 23:40, Peter Geoghegan pe...@2ndquadrant.com wrote: On 7 June 2012 23:15, Tom Lane t...@sss.pgh.pa.us wrote:  Please join me in welcoming him aboard. Congratulations, Kevin. Idle thought for the web team: Now might be a good time to take down the blurb on .org in which Kevin

Re: [HACKERS] Avoiding adjacent checkpoint records

2012-06-07 Thread Peter Geoghegan
. Your customer's use-case seems very narrow, and your complaint seems unusual to me, but couldn't you just get the customer to force checkpoints in a cronjob or something? CheckPointStmt will force, provided !RecoveryInProgress() . -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] sortsupport for text

2012-06-14 Thread Peter Geoghegan
common denominator...or it could be because it just doesn't matter that much. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] sortsupport for text

2012-06-14 Thread Peter Geoghegan
() calls with copying each text string, somewhere like within a specialised datumCopy(), that would make the approach more efficient still, as you specify a location for the blob in the just-palloc()'d leading-key private memory directly, rather than just using memcpy. -- Peter Geoghegan       http

Re: [HACKERS] sortsupport for text

2012-06-14 Thread Peter Geoghegan
worked with would probably be able to fit a large majority of its text strings into 16 chars of memory - you yourself said that sorting toasted text isn't at all common. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] sortsupport for text

2012-06-14 Thread Peter Geoghegan
, given that in general each buffer is expected to grow at exactly the same rate? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] sortsupport for text

2012-06-14 Thread Peter Geoghegan
that in general each buffer is expected to grow at exactly the same rate? Sure, but it would be making the code more complicated in return for no measurable performance benefit.  We generally avoid that. Fair enough. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] sortsupport for text

2012-06-15 Thread Peter Geoghegan
, if it's the leading key we're dealing with (and of course, it usually will be), before exceeding work_mem all of the *entire* set of strings to be sorted are sitting in palloc()'d memory anyway. I'm surprised that you didn't immediately concede the point, to be honest. -- Peter Geoghegan       http

Re: [HACKERS] sortsupport for text

2012-06-16 Thread Peter Geoghegan
be represented as ASCII. In light of this, I think there is a pretty strong case to be made for pre-processing text via strxfrm() as part of this patch. Thoughts? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services strxfrm_test.tar.gz

Re: [HACKERS] sortsupport for text

2012-06-17 Thread Peter Geoghegan
as we go blue in the face telling them not to of course, but that's fairly normal. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] sortsupport for text

2012-06-17 Thread Peter Geoghegan
against poor quality qsort() implementations that went quadratic in the face of lots of duplicates, No, I don't recall that that had anything to do with it. Oh, okay. It looked very much like the avoid equality at all costs thing you still see some of in tuplesort.c . -- Peter Geoghegan

Re: [HACKERS] sortsupport for text

2012-06-17 Thread Peter Geoghegan
On Jun 17, 2012 5:50 PM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: On 17 June 2012 17:01, Tom Lane t...@sss.pgh.pa.us wrote: How exactly do you plan to shoehorn that into SQL? You could invent some nonstandard equivalence operator I suppose, but what

Re: [HACKERS] sortsupport for text

2012-06-17 Thread Peter Geoghegan
have any simpler ideas, assuming this one is no good? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] sortsupport for text

2012-06-17 Thread Peter Geoghegan
On 17 June 2012 23:58, Peter Geoghegan pe...@2ndquadrant.com wrote: We can decree that equivalency implies equality, or make all this internal (which, perversely, I suppose the C++ committee people cannot). Sorry, that should obviously read equality implies equivalency. We may not have

Re: [HACKERS] sortsupport for text

2012-06-18 Thread Peter Geoghegan
(from 2005, on a Fedora 4 machine) cannot be recreated. So it may be that they've tightened these things up in some way. It's far from clear why that should be. It could be worth -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] sortsupport for text

2012-06-18 Thread Peter Geoghegan
On 18 June 2012 16:59, Peter Geoghegan pe...@2ndquadrant.com wrote: Perhaps more importantly, I cannot recreate any of these problems on my Fedora 16 machine. Even with hu_HU on LATIN2, Tom's original test case (from 2005, on a Fedora 4 machine) cannot be recreated. So it may be that they've

Re: [HACKERS] sortsupport for text

2012-06-19 Thread Peter Geoghegan
time. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] sortsupport for text

2012-06-19 Thread Peter Geoghegan
On 19 June 2012 16:17, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Peter Geoghegan pe...@2ndquadrant.com wrote: So, just to give a bit more weight to my argument that we should recognise that equivalent strings ought to be treated identically Since we appear to be questioning

Re: [HACKERS] sortsupport for text

2012-06-19 Thread Peter Geoghegan
On 19 June 2012 17:45, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Peter Geoghegan pe...@2ndquadrant.com wrote: Are you sure that they actually have a tie-breaker, and don't just make the distinction between equality and equivalence (if only internally)? I'm pretty sure that when I

Re: [HACKERS] sortsupport for text

2012-06-19 Thread Peter Geoghegan
(), this won't help you. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] sortsupport for text

2012-06-19 Thread Peter Geoghegan
On 19 June 2012 19:44, Peter Geoghegan pe...@2ndquadrant.com wrote: You could do that, and some people do use custom collations for various reasons. That's obviously very much of minority interest though. Most people will just use citext or something. However, since citext is itself a client

Re: [HACKERS] use of int4/int32 in C code

2012-06-19 Thread Peter Geoghegan
that. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] sortsupport for text

2012-06-20 Thread Peter Geoghegan
On 20 June 2012 11:00, Peter Eisentraut pete...@gmx.net wrote: On sön, 2012-06-17 at 23:58 +0100, Peter Geoghegan wrote: So if you take the word Aßlar here - that is equivalent to Asslar, and so strcoll(Aßlar, Asslar) will return 0 if you have the right LC_COLLATE This is not actually

Re: [HACKERS] sortsupport for text

2012-06-20 Thread Peter Geoghegan
On 19 June 2012 19:44, Peter Geoghegan pe...@2ndquadrant.com wrote: PostgreSQL supported Unicode before 2005, when the tie-breaker was introduced. I know at least one Swede who used Postgres95. I just took a look at the REL6_4 branch, and it looks much the same in 1999 as it did in 2005

Re: [HACKERS] sortsupport for text

2012-06-20 Thread Peter Geoghegan
equality use strcoll and not fall back to strcmp. What about per-column collations? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] sortsupport for text

2012-06-20 Thread Peter Geoghegan
On 20 June 2012 15:55, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: I think that this change may have made the difference between the Hungarians getting away with it and not getting away with it. Might it have been that for text, they were using some

Re: [HACKERS] sortsupport for text

2012-06-20 Thread Peter Geoghegan
On 20 June 2012 17:41, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: No, I'm suggesting it would probably be at least a bit of a win here to cache the constant, and only have to do a strxfrm() + strcmp() per comparison. Um, have you got any hard evidence

Re: [HACKERS] pgbench--new transaction type

2012-06-20 Thread Peter Geoghegan
ought to make an effort to give people more options. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] pgbench--new transaction type

2012-06-20 Thread Peter Geoghegan
a facility for specifying new tables in scripts, with a moderate degree of flexibility as to their definition, data, and the distribution of that data. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] sortsupport for text

2012-06-20 Thread Peter Geoghegan
On 20 June 2012 17:41, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: No, I'm suggesting it would probably be at least a bit of a win here to cache the constant, and only have to do a strxfrm() + strcmp() per comparison. Um, have you got any hard evidence

Re: [HACKERS] sortsupport for text

2012-06-20 Thread Peter Geoghegan
On 21 June 2012 01:22, Peter Geoghegan pe...@2ndquadrant.com wrote: I've written a very small C++ program, which I've attached, that basically proves that this can still make a fairly large difference - I hope it's okay that that it's C++, but that allowed me to write the program quickly

<    1   2   3   4   5   6   7   8   9   10   >