Re: [HACKERS] sortsupport for text

2012-06-21 Thread Peter Geoghegan
On 21 June 2012 10:24, Florian Pflug f...@phlo.org wrote: On Jun21, 2012, at 02:22 , Peter Geoghegan wrote: I've written a very small C++ program, which I've attached, that basically proves that this can still make a fairly large difference - I hope it's okay that that it's C

Re: [HACKERS] sortsupport for text

2012-06-21 Thread Peter Geoghegan
characteristics of using strxfrm() to traverse an index. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] [PATCH 04/16] Add embedded list interface (header only)

2012-06-21 Thread Peter Geoghegan
(head, t); In the first call, head is specified and then node. In the second, node and then head. This could probably stand to be made consistent. That's all for now... -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] [PATCH 04/16] Add embedded list interface (header only)

2012-06-21 Thread Peter Geoghegan
the position that we don't care about any compiler not represented in the buildfarm. I note that you said that it doesn't pass the quiet inline test, and not that it doesn't support inline functions. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Preferred way to define 64-bit constants?

2012-06-24 Thread Peter Geoghegan
not be a problem in practice, but I'm told that some very esoteric compilers could baulk at things like that. http://gcc.gnu.org/onlinedocs/gcc/Long-Long.html -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing

Re: [HACKERS] [PATCH 04/16] Add embedded list interface (header only)

2012-06-25 Thread Peter Geoghegan
hard to deal with that we should just blow off compilers where inline doesn't work well. Fair enough. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-06-27 Thread Peter Geoghegan
the GUCs, since this patch will cause them to control WAL flush in general, as opposed to commit specifically? Peter Geoghegan and Simon were arguing that we should retitle it to group_commit_delay rather than just commit_delay, but that doesn't seem to be much of an improvement in describing what

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-06-28 Thread Peter Geoghegan
don't see why you would, it seems like a really bad judgement to not change the name. Is anyone aware of a non-zero commit_delay in the wild today? I personally am not. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-06-28 Thread Peter Geoghegan
On 28 June 2012 19:25, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Peter Geoghegan pe...@2ndquadrant.com wrote: Is anyone aware of a non-zero commit_delay in the wild today? I personally am not. http://archives.postgresql.org/pgsql-performance/2011-11/msg00083.php In that thread

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-06-28 Thread Peter Geoghegan
On 28 June 2012 19:55, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 28, 2012 at 2:18 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: You think it will confuse users less if we start telling them to use something that we have a very long history of telling them not to use? I don't

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-06-28 Thread Peter Geoghegan
deprecating VACUUM FULL. The old VACUUM FULL actually had something to recommend it. It seems unlikely that the same thing can be said for commit_delay. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-06-28 Thread Peter Geoghegan
it had no plausible downside, so why not? That's all I have to say about the matter. If it isn't obvious that the name should be changed, based on what I've already said, it never will be. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-06-28 Thread Peter Geoghegan
if there was any downside to doing so, but there isn't. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] elog/ereport noreturn decoration

2012-06-29 Thread Peter Geoghegan
all those false positives. The greater problem is that the analyser apparently won't work across translation units. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] enhanced error fields

2012-07-02 Thread Peter Geoghegan
. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services eelog-2012-07-02.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] enhanced error fields

2012-07-02 Thread Peter Geoghegan
On 2 July 2012 15:19, Peter Geoghegan pe...@2ndquadrant.com wrote: On 9 May 2012 14:33, Pavel Stehule pavel.steh...@gmail.com wrote: here is patch with enhancing ErrorData structure. Now constraints errors and RI uses these fields So I took a look at the patch eelog-2012-05-09.diff today. All

Re: [HACKERS] enhanced error fields

2012-07-03 Thread Peter Geoghegan
On 3 July 2012 17:26, Pavel Stehule pavel.steh...@gmail.com wrote: Hello Peter, thank you very much for review No problem. I'll do some copy-editing of comments and doc changes when you produce another revision. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] pgfoundry references in docs

2012-07-03 Thread Peter Geoghegan
. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Re: Latch implementation that wakes on postmaster death on both win32 and Unix

2011-05-26 Thread Peter Geoghegan
I'm a bit disappointed that no one has commented on this yet. I would have appreciated some preliminary feedback. Anyway, I've added it to CommitFest 2011-06. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-05-26 Thread Peter Geoghegan
on win32. It's far neater there. I'm still seeing that lagger process (which is an overstatement) at times, so I guess it is normal. On Windows, there is no detailed PS output, so I actually don't know what the lagger process is, and no easy way to determine that immediately occurs to me. -- Peter

Re: [HACKERS] kill -KILL: What happens?

2011-05-27 Thread Peter Geoghegan
On 27 May 2011 10:01, Florian Pflug f...@phlo.org wrote: Anyway, I'm glad to see that Peter Geoghegan has picked this up any turned this into an actual patch. Extremely cool! Thanks Florian. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] bad posix_fadvise support causes initdb to exit ungracefully

2011-06-15 Thread Peter Geoghegan
to posix_fadvise() when various macros are defined. It isn't exactly uncommon for it to be merely unavailable - on many of our supported platforms, setting effective_io_concurrency to anything other than 0 causes an error. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Peter Geoghegan
to do it this way than to touch all the different ways in which MyProcPid might be initialised, I suspect. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Peter Geoghegan
compare the pid with? And you can include the pid in log_line_prefix if it turns out to be useful after all. All fair points. FWIW, I think it's pretty unlikely that anyone will ever see this error message. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Peter Geoghegan
point, because, as you say, it's unlikely that clients will ever much care. I'd be happy to document that we make no promises, on the off chance that some future caller might care. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-17 Thread Peter Geoghegan
at least, because it doesn't occur to me how we can handle that failure usefully in an asynchronous fashion. Anyway, that code has been simplified, and my intent clarified. Thanks. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-19 Thread Peter Geoghegan
I took another look at this this evening, and realised that my comments could be a little clearer. Attached revision cleans them up a bit. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/access/transam

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-21 Thread Peter Geoghegan
. That is another patch though, that I thought best to have independently reviewed, only when this patch is committed. I've only made the walsender use the new interface, changing as little as possible and not affecting walsender's behaviour, as a stopgap towards that patch. -- Peter Geoghegan

Re: [HACKERS] Coding style point: const in function parameter declarations

2011-06-21 Thread Peter Geoghegan
memory?), but that isn't very relevant in practice. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-22 Thread Peter Geoghegan
, built-in facility. Fixed. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 4952d22..bfe6bcd 100644 --- a/src/backend/access/transam/xlog.c +++ b

Re: [HACKERS] pg_dump vs malloc

2011-06-22 Thread Peter Geoghegan
On 22 June 2011 16:25, Magnus Hagander mag...@hagander.net wrote: Something along the line of this? IMHO the redefinition of malloc() looks a bit hairy...can't you just make the callers use the functions directly? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] Coding style point: const in function parameter declarations

2011-06-22 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-24 Thread Peter Geoghegan
those two small changes. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] News on Clang

2011-06-24 Thread Peter Geoghegan
numbers claimed (at -O0), I still think that Clang has a lot of promise. Here are the slides from that presentation: http://www.scribd.com/doc/48921683/LLVM-Clang-Advancing-Compiler-Technology -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] News on Clang

2011-06-24 Thread Peter Geoghegan
On 25 June 2011 00:27, Peter Eisentraut pete...@gmx.net wrote: On fre, 2011-06-24 at 18:02 +0100, Peter Geoghegan wrote: I'm very encouraged by this - Clang is snapping at the heels of GCC here. I'd really like to see Clang as a better supported compiler, We have a build farm member for Clang

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-24 Thread Peter Geoghegan
Attached is patch that addresses Fujii's third and most recent set of concerns. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 4952d22

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-30 Thread Peter Geoghegan
I've phrased my error messages is inconsistent with that style guide, excepty perhaps the pipe() reference, but if you feel it's important to try and use could not, I have no objections. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] Potential NULL dereference found in typecmds.c

2011-07-04 Thread Peter Geoghegan
is never executed. Perhaps this is a can-never-happen situation? Alvaro? Seems slightly academic IMHO. No code path should dereference an invariably NULL or wild pointer. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] Problem installing odbc and .Net drivers on Windows 7 64 Ultimate

2011-07-04 Thread Peter Geoghegan
can fix it. This is the developer's mailing list. You should ask this question on the pgsql-general mailing list. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-07-04 Thread Peter Geoghegan
disadvantage of making Heikki's proposed assertion failure useless. Is the implementation of PostmasterIsAlive() really a problem at the moment? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-07-04 Thread Peter Geoghegan
the behaviour guaranteed across platforms, however unlikely it seems. I'd like to hear what Heikki has to say about asserting or otherwise verifying postmaster death in the case of apparent postmaster death wake-up. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-07-05 Thread Peter Geoghegan
on Windows. Since that standard cannot be the kill() based test, because that would make a postmaster death aware latch implementation impossible, it has to be the read() test proposed by Florian. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Changing extension schema fails silently

2011-07-05 Thread Peter Geoghegan
-extnamespace = nspOid; So clearly the catalog column ought to have been updated. I can't recreate the problem here, and I too am working from git head on the master branch. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] proper format for printing GetLastError()

2011-07-06 Thread Peter Geoghegan
/en-us/library/ms680582(v=VS.85).aspx -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-07-07 Thread Peter Geoghegan
). Making them a bit weaker still seems acceptable. In addition, we'd change the implementation of PostmasterIsAlive() to /just/ perform the read() test as already described. I'm not concerned about the possibility of spurious extra cycles of auxiliary process event loops - should I be? -- Peter

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-07-08 Thread Peter Geoghegan
rather flimsy. Anyone that still has any misgivings about this will probably feel better once the assertion is never reported to fail on any of the diverse systems that PostgreSQL will be tested on in advance of the 9.2 release. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-07-08 Thread Peter Geoghegan
by ' PGARCH_AUTOWAKE_INTERVAL having passed since last_copy_time, or * until postmaster dies. */ Other than that, I suggest you commit v8 as-is. Incidentally, I like that this removes the amDirectChild argument to PostmasterIsAlive() - an added benefit. -- Peter Geoghegan       http://www

Re: [HACKERS] News on Clang

2011-07-08 Thread Peter Geoghegan
On 8 July 2011 15:15, Peter Eisentraut pete...@gmx.net wrote: On lör, 2011-06-25 at 01:02 +0100, Peter Geoghegan wrote: I'm glad that you feel we're ready to officially support Clang - should this be in the 9.1 release notes? Done Reportedly, LLVM r134697 speeds things up considerably

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-07-08 Thread Peter Geoghegan
it, given that we use the same masks on wakeEvents to inform the function what events we'll actually be waiting on for the call. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-07-08 Thread Peter Geoghegan
On 8 July 2011 17:10, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I just committed the v8 of the patch, BTW, after fixing the comment typo you pointed out. Thanks! Great, thanks. Also, thank you Florian and Fujii. -- Peter Geoghegan       http://www.2ndQuadrant.com

[HACKERS] Reduced power consumption in WAL Writer process

2011-07-13 Thread Peter Geoghegan
there is a codepath specifically for the case where wal_writer_delay exceeds one second, so it is included in this initial version. Comments? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/postmaster

Re: [HACKERS] Reduced power consumption in WAL Writer process

2011-07-15 Thread Peter Geoghegan
. I'll work towards that implementation. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Reduced power consumption in WAL Writer process

2011-07-17 Thread Peter Geoghegan
, should I worry about the timeout long for WaitLatch() overflowing? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c index 2f3fcbf..cf5eb59 100644

[HACKERS] Reduced power consumption in autovacuum launcher process

2011-07-18 Thread Peter Geoghegan
), which is just 4 bytes. (2^31) - 1 = 2,147,483,647 microseconds = only about 35 minutes. There are corner cases, such as if someone were to set autovacuum_naptime to something silly. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] Reduced power consumption in autovacuum launcher process

2011-07-19 Thread Peter Geoghegan
of microseconds. +1 -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PL/Python: No stack trace for an exception

2011-07-21 Thread Peter Geoghegan
problem or this needs addressing? Traceback information will be added to PL/Python errors in Postgres 9.1, due out in about September. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-21 Thread Peter Geoghegan
, while preserving the original copyright notices. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] libedit memory stomp is apparently fixed in OS X Lion

2011-07-22 Thread Peter Geoghegan
and indeed it looks fixed.  So, if any early adopters want to try it out ... I'll add that I've heard reports that Lion Server comes with PostgreSQL as standard, and Lion Desktop comes with psql. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] libpq SSL with non-blocking sockets

2011-07-24 Thread Peter Geoghegan
the commit made immediately prior to this one - d0c23026b2499ba9d6797359241ade076a5a677d. I'm building with my usual, rather generic settings for hacking. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] Netbeans and postgres

2011-07-28 Thread Peter Geoghegan
2011/7/28 pasman pasmański pasma...@gmail.com: I install netbeans 7. When i try to configure postgresql project, path is set up incorectly - gcc not found How to set the path ? Install GCC? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Reduced power consumption in autovacuum launcher process

2011-07-29 Thread Peter Geoghegan
implementation will not provide that granularity anyway as things stand. Thoughts? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 6a6959f..b2cf973

[HACKERS] Further news on Clang - spurious warnings

2011-08-02 Thread Peter Geoghegan
/include -D_GNU_SOURCE -c -o gram.o src/backend/parser/gram.c In file included from gram.y:12949:0: scan.c: In function ‘yy_try_NUL_trans’: scan.c:16246:23: warning: unused variable ‘yyg’ [-Wunused-variable] -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-03 Thread Peter Geoghegan
On 3 August 2011 00:52, Peter Geoghegan pe...@2ndquadrant.com wrote: Now, the only warning that remains is that same Correction - there are actually 3 additional warnings like this in repl_gram.c: /home/peter/build/Release/bin/clang -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-03 Thread Peter Geoghegan
Attached patch removes the tautologolical part of an evaluated expression, fixing the problem flagged by this quite valid warning. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/interfaces/libpq/fe-exec.c b/src

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-03 Thread Peter Geoghegan
, thus precluding the possibility of the value being 0, barring some abuse of the enum. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-03 Thread Peter Geoghegan
On 3 August 2011 11:05, Peter Geoghegan pe...@2ndquadrant.com wrote: I don't believe that the standard allows for an implementation of enums as unsigned integers - after all, individual enum literals can be given corresponding negative integer values. It actually gives leeway to implement

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-03 Thread Peter Geoghegan
that PGRES_EMPTY_QUERY is the first value in the enum can be safely assumed to be stable, not least because we've even already explicitly given it a corresponding value of 0. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-03 Thread Peter Geoghegan
a function-like macro with deep nesting). -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-03 Thread Peter Geoghegan
of the enum value is in range. I'm not convinced that that is an improvement to rely on the conversion doing so, but it's not as if I feel very strongly about it. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-03 Thread Peter Geoghegan
don't. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-04 Thread Peter Geoghegan
On 4 August 2011 07:08, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: On 3 August 2011 21:03, Tom Lane t...@sss.pgh.pa.us wrote: I mean that it's unclear what you'll get if status has a bitpattern equivalent to a negative integer.  If the compiler implements

Re: [HACKERS] TRUE/FALSE vs true/false

2011-08-04 Thread Peter Geoghegan
or other. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-04 Thread Peter Geoghegan
Can we please commit a fix for this problem? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-05 Thread Peter Geoghegan
On 5 August 2011 17:12, Robert Haas robertmh...@gmail.com wrote: On Thu, Aug 4, 2011 at 4:49 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: Can we please commit a fix for this problem? Done. Thanks Robert. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-05 Thread Peter Geoghegan
is the same number as GCC 4.5 - 1. On GCC 4.6, there are still quite a few -Wunused-but-set-variable warnings left despite an effort to eradicate them. Perhaps I should look into that next. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-06 Thread Peter Geoghegan
the constants to the global, generic NodeTag enum fixes the issue. That is what the attached patch does. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/include/nodes/nodes.h b/src/include/nodes/nodes.h index d8bc6b8

Re: [HACKERS] Yes, WaitLatch is vulnerable to weak-memory-ordering bugs

2011-08-08 Thread Peter Geoghegan
is accurate. Everything you do for the defined(WIN32_ONLY_COMPILER) case is documented as working with 2003. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Reduced power consumption in autovacuum launcher process

2011-08-09 Thread Peter Geoghegan
to port to 9.2. That is a good point. I'm aware that someone already made the mistake of giving the value of timeout as milliseconds rather than microseconds at one point, so this seems to be a fertile source of confusion. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] Reduced power consumption in autovacuum launcher process

2011-08-10 Thread Peter Geoghegan
as the generic, per-process latch. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Further news on Clang - spurious warnings

2011-08-12 Thread Peter Geoghegan
hacking on Postgres. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] walprotocol.h vs frontends

2011-08-15 Thread Peter Geoghegan
, during work on PL/Java. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] walprotocol.h vs frontends

2011-08-15 Thread Peter Geoghegan
representation is entirely a case of compile time either/or. There is no apparent fall-back to the double representation available to binaries built without --disable-integer-datetimes. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] walprotocol.h vs frontends

2011-08-15 Thread Peter Geoghegan
, but that doesn't sit well with me. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

[HACKERS] Should we have an optional limit on the recursion depth of recursive CTEs?

2011-08-15 Thread Peter Geoghegan
by unprivileged users, that independently limits the recursion depth per session. This could be used as a sort of assertion of the maximum recursion depth of a given query. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql

Re: [HACKERS] Should we have an optional limit on the recursion depth of recursive CTEs?

2011-08-15 Thread Peter Geoghegan
of anecdotal evidence out there that this is useful in larger commercial contexts, and I've already named some places where a person might look for such anecdotal evidence. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql

Re: [HACKERS] Re: Should we have an optional limit on the recursion depth of recursive CTEs?

2011-08-16 Thread Peter Geoghegan
as the contents of tables changes over time. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Re: Should we have an optional limit on the recursion depth of recursive CTEs?

2011-08-20 Thread Peter Geoghegan
use UNION ALL. It's just a different way of specifying a terminating condition that isn't likely to be applicable to more complicated rCTEs. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Cascading replication: should we detect/prevent cycles?

2013-01-31 Thread Peter Geoghegan
On Sunday, 27 January 2013, Robert Haas robertmh...@gmail.com wrote: If we're going to start installing safeguards against doing stupid things, there's a long list of scenarios that happen far more regularly than this ever will and cause far more damage. +1 -- Regards, Peter Geoghegan

Re: [HACKERS] Fwd: Successful post to pgsql-hackers

2013-02-09 Thread Peter Geoghegan
changed e-mail addresses. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pgbench --startup option

2013-02-10 Thread Peter Geoghegan
as a different color) generally only exists for one or two settings, so it is probably better to pursue the approach that you propose here. I guess what I've outlined could still be useful for PGC_POSTMASTER gucs, like shared_buffers. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing

Re: [HACKERS] overlapping strncpy/memcpy errors via valgrind

2013-02-17 Thread Peter Geoghegan
approach of applying the patch that Noah Misch originally wrote (but did not publicly submit, iirc) on an ad-hoc basis isn't great. That is what you've done here, right? -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: unified vs context diffs (was Re: [HACKERS] Strange Windows problem, lock_timeout test request)

2013-02-24 Thread Peter Geoghegan
for it. I can see how other people's habits might differ from my own here, and that they might reasonably state a preference for unified, which is fine. I developed a preference for unified over time, having originally just used the format on the advice of the wiki. -- Regards, Peter Geoghegan

Re: [HACKERS] Why do we still perform a check for pre-sorted input within qsort variants?

2013-02-25 Thread Peter Geoghegan
. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_xlogdump

2013-02-26 Thread Peter Geoghegan
working on external modules would not be to generalise from the example of /contrib, but to generalise from the example of popular external modules. This is particularly important when targeting multiple Postgres versions. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Why do we still perform a check for pre-sorted input within qsort variants?

2013-03-08 Thread Peter Geoghegan
in the tests. Well, that's good to hear. I wouldn't mind taking a look at that. We're not the only ones that use (more or less) that same algorithm. I noticed that Redis does so too, just for example (though they didn't get wise to the problems with the swap_cnt pessimisation). -- Regards, Peter

[HACKERS] Should commit_delay be PGC_SIGHUP?

2013-03-20 Thread Peter Geoghegan
fraction of commit_delay (about 1/2, on average) blocking on LWLockAcquireOrWait(). -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Should commit_delay be PGC_SIGHUP?

2013-03-21 Thread Peter Geoghegan
the full commit_delay, and will only rarely actually be 0. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Should commit_delay be PGC_SIGHUP?

2013-03-22 Thread Peter Geoghegan
happy enough to have the setting be PGC_SUSET, since that more or less conveys that commit_delay isn't something that is sensible to set dynamically. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Clang compiler warning on 9.3 HEAD

2013-04-03 Thread Peter Geoghegan
generally sound and useful at the time. This looks like a real problem to me. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Back branches vs. gcc 4.8.0

2013-04-05 Thread Peter Geoghegan
semantics), it might be possible to do this across the board without contorting the code with preprocessor hacks. That's something that I'd certainly be in favor of pursuing. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

<    1   2   3   4   5   6   7   8   9   10   >