Re: Create shorthand for including all extra tests

a new category as 'slow' but still open to suggestions. I am not very familiar with perl syntax, I would like to hear your opinions on how the implementation of the check_extra_text_enabled() function could be done better. Regards, Nazir Bilal Yavuz Microsoft From 3a33161eef699e4fbcfeb2d62ec387621

Remove unnecessary 'always:' from CompilerWarnings task

Bilal Yavuz Microsoft From 3bd8f6ff5b8add90dcfe42761a3c1fe81a5c174a Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Tue, 5 Sep 2023 13:04:24 +0300 Subject: [PATCH v1] Remove unnecessary 'always:' from CompilerWarnings task Warning scripts and upload_caches instructions can be defined under

Add resource intensiveness as a reason to not running tests by default

be appreciated. Regards, Nazir Bilal Yavuz Microsoft From 847a06a3a0546a14f07654ff79da4039c5c7cc34 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 7 Sep 2023 13:33:46 +0300 Subject: [PATCH v1] Update the reasons of tests not running by default on docs With f47ed79cc8, test suite doesn't

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

Hi, Thanks for the reply! On Fri, 8 Sept 2023 at 11:05, Daniel Gustafsson wrote: > > > On 7 Sep 2023, at 18:06, Nazir Bilal Yavuz wrote: > > > if the changes are only in the docs, don't run > > all tasks except building the docs task; this could help to save more >

Re: BufferUsage counters' values have changed

same path as [1] but [2] is new. 'fsm extends' wasn't counted in local_blks_written in PG_15. Calling ExtendBufferedRelTo() from fsm_extend() caused 'fsm extends' to be counted in local_blks_written. I am not sure which one is correct. I hope these help. Regards, Nazir Bilal Yavuz Microsoft

Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

are only in the docs: Only run build the docs task. 4- If 'ci-os-only:' set (There could be changes in the docs): Don't run build the docs task. Any kind of feedback would be appreciated. Regards, Nazir Bilal Yavuz Microsoft From 43e18ed9eb328b4703ad3d8cb95d7d4b6140db89 Mon Sep 17 00:00:00 2001 From

pgBufferUsage.blk_{read|write}_time are zero although there are pgBufferUsage.local_blks_{read|written}

blk_write_time | 4.050305 Any kind of feedback would be appreciated. Regards, Nazir Bilal Yavuz Microsoft From 96f7b82e2ec5e8f68b509ea58131fba42deac7c0 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Fri, 15 Sep 2023 11:55:43 +0300 Subject: [PATCH v1 2/2] Include IOOp IOOP_EXTENDs while

Create shorthand for including all extra tests

in CI. But when 'wal_consistency_checking' is enabled, CI times get longer since it does resource intensive operations. Any kind of feedback would be appreciated. Regards, Nazir Bilal Yavuz Microsoft From be91a0aaf926c83bf266f92e0523f41ca333b048 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz

Re: pgBufferUsage.blk_{read|write}_time are zero although there are pgBufferUsage.local_blks_{read|written}

Hi, Thanks for the review! On Tue, 17 Oct 2023 at 11:40, Michael Paquier wrote: > > On Mon, Oct 16, 2023 at 01:07:07PM +0300, Nazir Bilal Yavuz wrote: > > Yes, that could be a better solution. Also, having more detailed stats > > for shared and local buffers is helpful.

Re: gcc 12.1.0 warning

ng 'upgrading CI Debian images to bookworm'. I tested the bookworm on REL_15, REL_16 and upstream. REL_16 and upstream finished successfully but the CompilerWarnings task failed on REL_15 with the same error. gcc version: 12.2.0 CI Run: https://cirrus-ci.com/task/6151742664998912 Regards, Nazir Bilal Yavuz Microsoft

Re: pgBufferUsage.blk_{read|write}_time are zero although there are pgBufferUsage.local_blks_{read|written}

stuff alone. I think switching it to 'shared' makes sense. That shouldn't confuse existing monitoring queries much as the numbers won't change, right? Also, if we keep 'shared/local' there could be similar complaints to this thread in the future; so, at least adding comments can be helpful. Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

Hi, Thank you for the feedback! On Thu, 26 Oct 2023 at 09:28, Michael Paquier wrote: > > On Wed, Sep 20, 2023 at 10:57:48AM +0300, Nazir Bilal Yavuz wrote: > > Any kind of feedback would be appreciated. > > This was registered in the CF, so I have given it a look. No

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Tue, 31 Oct 2023 at 16:57, Nazir Bilal Yavuz wrote: > On Thu, 26 Oct 2023 at 09:28, Michael Paquier wrote: > > > > And perhaps just putting that everything that calls > > pgstat_count_io_op_time() under track_io_timing is just natural? > > What's the perfo

Re: Adding facility for injection points (or probe points?) for more advanced tests

That could be misleading, IMO the test should be skipped if Postgres is not compiled with the injection points. Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

T_NORMAL && > > +!(io_op == IOOP_WRITE || io_op == IOOP_READ || io_op == IOOP_FSYNC)) > > + return false; > > These are the first "bans" that we have for an IOOp for a specific > combination of io_context and io_object. We should add a new

Re: how to manage Cirrus on personal repository

private repositories. I hope these help. Regards, Nazir Bilal Yavuz Microsoft

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

Hi, On Tue, 26 Sept 2023 at 13:48, Peter Eisentraut wrote: > > On 25.09.23 12:56, Nazir Bilal Yavuz wrote: > > + # Only run if a specific OS is not requested and if there are changes in > > docs > > + # or in the CI files. > > + skip: > > > +$C

Re: pgBufferUsage.blk_{read|write}_time are zero although there are pgBufferUsage.local_blks_{read|written}

shared buffers (in FlushBuffer()). I think it makes sense to propose a > bug fix to stable branches counting blk_write_time for local buffers > as well. I attached the PG16+ (after pg_stat_io) and PG15- (before pg_stat_io) versions of the same patch. Regards, Nazir Bilal

Re: bgwriter doesn't flush WAL stats

the push! Actual commitfest entry for the second patch is: https://commitfest.postgresql.org/45/4416/. I sent a second patch to this thread just to show how I found this bug. There is no need to review it, this commitfest entry could be closed as committed. Regards, Nazir Bilal Yavuz Microsoft

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

Hi, I attached the second version of the patch. On Mon, 11 Sept 2023 at 15:11, Daniel Gustafsson wrote: > > > On 11 Sep 2023, at 13:03, Nazir Bilal Yavuz wrote: > > >> Almost, but not entirely. There are a set of scripts which generate > >> content > >

Re: [RFC] Add jit deform_counter

statements is bumped to 1.11 with this patch but oldextversions test is not updated. So, I attached a patch for updating oldextversions. Regards, Nazir Bilal Yavuz Microsoft From d3c63a5d68ed76257d110db6377bd3ec859d65a4 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 12 Oct 2023 14

Re: pgBufferUsage.blk_{read|write}_time are zero although there are pgBufferUsage.local_blks_{read|written}

me? In my opinion if something increments {shared|local}_blks_written, then it needs to be counted in blk_write_time too. I am not sure why it is decided like that. Regards, Nazir Bilal Yavuz Microsoft

Re: pgBufferUsage.blk_{read|write}_time are zero although there are pgBufferUsage.local_blks_{read|written}

ution. Also, having more detailed stats for shared and local buffers is helpful. I updated patches in line with that: 0001: Counts extends same way as a write. 0002: Rename blk_{read|write}_time as shared_blk_{read|write}_time. 0003: Add new local_blk_{read|write}_time variables. Re

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

uld be better for PG developers. For sure that could be the subject of another patch. Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Non-feature feature options

Yavuz Microsoft From 83f3222f83b5bb508fc7ce7140731f742e84f166 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 17 Aug 2023 13:08:32 +0300 Subject: [PATCH v2] meson: Make auto the default of the uuid option The 'uuid' option is of type 'combo', but we add a choice 'auto' that simulates

Re: Add PG CI to older PG releases

s-Fix-windows-logging-problems.patch is a combination of [1] and the rest are the same. Regards, Nazir Bilal Yavuz Microsoft From 213b049f4f62d22e9b87fbaa572f9e35cf518d63 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 10 Aug 2023 18:40:35 +0300 Subject: [PATCH v2 2/3] Make PG_TEST_

Use the same Windows image on both VS and MinGW tasks

a patch for using pg-ci-windows-ci Windows image on VS and MinGW tasks. CI run when pg-ci-windows-ci is used: https://cirrus-ci.com/build/6063036847357952 [1]: https://github.com/anarazel/pg-vm-images/commit/6747f676b97348d47f041b05aa9b36cde43c33fe Regards, Nazir Bilal Yavuz Microsoft From

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

timization makes it easier to choose the buildtype. Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

d changed 'pgstat_report_wal(false)' to 'pgstat_flush_io(false)' in xlogrecovery.c. I will share the new version of the patchset once I address the feedback. Regards, Nazir Bilal Yavuz Microsoft From e5db5cd6d8c47cadde0539f06bbee22368d17a41 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 26 Oct 2

Re: Remove unnecessary 'always:' from CompilerWarnings task

Hi, Thanks for the review. On Wed, 8 Nov 2023 at 10:31, Peter Eisentraut wrote: > > On 05.09.23 12:25, Nazir Bilal Yavuz wrote: > > There are multiple 'always:' keywords under the CompilerWarnings task. > > Instead of that, we can use one 'always:' and move the instructions

Re: Show WAL write and fsync stats in pg_stat_io

g_stat_wal's or pg_stat_io's behaviour will be changed. Regards, Nazir Bilal Yavuz Microsoft

Re: configure --with-uuid=bsd fails on NetBSD

Hi, On 8/21/22 04:37, Tom Lane wrote: Andres Freund writes: Perhaps we should make them error out instead? It doesn't seem helpful to just return something wrong... Yeah, might be appropriate. Based on these discussions, I attached a patch. Thanks, Nazir Bilal Yavuzdiff --git

Re: kerberos/001_auth test fails on arm CPU darwin

paths(I added arm and MacPorts paths for darwin) 3 - from PATH Also, I tried to do some refactoring for adding another paths to search in the future and being sure about all executables are found. Ci run after fix is applied: https://cirrus-ci.com/build/5758254918664192 Regards, Nazir Bilal Yavuz

Re: Mingw task for Cirrus CI

debug -Dcassert=true -Db_pch=true -DTAR=%TAR% build" will work. Regards, Nazir Bilal Yavuz

Re: kerberos/001_auth test fails on arm CPU darwin

ot;krb5-config --prefix" command run it gives "/" as output. This issue can be related about the CI VMs but I couldn't check it. Regards, Nazir Bilal Yavuz

Re: configure --with-uuid=bsd fails on NetBSD

Hi, On 8/26/22 19:21, Tom Lane wrote: Nazir Bilal Yavuz writes: Based on these discussions, I attached a patch. I think the right fix is to call uuid_create and then actually check the version field of the result. This avoids breaking what need not be broken, and it'd also guard against

Re: kerberos/001_auth test fails on arm CPU darwin

nd '/usr/bin/'. Does that cause a problem? Ci run after fix is applied: https://cirrus-ci.com/build/5359971746447360 Regards, Nazir Bilal Yavuz From 5aa95409db8146a076255e00be399a0d9ce1efe8 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Mon, 26 Sep 2022 10:56:51 +0300 Subject: [PATCH

Re: [RFC] building postgres with meson - v10

directories. Greetings, Nazir Bilal Yavuz

Use windows VMs instead of windows containers on the CI

/5468256027279360 Regards, Nazir Bilal Yavuz Microsoft From 6981319d054f0736e474bc315ab094094d159979 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Tue, 10 Jan 2023 13:58:39 +0300 Subject: [PATCH] Use windows VMs instead of windows containers --- .cirrus.yml | 12 1 file changed, 8

Re: Use windows VMs instead of windows containers on the CI

:28m Execution step: | VS 2019 | MinGW64 -- VM | 12:16m| 07:55m -- Container | 26:02m | 16:34m Regards, Nazir Bilal Yavuz Microsoft

Re: Use windows VMs instead of windows containers on the CI

Container + MinGW64: 16.34m Sorry for the multiple mails. Regards, Nazir Bilal Yavuz Microsoft

Re: Fix database creation during installchecks for ICU cluster

$ ./configure --with-icu --prefix=$PWD/build_dir $ make && make install && export PATH=$PWD/build_dir/bin:$PATH $ initdb --locale-provider icu --icu-locale en-US -D data && pg_ctl -D data -l logfile start $ make NO_LOCALE=1 installcheck [1] https://github.com/postgres/postgres/blob/ce20f8b9f4354b46b40fd6ebf7ce5c37d08747e0/src/interfaces/ecpg/test/Makefile#L18 Regards, Nazir Bilal Yavuz

Re: Documentation for building with meson

localedir, mandir), default path is correct for all of them. Regards, Nazir Bilal Yavuz

Re: meson: Optionally disable installation of test modules

308012940.edexipb3vqylcu6r%40awork3.anarazel.de Regards, Nazir Bilal Yavuz Microsoft

Re: buildfarm + meson

to the '$install_dir/$install_dir'. Could you try only running 'run_log("meson compile -C $pgsql install-test-files");' without setting DESTDIR, this could work. Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Non-feature feature options

Hi, On Wed, 22 Feb 2023 at 12:14, Peter Eisentraut wrote: > > On 21.02.23 17:32, Nazir Bilal Yavuz wrote: > >>> I like the second approach, with a 'uuid' feature option. As you wrote > >>> earlier, adding an 'auto' choice to a combo option doesn't work fully &

Re: Refactor calculations to use instr_time

t a way to > maintain WalUsage separately from PgStat_WalStats or something else. > Worst case, add more comments to the struct definitions to explain why > they have the members they have and how WalUsage relates to them. Yes, but like Andres said this could be better done as a separate patc

Re: meson: Non-feature feature options

hat unless the 'ssl' option is set to 'openssl'. Is it possible that it has been set to 'openssl' without you noticing? Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Non-feature feature options

Hi, On Wed, 15 Mar 2023 at 11:12, Peter Eisentraut wrote: > > On 14.03.23 15:07, Nazir Bilal Yavuz wrote: > >> I think the uuid side of this is making this way too complicated. I'm > >> content leaving this as a manual option for now. > >> > >> There i

Re: meson: Non-feature feature options

Hi, On Thu, 9 Mar 2023 at 17:18, Peter Eisentraut wrote: > > On 09.03.23 15:12, Nazir Bilal Yavuz wrote: > > Hi, > > > > On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson wrote: > >> > >>> On 9 Mar 2023, at 14:45, Peter Eisentraut > >>> wr

Re: Refactor calculations to use instr_time

Hi, There was a warning while applying the patch, v5 is attached. Regards, Nazir Bilal Yavuz Microsoft From dcd49e48a0784a95b8731df1c6ee7c3a612a8529 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 9 Mar 2023 15:35:38 +0300 Subject: [PATCH v5] Refactor instr_time calculations

Re: meson: Non-feature feature options

ssl.found() ? [ssl, '(@0@)'.format(ssl_library)] : ssl, }, section: 'External libraries', list_sep: ', ', ) And it will output: ssl: YES 3.0.8, (openssl) I don't think that using 'ssl_library' will increase the complexity. Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Non-feature feature options

Hi, On Mon, 13 Mar 2023 at 23:14, Andres Freund wrote: > > Hi, > > On 2023-03-13 21:57:22 +0300, Nazir Bilal Yavuz wrote: > > On Mon, 13 Mar 2023 at 21:04, Nathan Bossart > > wrote: > > > > > > On Mon, Mar 13, 2023 at 07:27:18AM +0100, Peter Eisentra

Re: Refactor calculations to use instr_time

but it seems the required changes for additional refactoring aren't small. So, I think we can create a separate patch for these changes. Regards, Nazir Bilal Yavuz Microsoft v4-0001-Refactor-instr_time-calculations.patch Description: Binary data

Re: Refactor calculations to use instr_time

inor code-formatting point: In postgres we don't put code in the same line as a multi-line comment starting with the /*. So either /* single line comment */ or /* * multi line * comment */ Thanks for the review. I updated the patch. Regards, Nazir Bilal Yavuz Microso

Re: meson: Non-feature feature options

option with ['auto', 'bsd', 'e2fs', 'ossp'] choices. If 'uuid_library' is set other than 'auto' and it can't be found, build throws an error. What do you think? Regards, Nazir Bilal Yavuz Microsoft From e607f8e6de8bdd65cbaede200e184d7f908991c5 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz

Re: meson: Non-feature feature options

. It uses the first one it finds and doesn't try to find the rest but the build doesn't fail if it can't find any library. Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Non-feature feature options

Hi, On Mon, 20 Feb 2023 at 22:42, Andres Freund wrote: > On 2023-02-20 19:53:53 +0100, Peter Eisentraut wrote: > > On 20.02.23 13:33, Nazir Bilal Yavuz wrote: > > > I added SSL and UUID patches. UUID patch has two different fixes: > > > > > > 1 - v1-0002-meso

Re: meson: Non-feature feature options

)) > > We don't want to issue a message like this when a non-required function > is missing. I agree, the message part can be removed. Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Non-feature feature options

Hi, On Fri, 3 Mar 2023 at 12:16, Peter Eisentraut wrote: > > On 02.03.23 11:41, Nazir Bilal Yavuz wrote: > > I am kind of confused. I added these checks for considering other SSL > > implementations in the future, for this reason I have two nested if > > checks. The top o

Re: meson: Optionally disable installation of test modules

t; +test_install_data += files( > > Let me know if you have any concerns about this version. Otherwise, I'm > happy to commit it. That makes sense, thanks! Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Optionally disable installation of test modules

nder the build directory? Regards, Nazir Bilal Yavuz Microsoft

Refactor calculations to use instr_time

'instr_time' instead of 'PgStat_Counter' while accumulating 'wal_write_time' and 'wal_sync_time'. Also, I refactored some calculations to use 'INSTR_TIME_ACCUM_DIFF' instead of using 'INSTR_TIME_SUBTRACT' and 'INSTR_TIME_ADD'. What do you think? Regards, Nazir Bilal Yavuz Microsoft From

Re: allow meson to find ICU in non-standard localtion

re found by dependency checks. Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Non-feature feature options

Hi, On Wed, 22 Feb 2023 at 12:14, Peter Eisentraut wrote: > > On 21.02.23 17:32, Nazir Bilal Yavuz wrote: > >>> I like the second approach, with a 'uuid' feature option. As you wrote > >>> earlier, adding an 'auto' choice to a combo option doesn't work fully &

Re: meson logs environment

ents environment variables from being logged. Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Optionally disable installation of test modules

your comments. Regards, Nazir Bilal Yavuz Microsoft From 7804aa928de7595cb89bfd7668952e1e1fe48038 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 23 Feb 2023 20:35:22 +0300 Subject: [PATCH v3] meson: prevent installation of test files during main install --- meson.build

Re: Refactor calculations to use instr_time

Hi, Thanks for the review. On Mon, 20 Feb 2023 at 06:01, Kyotaro Horiguchi wrote: > > At Fri, 17 Feb 2023 13:53:36 +0300, Nazir Bilal Yavuz > wrote in > > Thanks for the review. I updated the patch. > > > WalUsageAccumDiff(, , ); > -

Re: meson: Optionally disable installation of test modules

Hi, On 2/8/23 13:30, Peter Eisentraut wrote: If you feel that your patch is ready, please add it to the commit fest. I look forward to reviewing it. Thanks! Commit fest entry link: https://commitfest.postgresql.org/42/4173/ Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Non-feature feature options

? Regards, Nazir Bilal Yavuz Microsoft

Re: Use windows VMs instead of windows containers on the CI

. There were conflicts while applying current patch to the REL_15_STABLE branch. Regards, Nazir Bilal Yavuz Microsoft From ba88fe8effc1400f08bfa4fcdc44862faf2977d4 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Tue, 10 Jan 2023 13:58:39 +0300 Subject: [PATCH v2] [master] Use windows VMs

Re: meson: Non-feature feature options

and TCL already has a similar implementation with what you suggested: option('pltcl', type : 'feature', value: 'auto',   description: 'build with TCL support') option('tcl_version', type : 'string', value : 'tcl',   description: 'specify TCL version') Regards, Nazir Bilal Yavuz Microsoft

REASSIGN OWNED vs ALTER TABLE OWNER TO permission inconsistencies

Regards, Nazir Bilal Yavuz Microsoft

Re: meson: Optionally disable installation of test modules

and refint_regress to the test_install_libs. Regards, Nazir Bilal Yavuz Microsoft From 9e5d2a7f2e81360d728d02abf42959b529942ba3 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Wed, 1 Feb 2023 14:10:20 +0300 Subject: [PATCH v2] meson: prevent installation of test files during main install

Re: Show WAL write and fsync stats in pg_stat_io

] > https://www.postgresql.org/message-id/flat/20230216191138.jotc73lqb7xhfqbi%40awork3.anarazel.de#eb4a641427fa1eb013e9ecdd8648e640 > [2] > https://www.postgresql.org/message-id/20230504165738.4e2hfoddoels542c%40awork3.anarazel.de In addition to these, are WAIT_EVENT_WAL_COPY_* operations

Re: Add PG CI to older PG releases

h-zstd' from .cirrus.yml since it was not supported yet. Regards, Nazir Bilal Yavuz Microsoft From 382121670bb96c941d4ad0110b5d3479ecfb54d8 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 10 Aug 2023 18:40:35 +0300 Subject: [PATCH v2 2/3] Make PG_TEST_USE_UNIX_SOCKETS work for tap

Add PG CI to older PG releases

you failed 3 tests of 110. 2_ 45f52709d86ceaaf282a440f6311c51fc526340b is added for fixing socket directories on Windows. 3_ I removed '--with-zstd' since it was not supported yet. Any kind of feedback would be appreciated. Regards, Nazir Bilal Yavuz Microsoft From 34986d591eaa5bf66569674857832c

bgwriter doesn't flush WAL stats

│ wal│ 0 │ │ walwriter │ wal│719 │ └─┴┴┘ After the patch has been applied, there are no differences between pg_stat_wal and pg_stat_io. I appreciate any comment/feedback on this patch. Regards, Nazir Bilal Ya

Re: bgwriter doesn't flush WAL stats

Hi, Thanks for the explanation. On Wed, 21 Jun 2023 at 18:03, Matthias van de Meent < boekewurm+postg...@gmail.com> wrote: > > On Wed, 21 Jun 2023 at 13:04, Nazir Bilal Yavuz wrote: > > I was trying to add WAL stats to pg_stat_io. While doing that I was comparing pg_stat_wa

Re: bgwriter doesn't flush WAL stats

Hi, Created a commitfest entry for this. Link: https://commitfest.postgresql.org/43/4405/ Regards, Nazir Bilal Yavuz Microsoft On Thu, 22 Jun 2023 at 17:03, Melanie Plageman wrote: > On Wed, Jun 21, 2023 at 9:49 PM Kyotaro Horiguchi > wrote: > > Regarding the second patch, it in

Show WAL write and fsync stats in pg_stat_io

writer's WAL stats are not seen in pg_stat_wal but in pg_stat_io. I already sent a patch [1] to fix that. [1] https://www.postgresql.org/message-id/CAN55FZ2FPYngovZstr%3D3w1KSEHe6toiZwrurbhspfkXe5UDocg%40mail.gmail.com Any kind of feedback would be appreciated. Regards, Nazir Bilal Yavuz Microsoft

Re: Simplify documentation related to Windows builds

My initial testing showed that the directory is the '\usr\bin' subdirectory of the msys2 installation directory in my environment. [1] https://github.com/anarazel/pg-vm-images/blob/main/scripts/windows_install_perl.ps1 -- Regards, Nazir Bilal Yavuz Microsoft

Re: Simplify documentation related to Windows builds

diffutils package. It is mentioned under the Windows requirements page [1] since it does not come preinstalled. However, I agree that it could be good to mention it under the meson page listing the requirements. [1] https://www.postgresql.org/docs/devel/installation-platform-notes.html#WINDOWS-REQUIREMENTS -- Regards, Nazir Bilal Yavuz Microsoft

Re: Do away with zero-padding assumption before WALRead()

he reason or are there any other benefits of always reading XLOG_BLCKSZ instead of reading the sufficient part? I tried to search in older threads and code comments but I could not find an explanation. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Thu, 18 Jan 2024 at 04:22, Michael Paquier wrote: > > On Wed, Jan 17, 2024 at 03:20:39PM +0300, Nazir Bilal Yavuz wrote: > > I agree with your points. While the other I/O related work is > > happening we can discuss what we should do in the variable op_by

Use streaming read API in ANALYZE

kind of feedback would be appreciated. [1]: https://www.postgresql.org/message-id/CA%2BhUKGJkOiOCa%2Bmag4BF%2BzHo7qo%3Do9CFheB8%3Dg6uT5TUm2gkvA%40mail.gmail.com -- Regards, Nazir Bilal Yavuz Microsoft From 509e55997c084f831fcbcb46cabe79d4f97aa93e Mon Sep 17 00:00:00 2001 From: Thomas Munro Date

Re: Streaming I/O, vectored I/O (WIP)

but we do not check the overflow while doubling it. This could be a problem in longer reads. -- Regards, Nazir Bilal Yavuz Microsoft

Add missing error codes to PANIC/FATAL error reports in xlog.c and relcache.c

this error comes up in many places. Would it be reasonable to create a new error code specifically for this? Any kind of feedback would be appreciated. [1] https://www.postgresql.org/message-id/CAPMWgZ8g17Myb5ZRE5aTNowUohafk4j48mZ_5_Zn9JnR5p2u0w%40mail.gmail.com -- Regards, Nazir Bilal Yavuz Micr

Re: Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI)

Hi, You may want to check out the WIP patch [1] about adding meson targets to run pgindent by Andres. [1] https://www.postgresql.org/message-id/20231019044907.ph6dw637loqg3lqk%40awork3.anarazel.de -- Regards, Nazir Bilal Yavuz Microsoft

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

rth implementing this logic on buildfarm animals. In case we want to implement the same logic on the CI, I added a new version of the patch; it skips CI completely if the changes are only in the README files. -- Regards, Nazir Bilal Yavuz Microsoft From 6c268233d13262a31965baf2dbb42913d83dab1d Mo

Re: Show WAL write and fsync stats in pg_stat_io

, the two GUCs, the > contexts, the I/O operation type and the objects is the tricky part of > this patch. If the dependency to PendingWalStats is removed and if > the interface of pgstat_prepare_io_time is improved, things are a bit > cleaner, but it feels like we could do more.. Nya

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Tue, 26 Dec 2023 at 13:10, Michael Paquier wrote: > > On Tue, Dec 26, 2023 at 11:27:16AM +0300, Nazir Bilal Yavuz wrote: > > Maybe it is better to create a pg_stat_io_wal view like you said > > before. We could remove unused columns and add op_bytes for each > > wr

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Tue, 26 Dec 2023 at 03:06, Michael Paquier wrote: > > On Mon, Dec 25, 2023 at 04:09:34PM +0300, Nazir Bilal Yavuz wrote: > > On Wed, 9 Aug 2023 at 21:52, Melanie Plageman > > wrote: > >> If there is any combination of BackendType and IOContext which will &

Re: Remove MSVC scripts from the tree

e not-found external program in "command" I think we need to require sed when dtrace or selinux is found, not by looking at the return value of the get_option().enabled(). Second patch looks good to me. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Sun, 31 Dec 2023 at 03:58, Michael Paquier wrote: > > On Tue, Dec 26, 2023 at 03:35:52PM +0300, Nazir Bilal Yavuz wrote: > > On Tue, 26 Dec 2023 at 13:10, Michael Paquier wrote: > >> I am not sure while the whole point of the exercise is to have all the > >>

Re: Confine vacuum skip logic to lazy_scan_skip

unction ) and the X will be determined by Postgres itself. Do you have something different in your mind? -- Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Wed, 10 Jan 2024 at 08:25, Michael Paquier wrote: > > On Wed, Jan 03, 2024 at 04:10:58PM +0300, Nazir Bilal Yavuz wrote: > > > > I thought removing op_bytes completely ( as you said "This patch > > extends it with two more operation sizes, and there ar

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Thu, 11 Jan 2024 at 08:01, Michael Paquier wrote: > > On Wed, Jan 10, 2024 at 07:24:50PM -0500, Melanie Plageman wrote: > > I have code review feedback as well, but I've saved that for my next email. > > Ah, cool. > > > On Wed, Jan 3, 2024 at 8:11 AM Nazir Bila

Re: Create shorthand for including all extra tests

Hi, On Wed, 10 Jan 2024 at 23:48, Peter Eisentraut wrote: > > On 05.09.23 19:26, Nazir Bilal Yavuz wrote: > > Thanks for the feedback! I updated the patch, 'needs-private-lo' > > option enables kerberos, ldap, load_balance and ssl extra tests now. > > As was discuss

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Thu, 11 Jan 2024 at 17:28, Melanie Plageman wrote: > > On Thu, Jan 11, 2024 at 6:19 AM Nazir Bilal Yavuz wrote: > > > > On Thu, 11 Jan 2024 at 08:01, Michael Paquier wrote: > > > > > > On Wed, Jan 10, 2024 at 07:24:50PM -0500, Melanie Plageman wrote:

  1   2   >