Re: [HACKERS] TCP keepalive support for libpq

2010-02-11 Thread Peter Geoghegan
. Speaking as someone who uses Slony quite a lot, this patch sounds very helpful. Why hasn't libpq had keepalives for years? Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] TCP keepalive support for libpq

2010-02-11 Thread Peter Geoghegan
. Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] TCP keepalive support for libpq

2010-02-12 Thread Peter Geoghegan
ameliorate these problems, which are probably not noticed by the majority of users, but are a real inconvenience when they do arise. Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Alpha release this week?

2010-04-02 Thread Peter Geoghegan
the libpqxx 3.1 tests too, if that helps. Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Clarifications of licences on pgfoundry

2010-05-18 Thread Peter Geoghegan
they submit code for inclusion. Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Specification for Trusted PLs?

2010-05-21 Thread Peter Geoghegan
to be plpython back in 7.3 serves to illustrate that the distinction is not all that well defined. I guess that someone made an executive decision that the python restricted execution environment wasn't restricted enough. Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS]

2010-06-04 Thread Peter Geoghegan
This is really a postgreSQL developers list; I suggest you post user level questions to the -general list -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] extensible enum types

2010-06-19 Thread Peter Geoghegan
is within your lookup table. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] extensible enum types

2010-06-20 Thread Peter Geoghegan
. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] extensible enum types

2010-06-20 Thread Peter Geoghegan
was very much ancillary to my main point. Ideally, if you restore a schema-only dump of your database, you shouldn't be missing anything that is schema. Things like the possible states of a table's tuples are often schema, not data, and should be treated as such. -- Regards, Peter Geoghegan

Re: [HACKERS] string_to_array with an empty input string

2010-08-10 Thread Peter Geoghegan
an empty array. Some people might think that it's useful for the result to be NULL, but they'd probably also think that it's useful for an empty string to be NULL. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] string_to_array with an empty input string

2010-08-11 Thread Peter Geoghegan
return any other value. I think that there's a need for additional built-in array functions, including one to succinctly test if an array has no elements. Iterating through an array with plpgsql, for example, is more clunky than it should be. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers

Re: [HACKERS] string_to_array with an empty input string

2010-08-11 Thread Peter Geoghegan
that many of the idioms are on the clunky side, but I think that the fact that my original remarks about iterating over arrays generated discussion is a bit telling. unnest() was only introduced in PG 8.4. Iterating over an array is a simple thing. We should make simple things easy. -- Regards, Peter

Re: [HACKERS] string_to_array with an empty input string

2010-08-11 Thread Peter Geoghegan
On 11 August 2010 21:52, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan peter.geoghega...@gmail.com writes: What's wrong with something like array_is_empty(anyarray) returns boolean? What's that got to do with iterating over an array? Only that I'm of the opinion that we'd be well served

Re: [HACKERS] Version Numbering

2010-08-21 Thread Peter Geoghegan
marketing, and also because of HS/SR (plus we wanted to hint at the fact that 9.0 might not be the most stable release we've had), and I'm inclined to agree with that. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Windows Tools

2010-09-03 Thread Peter Geoghegan
variants that specify bounds. They can safely be ignored. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2011-12-30 Thread Peter Geoghegan
On 30 December 2011 19:46, Merlin Moncure mmonc...@gmail.com wrote: On Thu, Dec 29, 2011 at 8:03 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: * A spreadsheet that shows the results of re-running my earlier heap tuple sorting benchmark with this new patch. The improvement in the query

[HACKERS] Setting -Werror in CFLAGS

2012-01-03 Thread Peter Geoghegan
(plus others) Yes, I know that these only appeared in GCC 4.6+ and as such are a relatively recent phenomenon, but there has been some effort to eliminate them, and if I could get a non-hacked -Werror build I'd feel happy enough about excluding them as already outlined. -- Peter Geoghegan

[HACKERS] BGWriter latch, power saving

2012-01-03 Thread Peter Geoghegan
benchmarks, if that helps, but I think it's fairly unlikely that the patch introduces a measurable performance regression. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/bootstrap/bootstrap.c b/src/backend

Re: [HACKERS] BGWriter latch, power saving

2012-01-04 Thread Peter Geoghegan
that contains the latch's flag, that might get expensive. Also reasonable, but I don't think that I'll get around to it until after the final commitfest deadline. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src

Re: [HACKERS] Setting -Werror in CFLAGS

2012-01-04 Thread Peter Geoghegan
for that view. It took building with Clang to notice that we incorrectly used one enum rvalue to assign to a variable of another enum type, which I thought was a little bit surprising; I'd have expected GCC to catch that one, since it is pretty likely to be valid. -- Peter Geoghegan       http://www

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-05 Thread Peter Geoghegan
are on quite conservative. We can appreciate such things though. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-06 Thread Peter Geoghegan
was just thinking out loud. Also, we do a very good job on *perfectly* pre-sorted input because we check for pre-sorted input. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-06 Thread Peter Geoghegan
On 6 January 2012 17:29, Robert Haas robertmh...@gmail.com wrote: On Fri, Jan 6, 2012 at 12:10 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: As you know, all queries tested have lots and lots of duplicates (a ~1.5GB table that contains the same number of distinct elements as a ~10MB table

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-06 Thread Peter Geoghegan
On 6 January 2012 18:45, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: I didn't bother isolating that, because it doesn't really make sense to (not having it is probably only of particular value when doing what I'm doing anyway, but who knows). Go ahead

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-07 Thread Peter Geoghegan
on orderlines in advance of checking this. Revision to this patch that fixes the bug to follow - I produced these new numbers from a rough cut of that. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-09 Thread Peter Geoghegan
. There is most definitely a large overhead to creating such indexes, at least for scalar types. As far as I can tell, Tom's complaint is quite speculative. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Sending notifications from the master to the standby

2012-01-11 Thread Peter Geoghegan
useful, and of immediate benefit to a significant number of people. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] show Heap Fetches in EXPLAIN for index-only scans

2012-01-13 Thread Peter Geoghegan
ANALYZE output.  This might not be all the instrumentation we'll ever want here, but I think we at least want this much. Good idea. The fact that that information wasn't available did bother me. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] show Heap Fetches in EXPLAIN for index-only scans

2012-01-13 Thread Peter Geoghegan
be a uint32? That's all it's going to be on some platforms anyway. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] Our poll() based WaitLatch implementation is broken

2012-01-14 Thread Peter Geoghegan
()-based one. I wonder, how compelling a win is that expected to be? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Our poll() based WaitLatch implementation is broken

2012-01-15 Thread Peter Geoghegan
On 15 January 2012 07:26, Peter Geoghegan pe...@2ndquadrant.com wrote: Build Postgres master, on Linux or another platform that will use the poll() implementation rather than the older select(). Send the Postmaster SIGKILL. Observe that the WAL Writer lives on, representing a denial of service

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-15 Thread Peter Geoghegan
that the patch should be able to do. That said, it seems pretty likely that client libraries won't be dynamically generating SQL Prepare/Execute statements under the hood. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

[HACKERS] Group commit, revised

2012-01-15 Thread Peter Geoghegan
horrible heuristic, not least since it overloads checkpoint_segments, but is of course only a first-pass effort. Bright ideas are always welcome. Thoughts? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services /dev/sda: ATA device

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-16 Thread Peter Geoghegan
want two fields. I think we've already paid most of the price that this imposes, by using the @n feature in the first place. Certainly, I couldn't isolate any additional overhead. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-16 Thread Peter Geoghegan
that it is very important. Instrumentation of queries is something that it just isn't possible to do well right now, with each of the available third party solutions or pg_stat_statements. That really needs to change. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] BGWriter latch, power saving

2012-01-17 Thread Peter Geoghegan
scale factors, from smallish to quite large. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Group commit, revised

2012-01-17 Thread Peter Geoghegan
quickly, and do another flush to flush its own request after that. Maybe, but we should decide what a big flusher looks like first. That way, if we can't figure out a way to do what you describe with it in time for 9.2, we can at least do what I'm already doing. -- Peter Geoghegan       http

Re: [HACKERS] xlog location arithmetic

2012-01-17 Thread Peter Geoghegan
... FYI, my group commit patch has a little macro, in the spirit of XLByteAdvance, to get the delta between two LSNs in bytes as an uint64. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Group commit, revised

2012-01-17 Thread Peter Geoghegan
, with this patch. Although it's hard to tell from the graph I sent, there is a modest improvement in TPS for even a single client. See the tables in the PDF. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] Setting -Werror in CFLAGS

2012-01-18 Thread Peter Geoghegan
of these sorts of diagnostics. I have a rather low opinion of GCC's diagnostics though. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Simulating Clog Contention

2012-01-19 Thread Peter Geoghegan
is supposed to be a tool that's widely used by sysadmins, not a specialist database benchmarking tool. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Group commit, revised

2012-01-19 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] REVIEW: pg_stat_statements with query tree based normalization

2012-01-20 Thread Peter Geoghegan
that is ultimately produced. Should I keep you posted? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Group commit, revised

2012-01-20 Thread Peter Geoghegan
original e-mail. I have taken the time to re-run the benchmark and update the wiki with that new information - I'd call it a draw. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Group commit, revised

2012-01-20 Thread Peter Geoghegan
On 21 January 2012 03:13, Peter Geoghegan pe...@2ndquadrant.com wrote: I have taken the time to re-run the benchmark and update the wiki with that new information - I'd call it a draw. On second though, the occasional latency spikes that we see with my patch (which uses the poll() based latch

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-21 Thread Peter Geoghegan
proportional improvement than reported on Thursday, and at significantly greater scale. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Memory usage during sorting

2012-01-21 Thread Peter Geoghegan
an index in one case but not another? Is the difference large enough to warrant avoiding pre-deduction? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] Next steps on pg_stat_statements normalisation

2012-01-21 Thread Peter Geoghegan
the hash, at which point if it is seen again constant positions needs to be figured out again (that new canonicalised query string might have more whitespace than before, obviously). Thoughts? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Next steps on pg_stat_statements normalisation

2012-01-23 Thread Peter Geoghegan
On 22 January 2012 05:30, Peter Geoghegan pe...@2ndquadrant.com wrote: The syntax for constants is sufficiently simple that I think that a good set of regression tests should make this entirely practicable, covering all permutations of relevant factors affecting how the implementation should

Re: [HACKERS] basic pgbench runs with various performance-related patches

2012-01-23 Thread Peter Geoghegan
? Presumably this system has a battery-backed cache, whereas my numbers were obtained on my laptop. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] BGWriter latch, power saving

2012-01-26 Thread Peter Geoghegan
commit. I intend to blog about it in the next few days, and I'll present a careful analysis of the benefits of this work there. Look out for it on planet. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/doc/src/sgml

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-26 Thread Peter Geoghegan
of the patch, so I've committed those separately.  I also committed your change to downgrade the belt-and-suspenders check for self-comparison to an assert, with some rewording of your proposed comment. That seems reasonable. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-26 Thread Peter Geoghegan
couldn't very well do that with the existing SortSupport API. I certainly don't care about this capability enough to defend it against any objections that anyone may have, especially at this late stage in the cycle. I just think that we might as well have it. -- Peter Geoghegan       http://www

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-26 Thread Peter Geoghegan
enough. I certainly don't care about this capability enough to defend it against any objections that anyone may have, especially at this late stage in the cycle. I just think that we might as well have it. I don't see any reason not too, assuming it's not a lot of code. Good. -- Peter Geoghegan

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-01-27 Thread Peter Geoghegan
well understood. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Group commit, revised

2012-01-31 Thread Peter Geoghegan
benchmark on the original patch, which has seemingly identical performance characteristics to Heikki's anyway), and the new patch. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

[HACKERS] Proposal for a new severity level

2012-01-31 Thread Peter Geoghegan
obviously either one (error) or the other (severe error), and of those the vast majority are the former, not the latter. The patch footprint here, in raw terms of the number of lines modified, might end up being surprisingly small. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Issues with C++ exception handling in an FDW

2012-01-31 Thread Peter Geoghegan
have read about). I suggest that you generalise from the example of PLV8. The basic problem is that the effect of longjmp()ing over an area of the stack with a C++ non-POD type is undefined. I don't think you can even use structs, as they have implicit destructors in C++. -- Peter Geoghegan

Re: [HACKERS] Issues with C++ exception handling in an FDW

2012-01-31 Thread Peter Geoghegan
using C++11. Or, just use std::is_pod to build a static assertion. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-01 Thread Peter Geoghegan
On 31 January 2012 19:47, Robert Haas robertmh...@gmail.com wrote: On Fri, Jan 27, 2012 at 3:33 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: Patch is attached. I have not changed the duplicate functions. This is because I concluded that it was the lesser of two evils to have to get

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-06 Thread Peter Geoghegan
On 6 February 2012 21:19, Bruce Momjian br...@momjian.us wrote: Peter Geoghegan obviously has done some serious work in improving sorting, and worked well with the community process. Thank you for acknowledging that. It's unfortunate that C does not support expressing these kinds of ideas

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-08 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-08 Thread Peter Geoghegan
is that there is very clearly no net loss in performance at some reasonable granularity, which is a very practical definition. You can quite easily contrive a case that HOT handles really badly. Some people did, I believe, but HOT won out because it was clearly very useful in the real world. -- Peter

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-08 Thread Peter Geoghegan
\ inl_swapfunc(a, b, es, swaptype) inline static void inl_swapfunc(char *a, char *b, size_t n, int swaptype) { if (swaptype = 1) swapcode(long, a, b, n); else swapcode(char, a, b, n); } -- Peter Geoghegan       http://www.2ndQuadrant.com

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-08 Thread Peter Geoghegan
On 8 February 2012 18:48, Peter Geoghegan pe...@2ndquadrant.com wrote: I think that there may be additional benefits from making the qsort_arg specialisation look less like a c stdlib one, like refining the swap logic to have compile-time knowledge of the type it is sorting. I'm thinking

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-08 Thread Peter Geoghegan
On 8 February 2012 23:33, Robert Haas robertmh...@gmail.com wrote: On Wed, Feb 8, 2012 at 1:48 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: That was clear from an early stage, and is something that I acknowledged way back in September OK, so why didn't/don't we do and commit that part

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-09 Thread Peter Geoghegan
irrelevant, as there would be a net gain of zero copies of qsort_arg. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-09 Thread Peter Geoghegan
that the loops exist in those functions (which is the only way that they substantially differ) is because they each have to get the other keys through various ways that characterise the tuple class that they encapsulate (index_getattr(), heap_getattr(), etc). -- Peter Geoghegan       http://www

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-09 Thread Peter Geoghegan
, and there isn't a whole lot we can do about that, at least here. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-10 Thread Peter Geoghegan
representative, as I think that in general, a majority of comparisons won't result in equality. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c new file

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-15 Thread Peter Geoghegan
On 15 February 2012 06:16, Robert Haas robertmh...@gmail.com wrote: On Fri, Feb 10, 2012 at 10:30 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: [ new patch ] I spent quite a bit of time looking at this today - the patch specifically, and the issue of making quicksort fast more generally

Re: [HACKERS] CUDA Sorting

2012-02-15 Thread Peter Geoghegan
support, and because of how longjmp interacts with C++ stack unwinding and so on and so on. Now, you could introduce some kind of parallelism into sorting integers and floats, but that's an awful lot of work for a marginal reward. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-15 Thread Peter Geoghegan
instructions to the binary, or at least code that doesn't pull its weight. Clearly, that isn't the case here, and I suspect that we will find that it isn't the case in other places too. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] CUDA Sorting

2012-02-15 Thread Peter Geoghegan
is in the real world - we don't have so much as a synthetic test case with a single client, as far as I'm aware. I'd encourage the OP to share his work on github or something along those lines. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

[HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-02-20 Thread Peter Geoghegan
On 16 February 2012 21:11, Peter Geoghegan pe...@2ndquadrant.com wrote: *       # XXX: This test currently fails!:        #verify_normalizes_correctly(SELECT cast('1' as dnotnull);,SELECT cast(? as dnotnull);,conn, domain literal canonicalization/cast) It appears to fail because

[HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-02-20 Thread Peter Geoghegan
On 20 February 2012 23:16, Peter Geoghegan pe...@2ndquadrant.com wrote: Clearly this change is a quick and dirty workaround, and something better is required. The question I'd pose to the maintainer of this code is: what business does the coerce_to_target_type call have changing the location

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-02-21 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Support for foreign keys with arrays

2012-02-21 Thread Peter Geoghegan
=fb2923f94db06cd528d588fa52ca3294e025f9f6;hp=d926a88ff8468a43e7d2982273709fbc34058ade;hb=cd30728fb2ed7c367d545fc14ab850b5fa2a4850;hpb=2bbd88f8f841b01efb073972b60d4dc1ff1f6fd0 -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread Peter Geoghegan
to support 8 byte results, exactly as currently anticipated by comments above that function, while supplying a compatibility macro that is used by existing hash_any() clients. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] Document hashtext() and Friends?

2012-02-21 Thread Peter Geoghegan
On 21 February 2012 20:30, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: My pg_stat_statements normalisation patch actually extends the underlying hash_any() function to support 8 byte results, ... er, what?  That seems rather out of scope for that patch

Re: [HACKERS] Publish checkpoint timing and sync files summary data to pg_stat_bgwriter

2012-02-22 Thread Peter Geoghegan
this information if it's invariably being collected anyway. Cheers -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml new file mode 100644 index cb13c8e..56a3ca4

Re: [HACKERS] 16-bit page checksums for 9.2

2012-02-22 Thread Peter Geoghegan
scaling levels. I'll make a pdf of the full report available if that would be useful. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services config Description: Binary data attachment: scaling-sets-page-checksums.png -- Sent via pgsql

Re: [HACKERS] pg_stat_statements normalization: re-review

2012-02-23 Thread Peter Geoghegan
committer would agree that this was a useful change even without this patch, and go ahead and commit the necessary changes, but I can appreciate that everyone is quite busy at this time of the cycle and so I'm not relying on that happening. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] pg_stat_statements normalization: re-review

2012-02-23 Thread Peter Geoghegan
On 23 February 2012 11:09, Peter Geoghegan pe...@2ndquadrant.com wrote: On 23 February 2012 09:58, Daniel Farina dan...@heroku.com wrote: * The small changes to hashing are probably not strictly required, unless collisions are known to get terrible. I imagine that collisions would be rather

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-02-24 Thread Peter Geoghegan
=1244498ffb291b67d35917a6fdddb54b0d8d759d;hb=a2794623d292f7bbfe3134d1407281055acce584;hpb=6734182c169a1ecb74dd8495004e896ee4519adb -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-02-27 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-01 Thread Peter Geoghegan
feature, a committer has yet to step forward to work towards this patch getting committed. Can someone volunteer, please? My expectation is that this feature will make life a lot easier for a lot of Postgres users. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-01 Thread Peter Geoghegan
On 1 March 2012 22:09, Josh Berkus j...@agliodbs.com wrote: On 3/1/12 1:57 PM, Daniel Farina wrote: On Thu, Mar 1, 2012 at 1:27 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: My expectation is that this feature will make life a lot easier for a lot of Postgres users. Yes.  It's hard

Re: [HACKERS] 16-bit page checksums for 9.2

2012-03-02 Thread Peter Geoghegan
://pagechecksum.staticloud.com/ Note that detailed latency figures for each test are not available in this report, so only the main page is available, but that gets you the raw tps numbers. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] pg_stat_statements and planning time

2012-03-08 Thread Peter Geoghegan
on the common case where we don't particularly care about plan time. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] pg_stat_statements and planning time

2012-03-08 Thread Peter Geoghegan
as possible generally. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Checksums, state of play

2012-03-08 Thread Peter Geoghegan
/Articles/292984/ -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Is it time for triage on the open patches?

2012-03-10 Thread Peter Geoghegan
marked RFC now. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-13 Thread Peter Geoghegan
that seem like an interesting idea? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-17 Thread Peter Geoghegan
of clean-up, to cut back on some of the tests that are redundant. Some of the tests are merely fuzz tests, which are perhaps a bit questionable. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-18 Thread Peter Geoghegan
this be integrated with the standard regression tests, if that's something that is important? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-18 Thread Peter Geoghegan
to maintain. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-18 Thread Peter Geoghegan
testing stuff, which probably isn't all that useful). -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-18 Thread Peter Geoghegan
on a pg_regress based approach with a reasonably-sized random subset of about 20 of my existing tests, to provide some basic smoke testing. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

  1   2   3   4   5   6   7   8   9   10   >