Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread David E. Wheeler
On Oct 14, 2008, at 12:36, Alvaro Herrera wrote: I don't know if you have noticed, but the spoonbill buildfarm member is failing the citext test. Unfortunately the regression diff is not very helpful: Binary files /home/pgbuild/pgbuildfarm/HEAD/pgsql.2397/contrib/

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Maybe we should pass -a to diff so that it displays the difference even if it thinks the file is binary. Unfortunately not portable: $ /usr/bin/diff -a foo bar /usr/bin/diff: illegal option -- a usage: diff [ -C n ] [ -S name ] [ -bcefhilnrstw ]

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Aidan Van Dyk
* Tom Lane [EMAIL PROTECTED] [081014 16:08]: Alvaro Herrera [EMAIL PROTECTED] writes: Maybe we should pass -a to diff so that it displays the difference even if it thinks the file is binary. Unfortunately not portable: $ /usr/bin/diff -a foo bar /usr/bin/diff: illegal option -- a

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Andrew Dunstan
Aidan Van Dyk wrote: * Tom Lane [EMAIL PROTECTED] [081014 16:08]: Alvaro Herrera [EMAIL PROTECTED] writes: Maybe we should pass -a to diff so that it displays the difference even if it thinks the file is binary. Unfortunately not portable: $ /usr/bin/diff -a foo bar

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Stefan Kaltenbrunner
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Maybe we should pass -a to diff so that it displays the difference even if it thinks the file is binary. Unfortunately not portable: $ /usr/bin/diff -a foo bar /usr/bin/diff: illegal option -- a usage: diff [ -C n ] [ -S name ]

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread David E. Wheeler
On Oct 14, 2008, at 14:00, Stefan Kaltenbrunner wrote: well what we are looking at here are actually two issues - one is the regression failure - diff -a produces: http://www.kaltenbrunner.cc/files/citext.diff.txt Am I reading that right? Is there really just an issue of a different

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Andrew Dunstan
Stefan Kaltenbrunner wrote: Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Maybe we should pass -a to diff so that it displays the difference even if it thinks the file is binary. Unfortunately not portable: $ /usr/bin/diff -a foo bar /usr/bin/diff: illegal option -- a

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Stefan Kaltenbrunner
David E. Wheeler wrote: On Oct 14, 2008, at 14:00, Stefan Kaltenbrunner wrote: well what we are looking at here are actually two issues - one is the regression failure - diff -a produces: http://www.kaltenbrunner.cc/files/citext.diff.txt Am I reading that right? Is there really just an

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Tom Lane
Stefan Kaltenbrunner [EMAIL PROTECTED] writes: Tom Lane wrote: Perhaps Stefan can run the test manually and get us a readable diff. well what we are looking at here are actually two issues - one is the regression failure - diff -a produces: http://www.kaltenbrunner.cc/files/citext.diff.txt

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Andrew Dunstan
Tom Lane wrote: the other problem is that each of those failures leaves spoonbill with a running postgresql instance that causes a follow up failure with the next buildfarm run I think this is a known buildfarm-script problem --- it forgets to shut down the installed postmaster if

Re: [HACKERS] spoonbill is failing citext test

2008-10-14 Thread Stefan Kaltenbrunner
Andrew Dunstan wrote: Tom Lane wrote: the other problem is that each of those failures leaves spoonbill with a running postgresql instance that causes a follow up failure with the next buildfarm run I think this is a known buildfarm-script problem --- it forgets to shut down the