Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-02 Thread Stéphane Ducasse
OK marcus will give a try. We will have to clean all these points with weakstuff once for all and getting more or less aligned with the work levente did. Stef On Oct 1, 2010, at 5:48 PM, Igor Stasenko wrote: Here what happens: Original method WeakKeyDictionaryfinalizeValues

[Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Marcus Denker
Issue 3002: A new finalization code ready for integration in Pharo Issue 3026: after 12172, sync with repository and reload -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD. ___ Pharo-project mailing

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Levente Uzonyi
On Fri, 1 Oct 2010, Marcus Denker wrote: Issue 3002: A new finalization code ready for integration in Pharo Issue 3026: after 12172, sync with repository and reload If you didn't fix the migration code, then WeakFinalizationRegistry is still in the system. Details here:

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Igor Stasenko
On 1 October 2010 12:06, Levente Uzonyi le...@elte.hu wrote: On Fri, 1 Oct 2010, Marcus Denker wrote: Issue 3002:     A new finalization code ready for integration in Pharo Issue 3026: after 12172, sync with repository and reload If you didn't fix the migration code, then

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Levente Uzonyi
On Fri, 1 Oct 2010, Igor Stasenko wrote: On 1 October 2010 12:06, Levente Uzonyi le...@elte.hu wrote: On Fri, 1 Oct 2010, Marcus Denker wrote: Issue 3002:     A new finalization code ready for integration in Pharo Issue 3026: after 12172, sync with repository and reload If you didn't fix

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Igor Stasenko
2010/10/1 Levente Uzonyi le...@elte.hu: On Fri, 1 Oct 2010, Igor Stasenko wrote: On 1 October 2010 12:06, Levente Uzonyi le...@elte.hu wrote: On Fri, 1 Oct 2010, Marcus Denker wrote: Issue 3002:     A new finalization code ready for integration in Pharo Issue 3026: after 12172, sync with

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Stéphane Ducasse
Igor Can you have a look because right now in 12174 I cannot do any update anymore so - either we fix it now or we have to rollbakc to 12161. Thanks. On Oct 1, 2010, at 12:49 PM, Igor Stasenko wrote: 2010/10/1 Levente Uzonyi le...@elte.hu: On Fri, 1 Oct 2010, Igor Stasenko

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Igor Stasenko
On 1 October 2010 15:47, Stéphane Ducasse stephane.duca...@inria.fr wrote: Igor Can you have a look because right now in 12174 I cannot do any update anymore so        - either we fix it now        or we have to rollbakc to 12161. I will take a look Thanks. On Oct 1, 2010, at 12:49 PM,

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Stéphane Ducasse
Igor I was thinking to rollback now because we cannot do anything. Is is ok for you? And after we can include everything. Stef On Oct 1, 2010, at 3:08 PM, Igor Stasenko wrote: On 1 October 2010 15:47, Stéphane Ducasse stephane.duca...@inria.fr wrote: Igor Can you have a look because right

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Igor Stasenko
On 1 October 2010 16:15, Stéphane Ducasse stephane.duca...@inria.fr wrote: Igor I was thinking to rollback now because we cannot do anything. Is is ok for you? And after we can include everything. Sure, no problem. It should not behave like that. There could be some very little speed

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Igor Stasenko
I found the bug.. This was in WeakKeyDictionaryexpiredValuesDo: Please, try doing the same with this patch, and see if problem gone. See attachment. -- Best regards, Igor Stasenko AKA sig. WeakKeyDictionary-expiredValuesDo.st Description: Binary data

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Levente Uzonyi
On Fri, 1 Oct 2010, Igor Stasenko wrote: On 1 October 2010 16:15, Stéphane Ducasse stephane.duca...@inria.fr wrote: Igor I was thinking to rollback now because we cannot do anything. Is is ok for you? And after we can include everything. Sure, no problem. It should not behave like that.

[Pharo-project] [update 1.2] #12161

2010-10-01 Thread stephane ducasse
12161 - - Issue 3003: handleDisabledKey: is missing in Editor and subclasses - Issue 2963: systemOrganizer fixes. Thanks German Leiva and James Foester Stef ___ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Igor Stasenko
2010/10/1 Levente Uzonyi le...@elte.hu: On Fri, 1 Oct 2010, Igor Stasenko wrote: On 1 October 2010 16:15, Stéphane Ducasse stephane.duca...@inria.fr wrote: Igor I was thinking to rollback now because we cannot do anything. Is is ok for you? And after we can include everything. Sure, no

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Igor Stasenko
Oh crap.. the problem is not in that. MC produces huge weak-key dictionary during updates for instance 12159 - 12162 produces dictionary with 14k entries, which sits in #FinalizationDependents array and scanned after each GC. And during scanning, its using block closures (and each push of block

Re: [Pharo-project] [update 1.2] #12161 - #12172

2010-10-01 Thread Igor Stasenko
Here what happens: Original method WeakKeyDictionaryfinalizeValues WeakKeyDictionaryfinalizeValues Clear all associations with nil keys array do:[:assoc| 1 to: array size do:[:i | | assoc | assoc := array at: i. assoc ifNotNil:[