Good catch
We should move them close to MultiCompositionScanner
Stef
On Mar 14, 2012, at 3:14 PM, Guillermo Polito wrote:
-
MultiCompositionScannercomposeFrom:inRectangle:firstLine:leftSide:rightSide:
depends on TextLine which is packaged as Morphic-Text Support
-
On Mar 15, 2012, at 4:18 PM, Stéphane Ducasse wrote:
Good catch
We should move them close to MultiCompositionScanner
Yes, in general the structure of the system is ad-hoc. e.g. the whole Multi-*
changes should be folded into
the classes that they extend (or at least be moved close).
Good catch
We should move them close to MultiCompositionScanner
Yes, in general the structure of the system is ad-hoc. e.g. the whole Multi-*
changes should be folded into
the classes that they extend (or at least be moved close).
Other: Canvas is in Morphic,
it should not :)
On Wed, Mar 14, 2012 at 11:14 AM, Guillermo Polito
guillermopol...@gmail.com wrote:
*-
MultiCompositionScannercomposeFrom:inRectangle:firstLine:leftSide:rightSide:
*
depends on TextLine which is packaged as Morphic-Text Support
TextLine seems that can be safely moved along with
TextLine seems that can be safely moved along with MultiCompositionScanner.
good!
- MultiCompositionScannersetFont
depends on TextComposer which is packaged as Morphic-Text Support also
This dependency is only for this method:
TextComposer classcharacterForColumnBreak
MultiCompositionScannersetFont uses
TextComposercharacterForColumnBreak...
What I do suggest is to move #characterForColumnBreak to the scanner (or
make the scanner know its composer instead of hardcoding the reference).
But since I don't really know these classes I'm totally blind :/
On Thu,
Hey, composition scanners and display scanners should not belong to Kernel.
they should be either in graphics package or in morphic itself.
Why we moved this stuff to kernel?
--
Best regards,
Igor Stasenko.
On Mar 15, 2012, at 5:32 PM, Igor Stasenko wrote:
Hey, composition scanners and display scanners should not belong to Kernel.
they should be either in graphics package or in morphic itself.
Why we moved this stuff to kernel?
Nobody moved... they where always there. It's a mess of epic
On Thu, Mar 15, 2012 at 1:34 PM, Marcus Denker marcus.den...@inria.frwrote:
On Mar 15, 2012, at 5:32 PM, Igor Stasenko wrote:
Hey, composition scanners and display scanners should not belong to
Kernel.
they should be either in graphics package or in morphic itself.
Why we moved this
Igor
I would not put it in Morphic.
Now it depends which kernel we are talking about. Because may be text should be
a large kernel.
Stef
On Mar 15, 2012, at 5:32 PM, Igor Stasenko wrote:
Hey, composition scanners and display scanners should not belong to Kernel.
they should be either in
Hi Guillermo,
great to see someone to improve modularity of the system. Look at
results of latest Pharo-Kernel:
https://ci.lille.inria.fr/pharo/view/Pharo-Kernel/job/Pharo%20Kernel%201.4/lastSuccessfulBuild/artifact/PharoKernel-1.4/info.txt
This Undeclared clearly show unwelcome kernel
Hi Guillermo,
great to see someone to improve modularity of the system.
:)
We are always thinking. Now Guille will start a PhD with us :)
Look at
results of latest Pharo-Kernel:
12 matches
Mail list logo
