[Pixman] [PATCHv2 0/3] More general reduction of BILINEAR to NEAREST

2016-03-18 Thread Søren Sandmann Pedersen
This series addresses the comments by Bill and also changes pixman-fast-path.c so that it picks NEAREST fast paths before BILINEAR. (I noticed this because the new filter-reduction-test.c failed to detect a bug that I deliberately introduced). Søren

Re: [Pixman] [PATCH v14 16/22] pixman-filter: distribute normalization error over filter

2016-03-18 Thread Søren Sandmann
On Fri, Mar 18, 2016 at 9:54 PM, Søren Sandmann wrote: > On Sun, Mar 6, 2016 at 8:06 PM, wrote: > >> From: Bill Spitzak >> >> This removes a high-frequency spike in the middle of some filters that is >> caused by math errors all

Re: [Pixman] [PATCH v14 16/22] pixman-filter: distribute normalization error over filter

2016-03-18 Thread Søren Sandmann
On Sun, Mar 6, 2016 at 8:06 PM, wrote: > From: Bill Spitzak > > This removes a high-frequency spike in the middle of some filters that is > caused by math errors all being in the same direction. > > Signed-off-by: Bill Spitzak > --- >

Re: [Pixman] [PATCHv2 2/3] Add new test of filter reduction from BILINEAR to NEAREST

2016-03-18 Thread Bill Spitzak
Looks like a good idea to me. It is unfortunate that if it fails there is not much indication which image failed but that would require a lot more checksums. I would guess the checksums are computed by running this with the fast paths disabled? ___