Re: [Pixman] [PATCH 13/15] pixman-filter: refactor cubic polynominal and don't range check

Indeed, further tests reveal there was a bug if one of the filters is IMPULSE. It was not sampling at the center of the filter, but instead offset by the width. I have a patch to fix this that will be in the next set. On 12/26/2015 08:05 PM, Bill Spitzak wrote: Sounds like I better look at

Re: [Pixman] [PATCH 13/15] pixman-filter: refactor cubic polynominal and don't range check

Sounds like I better look at this more carefully, it is quite possible it is producing bad filters but with small enough error that the images look OK. On Dec 23, 2015 5:25 AM, "Oded Gabbay" wrote: > On Tue, Dec 22, 2015 at 9:01 PM, Bill Spitzak wrote:

Re: [Pixman] [PATCH 13/15] pixman-filter: refactor cubic polynominal and don't range check

On Tue, Dec 22, 2015 at 4:38 AM, Oded Gabbay wrote: > On Sat, Dec 12, 2015 at 8:06 PM, wrote: > > From: Bill Spitzak > > > > The other filters do not check for x being in range, so there is > > no reason for cubic to do so. > > This

Re: [Pixman] [PATCH 13/15] pixman-filter: refactor cubic polynominal and don't range check

On Sat, Dec 12, 2015 at 8:06 PM, wrote: > From: Bill Spitzak > > The other filters do not check for x being in range, so there is > no reason for cubic to do so. This argument is a bit problematic. We could also argue that this filter was actually