Re: [Pixman] pixman-0.32.6 fails to build on mips32r2

2014-09-11 Thread Vicente Olivert Riera
Hello Nemanja, yes, it works. But your patch wrong because it can't be applied without reverting your last commit which was already pushed upstream. So, the right solution would be to apply a new patch which removes the wrong lines and add the right lines. I have attached a valid patch to

Re: [Pixman] [PATCH pixman 02/11] pixman-filter: Correct Simpsons integration

2014-09-11 Thread Bill Spitzak
Actually the previous version did 1,2,6,6...6,6,2,1. Since it divided by 3 it produced almost 2x the correct integration, though this was fixed by the normalization later. It also did not do Simpsons integration, instead it was much more like adding evenly-spaced samples. On 09/10/2014 07:01

[Pixman] [PATCH pixman 01/13] demos/scale: Compute filter size using boundary of xformed ellipse, not rectangle

2014-09-11 Thread Bill Spitzak
This is much more accurate and less blurry. In particular the filtering does not change as the image is rotated. --- demos/scale.c | 43 ++- 1 file changed, 2 insertions(+), 41 deletions(-) diff --git a/demos/scale.c b/demos/scale.c index

[Pixman] [PATCH pixman 05/13] pixman-filter: Speed up the BOX+BOX filter

2014-09-11 Thread Bill Spitzak
This is easy as the caller already intersected the two boxes. --- pixman/pixman-filter.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/pixman/pixman-filter.c b/pixman/pixman-filter.c index 816d085..15ea270 100644 --- a/pixman/pixman-filter.c +++

[Pixman] [PATCH pixman 08/13] pixman-filter: reduce amount of malloc/free/memcpy to generate filter

2014-09-11 Thread Bill Spitzak
--- pixman/pixman-filter.c | 59 1 file changed, 25 insertions(+), 34 deletions(-) diff --git a/pixman/pixman-filter.c b/pixman/pixman-filter.c index 220496e..b656923 100644 --- a/pixman/pixman-filter.c +++ b/pixman/pixman-filter.c @@ -225,25

[Pixman] [PATCH pixman 09/13] pixman-filter: make IMPULSE+IMPULSE not produce blank image

2014-09-11 Thread Bill Spitzak
--- pixman/pixman-filter.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pixman/pixman-filter.c b/pixman/pixman-filter.c index b656923..78ea72d 100644 --- a/pixman/pixman-filter.c +++ b/pixman/pixman-filter.c @@ -323,11 +323,13 @@

[Pixman] [PATCH pixman 12/13] pixman-filter: refactor polynominal and don't range check

2014-09-11 Thread Bill Spitzak
Also made impulse filter not range check. All the other filters do not test for x in range. --- pixman/pixman-filter.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/pixman/pixman-filter.c b/pixman/pixman-filter.c index dcbed11..8416550 100644 ---

[Pixman] [PATCH pixman 06/13] pixman-filter: Consistency in arg names to integral ()

2014-09-11 Thread Bill Spitzak
Rename kernel1/2 to reconstruct/sample and use 1/scale as the scale argument, thus matching the names in other functions. --- pixman/pixman-filter.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/pixman/pixman-filter.c

[Pixman] [PATCH pixman 04/13] pixman-filter: put error on center of odd-sized filters

2014-09-11 Thread Bill Spitzak
--- pixman/pixman-filter.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pixman/pixman-filter.c b/pixman/pixman-filter.c index a9af72c..816d085 100644 --- a/pixman/pixman-filter.c +++ b/pixman/pixman-filter.c @@ -294,7 +294,7 @@ create_1d_filter (int *width,

[Pixman] [PATCH pixman 11/13] pixman-filter: Gaussian fixes

2014-09-11 Thread Bill Spitzak
Simplified the function. Expanded size slightly (from ~4.25 to 5) to make the cutoff less noticable. The filter is truncated at a value of .001 instead of .006, this new value is less than 1/2 of 1/255, rather than greater than it. --- pixman/pixman-filter.c |7 ++- 1 file changed, 2

[Pixman] [PATCH pixman 13/13] pixman-image: Implement PIXMAN_FILTER_GOOD/BEST as separable convolutions

2014-09-11 Thread Bill Spitzak
GOOD uses the BOX.BOX filter, and uses BILINEAR for all scales 1/1.35. If only one scale is 1/1.35 if uses LINEAR.IMPULSE for it to match the BILINEAR result. At very small scales it clamps the filter size to 16. BEST uses the IMPULSE.LANCZOS2 filter up to a scale of 2 with the filter size