Re: [Pixman] [PATCH v10 10/15] pixman-filter: Gaussian fixes

On Tue, Feb 2, 2016 at 8:28 AM, wrote: > From: Bill Spitzak > > The SIGMA term drops out on simplification. > > Expanded the size slightly (from ~4.25 to 5) to make the cutoff less > noticable. > The filter is truncated at a value of .001 instead of .006,

Re: [Pixman] [PATCH v10 06/15] pixman-filter: reduce amount of malloc/free/memcpy to generate filter

On Tue, Feb 2, 2016 at 8:28 AM, wrote: > From: Bill Spitzak > > Rearranged so that the entire block of memory for the filter pair > is allocated first, and then filled in. Previous version allocated > and freed two temporary buffers for each filter and did

Re: [Pixman] [PATCH v10 08/15] pixman-filter: Corrections to the integral() function

On Tue, Feb 2, 2016 at 8:28 AM, wrote: > From: Bill Spitzak > > The IMPULSE special-cases did not sample the center of the of the region. > This caused it to sample the filters outside their range, and produce > assymetric filters and other errors. Fixing

Re: [Pixman] [PATCH v10 12/15] pixman-filter: Made reconstruct==impulse and scale < 1 set scale to 1

On Tue, Feb 2, 2016 at 8:28 AM, wrote: > From: Bill Spitzak > > This replaces settings that don't work (because the filter cannot be > normalized) > with something that produces an image. > > v7: First version with this. Previously you got lots of strange

Re: [Pixman] [PATCH v10 11/15] pixman-filter: Turn off subsampling for width=1 filters

On Tue, Feb 2, 2016 at 8:28 AM, wrote: > From: Bill Spitzak > > Due to normalization these filters must all be identical (a single 1.0). > > Also make IMPULSE.IMPULSE produce a width=1 filter, rather than zero > (which did not work). > > v7: Replaced

[Pixman] [PATCH v11 08/14] pixman-filter: Corrections to the integral() function

From: Bill Spitzak The IMPULSE special-cases did not sample the center of the of the region. This caused it to sample the filters outside their range, and produce assymetric filters and other errors. Fixing this required changing the arguments to integral() so the correct

[Pixman] [PATCH v11 12/14] pixman-filter: Add description to pixman_filter_create_separable_convolution()

From: Bill Spitzak v9: Described arguments and more filter combinations, fixed some errors. v11: Further correction, in particular replaced "scale" with "size" Signed-off-by: Bill Spitzak --- pixman/pixman-filter.c | 50

[Pixman] [PATCH v11 05/14] pixman-filter: Consistency in arg names to integral ()

From: Bill Spitzak Rename kernel1/2 to reconstruct/sample to match the other functions. Rename "scale" to "size" to avoid confusion with the scale being applied to the image, which is the reciprocol of this value. v10: Renamed "scale" to "size" Signed-off-by: Bill Spitzak

[Pixman] [PATCH v11 14/14] demos/scale: default to GOOD and locked-together axis

From: Bill Spitzak This makes the demo match normal behavior of pixman/cairo at startup. Signed-off-by: Bill Spitzak --- demos/scale.c | 10 +- demos/scale.ui | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/demos/scale.c

[Pixman] [PATCH v11 02/14] demos/scale: Added pulldown to choose PIXMAN_FILTER_* value

From: Bill Spitzak This allows testing of GOOD/BEST and to do comparisons between the basic filters and PIXMAN_FILTER_SEPARABLE_CONVOLUTION settings. Signed-off-by: Bill Spitzak Reviewed-by: Oded Gabbay --- demos/scale.c | 14

[Pixman] [PATCH v11] Implement PIXMAN_FILTER_GOOD/BEST

Changes form previous version: - whitespace and formatting fixes - removed "fixes" for IMPULSE.x at size < 1 or IMPULSE.IMPULSE, just let them produce unusable filters, since caller can avoid doing this. - removed patch that deleted range checks - simplification of the filter_width function -

[Pixman] [PATCH v11 04/14] pixman-image: Added enable-gnuplot config to view filters in gnuplot

From: Bill Spitzak If enable-gnuplot is configured, then you can pipe the output of a pixman-using program to gnuplot and get a continuously-updated plot of the horizontal filter. This works well with demos/scale to test the filter generation. The plot is all the different

[Pixman] [PATCH v11 03/14] demos/scale: Only generate filters when used for separable

From: Bill Spitzak This makes the speed of the demo more accurate, as the filter generation is a visible fraction of the time it takes to do a transform. This also prevents the output of unused filters in the gnuplot option in the next patch. Signed-off-by: Bill Spitzak

[Pixman] [PATCH v11 06/14] pixman-filter: reduce amount of malloc/free/memcpy to generate filter

From: Bill Spitzak Rearranged so that the entire block of memory for the filter pair is allocated first, and then filled in. Previous version allocated and freed two temporary buffers for each filter and did an extra memcpy. v8: small refactor to remove the filter_width

[Pixman] [PATCH v11 09/14] pixman-filter: Nested polynomial for cubic

From: Bill Spitzak v11: Restored range checks Signed-off-by: Bill Spitzak --- pixman/pixman-filter.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/pixman/pixman-filter.c b/pixman/pixman-filter.c index e82871f..e5ef8e6

Re: [Pixman] [PATCH 1/2] Add test for _intersect_rect(, )

Hello Bill, Thanks for the patches. By the way, they are a little bit mangled, maybe because you did not use "git send-email" to send them? This is easily fixable for small patches like this, but may become a problem for larger patch sets. On Tue, 2 Feb 2016 17:35:28 -0800 Bill McCloskey

Re: [Pixman] [PATCH v10 15/15] pixman-image: Implement PIXMAN_FILTER_GOOD/BEST as separable convolutions

On 02/04/2016 05:42 AM, Oded Gabbay wrote: On Tue, Feb 2, 2016 at 8:28 AM, wrote: From: Bill Spitzak Detects and uses PIXMAN_FILTER_NEAREST for all 8 90-degree rotations and reflections when the scale is 1.0 and integer translation. GOOD uses: scale

Re: [Pixman] [PATCH v10 15/15] pixman-image: Implement PIXMAN_FILTER_GOOD/BEST as separable convolutions

On Tue, Feb 2, 2016 at 8:28 AM, wrote: > From: Bill Spitzak > > Detects and uses PIXMAN_FILTER_NEAREST for all 8 90-degree rotations and > reflections when the scale is 1.0 and integer translation. > > GOOD uses: > > scale < 1/16 : BOX.BOX at size 16 >