Re: [Pixman] [PATCH 1/3] Add pixman_composite_trapezoids().

2011-01-13 Thread Adam Jackson
On Wed, 2011-01-12 at 08:49 -0500, Søren Sandmann Pedersen wrote: This function is an implementation of the X server request Trapezoids. That request is what the X backend of cairo is using all the time; by moving it into pixman we can hopefully make it faster. This looks like it loses the

Re: [Pixman] [PATCH 4/5] vmx: fix unused var warnings

2015-06-17 Thread Adam Jackson
On Tue, 2015-06-16 at 18:28 +0300, Oded Gabbay wrote: @@ -214,7 +221,7 @@ vmx_combine_over_u_no_mask (uint32_t * dest, { int i; vector unsigned int vdest, vsrc; -vector unsigned char src_mask; +DECLARE_SRC_MASK_VAR while (width ((uintptr_t)dest 15))

Re: [Pixman] [PATCH 0/5] Fix vmx fast-paths for ppc64le

2015-06-17 Thread Adam Jackson
On Tue, 2015-06-16 at 18:27 +0300, Oded Gabbay wrote: Please review. With the style bug in 4/5 fixed, series is: Reviewed-by: Adam Jackson a...@redhat.com - ajax ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org

Re: [Pixman] [PATCH v2 03/11] vmx: implement fast path vmx_fill

2015-07-15 Thread Adam Jackson
On Wed, 2015-07-15 at 16:36 +0300, Oded Gabbay wrote: +else +{ + return FALSE; +} + +vfiller = create_mask_1x32_128(filler); This appears to be less of a regression for small operations if you fall back to the C code for byte_width 64 here. That seems to be about the

Re: [Pixman] [PATCH] vmx: Fix vector loads on ppc64le

2018-05-14 Thread Adam Jackson
On Fri, 2018-05-11 at 11:26 +0300, Siarhei Siamashka wrote: > That's an excellent example, demonstrating why the pixman test > suite exists in the first place and how it helps to ensure that > the end users are much less likely to encounter problems if > package maintainers are doing a proper

[Pixman] [PATCH] vmx: Fix vector loads on ppc64le

2018-05-10 Thread Adam Jackson
From: Dan Horák <d...@danny.cz> Bugzilla: https://bugzilla.redhat.com/1572540 Signed-off-by: Adam Jackson <a...@redhat.com> --- pixman/pixman-vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pixman/pixman-vmx.c b/pixman/pixman-vmx.c index 41efdcf..52

Re: [Pixman] Pushing unreviewed patches to the pixman git repository

2018-06-07 Thread Adam Jackson
enable this was unreviewed; mea maxima culpa. There's no magic in it, at least: --- commit 9034d0cc3241c56cbe3bdbc98247a68e3529ee48 (gitlab/ci, tmp, ci) Author: Adam Jackson Date: Thu May 31 12:32:18 2018 -0400 ci: Add .gitlab-ci.yml Just builds on Fedora 28 for x86_64 at the moment, bu

Re: [Pixman] Giving out commit access

2018-06-12 Thread Adam Jackson
On Tue, 2018-06-12 at 10:29 +0300, Pekka Paalanen wrote: > Hi, > > what are the criteria to give out commit access to Pixman? > As I could give access, I should probably have an idea when. > > I see Maarten already got his, and there is another asking for it, > but no discussion about them at

Re: [Pixman] [PATCH] test: Adjust for clang's removal of __builtin_shuffle

2018-06-05 Thread Adam Jackson
On Mon, 2018-06-04 at 13:46 -0700, Matt Turner wrote: > On Mon, Jun 4, 2018 at 10:37 AM, Adam Jackson wrote: > > I think we're starting to be well overdue for an 0.36 release, but I'd > > like to take the opportunity to suggest moving to fdo's gitlab as we do > > that.

[Pixman] Project moved to github

2018-06-05 Thread Adam Jackson
Well that was quick. The project page is over here now: https://gitlab.freedesktop.org/pixman/pixman New git URLs: https://gitlab.freedesktop.org/pixman/pixman.git g...@gitlab.freedesktop.org:pixman/pixman.git Bugzilla issues were imported. I'll make a pass through the patchwork queue (it's

Re: [Pixman] [PATCH] test: Adjust for clang's removal of __builtin_shuffle

2018-06-04 Thread Adam Jackson
it doesn't change semantics. With or without that bit: Reviewed-by: Adam Jackson I think we're starting to be well overdue for an 0.36 release, but I'd like to take the opportunity to suggest moving to fdo's gitlab as we do that. I already have a copy imported personally and have CI working: https://

Re: [Pixman] [BUG] SIGSEGV in sse2_fill

2018-08-29 Thread Adam Jackson
On Wed, 2018-08-29 at 10:59 +0200, Frédéric Fauberteau wrote: > I encounter a xorg segfault after building it with the following > optimization CFLAGS: -march=athlon64-sse3 -mfpmath=sse This is almost certainly a bug in either the radeon driver or in the X server. pixman is usually innocent in

Re: [Pixman] [PATCH] test: Fix stride calculation in stress-test

2018-07-06 Thread Adam Jackson
On Tue, 2018-06-12 at 12:13 -0400, Søren Sandmann wrote: > Reviewed-by: soren.sandm...@gmail.com Merged, thanks: remote: remote: I: patch #229063 updated using rev 018bf2f23033ea0c82df3e4cf48dbb330bec9414 remote: remote: I: 1 patch(es) updated to state Accepted. remote: To

Re: [Pixman] [PATCH 1/4] Implement floating point gradient computation

2018-12-11 Thread Adam Jackson
On Wed, 2018-12-05 at 10:08 +0200, Pekka Paalanen wrote: > On Tue, 4 Dec 2018 17:36:18 +0100 > Maarten Lankhorst wrote: > > Series looks sane, 1/4 is cleaner than my version. I would change Bpp > > to cpp, or multiply by 8, since Bpp usually means bits per pixel. > > And cpp means

Re: [Pixman] [PATCH 1/2] Implement floating point gradient computation

2019-01-11 Thread Adam Jackson
On Thu, 2019-01-03 at 12:18 +0100, Maarten Lankhorst wrote: > From: Basile Clement > > This patch modifies the gradient walker to be able to generate floating > point values directly in addition to a8r8g8b8 32 bit values. This is > then used by the various gradient implementations to render in

Re: [Pixman] Dithering patches, v2

2019-05-28 Thread Adam Jackson
On Sat, 2019-05-25 at 07:50 -0700, Bryce Harrington wrote: > Looks like since the move to gitlab.freedesktop.org I no longer have > commit access on pixman; you'll need to land them for us. Apologies for the oversight, I've added you to the pixman group. - ajax

Re: [Pixman] static TLS is a scarce resource

2019-06-25 Thread Adam Jackson
On Fri, 2019-06-21 at 17:07 +0200, Simon Richter wrote: > Hi, > > On Fri, Jun 21, 2019 at 04:44:08PM +0200, Dan Horák wrote: > > > Is there anything pixman could do to lower its > > consumption of TLS? Because it's only a matter of time when the "static > > TLS allocation" error will appear

Re: [Pixman] [PATCH v2 2/3] build: use '-mloongson-mmi' for Loongson MMI.

2020-02-21 Thread Adam Jackson
On Thu, 2020-02-20 at 22:23 +0800, Yin Shiyou wrote: > It's suggested to use '-mloongson-mmi' to enable MMI. > To keep compatible with old processor, '-mloongson-mmi' will be > setted for Loongson-3A only. The pattern we've used for other CPUs is to build support for as many ISA extensions as

Re: [Pixman] [PATCH 3/3] Add MSA support.

2020-02-11 Thread Adam Jackson
On Tue, 2020-02-11 at 16:28 +0800, Yin Shiyou wrote: > MSA is mips SIMD Architecture. > Loongson processor support MSA from 3A4000 and 2K1000. I'm not sure this patch accomplishes anything: > +static const pixman_fast_path_t msa_fast_paths[] = > +{ > +{ PIXMAN_OP_NONE }, > +}; > + >

Re: [Pixman] [PATCH v2] build: improve control logic for enabling MMI.

2020-03-06 Thread Adam Jackson
On Fri, 2020-03-06 at 19:28 +0800, Shiyou Yin wrote: > From: Yin Shiyou > > 1. Replace LS_CFLAGS with MMI_CFLAGS to express its intention more accurately. >LS_CFLAGS is still available, but it is not recommended. > 2. Improve the control logic for enabling MMI. > > Three essential

Re: [Pixman] trouble with pixman lib

2020-07-10 Thread Adam Jackson
On Wed, Jul 8, 2020 at 8:51 PM Jack wrote: > > Hello EveryOne > I am a new guy. While I am trying to build cairo, i use pixman. I build a > pixman lib and it seems well. After I add it in cairo project, something is > wrong, the wrong information tell it can not find get function port from lib

Re: [Pixman] Fwd: [PATCH] Avoid out-of-bounds read when accessing individual bytes from mask

2021-05-07 Thread Adam Jackson
Ugh, my fault there. That explanation all makes a ton of sense, thanks for the patch! I've opened a merge request for it here: https://gitlab.freedesktop.org/pixman/pixman/-/merge_requests/45 This is probably worth a minor release on its own, if anyone has a favorite bug or patch they want to