Re: [Pixman] [PATCH 2/8] Add pixman_glyph_cache_t API

2012-05-30 Thread Behdad Esfahbod
Looks nice. I don't see you updating the mru list though. behdad On 05/30/2012 07:41 PM, Søren Sandmann wrote: From: Søren Sandmann Pedersen s...@redhat.com This new API allows entire glyph strings to be composited in one go which reduces overhead compared to multiple calls to

Re: [Pixman] [PATCH 0/8] Add glyph API

2012-05-30 Thread Behdad Esfahbod
On 05/30/2012 07:41 PM, Søren Sandmann wrote: While this is going on, the cache must be frozen, which basically means that glyphs will not be evicted from it. That way, the application can be sure that all the glyphs are available at compositing time. Afterwards, when the cache is thawed, it

Re: [Pixman] [RFC] dithering 16 bit gradients

2012-07-12 Thread Behdad Esfahbod
On 07/12/2012 07:59 AM, Søren Sandmann wrote: GTK+ solved this by having a user-settable dither offset that would be added to the destination position before accessing the dither matrix. In the cairo xlib backend, I reused the device-offset as the dither offset. behdad

Re: [Pixman] Image resampling [PATCH 0/6]

2012-11-23 Thread Behdad Esfahbod
Hi Søren, This is a very well done patchset with great commentary. Great job! Cheers, behdad On 12-11-23 10:57 PM, Søren Sandmann wrote: Hi, Reviewing the supersampling patch here: http://cgit.freedesktop.org/~ajohnson/pixman/log/?h=supersampling I wasn't happy with either the

Re: [Pixman] [PATCH/RFC 0/4] New option to build pixman as C++ code (--enable-enforced-cplusplus)

2012-12-16 Thread Behdad Esfahbod
On 12-12-16 12:13 AM, Siarhei Siamashka wrote: Any comments or ideas? Hopefully not a C vs. C++ flamewar :) I would go as far as suggesting that C++ becomes a requirement. I did that in HarfBuzz and never looked back. It's possible to use many useful features of the language (templates, etc)

Re: [Pixman] [PATCH 4/4] Various remaining fixes needed for successful compilation with C++

2012-12-17 Thread Behdad Esfahbod
On 12-12-16 05:52 PM, Siarhei Siamashka wrote: -typedef enum -{ +typedef int cpu_features_t; + +enum { X86_MMX = (1 0), X86_MMX_EXTENSIONS = (1 1), X86_SSE = (1 2) | X86_MMX_EXTENSIONS, X86_SSE2 = (1

Re: [Pixman] Proposal for pixman's glyph rendering: alpha correction

2013-03-15 Thread Behdad Esfahbod
On 13-03-13 09:59 AM, Antti Lankila wrote: I have a suggestion for getting sRGB-like text rendering without having sRGB alpha blending primitive. It's based on adjusting the alpha values of the glyph masks based on text foreground color without knowledge of the background color. I generated