Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125135/ --- (Updated Sept. 10, 2015, 10:33 a.m.) Review request for Plasma.

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85091 --- For future references (opening kickoff multiple times

Adding further modules to api.kde.org

2015-09-10 Thread Martin Graesslin
Hi all, back in KDE4 days the workspace libraries were listed on api.kde.org [1]. But for the current version we don't have any API docs available. The section "Other KDE Software" [2] lists KDE Support, KDE Extragear and Playground but apparently nothing from what used to be KDE SC. Does

Review Request 125134: Add a role for screenshots in the widgetexplorer model

2015-09-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

2015-09-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/#review85095 --- +1 to idea in general However I am not so sure about

Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125135/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

2015-09-10 Thread Marco Martin
> On Sept. 10, 2015, 10:39 a.m., Martin Gräßlin wrote: > > I'm questioning the distribution of screenshots. Wouldn't it make more > > sense to generate it at runtime to show how it will look like (theme, > > proper dpi, etc.)? i don't think it's feasible, it would have to load each single

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Eike Hein
> On Sept. 10, 2015, 6:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, lines 433-434 > > > > > > on X11 the time might also come from the property. > > Marco Martin wrote: > for

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread Martin Klapetek
> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

2015-09-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/#review85096 --- I'm questioning the distribution of screenshots. Wouldn't it

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

2015-09-10 Thread Marco Martin
> On Sept. 10, 2015, 10:39 a.m., Bhushan Shah wrote: > > +1 to idea in general > > > > However I am not so sure about providing screenshot in package, given same > > plasmoid might look different in different form factor. What about having > > seperate data dir to provide the screenshots for

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread Martin Gräßlin
> On Sept. 10, 2015, 1:13 p.m., andreas kainz wrote: > > the thing is that it is not easy for the user to add or use an alternative > > plasmoid cause the plasmoids don't have specific application icons. now it > > is a mix between the user application icons, action icons, > > > > the

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread Marco Martin
> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Marco Martin
> On Sept. 10, 2015, 6:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, line 277 > > > > > > this connect is dangerous: it doesn't have a context. It will fire > > after slide is

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Marco Martin
> On Sept. 10, 2015, 6:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, lines 433-434 > > > > > > on X11 the time might also come from the property. for Eike: is the custom animation

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

2015-09-10 Thread kainz.a
Generate the preview would be nice BUT really difficult cause you should look that the plasmoid fits into an square. about kwin screenshots I will have a look at if, if you like because also the KCM HIG is defined like that: Preview where you can add or select and an panel on buttom of the

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Marco Martin
> On Sept. 10, 2015, 6:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, lines 433-434 > > > > > > on X11 the time might also come from the property. > > Marco Martin wrote: > for

[Breeze] [Bug 352506] Breeze High Contrast color scheme has defaults that are bad for people with low contrast sensitivity vision

2015-09-10 Thread Aaron Honeycutt
https://bugs.kde.org/show_bug.cgi?id=352506 Aaron Honeycutt changed: What|Removed |Added CC|

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125135/#review85105 --- First of all, I like the idea. However, I think we should go

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread Martin Gräßlin
> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Marco Martin
> On Sept. 10, 2015, 6:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, line 277 > > > > > > this connect is dangerous: it doesn't have a context. It will fire > > after slide is

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

2015-09-10 Thread Igor Poboiko
https://bugs.kde.org/show_bug.cgi?id=352442 --- Comment #5 from Igor Poboiko --- Okay, seems like it is an upstream (e.g kernel/ACPI) bug: even in "showkey --scancodes" it appears after a delay; and also "cat /sys/class/backlight/intel_backlight/brightness" hangs at the

Review Request 125138: do not crash when context gets defunct & implement respawn

2015-09-10 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125138/ --- Review request for Plasma. Repository: plasma-pa Description ---

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread kainz.a
I can also make it with transparent background. no Problem. we also can say we move the Screenshot into KDE:breeze with the APP Name for the linking so it would be more in or focus to change something. whatever you like. it is an improvement for our users and it is according to our guidelines.

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

2015-09-10 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=352442 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |UPSTREAM

Re: Review Request 125138: do not crash when context gets defunct & implement respawn

2015-09-10 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125138/ --- (Updated Sept. 10, 2015, 12:38 p.m.) Status -- This change has been

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
Martin, I took a look at this as part of the gardening documentation websites, but I didn't get very far. The code that runs this and ebn is in kde:websites/quality-kde-org and is pretty outdated unfortunately. Actually now that Allen Winter is back maybe he could add it (Added him to cc)? What I

Re: Review Request 125138: do not crash when context gets defunct & implement respawn

2015-09-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125138/#review85111 --- Ship it! Ship It! - David Edmundson On Sept. 10, 2015,

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Martin Gräßlin
> On Sept. 10, 2015, 8:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, line 277 > > > > > > this connect is dangerous: it doesn't have a context. It will fire > > after slide is

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

2015-09-10 Thread Martin Gräßlin
> On Sept. 10, 2015, 12:39 p.m., Martin Gräßlin wrote: > > I'm questioning the distribution of screenshots. Wouldn't it make more > > sense to generate it at runtime to show how it will look like (theme, > > proper dpi, etc.)? > > Marco Martin wrote: > i don't think it's feasible, it

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125135/#review85102 --- the thing is that it is not easy for the user to add or use

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Martin Gräßlin
> On Sept. 10, 2015, 8:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, line 277 > > > > > > this connect is dangerous: it doesn't have a context. It will fire > > after slide is

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Thomas Lübking
> On Sept. 10, 2015, 6:33 vorm., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, line 277 > > > > > > this connect is dangerous: it doesn't have a context. It will fire > > after slide is

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-10 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=350676 Weng Xuetian changed: What|Removed |Added CC||wen...@gmail.com --- Comment

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

2015-09-10 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=352442 Weng Xuetian changed: What|Removed |Added CC||wen...@gmail.com --- Comment

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

2015-09-10 Thread Igor Poboiko
https://bugs.kde.org/show_bug.cgi?id=352442 --- Comment #8 from Igor Poboiko --- (In reply to Weng Xuetian from comment #7) > I tired to bind the key with some random key other than brightness up/down. > Probably the brightness is being adjusted by hardware when such key

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-10 Thread kainz.a
and when the Screenshot was only shown when the Screenshot is e.g. 6 month old. Am 10.09.2015 15:36 schrieb "Martin Klapetek" : > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125135/ > > On September 10th, 2015, 1:43

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
Well, it's not even just about workspace, we had in kde4 times kdeedu, kdegames, etc. etc. all on api.kde.org. Not all of it was api per se (I don't know anyone that would want to read the apidocs for kanagram for example, except to know how it's internals work or used to work when hacking on it).

Re: Review Request 125118: [Icon widget] support dropping onto folder

2015-09-10 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125118/#review85129 --- Looks good to me, +1 - Emmanuel Pescosta On Sept. 9, 2015,

Re: Review Request 125118: [Icon widget] support dropping onto folder

2015-09-10 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125118/#review85130 --- applets/icon/plugin/icon_p.cpp (line 114)

Re: Adding further modules to api.kde.org

2015-09-10 Thread Allen Winter
On Thursday, September 10, 2015 01:55:21 PM Jeremy Whiting wrote: > Allen, > > Those are both KDE4 versions of workspace stuff. I don't see any place > where kf5 versions are. > oh. sorry I misunderstood the problem. > > On Thu, Sep 10, 2015 at 1:50 PM, Allen Winter wrote: >

Re: Adding further modules to api.kde.org

2015-09-10 Thread Allen Winter
On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote: > Hi all, > > back in KDE4 days the workspace libraries were listed on api.kde.org [1]. But > for the current version we don't have any API docs available. The section > "Other KDE Software" [2] lists KDE Support, KDE Extragear

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
Allen, Those are both KDE4 versions of workspace stuff. I don't see any place where kf5 versions are. BR, Jeremy On Thu, Sep 10, 2015 at 1:50 PM, Allen Winter wrote: > On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote: >> Hi all, >> >> back in KDE4 days the

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

2015-09-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/#review85080 --- components/sessionsprivate/sessionsmodel.cpp (line 30)

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85082 --- I just pulled in the patch, but didn't hit the assert -

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85083 --- What I miss in general is support for removing the "property"