Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122522/ --- (Updated Sept. 29, 2015, 9:35 a.m.) Status -- This change has been

Review Request 125445: [libtaskmanager] Protect against X11 usage on Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125445/ --- Review request for Plasma and Eike Hein. Repository: plasma-workspace

Re: Review Request 125234: [wayland] Add key repeat information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125234/ --- (Updated Sept. 29, 2015, 7:32 a.m.) Status -- This change has been

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 29, 2015, 3:01 p.m.) Review request for Plasma and Eike

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On 9月 29, 2015, 1:43 a.m., Eike Hein wrote: > > Good idea, but can you make it so that the tooltip is only shown when the > > text is elided? :) Thank you for your review and comment. Yes that's nice enhancement:) I'd like to update patch. As the contentWidth of elided text object is

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/ --- (Updated Sept. 29, 2015, 9:37 a.m.) Status -- This change has been

Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125443/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 125445: [libtaskmanager] Protect against X11 usage on Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125445/#review86109 --- Ship it! Ship It! - Eike Hein On Sept. 29, 2015, 8:39

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 205 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/205/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Sep 2015 13:04:24 + Build duration: 6 min 20 sec CHANGE SET Revision

Re: Review Request 125437: Made new applet icons for all applets

On Tue, 29 Sep 2015 15:26:04 +0200 "kainz.a" wrote: > 2015-09-28 23:24 GMT+02:00 Sebastian Kügler : > > > On Monday, September 28, 2015 20:33:33 Marco Martin wrote: > > > On Monday 28 September 2015, andreas kainz wrote: > > > > > On Sept. 28, 2015, 2:29 p.m.,

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On 9月 29, 2015, 1:43 a.m., Eike Hein wrote: > > Good idea, but can you make it so that the tooltip is only shown when the > > text is elided? :) > > Takahiro Hashimoto wrote: > Thank you for your review and comment. Yes that's nice enhancement:) I'd > like to update patch. > >

Re: Review Request 125437: Made new applet icons for all applets

2015-09-28 23:24 GMT+02:00 Sebastian Kügler : > On Monday, September 28, 2015 20:33:33 Marco Martin wrote: > > On Monday 28 September 2015, andreas kainz wrote: > > > > On Sept. 28, 2015, 2:29 p.m., Eike Hein wrote: > > > > > applets/showActivityManager/package/metadata.desktop,

Re: Review Request 125437: Made new applet icons for all applets

2015-09-29 15:38 GMT+02:00 Sebastian Kügler : > On Tue, 29 Sep 2015 15:26:04 +0200 > "kainz.a" wrote: > > > 2015-09-28 23:24 GMT+02:00 Sebastian Kügler : > > > > > On Monday, September 28, 2015 20:33:33 Marco Martin wrote: > > > > On Monday 28

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/#review86108 --- applets/kicker/package/contents/ui/ItemGridDelegate.qml

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On 9月 29, 2015, 10:12 p.m., Eike Hein wrote: > > applets/kicker/package/contents/ui/ItemGridDelegate.qml, line 139 > > > > > > It's better to use TextMetrics :) Wow nice! Thank you! - Takahiro

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 29, 2015, 10:55 p.m.) Review request for Plasma and Eike

Discontinuing plasmate/1.0

Hi, There have been no code changes in the plasma-sdk.git[plasmate/1.0] branch since early 2013, but translators still see .pot templates extracted from this branch. If you confirm plasmate/1.0 is now "done", please remove it from i18n branches configuration at projects.kde.org and let i18n

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 193 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Sep 2015 09:12:18 + Build duration: 6 min 15 sec CHANGE SET Revision

Re: Review Request 122528: [screenlocker] Grab XServer while establishing the grab

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122528/ --- (Updated Sept. 29, 2015, 8:43 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 192 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Sep 2015 08:43:48 + Build duration: 6 min 9 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 193 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Sep 2015 09:12:18 + Build duration: 6 min 15 sec CHANGE SET Revision

Re: Review Request 125445: [libtaskmanager] Protect against X11 usage on Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125445/ --- (Updated Sept. 29, 2015, 2:24 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 206 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Sep 2015 14:35:25 + Build duration: 7 min 6 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125443/ --- (Updated 9月 29, 2015, 11:24 p.m.) Review request for Plasma. Changes

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 206 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Sep 2015 14:35:25 + Build duration: 7 min 6 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125395/ --- (Updated Sept. 29, 2015, 3:48 p.m.) Review request for Plasma, Daniel

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 30, 2015, 9:33 a.m.) Review request for Plasma and Eike

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/#review86137 --- Ship it! Ship It! - Eike Hein On Sept. 30, 2015, 12:33

Re: Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thread

> On Sept. 29, 2015, 5:15 p.m., Daniel Nicoletti wrote: > > Why is it better? I found the first less intrusive, simpler and likely > > faster The first one wouldn't be faster. We had the queued connection on start() on the timer anyway whereas with patch 2 it's a direct call. So that's the

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/#review86130 --- There are some problems left I think: a) I think the

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On Sept. 29, 2015, 10:32 nachm., Eike Hein wrote: > > There are some problems left I think: > > > > a) I think the delegate should be 'toolTipDelegate' (from main.qml) as used > > by MenuRepresentation's SideBarItem.qml. > > > > b) TextMetrics needs to have a font set - should be

Re: Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125443/#review86133 --- src/declarativeimports/core/tooltip.cpp (line 339)

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 30, 2015, 9:31 a.m.) Review request for Plasma and Eike

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On Sept. 29, 2015, 10:32 nachm., Eike Hein wrote: > > There are some problems left I think: > > > > a) I think the delegate should be 'toolTipDelegate' (from main.qml) as used > > by MenuRepresentation's SideBarItem.qml. > > > > b) TextMetrics needs to have a font set - should be

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On 9月 30, 2015, 7:32 a.m., Eike Hein wrote: > > There are some problems left I think: > > > > a) I think the delegate should be 'toolTipDelegate' (from main.qml) as used > > by MenuRepresentation's SideBarItem.qml. > > > > b) TextMetrics needs to have a font set - should be

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On Sept. 29, 2015, 10:32 p.m., Eike Hein wrote: > > There are some problems left I think: > > > > a) I think the delegate should be 'toolTipDelegate' (from main.qml) as used > > by MenuRepresentation's SideBarItem.qml. > > > > b) TextMetrics needs to have a font set - should be

Re: Review Request 125453: introduce SkipsTaskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125453/#review86141 --- general note: in KWin it's called "skipTaskbar" also in the

Re: Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea

> On 9月 30, 2015, 9:22 a.m., David Edmundson wrote: > > src/declarativeimports/core/tooltip.cpp, line 339 > > > > > > I don't think you need the dismiss, It seems we can just wrap this > > keepAlive line in an

Re: Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125443/ --- (Updated 9月 30, 2015, 10:43 a.m.) Review request for Plasma. Changes

Re: Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125443/ --- (Updated 9月 30, 2015, 10:48 a.m.) Review request for Plasma. Changes

Re: Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125395/#review86139 --- Ship it! Oh I missed the queued call to timer->start(), so

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 30, 2015, 10:53 a.m.) Review request for Plasma and Eike

[plasma-workspace] shell: Delay desktop view geometry update

Git commit 35003951e4b6d18b3761ee266255526f0370f2f8 by Aleix Pol. Committed on 29/09/2015 at 17:21. Pushed by apol into branch 'master'. Delay desktop view geometry update Otherwise it enters an infinite loop where the DesktopView starts to be moved from a screen to another. That happens on XCB

Review Request 125453: introduce SkipsTaskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125453/ --- Review request for kwin and Plasma. Repository: kwayland Description

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125416/#review86121 --- Ship it! Ship It! - Raphael Kugelmann On Sept. 26, 2015,

Review Request 125454: supports kwayland skipsTaskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125454/ --- Review request for kwin and Plasma. Repository: kwin Description

Re: Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125395/#review86120 --- Why is it better? I found the first less intrusive, simpler

Re: Review Request 125023: Fix initialization of the DesktopView on Qt 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125023/ --- (Updated Sept. 29, 2015, 7:29 p.m.) Status -- This change has been

Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

> On Sept. 28, 2015, 8:37 vorm., Marco Martin wrote: > > Ship It! Hi, I have no commit rights. please commit it. Thanks! - Raphael --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125437: Made new applet icons for all applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125437/ --- (Updated Sept. 29, 2015, 6:48 p.m.) Status -- This change has been

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review86123 --- very happy about this \o/ I'll test on this system once i'll

Re: Review Request 125438: Made new applet icons for all workspace applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125438/ --- (Updated Sept. 29, 2015, 7:43 p.m.) Status -- This change has been