Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87113 --- src/declarativeimports/calendar/calendar.cpp (line 195)

RFC: activity pager in kdeplasma-addons

2015-10-20 Thread Marco Martin
always on the infamous bug: https://bugs.kde.org/show_bug.cgi?id=341143 some time ago for myself i made a little applet, pretty much a fork of the pager (that's how i see and use activities, I know is different from others but whatever, that's why i kept this mostly for myself)

Re: RFC: activity pager in kdeplasma-addons

2015-10-20 Thread Ivan Čukić
> how would you feel this applet to be added to kdeplasma-addons? Not a fan of the spacial activities idea, but I do get that some people like it. I say go for it. Cheerio, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76 ___

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/ --- (Updated Oct. 20, 2015, 9:11 a.m.) Review request for Plasma.

Re: RFC: activity pager in kdeplasma-addons

2015-10-20 Thread Marco Martin
On Tuesday 20 October 2015, Ivan Čukić wrote: > > how would you feel this applet to be added to kdeplasma-addons? > > Not a fan of the spacial activities idea, but I do get that some people > like it. > > I say go for it. one thing I think is quite important for me that you greenflag it, is: do

Review Request 125720: set default theme to breeze rather than oxygen

2015-10-20 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/ --- Review request for KDE Frameworks, Plasma and Christoph Feck. Bugs:

Re: RFC: activity pager in kdeplasma-addons

2015-10-20 Thread Ivan Čukić
I don't see how it could turn out to be a problem. While the default switcher (and all around it) is going to be more focused on the workflow that we (with VDG) have chosen, I am not against people using activities in their own way. The only problematic part I see is that it communicates that

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/ --- (Updated Oct. 20, 2015, 9:49 a.m.) Status -- This change has been

Re: Review Request 125720: set default theme to breeze rather than oxygen

2015-10-20 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/#review87155 --- Ship it! src/kicontheme.cpp (line 545)

Re: Review Request 125709: Ensure correct timezone is displayed when the selected ones change

2015-10-20 Thread Martin Klapetek
> On Oct. 19, 2015, 8:02 p.m., David Edmundson wrote: > > can it be merged with the code in main.qml which is already binding the > > connectedSources to plasmoid.configuration.selectedTimeZones ? > > > > (this is the bit I meant last comment, I just got confused and pointed at > > the wrong

Re: Review Request 125709: Ensure correct timezone is displayed when the selected ones change

2015-10-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125709/ --- (Updated Oct. 20, 2015, 8:58 p.m.) Review request for Plasma. Bugs:

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/ --- (Updated Oct. 20, 2015, 9:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Martin Klapetek
> On Oct. 20, 2015, 9:12 a.m., Xuetian Weng wrote: > > src/declarativeimports/calendar/calendar.cpp, line 195 > > > > > > This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe > > even LANGUAGE

Re: Review Request 125719: make pre-specified view size precede initial object size in QuickViewSharedEngine

2015-10-20 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125719/ --- (Updated 10月 21, 2015, 12:50 a.m.) Review request for Plasma. Changes

Re: Review Request 125719: make pre-specified view size precede initial object size in QuickViewSharedEngine

2015-10-20 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125719/ --- (Updated 10月 21, 2015, 1:14 a.m.) Review request for Plasma.

Review Request 125719: make pre-specified view size precede initial object size in QuickViewSharedEngine

2015-10-20 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125719/ --- Review request for Plasma. Summary (updated) - make

Review Request 125727: [ksplash] refrect windowState correctly

2015-10-20 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125727/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125719: make pre-specified view size precede initial object size in QuickViewSharedEngine

2015-10-20 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125719/ --- (Updated 10月 21, 2015, 1:07 a.m.) Review request for Plasma. Changes

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87164 --- src/declarativeimports/calendar/calendar.cpp (line 197)

RE: RFC: activity pager in kdeplasma-addons

2015-10-20 Thread Tim Climis
> The only problematic part I see is that it communicates that activities are > about windows which we > are trying to avoid. > It would be nice if it: > - showed the activity icons on the pages > - had activity configuration (kcmshell5 activities) in the context menu > instead of add/remove >

Re: RFC: Put notifications in sidepanel like widget explorer

2015-10-20 Thread Marco Martin
On Tuesday 20 October 2015, Martin Klapetek wrote: > Basically the idea is to reinvent the notifications in Plasma a bit > and create a kind of notification center. > > My plan would be to get a VDG design and then work on it for > Plasma 5.6. > > Thoughts? I'm not sure, iirc at a sprint

RFC: Put notifications in sidepanel like widget explorer

2015-10-20 Thread Martin Klapetek
Hey, today I was thinking a bit about our notification system. I believe that the constraints the tiny popup give us are just too limiting. Currently it fits about two notifications and for everything else one has to scroll, plus the space is really cramped for anything else besides the

Re: RFC: Put notifications in sidepanel like widget explorer

2015-10-20 Thread kainz.a
2015-10-20 22:16 GMT+02:00 Marco Martin : > On Tuesday 20 October 2015, Martin Klapetek wrote: >> Basically the idea is to reinvent the notifications in Plasma a bit >> and create a kind of notification center. >> >> My plan would be to get a VDG design and then work on it for

Re: RFC: Put notifications in sidepanel like widget explorer

2015-10-20 Thread Martin Klapetek
On Tue, Oct 20, 2015 at 4:16 PM, Marco Martin wrote: > On Tuesday 20 October 2015, Martin Klapetek wrote: > > Basically the idea is to reinvent the notifications in Plasma a bit > > and create a kind of notification center. > > > > My plan would be to get a VDG design and then

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Xuetian Weng
> On Oct. 20, 2015, 9:30 p.m., Albert Astals Cid wrote: > > src/declarativeimports/calendar/calendar.cpp, line 197 > > > > > > uilanguages is not good for direct inputing into QLocale (yes i know, > > it's

Re: Review Request 125700: Drop remaning code for ShowDashboard

2015-10-20 Thread Thomas Lübking
> On Okt. 19, 2015, 1:41 nachm., Martin Gräßlin wrote: > > This also needs a kconf update, but I fear my scripting capabilities are > > not sufficient for that. It should be doable with a simple sed call, though. > > Thomas Lübking wrote: > Humm? Looks like it's resolved to "None", what's

Re: Review Request 125706: Install kconf_update script in kdelibs4 directory

2015-10-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125706/#review87131 --- Ship it! Ship It! - Sebastian Kügler On Oct. 19, 2015,

Re: Plasma mobile and Fairphone

2015-10-20 Thread Sebastian Kügler
On Thursday, October 15, 2015 02:34:34 PM Martin Steigerwald wrote: > Am Sonntag, 26. Juli 2015, 20:08:04 CEST schrieb Sebastian Kügler: > > > We were in contact with Fairphone last year about participating in the > > > Randa Meetings which in the end didn't happen because of too many > > >

Re: Review Request 125720: set default theme to breeze rather than oxygen

2015-10-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/#review87132 --- +1 - Martin Klapetek On Oct. 20, 2015, 11:52 a.m., Harald