Re: Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125734/ --- (Updated Oct. 21, 2015, 2:54 p.m.) Status -- This change has been

Re: Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125734/#review87201 --- Ship it! Ship It! - David Edmundson On Oct. 21, 2015,

Re: RFC: Put notifications in sidepanel like widget explorer

On Thursday, October 22, 2015, Martin Klapetek wrote: > But I don't want a hidden panel. I want this to be a core part of the > shell, basically. In the end it would kinda be, but while sharing most of the code with an hidden panel, would behave in its own way. However

Re: RFC: Put notifications in sidepanel like widget explorer

On Tue, Oct 20, 2015 at 4:34 PM, kainz.a wrote: > 2015-10-20 22:16 GMT+02:00 Marco Martin : > > On Tuesday 20 October 2015, Martin Klapetek wrote: > >> Basically the idea is to reinvent the notifications in Plasma a bit > >> and create a kind of notification

Re: Review Request 125706: Install kconf_update script in kdelibs4 directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125706/ --- (Updated Oct. 21, 2015, 4 p.m.) Status -- This change has been

Re: Review Request 125702: switch to noto sans

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125702/ --- (Updated Oct. 21, 2015, 4:01 p.m.) Status -- This change has been

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 8:24 p.m., Martin Gräßlin wrote: > > did you try whether the proxy works without compositing? I just hit the > > "suspend compositing" global shortcut to test something and it gave me bad > > rendering results in the davetray area. > > David Edmundson wrote: > I have.

Re: Review Request 125739: Don't connect to signals which don't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125739/#review87219 --- Ship it! Ship It! - Martin Klapetek On Oct. 21, 2015,

Re: Review Request 125555: Port KAuth return code error checking in fontinst

> On Oct. 19, 2015, 10:40 a.m., Martin Gräßlin wrote: > > kcms/kfontinst/dbus/FontInst.cpp, line 957 > > > > > > that's an async call, isn't it? So somehow I doubt it will work that > > way. > > David

Re: Review Request 125699: switch to Noto font and dejavu sans font

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125699/ --- (Updated Oct. 21, 2015, 3:57 p.m.) Status -- This change has been

Re: RFC: Put notifications in sidepanel like widget explorer

You're talking something similar as Windows 10 ? http://images.digitalcitizen.life/sites/digitalcitizen.life/files/img/win10_notifications/notification5.png I can tell i liked in some way what they did On Wed, Oct 21, 2015 at 3:01 PM, Martin Klapetek wrote: > On

Review Request 125739: Don't connect to signals which don't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125739/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125709: Ensure correct timezone is displayed when the selected ones change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125709/ --- (Updated Oct. 21, 2015, 6:26 p.m.) Status -- This change has been

Re: Review Request 125739: Don't connect to signals which don't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125739/ --- (Updated Oct. 21, 2015, 5:11 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 36 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Oct 2015 18:26:21 + Build duration: 18 min CHANGE SET Revision

Review Request 125743: Keep aspect ratio in default KSplash background

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125743/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: RFC: Put notifications in sidepanel like widget explorer

On Wed, Oct 21, 2015 at 1:04 PM, Helio Chissini de Castro wrote: > You're talking something similar as Windows 10 ? > > > http://images.digitalcitizen.life/sites/digitalcitizen.life/files/img/win10_notifications/notification5.png > > I can tell i liked in some way what they did >

Re: Review Request 125743: Keep aspect ratio in default KSplash background

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125743/ --- (Updated Oct. 21, 2015, 8:51 p.m.) Review request for Plasma.

Re: RFC: Put notifications in sidepanel like widget explorer

On Tuesday, October 20, 2015, Martin Klapetek wrote: > On Tue, Oct 20, 2015 at 4:16 PM, Marco Martin wrote: >> >> On Tuesday 20 October 2015, Martin Klapetek wrote: >> > Basically the idea is to reinvent the notifications in Plasma a bit >> > and

Re: RFC: Put notifications in sidepanel like widget explorer

On Wed, Oct 21, 2015 at 3:46 PM, Marco Martin wrote: > > > For now, just notifications. Opening it for other applets would make it > /the/ > > new system tray I fear. Although, > > Yeah, that was the idea. I would prefer this type of visualization > depending from a

Review Request 125745: Energy module: Limit org.freedesktop.UPower.Wakeups.GetData calls to one per second

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125745/ --- Review request for KInfoCenter and Plasma. Repository: kinfocenter

Re: Review Request 125743: Keep aspect ratio in default KSplash background

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125743/#review87228 --- Ship it! Makes sense for the default behaviours to match -

Re: Review Request 125744: Fix connecting to QAction::triggered signal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125744/#review87225 --- Ship it! Maybe port to new syntax so we catch this in

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/sniproxy.cpp, lines 180-183 > > > > > > maybe you could use the sync protocol? xsync would make sense, except there doesn't seem to be

Re: Review Request 125745: Energy module: Limit org.freedesktop.UPower.Wakeups.GetData calls to one per second

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125745/#review87227 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 21, 2015,

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Oct. 21, 2015, 9:01 p.m.) Review request for Plasma.

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Oct. 21, 2015, 9 p.m.) Review request for Plasma. Changes

Re: RFC: Put notifications in sidepanel like widget explorer

The thing I say hidden panel was that first we have widgets and panels and in an widget you can only have one item in an panel you can move different widgets and in my mind the user can say I want to see the notifications, the weather and some configuration in this "sidepanel" maybe you all know

Re: Review Request 125744: Fix connecting to QAction::triggered signal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125744/ --- (Updated Oct. 21, 2015, 8:41 p.m.) Review request for KInfoCenter and

Re: Review Request 125745: Energy module: Limit org.freedesktop.UPower.Wakeups.GetData calls to one per second

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125745/#review87226 --- Ship it! Ship It! - David Edmundson On Oct. 21, 2015,

Re: Review Request 125719: make pre-specified view size precede initial object size in QuickViewSharedEngine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125719/#review87229 --- Ship it! Ship It! - David Edmundson On Oct. 20, 2015,

Re: Review Request 125727: [ksplash] refrect windowState correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125727/#review87230 --- Ship it! Ship It! - David Edmundson On Oct. 20, 2015,

Re: Review Request 125719: make pre-specified view size precede initial object size in QuickViewSharedEngine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125719/ --- (Updated Oct. 21, 2015, 10:48 p.m.) Status -- This change has been

Re: RFC: Put notifications in sidepanel like widget explorer

On Wed, Oct 21, 2015 at 5:22 PM, kainz.a wrote: > The thing I say hidden panel was that first we have widgets and panels > and in an widget you can only have one item in an panel you can move > different widgets and in my mind the user can say I want to see the >

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125416/#review87231 --- Raphael, does the crash still happen with Plasma 5.4.2? There

Re: RFC: Put notifications in sidepanel like widget explorer

Actually for win 10... just think about if our systray popup takes full height of the screen.. and you'll find that we already get something quite similar. On Wed, Oct 21, 2015 at 10:10 AM, Martin Klapetek wrote: > On Wed, Oct 21, 2015 at 1:04 PM, Helio Chissini de

Re: Review Request 125719: make pre-specified view size precede initial object size in QuickViewSharedEngine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125719/#review87235 --- I'm madly sorry for taking mistake. I've found a critical

Re: Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125734/#review87183 --- Thanks Martin for the investigation! The crash is not

Re: Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

> On Oct. 21, 2015, 11:19 a.m., Christoph Feck wrote: > > Thanks Martin for the investigation! > > > > The crash is not specific to the kscreen kcm, but we also got it with other > > kcms that use QML, so the same (or a similiar) fix has to be applied there, > > too. all right, do you know

Re: Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

> On Oct. 21, 2015, 11:19 a.m., Christoph Feck wrote: > > Thanks Martin for the investigation! > > > > The crash is not specific to the kscreen kcm, but we also got it with other > > kcms that use QML, so the same (or a similiar) fix has to be applied there, > > too. > > Martin Gräßlin

Re: Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

> On Oct. 21, 2015, 9:19 a.m., Christoph Feck wrote: > > Thanks Martin for the investigation! > > > > The crash is not specific to the kscreen kcm, but we also got it with other > > kcms that use QML, so the same (or a similiar) fix has to be applied there, > > too. > > Martin Gräßlin wrote:

Re: Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

> On Oct. 21, 2015, 11:19 a.m., Christoph Feck wrote: > > Thanks Martin for the investigation! > > > > The crash is not specific to the kscreen kcm, but we also got it with other > > kcms that use QML, so the same (or a similiar) fix has to be applied there, > > too. > > Martin Gräßlin

Re: Review Request 125700: Drop remaning code for ShowDashboard

> On Oct. 19, 2015, 3:41 p.m., Martin Gräßlin wrote: > > This also needs a kconf update, but I fear my scripting capabilities are > > not sufficient for that. It should be doable with a simple sed call, though. > > Thomas Lübking wrote: > Humm? Looks like it's resolved to "None", what's

Re: Review Request 125720: set default theme to breeze rather than oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/ --- (Updated Oct. 21, 2015, 6:07 a.m.) Status -- This change has been

Re: Review Request 125700: Drop remaning code for ShowDashboard

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125700/ --- (Updated Oct. 21, 2015, 6:15 a.m.) Status -- This change has been

Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125734/ --- Review request for Plasma, Kai Uwe Broulik and Daniel Vrátil. Bugs:

Re: Review Request 125700: Drop remaning code for ShowDashboard

> On Okt. 19, 2015, 1:41 nachm., Martin Gräßlin wrote: > > This also needs a kconf update, but I fear my scripting capabilities are > > not sufficient for that. It should be doable with a simple sed call, though. > > Thomas Lübking wrote: > Humm? Looks like it's resolved to "None", what's