[Differential] [Accepted] D956: Pass a parent QObject to the AbstractLocker and it's subclasses

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH abstract-locker-parent REVISION DETAIL https://phabricator.kde.org/D956 EMAIL PREFERENCES

[Differential] [Request, 25 lines] D956: Pass a parent QObject to the AbstractLocker and it's subclasses

graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH abstract-locker-parent REVISION DETAIL https://phabricator.kde.org/D956 AFFECTED FILES

[Differential] [Accepted] D955: Remove KCrash from KSldApp

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH no-kcrash REVISION DETAIL https://phabricator.kde.org/D955 EMAIL PREFERENCES

[Differential] [Request, 3 lines] D955: Remove KCrash from KSldApp

graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY We need the applications linking KSldApp to integrate with KCrash, not the library itself. E.g. kwin_wayland doesn't want KCrash to

Re: Review Request 127091: Fix IconItem regression in 5.19

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127091/ --- (Updated Feb. 16, 2016, 3:16 p.m.) Status -- This change has been

Re: Review Request 127091: Fix IconItem regression in 5.19

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127091/#review92470 --- Is this testable at all? - Albert Astals Cid On Feb. 16,

Re: KActivities repository split

El Tuesday 16 February 2016, a les 13:31:40, Ivan Čukić va escriure: > Hi everyone, > > As previously announced, KActivities has been split into a few > separate repositories. This mail is mostly intended to notify our dear > packagers of the change, and the plan for the transition period. > >

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 5:05 p.m., Kai Uwe Broulik wrote: > > File Attachment: color4.png - color4.png > > > > > > This is hard to read, perhaps the background contrast effect is still > > using light color? > > Marco Martin wrote: >

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 5:05 p.m., Kai Uwe Broulik wrote: > > File Attachment: color4.png - color4.png > > > > > > This is hard to read, perhaps the background contrast effect is still > > using light color? > > Marco Martin wrote: >

Re: Review Request 127091: Fix IconItem regression in 5.19

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127091/#review92467 --- Ship it! Ship It! - Milian Wolff On Feb. 16, 2016,

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 5:05 nachm., Kai Uwe Broulik wrote: > > File Attachment: color4.png - color4.png > > > > > > This is hard to read, perhaps the background contrast effect is still > > using light color? > > Marco Martin wrote: >

[Differential] [Updated, 51 lines] D948: Don't show applet handle outside of desktop

drosca updated this revision to Diff 2326. drosca added a comment. Fix top/bottom offsets REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D948?vs=2311=2326 BRANCH handle-position (branched from master) REVISION DETAIL

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 5:05 p.m., Kai Uwe Broulik wrote: > > File Attachment: color4.png - color4.png > > > > > > This is hard to read, perhaps the background contrast effect is still > > using light color? > > Marco Martin wrote: >

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 p.m., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 5:05 p.m., Kai Uwe Broulik wrote: > > File Attachment: color4.png - color4.png > > > > > > This is hard to read, perhaps the background contrast effect is still > > using light color? yeah, it's not adjusting

Re: Review Request 127085: Make the desfault theme follow system colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/#review92462 --- Nice! File Attachment: color1.png - color1.png

Re: Review Request 127091: Fix IconItem regression in 5.19

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127091/#review92461 --- src/declarativeimports/core/iconitem.cpp (line 151)

Review Request 127091: Fix IconItem regression in 5.19

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127091/ --- Review request for KDE Frameworks, Plasma and David Edmundson. Bugs:

Re: Review Request 127085: Make the desfault theme follow system colors

thanks marco Am 16.02.2016 17:34 schrieb "Marco Martin" : > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127085/ > > On February 16th, 2016, 12:36 p.m. UTC, *Andreas Kainz* wrote: > > before I give you an ship It go the the

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:36 p.m., Andreas Kainz wrote: > > before I give you an ship It go the the breeze icons and check if the > > stylesheed stuff work there and where not, please fix it. I will talk to > > you at CERN that I can make it myself in the future. > > Marco Martin wrote: >

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:36 p.m., Andreas Kainz wrote: > > before I give you an ship It go the the breeze icons and check if the > > stylesheed stuff work there and where not, please fix it. I will talk to > > you at CERN that I can make it myself in the future. that's why I added an option for

Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 68 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 16 Feb 2016 13:12:31 + Build duration: 1 min 52 sec CHANGE SET Revision

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 16, 2016, 3:48 p.m.) Review request for kwin and Plasma.

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92455 ---

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92457 ---

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 16, 2016, 3:40 p.m., Martin Gräßlin wrote: > > effects/morphingpopups/package/metadata.desktop, line 5 > > > > > > popups? Rather tooltips? > > Marco Martin wrote: > tooltips and notifications yeah

[Differential] [Closed] D950: Fix size of drop placeholder after moving larger applet

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPf1ce45570e9f: Fix size of drop placeholder after moving larger applet (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D940: Fix positioning applets in free space on desktop

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3373696fe4ca: Fix positioning applets in free space on desktop (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 16, 2016, 2:40 p.m., Martin Gräßlin wrote: > > effects/morphingpopups/package/metadata.desktop, line 5 > > > > > > popups? Rather tooltips? tooltips and notifications - Marco

Re: Review Request 127088: Let KDocTools stay optional on KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127088/ --- (Updated Feb. 16, 2016, 3:19 p.m.) Status -- This change has been

Re: Review Request 127088: Let KDocTools stay optional on KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127088/#review92448 --- Ship it! Ship It! - Marco Martin On Feb. 16, 2016,

Review Request 127088: Let KDocTools stay optional on KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127088/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: KActivities repository split

Ivan Čukić ha scritto: > Hi everyone, > > As previously announced, KActivities has been split into a few > separate repositories. This mail is mostly intended to notify our dear > packagers of the change, and the plan for the transition period. > > KActivities framework 5.19 (as released a few

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 p.m., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/#review92441 --- before I give you an ship It go the the breeze icons and

KActivities repository split

Hi everyone, As previously announced, KActivities has been split into a few separate repositories. This mail is mostly intended to notify our dear packagers of the change, and the plan for the transition period. KActivities framework 5.19 (as released a few days ago) contains everything that it

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 nachm., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/ --- (Updated Feb. 16, 2016, 12:28 p.m.) Review request for Plasma and Jens

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 p.m., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 nachm., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 p.m., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 nachm., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 p.m., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 nachm., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they

Re: Review Request 127085: Make the desfault theme follow system colors

> On Feb. 16, 2016, 12:09 p.m., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? hmm no, I wanted to have existing users to the new one, if they don't have weird color schemes

Re: Review Request 127085: Make the desfault theme follow system colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/#review92431 --- Breeze theme version needs bumping as you need the cache to

Re: Disk Quota Applet: Icon sizes

can you send an screenshot cause I did the widget exporer icons too (breeze and oxygen) and therefore it would be good to know how it look like. cheers, Andreas ___ Plasma-devel mailing list Plasma-devel@kde.org

[Differential] [Accepted] D950: Fix size of drop placeholder after moving larger applet

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH placeholder-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D950 EMAIL PREFERENCES

Re: Review Request 127086: Raise the required CMake version to 3.4.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127086/ --- (Updated Feb. 16, 2016, 11:13 a.m.) Review request for Plasma.

[Differential] [Closed] D951: PanelShadow: Don't remove shadows from destroyed windows

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE88b668f8108a: PanelShadow: Don't remove shadows from destroyed windows (authored by drosca). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Review Request 127086: Raise the required CMake version to 3.4.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127086/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Disk Quota Applet: Icon sizes

Hi Andreas, On Mon, Feb 15, 2016 at 11:55 PM, kainz.a wrote: > Hi Dominik, > > I saw that disk quotas icons are really strange. As I first have really big > problems to get disk quota running (it's available in the widget explorer, > but the dependences want be installed in

Review Request 127085: Make the desfault theme follow system colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/ --- Review request for Plasma and Jens Reuterberg. Repository:

[Differential] [Accepted] D951: PanelShadow: Don't remove shadows from destroyed windows

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH panel-crash REVISION DETAIL https://phabricator.kde.org/D951 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 8 lines] D951: PanelShadow: Don't remove shadows from destroyed windows

drosca updated this revision to Diff 2318. drosca added a comment. Remove shadows on SurfaceAboutToBeDestroyed REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D951?vs=2313=2318 BRANCH panel-crash REVISION DETAIL

[Differential] [Commented On] D951: PanelShadow: Don't remove shadows from destroyed windows

graesslin added a comment. In https://phabricator.kde.org/D951#18409, @drosca wrote: > That could work too, but is it really needed to remove shadow (one property) from the window that is going to be destroyed right after? yes as otherwise on X11 we are leaking pixmaps and on

[Differential] [Commented On] D951: PanelShadow: Don't remove shadows from destroyed windows

drosca added inline comments. INLINE COMMENTS shell/panelshadows.cpp:630 QWindow derives from QSurface, so dynamic_cast would not make a difference here? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D951 EMAIL PREFERENCES

[Differential] [Commented On] D951: PanelShadow: Don't remove shadows from destroyed windows

drosca added a comment. That could work too, but is it really needed to remove shadow (one property) from the window that is going to be destroyed right after? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D951 EMAIL PREFERENCES