[Differential] [Commented On] D986: Revamp of the activity switcher backend

davidedmundson added inline comments. INLINE COMMENTS imports/activitymanager/sortedactivitiesmodel.cpp:228 We should cache the config as a member var and only reparse when in ::currentActivity changes. Otherwise you're parsing an entire config file (in fact 3, see last comment) lots of

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 12:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

[Differential] [Updated] D986: Revamp of the activity switcher backend

ivan marked 2 inline comments as done. INLINE COMMENTS imports/activitymanager/backport/model_updaters.h:3 It is a really old file from KActivities. I didn't want to change the year just because it was copied here. imports/activitymanager/backport/switcheractivitiesmodel.cpp:281 .contains

[Differential] [Updated] D987: KSplash looking consistent to sddm and lockscreen

andreaska added a comment. the height of the rectangular elements are different in height between SDDM and KSpalsh. Can I make an mockup for sddm, ksplash, user switch with incrementel changes which could come to plasma 5.6. If not I would suggest leave it as it is and we do something

[Differential] [Request, 13 lines] D989: Don't update size when minimum size changes while animation is running

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Changing the width/height while animation on width/height is running will cancel it. This fixes bug with applet being moved on top of

[Differential] [Updated, 108 lines] D987: KSplash looking consistent to sddm and lockscreen

mart updated this revision to Diff 2394. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D987?vs=2392=2394 REVISION DETAIL https://phabricator.kde.org/D987 AFFECTED FILES lookandfeel/contents/splash/Splash.qml EMAIL PREFERENCES

Re: plasma grub theme unified design

nice can we use the plasma blue gradient background in ksplash and sddm. sliding from right to center in sddm and left to center in ksplash. thanks marco Am 18.02.2016 20:29 schrieb "Marco Martin" : > On Thursday 18 February 2016 20:19:22 you wrote: > > On Thursday 18

[Differential] [Updated] D987: KSplash looking consistent to sddm and lockscreen

broulik added a comment. I use QT_DEVICE_PIXEL_RATIO=2 so for me it is larger than SDDM which doesn't do this. I like it, though. INLINE COMMENTS lookandfeel/contents/splash/Splash.qml:87 You don't import PlasmaCore REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

Re: plasma grub theme unified design

On Thursday 18 February 2016 20:19:22 you wrote: > On Thursday 18 February 2016 14:53:48 kainz.a wrote: > > Plasma 5.4 SDDM theme > > http://i1-news.softpedia-static.com/images/news2/Kubuntu-15-04-Alpha-2-Is-> > > > th e-Most-Exciting-Release-in-a-Long-Time-Screenshot-Tour-470968-11.jpg > > > >

[Differential] [Commented On] D987: KSplash looking consistent to sddm and lockscreen

mart added a comment. http://youtu.be/68FDY4t0cIE REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc: plasma-devel

Re: plasma grub theme unified design

On Thursday 18 February 2016 14:53:48 kainz.a wrote: > Plasma 5.4 SDDM theme > http://i1-news.softpedia-static.com/images/news2/Kubuntu-15-04-Alpha-2-Is-th > e-Most-Exciting-Release-in-a-Long-Time-Screenshot-Tour-470968-11.jpg > > Plasma 5.5 SDDM theme >

[Differential] [Updated] D987: KSplash looking consistent to sddm and lockscreen

mart added reviewers: davidedmundson, broulik, andreaska. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc:

Re: KActivities repository split

El Thursday 18 February 2016, a les 12:30:59, Ivan Čukić va escriure: > Hi Albert, > > What schedule kio-extras have? kio-extras gets released with KDE Applications. Cheers, Albert > > Cheerio, > Ivan > > p.s. I'm thinking more and more that kactivities-workspace repository > might be a

[Differential] [Request, 109 lines] D987: KSplash looking consistent to sddm and lockscreen

mart created this revision. mart set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY this makes kspash be in a rectanle that looks just like the one used now in lockscreen and sddm.

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

[Differential] [Commented On] D986: Revamp of the activity switcher backend

davidedmundson added inline comments. INLINE COMMENTS imports/activitymanager/backport/model_updaters.h:2 year. imports/activitymanager/backport/switcheractivitiesmodel.cpp:280 just use shownActivities.contains() it's a normal QVector after all

[Differential] [Closed] D986: Revamp of the activity switcher backend

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP1d2b8fbe6150: Revamp of the activity switcher backend (authored by ivan). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D986?vs=2388=2391

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

[Differential] [Accepted] D986: Revamp of the activity switcher backend

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D986 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan,

[Differential] [Request, 1,400 lines] D986: Revamp of the activity switcher backend

ivan created this revision. ivan added reviewers: mart, davidedmundson, sebas. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY - Activities are sorted based on the last time used (an often requested feature, that makes meta+tab order activities like

Re: plasma grub theme unified design

martin here is the screenshot for the sddm theme in 5.5.1 https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/sddm.png you have right for VDG the SDDM login screen is the same than the user switch screen. I will post an incremental changed theme for 5.6 and at CERN we will update the

Re: plasma grub theme unified design

On Thursday 18 February 2016 14:53:48 kainz.a wrote: > > I would suggest to make an more cosmetic change for 5.6 where we change the > bug's thomas added 3 mounths ago about the button background and in the > next release circle the finalized design. But I think when we change to the > plasma

Re: plasma grub theme unified design

On Thursday, February 18, 2016 2:53:48 PM CET kainz.a wrote: > 2016-02-18 14:29 GMT+01:00 Marco Martin : > > On Thursday 18 February 2016 14:20:18 kainz.a wrote: > > > Hi, > > > > > > the VDG is working on an unified design from the boot to the shut down. > > > therefore we

[Powerdevil] [Bug 359535] New: Activity Settings have "Act like" selectbox even on desktop computers

https://bugs.kde.org/show_bug.cgi?id=359535 Bug ID: 359535 Summary: Activity Settings have "Act like" selectbox even on desktop computers Product: Powerdevil Version: 5.5.4 Platform: Other OS: Linux

Re: plasma grub theme unified design

2016-02-18 14:29 GMT+01:00 Marco Martin : > On Thursday 18 February 2016 14:20:18 kainz.a wrote: > > Hi, > > > > the VDG is working on an unified design from the boot to the shut down. > > therefore we workon a grub2, plymouth, sddm, ksplah theme. we have a wiki > > page

Re: plasma grub theme unified design

On Thursday 18 February 2016 14:20:18 kainz.a wrote: > Hi, > > the VDG is working on an unified design from the boot to the shut down. > therefore we workon a grub2, plymouth, sddm, ksplah theme. we have a wiki > page https://community.kde.org/KDE_Visual_Design_Group/Unified_Login which > will be

plasma grub theme unified design

Hi, the VDG is working on an unified design from the boot to the shut down. therefore we workon a grub2, plymouth, sddm, ksplah theme. we have a wiki page https://community.kde.org/KDE_Visual_Design_Group/Unified_Login which will be updated when we have access again. grub theme is finished and

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127103: Add autotests for IconItem

> On Feb. 18, 2016, 11:20 a.m., Kai Uwe Broulik wrote: > > autotests/iconitemtest.h, line 20 > > > > > > Can we use this now? It's supported by all compilers in minimal versions supported by frameworks, but

Re: KActivities repository split

Hi Albert, What schedule kio-extras have? Cheerio, Ivan p.s. I'm thinking more and more that kactivities-workspace repository might be a better solution ... -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76 ___ Plasma-devel mailing

Re: Review Request 127103: Add autotests for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127103/#review92524 --- Ship it! autotests/iconitemtest.h (line 20)

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 12:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 17, 2016, 11:59 p.m., David Edmundson wrote: > > Is this needed after: https://git.reviewboard.kde.org/r/127073/ ? probably - Marco --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 127103: Add autotests for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127103/#review92521 --- Ship it! Ship It! - Marco Martin On Feb. 17, 2016,

Re: RFC: Put notifications in sidepanel like widget explorer

On Thursday 18 February 2016 02:03:08 Thomas Pfeiffer wrote: > The thing is: When you open the popup, your attention is focused on it, > anyway, regardless of its size. It would feel clunky if we opened it with a > long animation like we still do far too often in Plasma, but if it opened > and

Re: Review Request 127103: Add autotests for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127103/#review92520 --- Ship it! Ship It! - Sebastian Kügler On Feb. 17, 2016,

Re: RFC: Put notifications in sidepanel like widget explorer

2016-02-18 2:03 GMT+01:00 Thomas Pfeiffer : > On Montag, 26. Oktober 2015 09:57:37 CET Sebastian Kügler wrote: > > On Tuesday, October 20, 2015 15:54:01 Martin Klapetek wrote: > > > today I was thinking a bit about our notification system. I believe > > > that the