Re: Review Request 127079: fix uninitialised var

2016-02-19 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127079/#review92574 --- Ship it! Ship It! - Milian Wolff On Feb. 19, 2016,

Re: Review Request 127118: ToolTip: Don't change geometry twice when repositioning

2016-02-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127118/ --- (Updated Feb. 19, 2016, 10:21 p.m.) Status -- This change has been

Re: kdereview: breeze-grub & breeze-plymouth

2016-02-19 Thread kainz.a
it was a joke. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127118: ToolTip: Don't change geometry twice when repositioning

2016-02-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127118/ --- Review request for Plasma. Repository: plasma-framework Description

[Differential] [Updated] D986: Revamp of the activity switcher backend

2016-02-19 Thread Ivan Čukić
ivan marked an inline comment as done. INLINE COMMENTS imports/activitymanager/sortedactivitiesmodel.cpp:228 This will go away - we are planning to make wallpaper exposed via dbus api because basing this code on config files is not really robust.

Re: kdereview: breeze-grub & breeze-plymouth

2016-02-19 Thread Martin Klapetek
On Fri, Feb 19, 2016 at 3:24 PM, kainz.a wrote: > hi > > no the up to date stuff is in this wiki https:// > > community.kde.org > >

Re: kdereview: breeze-grub & breeze-plymouth

2016-02-19 Thread kainz.a
hi no the up to date stuff is in this wiki https:// community.kde.org /KDE_Visual_Design_ Group

Re: kdereview: breeze-grub & breeze-plymouth

2016-02-19 Thread Martin Klapetek
Hi, On Fri, Feb 19, 2016 at 3:43 AM, Harald Sitter wrote: > Salut! > > As mentioned yesterday by Andreas Kainz, the VDG is working on a > unified design from boot to shutdown. To facilitate this we started > working on a GRUB and Plymouth theme that can now be found in >

Re: Review Request 127115: SvgItem: Don't use Plasma::Theme from rendering thread

2016-02-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127115/ --- (Updated Feb. 19, 2016, 5:22 p.m.) Status -- This change has been

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-19 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/ --- (Updated Feb. 19, 2016, 6:11 nachm.) Review request for kde-workspace

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-19 Thread Thomas Lübking
> On Feb. 18, 2016, 12:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: RFC: Put notifications in sidepanel like widget explorer

2016-02-19 Thread Thomas Pfeiffer
On Freitag, 19. Februar 2016 13:36:33 CET Marco Martin wrote: > On Friday 19 February 2016 13:06:28 Thomas Pfeiffer wrote: > > They both have a quite powerful sidebar (they both actually do their whole > > system configuration in there, which I find a bit extreme, but it seems to > > be working

[Differential] [Request, 3 lines] D991: TaskManager: Don't use Plasma theme icons in task icon

2016-02-19 Thread drosca (David Rosca)
drosca created this revision. drosca added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Also disable animation for icon in tooltip (normal Plasma tooltips no longer have animated icon too). BUG: 359387 REPOSITORY

Re: Review Request 127115: SvgItem: Don't use Plasma::Theme from rendering thread

2016-02-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127115/#review92568 --- Fix it, then Ship it!

Review Request 127115: SvgItem: Don't use Plasma::Theme from rendering thread

2016-02-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127115/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 127035: Show Frameworks version next to Qt Version

2016-02-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127035/#review92567 --- Ship it! Ship It! - Martin Gräßlin On Feb. 19, 2016,

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-19 Thread Daniel Faust
> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-19 Thread Daniel Faust
> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127035: Show Frameworks version next to Qt Version

2016-02-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127035/ --- (Updated Feb. 19, 2016, 12:57 p.m.) Review request for Plasma.

Re: RFC: Put notifications in sidepanel like widget explorer

2016-02-19 Thread Marco Martin
On Friday 19 February 2016 13:06:28 Thomas Pfeiffer wrote: > They both have a quite powerful sidebar (they both actually do their whole > system configuration in there, which I find a bit extreme, but it seems to > be working out pretty well for them). > > Just for a quick glance, feel free to

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

2016-02-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/ --- (Updated Feb. 19, 2016, 12:27 p.m.) Status -- This change has been

Re: Review Request 127112: Reparse svgElementsCache instead of deleting it in discardCache

2016-02-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127112/ --- (Updated Feb. 19, 2016, 12:27 p.m.) Status -- This change has been

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

2016-02-19 Thread David Rosca
> On Feb. 19, 2016, 12:02 p.m., David Edmundson wrote: > > src/plasmaquick/appletquickitem.cpp, lines 572-573 > > > > > > can you get rid of this. > > > > I think it's trying to do what your patch

Re: RFC: Put notifications in sidepanel like widget explorer

2016-02-19 Thread Thomas Pfeiffer
On Donnerstag, 18. Februar 2016 11:28:27 CET Marco Martin wrote: > On Thursday 18 February 2016 02:03:08 Thomas Pfeiffer wrote: > > The thing is: When you open the popup, your attention is focused on it, > > anyway, regardless of its size. It would feel clunky if we opened it with > > a > > long

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

2016-02-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92552 --- Fix it, then Ship it!

Re: Review Request 127112: Reparse svgElementsCache instead of deleting it in discardCache

2016-02-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127112/ --- (Updated Feb. 19, 2016, 11:56 a.m.) Review request for Plasma. Changes

Re: Review Request 127112: Reparse svgElementsCache instead of deleting it in discardCache

2016-02-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127112/#review92551 --- Ship it! Ship It! - Marco Martin On Feb. 19, 2016,

Re: Review Request 127079: fix uninitialised var

2016-02-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127079/ --- (Updated Feb. 19, 2016, 11:46 a.m.) Review request for KDE Frameworks

Review Request 127112: Reparse svgElementsCache instead of deleting it in discardCache

2016-02-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127112/ --- Review request for Plasma. Bugs: 359539

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2016-02-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review92550 --- Ship it! Ship It! - Marco Martin On Nov. 23, 2015,

kdereview: breeze-grub & breeze-plymouth

2016-02-19 Thread Harald Sitter
Salut! As mentioned yesterday by Andreas Kainz, the VDG is working on a unified design from boot to shutdown. To facilitate this we started working on a GRUB and Plymouth theme that can now be found in kdereview for your review pleasure. GRUB is ready for review. Plymouth is still in development