another Kirigami patch

This one is not directly related to the feedback that I had already collected, so instead of constantly replying to myself, I'll start a new email. If a page in a PageRow updates it title but the page object in the page stack doesn't change, Kirigami doesn't notice and happily shows the now

Re: Kirigami 1.0 feedback

Responding to myself again... must be a sign of approaching senility... On Sat, Apr 02, 2016 at 09:55:51AM -0500, Dirk Hohndel wrote: > > > > > I think this is our consolidated feedback: > > > > > > - make it an intentional action; stop at the top when scrolling, but when > > > the user stops

[Differential] [Updated, 61 lines] D1292: Add mute microphone global shortcut

drosca updated this revision to Diff 3079. drosca added a comment. Also add mic volume up/down REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1292?vs=3074=3079 BRANCH mic-mute-globalshortcut REVISION DETAIL

[Differential] [Request, 1 line] D1296: AppletConfiguration: Respect button visibility preference of KCModules

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Don't show Apply button when it's not in KCModule::buttons(). REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL

Re: Kirigami 1.0 feedback

On Sat, Apr 02, 2016 at 04:38:43PM +0200, Thomas Pfeiffer wrote: > even though you addresses Marco, let me comment on your suggestions so Marco > knows what's "Kirigami design approved": Bad habit of mine to address one person instead of all of you... > > I have spent quite a few hours on

[Differential] [Commented On] D1291: Add microphone volume OSD

colomar added a comment. I've asked Andreas to create the needed icons, please wait for them to arrive. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Kirigami 1.0 feedback

On Freitag, 1. April 2016 22:44:03 CEST Dirk Hohndel wrote: > Hi Marco, Hi Dirk, even though you addresses Marco, let me comment on your suggestions so Marco knows what's "Kirigami design approved": > I have spent quite a few hours on porting Subsurface-mobile to Kirigami > 1.0 and playing with

Re: Kirigami 1.0 feedback

Responding to myself to add some clarifications based on some more discussions with some of the testers... On Fri, Apr 01, 2016 at 10:44:03PM -0500, Dirk Hohndel wrote: > > 5. the margin at the top when pulling down a list (e.g., our dive list) > seems HUGE and unintuitive. It really looks like

[Differential] [Changed Subscribers] D1292: Add mute microphone global shortcut

drosca added a subscriber: plasma-devel. drosca added a project: Plasma. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1292 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: plasma-devel,

[Differential] [Updated] D1291: Add microphone volume OSD

drosca added a dependent revision: D1292: Add mute microphone global shortcut. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, Plasma: Design

[Differential] [Updated] D1291: Add microphone volume OSD

drosca added a reviewer: Plasma: Design. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, Plasma: Design Cc: plasma-devel, sebas

[Differential] [Commented On] D1291: Add microphone volume OSD

drosca added a comment. F103259: micmute-osd.png Maybe would be better to have microphone-volume-low/medium-high icons as for audio volume. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL

[Differential] [Request, 10 lines] D1291: Add microphone volume OSD

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1291 AFFECTED FILES shell/osd.cpp

Re: Review Request 127549: const

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127549/#review94203 --- Ship it! Looks good to me. - Dominik Haumann On April

[Differential] [Abandoned] D1079: UdevNotifier: Emit new devices on resume from suspend

drosca abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1079 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, broulik Cc: plasma-devel, sebas