Re: appstream in Plasma

On Thursday, April 7, 2016 11:28:17 PM CEST Alexander Potashev wrote: > Martin, > > Thanks for your reply. Please see my comments below. > > 2016-04-07 17:24 GMT+03:00 Martin Graesslin : > > On Thursday, April 7, 2016 4:37:14 PM CEST Alexander Potashev wrote: > >> 2016-04-07

Re: metadata.yaml for Plasma projects?

2016-04-07 13:55 GMT+02:00 Martin Graesslin : > On Thursday, April 7, 2016 1:21:55 PM CEST Aleix Pol wrote: >> On Thu, Apr 7, 2016 at 11:41 AM, Martin Graesslin > wrote: >> > Hi Plasmates, >> > >> > an idea for better documentation is to introduce some

Re: Questions on Plasma i18n strings, offset=39

​I'm taking tasks 50-59. if a few people grab another block of 10, we'll be done in no time. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1352: Correctly translate combo box in media frame plasmoid

davidedmundson added a reviewer: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1352 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel, sebas

[Differential] [Request, 61 lines] D1352: Correctly translate combo box in media frame plasmoid

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ListElement doesn't support script values. The original code used a "stupid hack" to try and run i18n later, but that doesn't work as

Re: Review Request 127612: Stop removing QT_NO_CAST_FROM_ASCII

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127612/ --- (Updated April 7, 2016, 4:57 p.m.) Status -- This change has been

Re: Review Request 127612: Stop removing QT_NO_CAST_FROM_ASCII

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127612/#review94416 --- Ship it! Ship It! - David Edmundson On April 7, 2016,

Review Request 127612: Stop removing QT_NO_CAST_FROM_ASCII

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127612/ --- Review request for Plasma. Repository: plasma-integration Description

Questions on Plasma i18n strings, offset=39

Hi, (This is a follow up to https://mail.kde.org/pipermail/plasma-devel/2016-March/050714.html. Because only a few of my questions/requests from that thread were addressed, I'm going to create 30+ bug reports at bugs.kde.org, so that those requests do not get lost.) I have another couple of

Re: appstream in Plasma

Martin, Thanks for your reply. Please see my comments below. 2016-04-07 17:24 GMT+03:00 Martin Graesslin : > On Thursday, April 7, 2016 4:37:14 PM CEST Alexander Potashev wrote: >> 2016-04-07 16:14 GMT+03:00 Martin Graesslin : >> > system settings is a

[Differential] [Commented On] D1350: [Digital Clock] Allow copying current date to clipboard

colomar added a comment. I'd change the label to "Copy date/time to clipboard", otherwise it looks good! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1350 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: appstream in Plasma

> In the case of the systemd KCM, you could declare that to be an addon to > Systemsettings... I like that idea. There's many handy 3rd party kcms hardly anybody knows about. I could imagine searching for system settings in the application manager and then finding various configuration UI

Re: appstream in Plasma

2016-04-07 19:47 GMT+02:00 Martin Gräßlin : > Am 2016-04-07 18:01, schrieb Scarlett Clark: >> >> FWIW some distros like Kubuntu (neon?) use systemsettings for all of >> our system settings. So having separate places for all other settings >> is very poor user experience. > >

[Differential] [Commented On] D1350: [Digital Clock] Allow copying current date to clipboard

broulik added a comment. F105986: Screenshot_20160407_205447.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1350 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 151 lines] D1350: [Digital Clock] Allow copying current date to clipboard

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It allows copying the

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

[Differential] [Request, 4 lines] D1348: Testing whether m_lastCreatedSettings is not null before calling its method

ivan created this revision. ivan added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It looks like something was forgotten here - there is a completely empty body for an if statement that checks

[Differential] [Request, 18 lines] D1347: Checking whether the m_textTexture is not null before dereferencing it

ivan created this revision. ivan added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It can be null even after updateTextTexture() if there is not text to generate the texture from: if

[Differential] [Request, 4 lines] D1346: Checking whether m_topLevel is not null before getting its property

ivan created this revision. ivan added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY From the rest of this method, it is obvious that m_topLevel can be null in any part of the method - we are

Re: appstream in Plasma

Am 2016-04-07 18:01, schrieb Scarlett Clark: FWIW some distros like Kubuntu (neon?) use systemsettings for all of our system settings. So having separate places for all other settings is very poor user experience. But Kubuntu uses Plasma and systemsettings is installed. So for Kubuntu it just

[Differential] [Abandoned] D1345: Checking whether m_topLevel is not null before getting its property

ivan abandoned this revision. ivan added a comment. Damn, arc merged these two, will recreate REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, graesslin Cc: plasma-devel,

[Differential] [Updated, 13 lines] D1345: Checking whether m_topLevel is not null before getting its property

ivan updated this revision to Diff 3195. ivan added a comment. - m_textTexture can be null even after updateTextTexture() REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1345?vs=3194=3195 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1345

[Differential] [Request, 4 lines] D1345: Checking whether m_topLevel is not null before getting its property

ivan created this revision. ivan added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This method checks whether m_topLevel is not null in a couple of places, but misses this one. p.s. If

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/ --- (Updated April 7, 2016, 5:08 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 07 Apr 2016 16:08:24 + Build duration: 16 min CHANGE SET Revision

Re: appstream in Plasma

FWIW some distros like Kubuntu (neon?) use systemsettings for all of our system settings. So having separate places for all other settings is very poor user experience. And I do recall seeing in various places third party KCMs like systemd and feel that this absolutely should be supported. Cheers,

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: appstream in Plasma

2016-04-07 15:08 GMT+02:00 Jonathan Riddell : > Martin's thread on metadata got me wondering about if we should have > appstream files in Plasma. It would be nice to have plasma-desktop in > software installers for people who run another desktop and want to > install it.

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 9:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 495-496 > > > > > > This part looks wrong to me and I think is the reason why reading icons > > fails in kwin_wayland now. >

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 9:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 495-496 > > > > > > This part looks wrong to me and I think is the reason why reading icons > > fails in kwin_wayland now. >

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: appstream in Plasma

On Thursday, April 7, 2016 4:37:14 PM CEST Alexander Potashev wrote: > 2016-04-07 16:14 GMT+03:00 Martin Graesslin : > > system settings is a workspace configuration tool. I don't see how that is > > useful to anyone not using Plasma > > Martin, > > One can use System

[Differential] [Closed] D1340: Rename AbstractBackend to Platform

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINd31e9e88b438: Rename abstract_backend.(h|cpp) to platform.(h|cpp) (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1340?vs=3185=3193#toc REPOSITORY rKWIN KWin

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 7:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, line 588 > > > > > > This looks wrong to me! This method is supposed to return the actual > > work area as set on X11, not

Re: appstream in Plasma

2016-04-07 16:14 GMT+03:00 Martin Graesslin : > system settings is a workspace configuration tool. I don't see how that is > useful to anyone not using Plasma Martin, One can use System Settings to start KCMs that are not related to Plasma: - Localization, - Akonadi, -

Re: appstream in Plasma

On Thursday, April 7, 2016 2:08:07 PM CEST Jonathan Riddell wrote: > Martin's thread on metadata got me wondering about if we should have > appstream files in Plasma. It would be nice to have plasma-desktop in > software installers for people who run another desktop and want to > install it.

appstream in Plasma

Martin's thread on metadata got me wondering about if we should have appstream files in Plasma. It would be nice to have plasma-desktop in software installers for people who run another desktop and want to install it. There's also applications like system settings (which has dozens of plugins),

[Differential] [Closed] D1339: waylandServer()->backend() replaced by kwinApp()->platform()

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN1d4cd55b9d42: Drop backend() -> AbstractBackend* from WaylandServer (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1339?vs=3184=3191#toc REPOSITORY rKWIN KWin

[Differential] [Accepted] D1344: Add an explicit dependency to Breeze to find decoration plugin

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Feel free to ship it once the BreezeConfig.cmake file is in. I can't comment on that one. REPOSITORY rKWIN KWin BRANCH dependency-to-breeze REVISION

Re: metadata.yaml for Plasma projects?

+1 to this, and actually I would reuse it for my CI revamp I am working on, I was working on something similiar, but if the devs keep up their own file would be even better! So in short, this would not duplicate kde-build-metadata because that is going away. Cheers, Scarlett On Thu, Apr 7, 2016

Re: bbcukmet feature in bugfix branch?

it sneaked in as a regression fix as bbcukmet was previously in the weather applet Jonathan On Wed, Apr 06, 2016 at 11:23:04AM +0200, Harald Sitter wrote: > Not that I know what an ion is but I am pretty sure [1] is a feature > and not a bug fix, yet it is in the bug fix branch for 5.6 :-( >

[Differential] [Request, 40 lines] D1344: Add an explicit dependency to Breeze to find decoration plugin

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KWin needs the plugin id of the breeze decoration plugin. Instead of hard coding that it's now

[Differential] [Updated] D1344: Add an explicit dependency to Breeze to find decoration plugin

graesslin added a dependency: D1343: Create a BreezeConfig.cmake. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1344 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

Re: metadata.yaml for Plasma projects?

On Thursday, April 7, 2016 1:21:55 PM CEST Aleix Pol wrote: > On Thu, Apr 7, 2016 at 11:41 AM, Martin Graesslin wrote: > > Hi Plasmates, > > > > an idea for better documentation is to introduce some metadata similar > > like > > what frameworks have. This could be useful for

[Differential] [Closed] D1338: Fix null values in currency conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS59614f7d8d9a: Fix null values in currency conversion (authored by davidedmundson). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 23 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 07 Apr 2016 11:04:51 + Build duration: 25 min CHANGE SET Revision

Re: metadata.yaml for Plasma projects?

On Thu, Apr 7, 2016 at 11:41 AM, Martin Graesslin wrote: > Hi Plasmates, > > an idea for better documentation is to introduce some metadata similar like > what frameworks have. This could be useful for potential devs who want to > contribute, but also for distributions as in

[Differential] [Closed] D1282: Subcompositor support in KWin

graesslin closed this revision. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1282 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: plasma-devel, sebas ___

Re: metadata.yaml for Plasma projects?

On Thursday, April 7, 2016 12:01:22 PM CEST Marco Martin wrote: > On Thursday 07 April 2016 11:41:25 Martin Graesslin wrote: > > Hi Plasmates, > > > > an idea for better documentation is to introduce some metadata similar > > like > > what frameworks have. This could be useful for potential devs

Re: metadata.yaml for Plasma projects?

On Thursday 07 April 2016 11:41:25 Martin Graesslin wrote: > Hi Plasmates, > > an idea for better documentation is to introduce some metadata similar like > what frameworks have. This could be useful for potential devs who want to > contribute, but also for distributions as in that way: > * we

metadata.yaml for Plasma projects?

Hi Plasmates, an idea for better documentation is to introduce some metadata similar like what frameworks have. This could be useful for potential devs who want to contribute, but also for distributions as in that way: * we can specify whether it's experimental, released, obsoleted, etc. * what

[Differential] [Commented On] D1340: Rename AbstractBackend to Platform

graesslin added a comment. In https://phabricator.kde.org/D1340#25034, @mart wrote: > the new name sounds better, but.. > didn't you want to keep kwayland binary compatible? it's kwin repo, not kwayland REPOSITORY rKWIN KWin REVISION DETAIL

[Differential] [Accepted] D1338: Fix null values in currency conversion

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D1338 EMAIL PREFERENCES

[Differential] [Commented On] D1340: Rename AbstractBackend to Platform

mart added a comment. the new name sounds better, but.. didn't you want to keep kwayland binary compatible? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1340 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma

[Differential] [Request, 297 lines] D1339: waylandServer()->backend() replaced by kwinApp()->platform()

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Drop backend() -> AbstractBackend* from WaylandServer No longer needed, provided through

[Differential] [Request, 15 lines] D1341: Add metainfo.yaml as needed for frameworks

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKWAYLAND KWayland BRANCH metainfo REVISION DETAIL https://phabricator.kde.org/D1341 AFFECTED FILES

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: Review Request 124648: Handle clients having a different device pixel ratio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/#review94357 --- Sorry that I didn't notice this review earlier. But the

[Differential] [Updated] D1339: waylandServer()->backend() replaced by kwinApp()->platform()

graesslin added a dependent revision: D1340: Rename AbstractBackend to Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1339 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

[Differential] [Updated] D1340: Rename AbstractBackend to Platform

graesslin added a dependency: D1339: waylandServer()->backend() replaced by kwinApp()->platform(). REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1340 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc:

[Differential] [Request, 249 lines] D1340: Rename AbstractBackend to Platform

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Rename abstract_backend.(h|cpp) to platform.(h|cpp) REPOSITORY rKWIN KWin BRANCH

[Differential] [Commented On] D1292: Add mute microphone global shortcut

drosca added inline comments. INLINE COMMENTS applet/contents/ui/main.qml:91 Yeah, that looks better. Will change it in next commit. src/qml/volumeosd.cpp:42 It's generated from XML, so it does not introspect. But indeed should be constructed just once. REPOSITORY rPLASMAPA Plasma Audio

[Differential] [Closed] D1331: Provide the platform() -> AbstractBackend* in KWin::Application

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN7996d954c526: Provide the platform() -> AbstractBackend* in KWin::Application (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1331?vs=3165=3182#toc REPOSITORY rKWIN

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/#review94351 --- Ship it! Ship It! - David Rosca On April 6, 2016, 5:24