[Differential] [Commented On] D1372: Fix unsetting associated application/urls for applets

2016-04-09 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. Hmpf, did I not tell arc to not pick up the CMakeLists.txt change? REVISION DETAIL https://phabricator.kde.org/D1372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, mart Cc: plasma-devel

Re: appstream in Plasma

2016-04-09 Thread Thomas Pfeiffer
On Samstag, 9. April 2016 20:32:24 CEST Martin Graesslin wrote: > If using a framework requires a workspace component being installed, > something is seriously broken in our workflows. We have worked a lot on > making our apps not depend on Plasma, let's not accept a status where that > doesn't

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 30 - Still Unstable!

2016-04-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 09 Apr 2016 18:23:33 + Build duration: 16 min CHANGE SET Revision

Re: appstream in Plasma

2016-04-09 Thread Martin Graesslin
On Saturday, April 9, 2016 3:48:33 PM CEST Alexander Potashev wrote: > Martin, > > Please find my comments below. > > 2016-04-08 8:55 GMT+03:00 Martin Graesslin : > > On Thursday, April 7, 2016 11:28:17 PM CEST Alexander Potashev wrote: > >> What if > >> > >> 1. I don't use

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 29 - Still Unstable!

2016-04-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 09 Apr 2016 15:56:14 + Build duration: 40 min CHANGE SET Revision

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/ --- (Updated April 9, 2016, 5:23 nachm.) Review request for Plasma. Bugs:

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
> On April 9, 2016, 2:22 nachm., Kai Uwe Broulik wrote: > > Nice cleanup work, haven't tried it so far, but a few nitpicks below. > > > > Also, you did a bunch of changes that were purely code-cosmetical, those > > should go into separate commits imho. > > > > Also, I think we should have a

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/ --- (Updated April 9, 2016, 5:21 nachm.) Review request for Plasma. Bugs:

[Differential] [Updated, 15 lines] D1267: TaskManager: Group tasks when losing demands attention state

2016-04-09 Thread drosca (David Rosca)
drosca updated this revision to Diff 3244. drosca added a comment. Use handleItem instead of remove+add to prevent moving the task to the end of task list REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1267?vs=3042=3244 BRANCH

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

2016-04-09 Thread drosca (David Rosca)
drosca added a comment. F106811: event-sounds.png Looks like this (always first in the list). It will need different icon, ideas? REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1366 EMAIL

[Differential] [Updated] D1366: Add Event Sounds stream to Applications list

2016-04-09 Thread drosca (David Rosca)
drosca added a reviewer: Plasma: Design. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1366 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, Plasma: Design Cc: plasma-devel, sebas

Re: Review Request 127618: Applet : Display icons and device selection for streams

2016-04-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127618/#review94457 --- The device combobox for streams was there (in my older

Review Request 127618: Applet : Display icons and device selection for streams

2016-04-09 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127618/ --- Review request for Plasma. Repository: plasma-pa Description ---

[Differential] [Request, 33 lines] D1367: PulseObjectFilterModel: Allow to set more filters

2016-04-09 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Also in applet: hide event stream and move default devices first in the list BUG: 353436 REPOSITORY

Re: appstream in Plasma

2016-04-09 Thread Alexander Potashev
Martin, Please find my comments below. 2016-04-08 8:55 GMT+03:00 Martin Graesslin : > On Thursday, April 7, 2016 11:28:17 PM CEST Alexander Potashev wrote: >> What if >> 1. I don't use a desktop environment, but I need a way to setup >> localization for KDE applications? > >

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/#review94456 --- Nice cleanup work, haven't tried it so far, but a few

[Differential] [Request, 235 lines] D1366: Add Event Sounds stream to Applications list

2016-04-09 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It is now possible to change volume of notification sounds. BUG: 355470 FIXED-IN: 5.7.0 REPOSITORY

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 28 - Still Unstable!

2016-04-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 09 Apr 2016 09:59:57 + Build duration: 26 min CHANGE SET Revision

Re: [KDE Usability] Review Request 126953: Remove Theme Details KCM

2016-04-09 Thread Ben Cooksley
Hi, Please refrain from using the phrase "KDE Identity" outside the context of KDE.org sites which use identity.kde.org for login. For a moment there I thought you were referring to breakages in our infrastructure. Regards, Ben ___ Plasma-devel mailing

Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/ --- Review request for Plasma. Bugs: 354239 and 360059

Re: Review Request 126953: Remove Theme Details KCM

2016-04-09 Thread kainz.a
Do you want to ship broken stuff. That should not be the kde identity. If someone want to maintain it perfect. Am 09.04.2016 10:25 schrieb "Michał Dybczak" : > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126953/ > > On

Re: Review Request 126953: Remove Theme Details KCM

2016-04-09 Thread Michał Dybczak
> On Kwi 5, 2016, 7:37 rano, Luigi Toscano wrote: > > Refraining from personal comments, there is a question related to this > > regarding the documentation: > > > > https://mail.kde.org/pipermail/kde-doc-english/2016-April/013341.html > > > > I would add: is there a document that explain how