Review Request 127744: [taskmanager] ToolTipDelegate Dragon fix

2016-04-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127744/ --- Review request for KDE Multimedia, Plasma, Kai Uwe Broulik, and Harald

[Differential] [Request, 7 lines] D1491: Don't try to read X11 properties on ShellClient

2016-04-25 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Effects and Shadow tried to read X11 properties unconditionally on the window id. If the window id is

[Differential] [Request, 2 lines] D1490: Don't call xcb_damage_subtract for Wayland windows

2016-04-25 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of checking the operation mode for X11, we check whether the damage_handle is created. This

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-04-25 Thread Anthony Fieroni
> On Април 25, 2016, 1:54 след обяд, Anthony Fieroni wrote: > > Ping > > Sebastian Kügler wrote: > I think you made this hard to track, the original review request is here: > https://git.reviewboard.kde.org/r/123653/ > > Anthony Fieroni wrote: > But i can't change patch, no? > >

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-04-25 Thread Sebastian Kügler
> On April 25, 2016, 10:54 a.m., Anthony Fieroni wrote: > > Ping > > Sebastian Kügler wrote: > I think you made this hard to track, the original review request is here: > https://git.reviewboard.kde.org/r/123653/ > > Anthony Fieroni wrote: > But i can't change patch, no? I don't

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-04-25 Thread Anthony Fieroni
> On Април 25, 2016, 1:54 след обяд, Anthony Fieroni wrote: > > Ping > > Sebastian Kügler wrote: > I think you made this hard to track, the original review request is here: > https://git.reviewboard.kde.org/r/123653/ But i can't change patch, no? - Anthony

Minutes Monday Plasma Meeting

2016-04-25 Thread Sebastian Kügler
Minutes Plasma 'hangout', 26-4-2016, 12:00 CET Present: Sho, mgraesslin, bshah, notmart, kbroulik, Roman (subdiff) (just listening), sebas Sho: - Added Bugzilla product for plasma-integration, default assignee is mgraesslin - Next Plasma Test Days prep meeting tomorrow 12:00 UTC in #plasma -

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-04-25 Thread Sebastian Kügler
> On April 25, 2016, 10:54 a.m., Anthony Fieroni wrote: > > Ping I think you made this hard to track, the original review request is here: https://git.reviewboard.kde.org/r/123653/ - Sebastian --- This is an automatically generated

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-04-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/#review94830 --- Ping - Anthony Fieroni On Април 15, 2016, 7:05 преди

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 56 - Still Unstable!

2016-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 25 Apr 2016 10:27:34 + Build duration: 14 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 55 - Still Unstable!

2016-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 25 Apr 2016 09:38:56 + Build duration: 7 min 34 sec CHANGE SET Revision

[Differential] [Closed] D1475: [OSD] Load QML file on demand

2016-04-25 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE79c081e2ea35: [OSD] Load QML file on demand (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1475?vs=3490=3508

[Differential] [Accepted] D1475: [OSD] Load QML file on demand

2016-04-25 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1475 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1456: Fix loading of widgetStyle in KHintsSettings

2016-04-25 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH fix-loading-style REVISION DETAIL https://phabricator.kde.org/D1456 EMAIL PREFERENCES

[Differential] [Closed] D1476: Conditionally compile tests which depend on XCB_ICCCM

2016-04-25 Thread ltoscano (Luigi Toscano)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN654a17686e4b: Conditionally compile tests which depend on XCB_ICCCM (authored by ltoscano). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1476?vs=3491=3507

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

2016-04-25 Thread mart (Marco Martin)
mart added a comment. +1 from me(provided the commit excludes the osd stuff), would like Martin taking a final look at this REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1478 EMAIL PREFERENCES

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

2016-04-25 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D1478#27445, @colomar wrote: > Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore. > Only errors

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

2016-04-25 Thread mart (Marco Martin)
mart added a comment. looks like you can see the top text only for a brief moment then it goes "away"? it makes sense even tough i think there should be some way to return to top to actually read it, and this should happen only in the popup, if it's a permentent one in the history is

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

2016-04-25 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Please ignore the OSD stuff in the patch :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1478 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: Design,

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

2016-04-25 Thread broulik (Kai Uwe Broulik)
broulik added a comment. > Why can we not make it scroll? There's no technical reason we cannot, I just haven't added it :) I'll figure something out. REVISION DETAIL https://phabricator.kde.org/D1479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Munich Sprint

2016-04-25 Thread Sebastian Kügler
On Thursday, April 21, 2016 09:58:35 PM John Layt wrote: > On 18 April 2016 at 20:58, John Layt wrote: > > That would be kprinter. Credative / Limux had a replacement for KDE4 > > called kprinter4 (part of which is a poorly-attributed fork of some > > code I wrote for Okular): > >

Re: Review Request 127467: PulseObject: Add iconName property

2016-04-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127467/ --- (Updated April 25, 2016, 8:57 a.m.) Status -- This change has been

Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

2016-04-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127734/#review94829 --- Ship it! Ship It! - Marco Martin On April 24, 2016,

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

2016-04-25 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1478#27450, @mck182 wrote: > So that users may leave long-taking jobs unattended and then click "Open folder" on the notification or something once they're back and/or the job is done. Ah, right, that makes sense. Not

Re: Review Request 127467: PulseObject: Add iconName property

2016-04-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127467/#review94828 --- Ship it! Ship It! - Kai Uwe Broulik On April 12, 2016,

Re: Review Request 127739: [Volume applet] Show application icon

2016-04-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127739/ --- (Updated April 25, 2016, 8:51 vorm.) Status -- This change has been

[Differential] [Request, 2 lines] D1483: Only destroy damage_handle if a damage_handle got created

2016-04-25 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of binding to the OperationMode whether the damage_handle should be destroyed, we bind it to

Re: Review Request 127263: Add Wireless Energy Saving action

2016-04-25 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated April 25, 2016, 7:52 a.m.) Status -- This change has been

Re: Review Request 127325: Replace all keywords by Qt macros

2016-04-25 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127325/ --- (Updated April 25, 2016, 7:52 a.m.) Status -- This change has been

[Differential] [Request, 6 lines] D1482: Connect Application::screensCreated to WaylandServer::initOutputs

2016-04-25 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of having the Application invoke initOutputs after creating the Screens, we can just connect

Re: Review Request 127325: Replace all keywords by Qt macros

2016-04-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127325/#review94827 --- Ship it! Not really happy with using a lib that forces

Re: Review Request 127739: [Volume applet] Show application icon

2016-04-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127739/#review94826 --- https://git.reviewboard.kde.org/r/127467/ Sorry I didn't