[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

colomar added a comment. Makes sense, and I agree that "notification sounds" is better. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1366 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma,

Re: plymouth theme is tagged in wrong branch and/or tarballed from wrong branch

On Tue, May 10, 2016 at 12:58:07PM +0200, Harald Sitter wrote: > 5.6.3 is tagged in master > $ git branch --contains v5.6.3 > master > > 5.5.95 was tagged in Plasma/5.6 branch > $ git branch --contains v5.5.95 > * Plasma/5.6 > master > > So... wtf? a failure in repo-metadata, fixed for 5.6.4

Plasma 5.6.4

Plasma 5.6.4 is now released https://www.kde.org/announcements/plasma-5.6.4.php More translations and useful bug fixes, highlights: Make sure kcrash is initialized for discover. Build Breeze Plymouth and Breeze Grub tars from correct branch [digital-clock] Fix display of seconds with certain

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

broulik added inline comments. INLINE COMMENTS src/context.cpp:150 Braces pls src/context.cpp:424 Avoid creating a temporary list keys() just to find something in it, use constFind and std::distance src/eventstream.cpp:29-32 Initializer list: : SinkInput(parent) ,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 77 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/77/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 May 2016 17:23:59 + Build duration: 17 min CHANGE SET Revision

[Differential] [Closed] D1564: [System Tray] Ensure pin is always on top

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6326af4bf981: [System Tray] Ensure pin is always on top (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1566: [System Tray] Use units.longDuration for transitions

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE941bfdb2ebc3: [System Tray] Use units.longDuration for transitions (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1567: [System Tray] Fix assigning global shortcuts to applets from the config interface

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7bfd0b03c446: [System Tray] Fix assigning global shortcuts to applets from the config… (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1565: [System Tray] Forward keyboard input to expanded representation

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf518442fd596: [System Tray] Forward keyboard input to expanded representation (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Review Request 127889: [QuickTheme] Fix properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127889/ --- (Updated May 10, 2016, 5:16 p.m.) Status -- This change has been

Re: Review Request 127889: [QuickTheme] Fix properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127889/#review95364 --- Ship it! Ship It! - Marco Martin On May 10, 2016, 3:50

Review Request 127889: [QuickTheme] Fix properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127889/ --- Review request for Plasma and David Faure. Repository: plasma-framework

Re: Review Request 127842: take highlight and highlightedText from proper color group

> On Mai 5, 2016, 8:02 nachm., Kai Uwe Broulik wrote: > > Switching themes no longer properly updates the highlight color, ie. > > switching from Breeze to Honeycomb leaves me with a blue highlight (and > > brokenness in task manager with yellow borders around blue items). Then > > switching

Re: Review Request 127888: use selected icon effect for current KPageView page

> On May 10, 2016, 5:17 p.m., Emmanuel Pescosta wrote: > > src/kpageview_p.cpp, line 402 > > > > > > option.state & (QStyle::State_Selected | QStyle::State_Active) maybe? > > Marco Martin wrote: > doesn't

Re: Review Request 127888: use selected icon effect for current KPageView page

> On May 10, 2016, 3:17 p.m., Emmanuel Pescosta wrote: > > src/kpageview_p.cpp, line 402 > > > > > > option.state & (QStyle::State_Selected | QStyle::State_Active) maybe? doesn't work, if state is

Review Request 127888: use selected icon effect for current KPageView page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127888/ --- Review request for KDE Frameworks and Plasma. Repository: kwidgetsaddons

Re: Review Request 127842: take highlight and highlightedText from proper color group

> On May 5, 2016, 8:02 p.m., Kai Uwe Broulik wrote: > > Switching themes no longer properly updates the highlight color, ie. > > switching from Breeze to Honeycomb leaves me with a blue highlight (and > > brokenness in task manager with yellow borders around blue items). Then > > switching to

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/#review95355 --- src/filewidgets/kfileplacesview.cpp (line 157)

Re: Review Request 127888: use selected icon effect for current KPageView page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127888/#review95354 --- src/kpageview_p.cpp (line 402)

[Differential] [Accepted] D1584: start struts timer in resizeEvent

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. Just tested and confirm that it fixes the problem. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1584 EMAIL PREFERENCES

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

> On May 6, 2016, 4:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 > > Aleix Pol Gonzalez wrote: > No, it's already called by `ShellCorona::loadDefaultLayout()`. > >

[Differential] [Accepted] D1584: start struts timer in resizeEvent

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1584 EMAIL PREFERENCES

Re: Kirigami popup

On Tuesday 10 May 2016 10:23:28 Martin Klapetek wrote: > Hey, > > so in SpaceBar, there's a button that opens a 1/3-screen-height > popup with emojis for the user to select. How should that be > styled? I found no Kirigami component for this kind of thing, > any suggestions? > > Currently it's

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

> On May 6, 2016, 6:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 > > Aleix Pol Gonzalez wrote: > No, it's already called by `ShellCorona::loadDefaultLayout()`. > >

Kirigami popup

Hey, so in SpaceBar, there's a button that opens a 1/3-screen-height popup with emojis for the user to select. How should that be styled? I found no Kirigami component for this kind of thing, any suggestions? Currently it's just a white Rectangle but does not really fit. Ultimately the best

Re: Review Request 127875: Selected state concept for icons

> On May 10, 2016, 12:50 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 839 > > > > > > Aren't we missing an arg? > > > > return QStringLiteral(".ColorScheme-Text {\ > > color:%1;\ >

[Differential] [Request, 9 lines] D1584: start struts timer in resizeEvent

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY starting the stuts timer in resize/move events means we don't have to litter it across any

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 10, 2016, 2:15 p.m.) Review request for KDE Frameworks and

[Differential] [Commented On] D1567: [System Tray] Fix assigning global shortcuts to applets from the config interface

broulik added inline comments. INLINE COMMENTS applets/systemtray/package/contents/ui/ConfigEntries.qml:233 visible: modelData.hasOwnProperty("shortcut") The shortcut item is only shown for applets REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95347 --- src/kiconloader.cpp (line 827)

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95345 --- src/kiconloader.cpp (line 839)

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 841 > > > > > > we're already passing a highlightedText colour for some reason. > > > > Either: > > - Kiconloader

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127876/ --- (Updated May 10, 2016, 12:41 p.m.) Review request for KDE Frameworks and

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 841 > > > > > > we're already passing a highlightedText colour for some reason. > > > > Either: > > - Kiconloader

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test the patch but: it compiles and code

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test the patch but: it compiles and code

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test the patch but: it compiles and code

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test the patch but: it compiles and code

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/ --- (Updated May 10, 2016, 11:57 a.m.) Review request for KDE Frameworks and

Plasma 5.7 Test Days prep meeting #4 notes & log

attendees: eike, jensreu, bshah chair: eike a) ISO status - No further communication with Fedora yet (Eike, Jens) due to vacations - Bhushan says Arch ISOs will be trivial b) Dates - Future meetings at 13:00 instead of 12:00 to avoid conflict with Kirigami meetings c) Test cases - Bhushan

[Differential] [Accepted] D1565: [System Tray] Forward keyboard input to expanded representation

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1565 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1564: [System Tray] Ensure pin is always on top

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1564 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg Well, Ship it is a bit premature. I could not test the patch but: it compiles and code looks sensible. However, there are probably

[Differential] [Accepted] D1567: [System Tray] Fix assigning global shortcuts to applets from the config interface

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS applets/systemtray/package/contents/ui/ConfigEntries.qml:233 may be more robust if the type (sni or applet) is actually a role in the model? REPOSITORY rPLASMAWORKSPACE

[Differential] [Accepted] D1578: [Notifications] Unbreak notification actions

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1578 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

plymouth theme is tagged in wrong branch and/or tarballed from wrong branch

5.6.3 is tagged in master $ git branch --contains v5.6.3 master 5.5.95 was tagged in Plasma/5.6 branch $ git branch --contains v5.5.95 * Plasma/5.6 master So... wtf? ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 10, 2016, 10:56 a.m.) Review request for KDE Frameworks and

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 311 > > > > > > was createIconImage in the last frameworks? > > > > if so this is an ABI break. > > > >

[Differential] [Changed Subscribers] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

sitter added a subscriber: plasma-devel. sitter added a project: Plasma. REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, dfaure Cc: plasma-devel, sebas

[Differential] [Updated] D1582: Move the OpenGL unsafe check into the Platform

graesslin added dependencies: D1581: If glx is not available try to create egl backend, D1576: Provide functionality of CompositingPrefs through Platform, D1575: Move requiresCompositing from Application to Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1582

[Differential] [Updated] D1575: Move requiresCompositing from Application to Platform

graesslin added a dependent revision: D1582: Move the OpenGL unsafe check into the Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1575 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel,

[Differential] [Updated] D1581: If glx is not available try to create egl backend

graesslin added a dependent revision: D1582: Move the OpenGL unsafe check into the Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1581 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel,

[Differential] [Request, 46 lines] D1582: Move the OpenGL unsafe check into the Platform

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A new virtual method createOpenGLSafePoint is added to Platform. This is invoked through the

[Differential] [Updated] D1576: Provide functionality of CompositingPrefs through Platform

graesslin added a dependent revision: D1582: Move the OpenGL unsafe check into the Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1576 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel,

[Differential] [Updated] D1576: Provide functionality of CompositingPrefs through Platform

graesslin added a dependent revision: D1581: If glx is not available try to create egl backend. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1576 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel,

[Differential] [Request, 14 lines] D1581: If glx is not available try to create egl backend

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far the OpenGL is unsafe check functionality in Compositor disabled OpenGL compositing if glx is

[Differential] [Updated] D1575: Move requiresCompositing from Application to Platform

graesslin added a dependent revision: D1581: If glx is not available try to create egl backend. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1575 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel,

[Differential] [Updated] D1581: If glx is not available try to create egl backend

graesslin added dependencies: D1576: Provide functionality of CompositingPrefs through Platform, D1575: Move requiresCompositing from Application to Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1581 EMAIL PREFERENCES

[Differential] [Closed] D1423: Disallow ptrace on polkit agent on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rPOLKITKDEAGENT2e7efafe58f9: Disallow ptrace on polkit agent on FreeBSD (authored by tcberner). REPOSITORY rPOLKITKDEAGENT Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1570: fix serializertest by adding missing data

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN82cd8f829498: fix serializertest by adding missing data (authored by bshah). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1570?vs=3714=3742 REVISION

[Differential] [Accepted] D1570: fix serializertest by adding missing data

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH Plasma/5.6 REVISION DETAIL https://phabricator.kde.org/D1570 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, sebas,

[Differential] [Closed] D1571: [kcms/touchpad] Disable kded module on platforms != x11

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP52c4bb9efa03: [kcms/touchpad] Disable kded module on platforms != x11 (authored by graesslin). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1425: Disallow ptrace on greeter and kwin_wayland process on FreeBSD [... for the future]

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2ea5feb35b67: Disallow ptrace on greeter and kwin_wayland process on FreeBSD [... for the… (authored by tcberner). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1579: pid_t is defined in sys/types.h

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND1d531e997bfc: pid_t is defined in sys/types.h (authored by tcberner). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1579?vs=3732=3739 REVISION DETAIL

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

> On May 6, 2016, 4:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 > > Aleix Pol Gonzalez wrote: > No, it's already called by `ShellCorona::loadDefaultLayout()`. Yes,

[Differential] [Commented On] D1425: Disallow ptrace on greeter and kwin_wayland process on FreeBSD [... for the future]

graesslin added a comment. I cannot give another accept, so ShipIt REPOSITORY rKWIN KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D1425 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: tcberner, rakuco, graesslin Cc: plasma-devel,

[Differential] [Accepted] D1579: pid_t is defined in sys/types.h

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D1579 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: tcberner, graesslin Cc: