[Differential] [Commented On] D1807: Request the resize of ShellSurface after Decoration updated the borders when maximizing

2016-06-09 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > luebking wrote in shell_client.cpp:592 > ifff geometry() includes the deco for the ShellClient, this will get it > shrinking away on each max/restore cycle. > (If it's only the client geo, there's no problem) I actually tested that manually

Re: Review Request 128144: Windecoration KCM theme color

2016-06-09 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128144/ --- (Updated Juni 9, 2016, 11:30 nachm.) Review request for Plasma.

Re: Review Request 128144: Windecoration KCM theme color

2016-06-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128144/#review96335 --- kcmkwin/kwindecoration/qml/Buttons.qml (line 42)

Review Request 128144: Windecoration KCM theme color

2016-06-09 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128144/ --- Review request for Plasma. Repository: kwin Description ---

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 133 - Still Unstable!

2016-06-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/133/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Jun 2016 22:34:05 + Build duration: 11 min CHANGE SET Revision

[Differential] [Closed] D1810: Don't call a plugin "something plugin"

2016-06-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE84671a081382: Don't call a plugin "something plugin" (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1809: Fix i18n in plasmacalendarintegration

2016-06-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6f0a88a2a500: Fix i18n in plasmacalendarintegration (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D1809: Fix i18n in plasmacalendarintegration

2016-06-09 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1809 EMAIL PREFERENCES

[Differential] [Accepted] D1810: Don't call a plugin "something plugin"

2016-06-09 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1810 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D1810: Don't call a plugin "something plugin"

2016-06-09 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The fact that it's a plugin isn't very relevant. REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Request, 12 lines] D1809: Fix i18n in plasmacalendarintegration

2016-06-09 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

[Differential] [Closed] D1802: Hide the fact that sebas managed to spell his own name wrong.Not once, but 62 times.

2016-06-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREEN8a23e004e02d: Provide .mailmap file to fix broken locale in git logs (authored by davidedmundson). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D1802: Hide the fact that sebas managed to spell his own name wrong.Not once, but 62 times.

2016-06-09 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. davidedmundson added a comment. pushed with a more professional commit message, so closing this manually. REPOSITORY rLIBKSCREEN KScreen Library REVISION DETAIL https://phabricator.kde.org/D1802 EMAIL PREFERENCES

Re: New idea for Plasma's logo

2016-06-09 Thread Ken Vermette
Of course! As a matter of fact, it would be interesting if we encouraged participants to provide any sources to freely remix, mash-up, and build on each-others entries. Make this a co-operative event. On Thu, Jun 9, 2016 at 11:16 AM, Thomas Pfeiffer wrote: > On

Re: New idea for Plasma's logo

2016-06-09 Thread Thomas Pfeiffer
On 09.06.2016 16:21, Ken Vermette wrote: I don't want to sweep my stupidity under the rug, but I'd like to steer the conversation back to logo design; are there any thoughts on posting a community-oriented competition? I think it would be best if we collected a wealth of candidates and

[Differential] [Changed Subscribers] D1807: Request the resize of ShellSurface after Decoration updated the borders when maximizing

2016-06-09 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > shell_client.cpp:592 > +if (m_maximizeMode == MaximizeFull) { > +m_geomMaximizeRestore = geometry(); > +requestGeometry(workspace()->clientArea(MaximizeArea, this)); ifff geometry() includes the deco for the ShellClient, this

[Differential] [Updated] D1807: Request the resize of ShellSurface after Decoration updated the borders when maximizing

2016-06-09 Thread Martin Gräßlin
graesslin added a dependent revision: D1808: Introduce a RequestGeometryBlocker in ShellClient. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1807 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland

[Differential] [Updated] D1808: Introduce a RequestGeometryBlocker in ShellClient

2016-06-09 Thread Martin Gräßlin
graesslin added a dependency: D1807: Request the resize of ShellSurface after Decoration updated the borders when maximizing. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1808 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 42 lines] D1807: Request the resize of ShellSurface after Decoration updated the borders when maximizing

2016-06-09 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This ensures that we don't send a size request with the borders

Re: New idea for Plasma's logo

2016-06-09 Thread Ken Vermette
I need to say that I was absolutely wrong, and I misread the conversation entirely. Alex certainly didn't "bypass" anybody, and what I said was blatantly incorrect. I apologise for the misinformation/confusion, I should have checked things first before even suggesting what I did. I don't want to

Re: ksplash unified login

2016-06-09 Thread kainz.a
> >> kspash >> == >> 1. introduction >> the pc is finished with Plymount (auto login) or SDDM so the default >> background is the blue gradient and in the center is the distro logo >> (Plymounth) or the user avatar (sddm) >> > > I'll change ksplash to default to the blue gradient, show the

[Differential] [Updated, 234 lines] D1800: Load a Wallpaper plugin in kscreenlocker_greet

2016-06-09 Thread Martin Gräßlin
graesslin updated this revision to Diff 4309. graesslin added a comment. Adressed some of Kai-Uwe's comments REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1800?vs=4295=4309 BRANCH wallpaper-plugin REVISION DETAIL

[Differential] [Updated] D1800: Load a Wallpaper plugin in kscreenlocker_greet

2016-06-09 Thread Martin Gräßlin
graesslin marked 7 inline comments as done. graesslin added inline comments. INLINE COMMENTS > broulik wrote in wallpaper_integration.cpp:33 > using namespace? I prefer having a huge namespace around the implementation of a class which is in the namespace. > broulik wrote in

Re: What happened to Dolphin's transfer dialog?

2016-06-09 Thread Alexander Potashev
CCed plasma-devel and Kai because your problem is probably tied with this commit: http://commits.kde.org/plasma-desktop/e284e9dc17051f22d05985e218fa44ddaba78de5 -- Alexander Potashev 2016-06-05 19:29 GMT+03:00 Mark Gaiser : > Hi, > > I used to have the file transfer dialog n

Re: ksplash unified login

2016-06-09 Thread David Edmundson
On Thu, Jun 9, 2016 at 2:25 PM, kainz.a wrote: > Hi David > > 2016-06-09 12:25 GMT+02:00 David Edmundson : > >> > is the new sddm theme already in master? >> Got a "ship it" yesterday, merging now. >> >> >about the ksplash theme, the idea was

[Differential] [Closed] D1796: Improve API documentation

2016-06-09 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND89f3a226df4c: Improve API documentation (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1796?vs=4298=4308 REVISION DETAIL

[Differential] [Closed] D1795: [windowsystem] Implement (un)minimizeWindow through KWayland::Client::PlasmaWindow

2016-06-09 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDINTEGRATION756d8e8c5e30: [windowsystem] Implement (un)minimizeWindow through KWayland::Client… (authored by graesslin). REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 132 - Still Unstable!

2016-06-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/132/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Jun 2016 12:23:55 + Build duration: 17 min CHANGE SET Revision

Re: Translation of click events to touch events in kwin.

2016-06-09 Thread Bhavisha Dhruve
On Thu, Jun 9, 2016 at 11:35 AM, Martin Graesslin wrote: > I think that's already quite a list, so I stop here for the moment. This > should be sufficient to get a nested kwin_wayland started. How to get it to > render and how to get input in is then something we need to look

Re: ksplash unified login

2016-06-09 Thread kainz.a
Hi David 2016-06-09 12:25 GMT+02:00 David Edmundson : > > is the new sddm theme already in master? > Got a "ship it" yesterday, merging now. > > >about the ksplash theme, the idea was descriped already here >

[Differential] [Closed] D1670: New login screen

2016-06-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE788c0110efcd: New login screen (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1670?vs=4210=4306#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Closed] D1805: Pass the maximized signal to DecoratedClient

2016-06-09 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc95ddb710215: Pass the maximized signal to DecoratedClient (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1805?vs=4303=4304 REVISION DETAIL

[Differential] [Accepted] D1795: [windowsystem] Implement (un)minimizeWindow through KWayland::Client::PlasmaWindow

2016-06-09 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland BRANCH minimize-kwindowsystem REVISION DETAIL https://phabricator.kde.org/D1795 EMAIL

Re: Review Request 128134: kate session applet change minimum height

2016-06-09 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128134/ --- (Updated June 9, 2016, 12:04 p.m.) Status -- This change has been

Review Request 128136: alignement for systemmonitoring applets

2016-06-09 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- Review request for Plasma. Repository: plasma-workspace Description

[Differential] [Accepted] D1796: Improve API documentation

2016-06-09 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH more-documentation REVISION DETAIL https://phabricator.kde.org/D1796 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D1800: Load a Wallpaper plugin in kscreenlocker_greet

2016-06-09 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > greeterapp.cpp:198 > +[this, qmlObject, view] { > +auto item = dynamic_cast(qmlObject->rootObject()); > +if (!item) { qobject_cast > greeterapp.cpp:200 > +if (!item) { > +

Re: Review Request 128134: kate session applet change minimum height

2016-06-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128134/#review96313 --- Ship it! Ship It! - David Edmundson On June 9, 2016,

Re: Review Request 128134: kate session applet change minimum height

2016-06-09 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128134/ --- (Updated June 9, 2016, 1:21 p.m.) Review request for Kate and Plasma.

[Differential] [Closed] D1804: kcm_keyboard: Don't require libxcb-xinput

2016-06-09 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPca7618dd6173: kcm_keyboard: Don't require libxcb-xinput (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Review Request 128089: [Quick Chat] Add context menu for copying text and links

2016-06-09 Thread Kai Uwe Broulik
> On Juni 7, 2016, 1:20 nachm., Thomas Pfeiffer wrote: > > Akthough of course I'd prefer being able to actually select text, this is a > > very helpful workaround for the fact that we cannot have that. > > > > Why do links have the option to open the link in the context menu? That's > > what

[Powerdevil] [Bug 364138] New: Power Management Problem Kubuntu 16.04

2016-06-09 Thread Denis via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364138 Bug ID: 364138 Summary: Power Management Problem Kubuntu 16.04 Product: Powerdevil Version: unspecified Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED

Re: ksplash unified login

2016-06-09 Thread David Edmundson
> > > Where? I can only see bits about > > Pressed send too early. "Where? I can only see bits about grub and plymouth". ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ksplash unified login

2016-06-09 Thread David Edmundson
> is the new sddm theme already in master? Got a "ship it" yesterday, merging now. >about the ksplash theme, the idea was descriped already here https://community.kde.org/KDE_Visual_Design_Group/Unified_Login Where? I can only see bits about ​> we are also working on the logout and user switch

Re: New idea for Plasma's logo

2016-06-09 Thread Thomas Pfeiffer
On 05.06.2016 13:22, Alessandro Longo wrote: Il 02-06-2016 20:47 Ken Vermette ha scritto: On a side note, like Thomas, I'm a little leery of the fact that you've seemingly bypassed the VDG main channel. I've done stupid things like that too (much more publicly) and I've learned that

[Differential] [Accepted] D1804: kcm_keyboard: Don't require libxcb-xinput

2016-06-09 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH no-xcbxinput (branched from master) REVISION DETAIL https://phabricator.kde.org/D1804 EMAIL PREFERENCES

[Differential] [Commented On] D1804: kcm_keyboard: Don't require libxcb-xinput

2016-06-09 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D1804#33504, @drosca wrote: > Should this go also to Plasma/5.6? I'd say better safe than sorry: master only REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1804 EMAIL

[Differential] [Commented On] D1804: kcm_keyboard: Don't require libxcb-xinput

2016-06-09 Thread drosca (David Rosca)
drosca added a comment. Great, so it works. Thanks for testing. Should this go also to Plasma/5.6? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1804 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 128131: biger output field

2016-06-09 Thread Andreas Kainz
> On June 9, 2016, 8:34 a.m., Marco Martin wrote: > > to change the size of the popup you change > > Layout.minimumWidth/Layout.minimumHeight of the root element of the popup, > > inthis case applet root element I play with id: main; Plasmoid.switchWidth: Layout.minimumWidth

[Differential] [Commented On] D1804: kcm_keyboard: Don't require libxcb-xinput

2016-06-09 Thread Martin Gräßlin
graesslin added a comment. output when plugging in a device: kded5(3129)/(org.kde.kcm_keyboard) unknown: New device id: 10 kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 2 name: Virtual core pointer used as: 0 kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 3 name: Virtual

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-06-09 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96307 --- Great! It's okay that you decided not to put in the "-",

[Differential] [Commented On] D1804: kcm_keyboard: Don't require libxcb-xinput

2016-06-09 Thread drosca (David Rosca)
drosca added a comment. In https://phabricator.kde.org/D1804#33497, @graesslin wrote: > How can I test the code on my Debian system and confirm that it works as intended? Enable debug for `org.kde.kcm_keyboard` category, plug keyboard/mouse and look for "new keyboard/pointer

[Differential] [Commented On] D1804: kcm_keyboard: Don't require libxcb-xinput

2016-06-09 Thread Martin Gräßlin
graesslin added a comment. How can I test the code on my Debian system and confirm that it works as intended? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1804 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Review Request 128133: sync with kate session applet

2016-06-09 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128133/ --- Review request for Plasma. Repository: kdeplasma-addons Description

Re: Review Request 128131: biger output field

2016-06-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128131/#review96306 --- to change the size of the popup you change

[Differential] [Request, 19 lines] D1804: kcm_keyboard: Don't require libxcb-xinput

2016-06-09 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Copying the definition of xcb_input_device_presence_notify_event_t to our code makes the new device

Re: ksplash unified login

2016-06-09 Thread Marco Martin
is not on master... is there work on it somewhere? and, is there still time to have it in 5.7? On Tuesday 07 June 2016, kainz.a wrote: > Hi David, > > is the new sddm theme already in master? > > about the ksplash theme, the idea was descriped already here >

[Differential] [Request, 157 lines] D1803: Fix the strut handling for wayland clients

2016-06-09 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma on Wayland, KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The implementation was broken as it transformed the QRects into

Re: Translation of click events to touch events in kwin.

2016-06-09 Thread Martin Graesslin
On Wednesday, June 8, 2016 9:58:28 PM CEST Bhavisha Dhruve wrote: > I now properly understood the actual idea, and how I will have to use > FakeInput interface, to sum up there will be QtQuick component, which will > be used by Plasma mobile emulator to embed KWin inside emulator window. yep >