Re: Is it able to make kservice's weightedOffers public access?

2016-06-27 Thread Leslie Zhai
Hi Sebastian, I am so sorry for my mistake, it will not happen again! 在 2016年06月27日 17:31, Sebastian Kügler 写道: Hi Leslie, On maandag 27 juni 2016 12:47:03 CEST 翟翔 wrote: in the src/services/kservicetypetrader.h about line 216, static KServiceOfferList weightedOffers(const QString ); is

[Differential] [Updated] D2000: Make it possible to adjust volume even if it's muted

2016-06-27 Thread xuetianweng (Xuetian Weng)
xuetianweng marked an inline comment as done. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2000 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: jensreuterberg, plasma-devel, sebas

[Differential] [Updated, 8 lines] D2000: Make it possible to adjust volume even if it's muted

2016-06-27 Thread xuetianweng (Xuetian Weng)
xuetianweng updated this revision to Diff 4779. xuetianweng added a comment. change it against master REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4749=4779 BRANCH master REVISION DETAIL

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Hm ok, good point. How do we prevent duplicate play controls, then? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2019 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Static desktop actions, which we use, are dumb static application launchers, ie. they cannot express status and worse it would launch an executable which then probably communicates through DBus to an existing instance, at which point we could just do that directly

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Ah damn you're right, Plasma once again does more than I know ;) Back to this review request, though: Shouldn't the application itself handle media controls as jump lists? Cantata, for example, already does just that. Would it then show playback controls twice

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread broulik (Kai Uwe Broulik)
broulik added a comment. We already have that. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2019 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, hein Cc: colomar,

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Nice addition! However, what I'd like even more to see (in addition) is having a tooltip with player controls also on a launcher. Would that be possible as well? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2019 EMAIL

[Differential] [Accepted] D2021: [PulseObject] Use application.process.binary instead of application.binary

2016-06-27 Thread drosca (David Rosca)
drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2021 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D2021: [PulseObject] Use application.process.binary instead of application.binary

2016-06-27 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, drosca. broulik set the repository for this revision to rPLASMAPA Plasma Audio Volume Applet. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY That's what

[Differential] [Commented On] D2000: Make it possible to adjust volume even if it's muted

2016-06-27 Thread drosca (David Rosca)
drosca added a comment. > Shall we do it this way (set opacity) for now I'd say let's go with it for now, unless VDG has better idea? In any case, this should go into master and not 5.7. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL

[Differential] [Request, 5 lines] D2020: [Folder View internallibkonq] Use KIO::highlightInFileManager

2016-06-27 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of just opening the

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread broulik (Kai Uwe Broulik)
broulik added a comment. F160500: Screenshot_20160627_190932.png Right clicking a pinned player running in the background with no window F160504: Screenshot_20160627_190958.png Right clicking a regular player

[Differential] [Request, 279 lines] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 220 - Still Unstable!

2016-06-27 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/220/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 14:13:24 + Build duration: 17 min CHANGE SET Revision

Re: KCM/colord-kde and it's KF5 release

2016-06-27 Thread Alessandro Longo
Il 21-06-2016 12:53 David Edmundson ha scritto: ​Note that kgamma which does something somewhat similar is part of the release. Colord-kde is specifically for loading ICC profiles. Kgamma doesn't support it afaik. ICC profiles are made through colorimeters and spectrophotometers and loaded

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 12 - Still Failing!

2016-06-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 14:15:54 + Build duration: 48 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Failing!

2016-06-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 14:12:54 + Build duration: 1 min 11 sec CHANGE SET Revision

[Differential] [Closed] D1911: [Smart Launcher Backend] Use KSharedConfig::openConfig

2016-06-27 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP73b079c0a730: [Smart Launcher Backend] Use KSharedConfig::openConfig (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1907: [System Tray] Hide popup when user configuring

2016-06-27 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE02f0f9ab1ede: [System Tray] Hide popup when user configuring (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Live image for Plasma 5.7 release

2016-06-27 Thread Luca Beltrame
In data lunedì 27 giugno 2016 14:12:32 CEST, Martin Graesslin ha scritto: Hello Martin, > If your distribution is able to create a live image with the released tars > before the release, we could include a link to it in the release Speaking on behalf of the openSUSE community KDE team: this can

Long term support release for Plasma?

2016-06-27 Thread Martin Graesslin
Hi distributions, in Plasma we are considering to add a long term support release. For this idea we want to get some feedback from your side to know how we should set this up. Here is an example (I mean it!) for how this could look like: * 5.8 first LTS release based on Qt 5.6 (which is also an

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Failing!

2016-06-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 12:14:43 + Build duration: 46 sec CHANGE SET Revision

[Differential] [Closed] D1893: [Panel Config Overlay] Make spacer size handles narrower

2016-06-27 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP8195ed3d34ae: [Panel Config Overlay] Make spacer size handles narrower (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Live image for Plasma 5.7 release

2016-06-27 Thread Martin Graesslin
Hi distributions, for the Plasma 5.7 release on July, 5th, I would like to have live images for the release announcement. If your distribution is able to create a live image with the released tars before the release, we could include a link to it in the release announcement. This would allow

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Failing!

2016-06-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 11:37:40 + Build duration: 44 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Failing!

2016-06-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 11:18:20 + Build duration: 53 sec CHANGE SET Revision

Jenkins-kde-ci: sddm-kcm Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 2 - Successful!

2016-06-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/sddm-kcm%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 11:02:26 + Build duration: 4 min 59 sec CHANGE SET No changes JUNIT RESULTS

Minutes Monday Plasma Meeting

2016-06-27 Thread Sebastian Kügler
Minutes Plasma 'hangout', 27-6-2016, 12:00 CET Present: mgraesslin, bshah, notmart, Sho, kbroulik, d_ed, sitter, sebas mgraesslin: * went to opensuse conf, reported * let's discuss an LTS * openqa usage * sync of clipboard between X11 and Wayland * tests found some issues regarding XWayland

Jenkins-kde-ci: ksshaskpass Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-06-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ksshaskpass%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 10:52:33 + Build duration: 5 min 15 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kmenuedit Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-06-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmenuedit%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 10:52:31 + Build duration: 1 min 1 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kde-gtk-config Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-06-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kde-gtk-config%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 10:43:01 + Build duration: 6 min 49 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Closed] D1916: [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player

2016-06-27 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP0d6442d8374f: [Task Manager ToolTipDelegate] Match DesktopEntry for associating… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Failing!

2016-06-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jun 2016 10:41:37 + Build duration: 1 min 11 sec CHANGE SET Revision

[Differential] [Closed] D1915: [FolderModel] Use mostLocalUrl() to properly resolve desktop:/ URLs

2016-06-27 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPa79cbce0fed0: [FolderModel] Use mostLocalUrl() to properly resolve desktop:/ URLs (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2018: [Plasma Engine Explorer] Don't crash on invalid engine plugin info

2016-06-27 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDK2e5a7e39fdd7: [Plasma Engine Explorer] Don't crash on invalid engine plugin info (authored by broulik). REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D1972: [server] Add support for setting the clipboard selection DataDeviceInterface manually

2016-06-27 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH selection REVISION DETAIL https://phabricator.kde.org/D1972 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D1930: Add support for new Notification role on PlasmaSurface

2016-06-27 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc81d8204f9a3: Add support for new Notification role on PlasmaSurface (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1930?vs=4575=4766

[Differential] [Accepted] D2018: [Plasma Engine Explorer] Don't crash on invalid engine plugin info

2016-06-27 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2018 EMAIL PREFERENCES

Re: Is it able to make kservice's weightedOffers public access?

2016-06-27 Thread Sebastian Kügler
Hi Leslie, On maandag 27 juni 2016 12:47:03 CEST 翟翔 wrote: > in the src/services/kservicetypetrader.h about line 216, > > static KServiceOfferList weightedOffers(const QString ); is > private access, is it able to make it public access? This is best discussed on the frameworks mailing list,

[Differential] [Request, 8 lines] D2018: [Plasma Engine Explorer] Don't crash on invalid engine plugin info

2016-06-27 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMASDK Plasma SDK. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Fixes a crash when doing "Service for

Re: Cleaning up Old Synchrotron Resources

2016-06-27 Thread R.Harish Navnit
Hi, On Sat, Jun 25, 2016 at 1:35 AM, Andreas Cord-Landwehr wrote: > > Hey, I am currently looking at all of the stuff we provide at Synchrotron [1]. > It seems that there are some Plasma related resources that nobody would miss > if we clean up the system (and possibly

Cleaning up Old Synchrotron Resources

2016-06-27 Thread Andreas Cord-Landwehr
Hey, I am currently looking at all of the stuff we provide at Synchrotron [1]. It seems that there are some Plasma related resources that nobody would miss if we clean up the system (and possibly completely shut it down when nobody is using it anymore). All of the resources below were last

[Differential] [Closed] D1929: [kwindowsystem] Wrap the notification type

2016-06-27 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDINTEGRATIONf0acbfad6bfe: [kwindowsystem] Wrap the notification type (authored by graesslin). REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland CHANGES SINCE LAST

Re: Review Request 127812: Fix the return value of Plasma::Service::operationDescription() for the docs

2016-06-27 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127812/ --- (Updated June 27, 2016, 8:50 a.m.) Status -- This change has been

[Differential] [Closed] D1932: [tests] Add a test application for PlasmaShellSurface

2016-06-27 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDa13705291a7a: [tests] Add a test application for PlasmaShellSurface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1928: Add a notification role to PlasmaShellSurface

2016-06-27 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND2f4cb0613b1c: Add a notification role to PlasmaShellSurface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1928?vs=4572=4759

[Differential] [Closed] D1938: [server] Ensure that Resource::Private::get returns nullptr if passed a nullptr

2016-06-27 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDa37bc2320eea: [server] Ensure that Resource::Private::get returns nullptr if passed a nullptr (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 219 - Still Unstable!

2016-06-27 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/219/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Jun 2016 12:46:57 + Build duration: 11 min CHANGE SET Revision

Jenkins-kde-ci: polkit-kde-agent-1 Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-06-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/polkit-kde-agent-1%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Jun 2016 12:47:23 + Build duration: 4 min 58 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Failing!

2016-06-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Jun 2016 12:46:57 + Build duration: 51 sec CHANGE SET Revision