[Differential] [Updated] D2231: [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and eglconfig

graesslin added a dependency: D2202: Support restarting the OpenGL compositor on Wayland. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2231 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc:

[Differential] [Updated] D2202: Support restarting the OpenGL compositor on Wayland

graesslin added a dependent revision: D2231: [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and eglconfig. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2202 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 4 lines] D2232: [plugins/hwcomposer] Use an RGBA_8888 format for rendering surface

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY When sharing surface and config used by the compositor scene with

[Differential] [Request, 65 lines] D2231: [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and eglconfig

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY So far SharingPlatformContext was only used if the OpenGL context

[Differential] [Closed] D2201: [platforms/wayland] Use XdgShell if available and prefer it

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINbec69b5705e1: [platforms/wayland] Use XdgShell if available and prefer it (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2201?vs=5254=5341

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 271 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/271/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Jul 2016 20:01:12 + Build duration: 18 min CHANGE SET Revision

[Differential] [Closed] D2204: [Service Runner] Search through "Comment" as well

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE501bba4a51ba: [Service Runner] Search through "Comment" as well (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2223: [Notifications] Only keep job finished notification in case of an error

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE35579e66489a: [Notifications] Only keep job finished notification in case of an error (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2222: [Notifications Dataengine] Fix default timeout

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEc521b596e043: [Notifications Dataengine] Fix default timeout (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

rwooninck added a comment. I have been using this patch for a couple of days now and I haven’t experienced issues anymore with the screens. Before the patch, I had the issue that despite the correct kscreen configuration, the panel would start on the wrong screen, etc. (This was then

[Differential] [Commented On] D2156: improve output identification

lbeltrame added a comment. So far, no bad side effects that I can tell, even with the newer version. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc:

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

mart added a comment. In https://phabricator.kde.org/D2223#41241, @colomar wrote: > Even in some minutes, quite a few notifications can pile up in the queue if you do lots of operations. > This would only be acceptable if they could all be collapsed into a single notification, but I

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

colomar added a comment. In https://phabricator.kde.org/D2223#41238, @mart wrote: > if they would auto clear, but still stay for some minutes, i would be fine Even in some minutes, quite a few notifications can pile up in the queue if you do lots of operations. This would only

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

mart added a comment. In https://phabricator.kde.org/D2212#41093, @andreaska wrote: > what's the reason for this pin stuff? many want to be able to keep the calendar open when doing something else, ie if you want to have a calendar at hand if you are talking with someone in a

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

mart added a comment. if they would auto clear, but still stay for some minutes, i would be fine REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

colomar added a comment. @mart If you started a file transfer job at some point and now you neither have a progress indicator anymore, nor see an error message, what is supposed to have happened other than that it succeeded? Of all the file transfer job, the vast majority will complete

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

mart added a comment. (no, don't like it) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, graesslin Cc: mart,

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

broulik added a comment. You do know, except it won't stick around forever (I got the habit of copying files, then clearing the notification history, it's so tedious). If something went wrong you'll either have the persistent error notification or a KIO error dialog anyway... REPOSITORY

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

mart added a comment. so i don't know what happened to the files i was copying, meh :( REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 48 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Jul 2016 16:02:28 + Build duration: 56 sec CHANGE SET Revision

[Differential] [Accepted] D2201: [platforms/wayland] Use XdgShell if available and prefer it

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH xdg-shell-platform REVISION DETAIL https://phabricator.kde.org/D2201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote: > > I acknowledge the problem in general, but I think the solution is wrong as > > this creates now a race condition on startup where apps don't show up in > > the systray at all. That is if an application tries to create a systray > > icon

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

> On July 19, 2016, 4:02 a.m., David Edmundson wrote: > > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled) > > already has a recursion check added in > > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which > > basically checks if we're using the KDE

[Differential] [Accepted] D2223: [Notifications] Only keep job finished notification in case of an error

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. asking the testing question: how can we autotest this? INLINE COMMENTS > broulik wrote in Jobs.qml:88 > !! is the JavaScript-way of casting to

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

broulik added inline comments. INLINE COMMENTS > graesslin wrote in Jobs.qml:88 > why !! !! is the JavaScript-way of casting to a bool, error is the KIO error number. I could do Boolean(error) or error ? true : false if you like. I do a toBool() in the notification action but I'd prefer being

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

colomar added a comment. +1 from me (of course, since it was my request ;) ) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Changed Subscribers] D2223: [Notifications] Only keep job finished notification in case of an error

graesslin added inline comments. INLINE COMMENTS > Jobs.qml:88 > body: errorText || message, > -isPersistent: true, > +isPersistent: !!error, // we'll assume success to be the > note-unworthy default, only be persistent in error case >

[Differential] [Accepted] D2222: [Notifications Dataengine] Fix default timeout

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D EMAIL PREFERENCES

[Differential] [Updated] D2222: [Notifications Dataengine] Fix default timeout

broulik added a dependent revision: D2223: [Notifications] Only keep job finished notification in case of an error. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D EMAIL PREFERENCES

[Differential] [Request, 2 lines] D2223: [Notifications] Only keep job finished notification in case of an error

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a dependency: D: [Notifications Dataengine] Fix default timeout. Restricted Application added a project: Plasma.

[Differential] [Updated] D2222: [Notifications Dataengine] Fix default timeout

broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, jensreuterberg, abetts,

[Differential] [Request, 1 line] D2222: [Notifications Dataengine] Fix default timeout

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As per notification spec

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

ochurlaud added a comment. In https://phabricator.kde.org/D2212#41053, @andreaska wrote: > the reduced calender size in the widget is way better than before, but what's with the text (time) in the panel? the time height in the panel should be the same height than the system tray icon

[Differential] [Closed] D2154: kscreen kcm: block changed signal after save

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN4b69f8708e63: kscreen kcm: block changed signal after save (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2154?vs=5309=5310 REVISION

[Differential] [Updated, 22 lines] D2154: kscreen kcm: block changed signal after save

sebas updated this revision to Diff 5309. sebas added a comment. - Add comment explaining the hack REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2154?vs=5139=5309 BRANCH blockkcmchanges REVISION DETAIL https://phabricator.kde.org/D2154 AFFECTED

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 33 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Jul 2016 13:59:10 + Build duration: 49 sec CHANGE SET Revision

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote: > > I acknowledge the problem in general, but I think the solution is wrong as > > this creates now a race condition on startup where apps don't show up in > > the systray at all. That is if an application tries to create a systray > > icon

[Differential] [Accepted] D2154: kscreen kcm: block changed signal after save

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH blockkcmchanges REVISION DETAIL https://phabricator.kde.org/D2154 EMAIL PREFERENCES

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

> On July 19, 2016, 4:02 a.m., David Edmundson wrote: > > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled) > > already has a recursion check added in > > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which > > basically checks if we're using the KDE

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

> On July 19, 2016, 4:02 a.m., David Edmundson wrote: > > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled) > > already has a recursion check added in > > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which > > basically checks if we're using the KDE

[Differential] [Updated] D2218: New logic for screen numbers in plasmashell

mart updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2218 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: graesslin, plasma-devel, jensreuterberg, abetts,

Plasma 5.7.2

Plasma 5.7.2 is now released https://www.kde.org/announcements/plasma-5.7.2.php ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 999 lines] D2218: New logic for screen numbers in plasmashell

mart updated this revision to Diff 5308. mart added a comment. - use .data and remoe dead code REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2218?vs=5296=5308 BRANCH mart/screenConnectorManagement REVISION DETAIL

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

mart added inline comments. INLINE COMMENTS > graesslin wrote in panelview.cpp:679-684 > what about that connect? right, that didn't work, it tried to be too smart and moved the panel around, while now when m_screenToFollow goes away, the panel view gets deleted externally in

[Differential] [Updated, 284 lines] D1989: Introduce QQuickItem to nest kwin_wayland

bdhruve updated this revision to Diff 5302. bdhruve added a comment. - Fixed automatic selection of backend to look for WAYLAND_SOCKET also - Rendering kwin instance - Fixed minor issues. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5014=5302

[Differential] [Closed] D2203: Expose Geometry in PlasmaWindowModel.

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND5732215ea7ba: Expose Geometry in PlasmaWindowModel. (authored by hein). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2203?vs=5298=5301 REVISION DETAIL

[Differential] [Reopened] D2156: improve output identification

sebas reopened this revision. sebas added a comment. (Pushed a branch for testing which closed this request. This patch is not merged, yet.) REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES

[Differential] [Closed] D2156: improve output identification

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN1b1c51cddda7: improve output identification (authored by sebas). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2156?vs=5194=5300#toc REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST

[Differential] [Accepted] D2203: Expose Geometry in PlasmaWindowModel.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D2203 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, graesslin

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

colomar added a comment. How about we keep it as one option and only add more fine-grained controls of users demand it? If we want to do fine-grained options right away, it should be hidden behind an "Advanced" expander (see https://techbase.kde.org/Projects/Usability/HIG/Settings ),

[Differential] [Request, 284 lines] D2219: Add option to enable volume feedback

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Play "pop" sound when changing volume BUG: 365197 REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH

[Differential] [Updated] D2219: Add option to enable volume feedback

drosca added a reviewer: Plasma: Design. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2219 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, #plasma:_design Cc: plasma-devel, jensreuterberg,

[Differential] [Abandoned] D2217: Add option to disable OSD on volume change

drosca abandoned this revision. drosca added a comment. > That looks like a way better way to do it, if we decide for it. Agree REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2217 EMAIL PREFERENCES

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

elvisangelaccio added inline comments. INLINE COMMENTS > dfaure wrote in kdeplatformfiledialoghelper.cpp:78 > Can you explain and document here what this function does, i.e. input args > and return value? It's a bit confusing. > > "kde" is a mimetype name, e.g. application/zip right? > "list"

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

graesslin added a comment. In https://phabricator.kde.org/D2217#41094, @broulik wrote: > See https://phabricator.kde.org/D1770 and https://phabricator.kde.org/D1771 > > What I could imagine is having a list of check boxes there: > "Show visual feedback for:" > > - [ ] Volume

[Differential] [Updated, 47 lines] D2203: Expose Geometry in PlasmaWindowModel.

hein updated this revision to Diff 5298. hein added a comment. Shake up x/y. REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2203?vs=5292=5298 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2203 AFFECTED FILES

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

broulik added a comment. See https://phabricator.kde.org/D1770 and https://phabricator.kde.org/D1771 What I could imagine is having a list of check boxes there: "Show visual feedback for:" - [ ] Volume change - [ ] Brightness change - etc but then I don't think we should

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

andreaska added a comment. what's the reason for this pin stuff? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma:_design, #plasma,

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

colomar added a comment. I agree with Martin: Either people want to see an OSD when changing a parameter using the keyboard, or they don't. Like Martin, I don't see why someone would want an OSD when changing screen brightness with the keyboard, but not when changing volume. Would it

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

graesslin added a comment. In https://phabricator.kde.org/D2217#41086, @drosca wrote: > I think there already is global option to disable OSD, but I think it makes sense to just disable OSD for volume. Also kmix has this option and there are users that want it. I'm not sure.

[Differential] [Changed Subscribers] D2218: New logic for screen numbers in plasmashell

graesslin added inline comments. INLINE COMMENTS > panelview.cpp:679-684 > +/*connect(screen, ::destroyed, this, [this]() { > +if (PanelView::screen()) { > +m_screenToFollow = PanelView::screen(); > +adaptToScreen(); > +} > +});*/ what about that

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 47 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Jul 2016 10:47:19 + Build duration: 55 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 32 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Jul 2016 10:45:39 + Build duration: 4 min 59 sec CHANGE SET Revision

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

drosca added a comment. I think there already is global option to disable OSD, but I think it makes sense to just disable OSD for volume. Also kmix has this option and there are users that want it. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL

[Differential] [Updated] D2218: New logic for screen numbers in plasmashell

mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2218 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

graesslin added a comment. Does it make sense to add an option for this to the plasmoid? If there is a need to disable osds, shouldn't we rather do it globally and disable all osd? REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2217 EMAIL

[Differential] [Request, 1,005 lines] D2218: New logic for screen numbers in plasmashell

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY screen numbers for containments are not anymore a sequential number starting from 0, but make the numbers correspond 1:1 to screen connector

Jenkins-kde-ci: khotkeys Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 5 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Jul 2016 10:41:48 + Build duration: 1 min 22 sec CHANGE SET Revision

Jenkins-kde-ci: khotkeys Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 5 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Jul 2016 10:41:48 + Build duration: 1 min 22 sec CHANGE SET Revision

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

drosca added a comment. F188070: Screenshot_20160719_122725.png REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2217 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D2217: Add option to disable OSD on volume change

drosca added a reviewer: Plasma: Design. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2217 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, #plasma:_design Cc: plasma-devel, jensreuterberg,

[Differential] [Request, 96 lines] D2217: Add option to disable OSD on volume change

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 363983 TEST PLAN I'm not really sure on the label "Show OSD" as that may not be clear to user what

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

broulik added a comment. The spacing is completely off now and the pin overlaps the calendar... REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud,

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

drosca added a comment. The calendar popup size is fine for me (with patched plasma-framework), what I *still* think is broken is the gridSize scaling - see https://git.reviewboard.kde.org/r/125773/ You can also test it simply by switching font to DejaVu Sans. REPOSITORY

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

andreaska added a comment. the reduced calender size in the widget is way better than before, but what's with the text (time) in the panel? the time height in the panel should be the same height than the system tray icon REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

Re: Review Request 128485: Reposition the krunner window if the width changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128485/#review97595 --- Ship it! Ship It! - Kai Uwe Broulik On Juli 19, 2016,

Re: Review Request 128484: Don't set a Window Icon on Plamsa::Dialog

> On Juli 19, 2016, 5:44 vorm., Martin Gräßlin wrote: > > In KWin it can be seen when e.g. activating Present Windows while Kickoff > > is open or the calendar. Also in Alt+Tab this could happen. > > > > KWin will show an icon - always - in the worst case it will be the generic > > X icon. If

[Differential] [Request, 117 lines] D2216: [platforms/virtual] Use rendernode or vgem device if available for egl

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The egl implementation for the virtual platform tries to use a

[Differential] [Requested Changes To] D2203: Expose Geometry in PlasmaWindowModel.

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_plasma_window_model.cpp:463 > + > +const QRect geom(0, 0, 50, 75); > +w->setGeometry(geom); and what about x and y? REPOSITORY

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

ochurlaud added a comment. Before: F188019: Screenshot_20160719_101221.png After: F188021: Screenshot_20160719_101336.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Updated, 47 lines] D2203: Expose Geometry in PlasmaWindowModel.

hein updated this revision to Diff 5292. hein added a comment. Drop flush/dispatch; use different values for width and height. REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2203?vs=5267=5292 BRANCH master REVISION DETAIL

[Differential] [Commented On] D2203: Expose Geometry in PlasmaWindowModel.

hein added inline comments. INLINE COMMENTS > graesslin wrote in test_plasma_window_model.cpp:460-461 > those two should not be needed. Dropped. > graesslin wrote in test_plasma_window_model.cpp:466 > could you use different values? E.g. if we swapped width and height, we > wouldn't notice.

[Differential] [Updated] D2203: Expose Geometry in PlasmaWindowModel.

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > hein wrote in test_plasma_window_model.cpp:446-447 > I copied that from testBooleanData Also m_pw is not actually a model but a PlasmaWindowManagement :-) REPOSITORY rKWAYLAND KWayland REVISION DETAIL

[Differential] [Commented On] D2203: Expose Geometry in PlasmaWindowModel.

hein added inline comments. INLINE COMMENTS > graesslin wrote in test_plasma_window_model.cpp:446-447 > you don't need to create a model. You have one in m_pw I copied that from testBooleanData REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D2203 EMAIL