apol updated this revision to Diff 5549.
apol added a comment.
Fix naming
REPOSITORY
rKIRIGAMI Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2306?vs=5547=5549
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2306
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
sebas marked an inline comment as done.
Closed by commit rLIBKSCREEN08df8462efd9: unit test Log::context (authored by
sebas).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2295?vs=5538=5548#toc
REPOSITORY
apol updated this revision to Diff 5547.
apol added a comment.
Add api documentation
REPOSITORY
rKIRIGAMI Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2306?vs=5546=5547
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2306
AFFECTED FILES
>
>> for DropShadow and the animation for hover to add it
>> in the PlasmaCore.IconItem right?
>>
>
> I'd put the animation in the DropShadow itself and scale that.
>
> I bet changing the size of a ShaderEffectSource triggers a re-render, and
> that's why you see the performance hit.
>
> Currently
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Sometimes we show some information on top of a flickable that goes away as
soon as the user scrolls
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI69d297937b01: Prefer alias to new property (authored
by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2305?vs=5541=5543#toc
REPOSITORY
rKIRIGAMI Kirigami
CHANGES SINCE LAST
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rKIRIGAMI Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2305
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAPA6814a96da412: Add option to enable volume feedback
(authored by drosca).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2219?vs=5299=5542#toc
REPOSITORY
rPLASMAPA Plasma Audio Volume
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It's better to just have a property aliased than duplicating it. Both for
readability and performance
sebas added a reviewer: dhaumann.
sebas added a comment.
@dhaumann Does this font satisfy your concerns?
REVISION DETAIL
https://phabricator.kde.org/D1816
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddell, #plasma, #plasma:_design, dhaumann
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENca49b5309ca7: categorized logging for kscreen kcm
(authored by sebas).
REPOSITORY
rKSCREEN KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2294?vs=5512=5539
REVISION DETAIL
drosca added a comment.
> Can we expect canberra to be available everywhere PA is?
KF5 kmix has it as non-optional dependency too, so I think that should not be
issue.
> Is the feedback only played when there is no other source playing?
It's played even if there is something
sebas added inline comments.
INLINE COMMENTS
> davidedmundson wrote in log.cpp:136
> why call instance() from inside a member function?
> it'll always return this.
Log::log(...) is static.
REPOSITORY
rLIBKSCREEN KScreen Library
BRANCH
sebas/log
REVISION DETAIL
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D2219#42920, @drosca wrote:
> > Can we expect canberra to be available everywhere PA is?
>
> KF5 kmix has it as
sebas added a comment.
In https://phabricator.kde.org/D2219#42870, @colomar wrote:
> Is the feedback only played when there is no other source playing?
> If not, it should be done like that. If you already have something
playing, it's just annoying to play an additional sound, and
sebas updated this revision to Diff 5538.
sebas marked 2 inline comments as done.
sebas added a comment.
- Address comments from David's review
REPOSITORY
rLIBKSCREEN KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2295?vs=5514=5538
BRANCH
sebas/log
REVISION
sebas added inline comments.
INLINE COMMENTS
> davidedmundson wrote in log.cpp:30
> why have it separate instead of a member of log?
I just tried making it a member, but running into problems.
QtMessageHandler is a typedef'ed function pointer, not a class. If I add a
static member in my Log
On Thu, Jul 28, 2016 at 1:08 PM, Michail Vourlakos
wrote:
> David, I had tried it some iterations before in my code path, it wasnt
> as equally performant as the Images solution, I will give it one more
> try...
>
> I suppose you are proposing to drop Images, add a
sebas added inline comments.
INLINE COMMENTS
> davidedmundson wrote in log.cpp:46
> It doesn't matter if there are threads *in* kscreen.
>
> The question is: Can a kscreen class be used *in* another thread by $app.
That's what I meant, it's not designed to be thread-safe at all. The backends
The IconItem to be done... scale, and appearScale create the hover animation:
PlasmaCore.IconItem {
id: iconImage
property int newTempSize: Math.floor(panel.iconSize *
wrapper.scale * wrapper.appearScale)
width: newTempSize
height: newTempSize
On 7/28/16,
David, I had tried it some iterations before in my code path, it wasnt
as equally performant as the Images solution, I will give it one more
try...
I suppose you are proposing to drop Images, add a ShaderEffectSource
with live:false for DropShadow and the animation for hover to add it
in the
ShaderEffectSource with live:false should be equally performant as this (if
anything more so).
It /should/ also fix your code.
Then call scheduleUpdate() whenever onSourceChanged is emitted.
We load the pixmap in the polish() event which happens between all QML
processing and the frame being
Image {
id: iconImageBuffer
property int newTempSize: Math.floor(panel.iconSize *
wrapper.scale * wrapper.appearScale)
width: newTempSize
height: newTempSize
anchors.centerIn: parent
source: (wrapper.containsMouse === true) ?
Hi,
Am Donnerstag, 28. Juli 2016 12:23:56 CEST schrieb Sebastian Kügler:
On donderdag 28 juli 2016 01:18:00 CEST David Kahles wrote:
I think the problem with this approach is, that most (or even all?) of
these processes aren't units but simple processes.
A better approach using the power of
On donderdag 28 juli 2016 14:03:24 CEST Michail Vourlakos wrote:
> is it possible to know when a PlasmaCore IconItem in QML is ready?
> I am trying to use the grabToImage for that element and the only way
> to achieve this until now, is after Component.OnCompleted to use a
> timer element.
>
> I
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in log.cpp:137
> It's one QLockFile line...
Edit: Some googling suggests this is fine as-is.
O_APPEND writes are atomic on local filesystems, and will lock between updating
the offset and the end of the write.
Hello,
is it possible to know when a PlasmaCore IconItem in QML is ready?
I am trying to use the grabToImage for that element and the only way
to achieve this until now, is after Component.OnCompleted to use a
timer element.
I use a shadereffect to drop a shadow under various IconItems and
after
davidedmundson added inline comments.
INLINE COMMENTS
> sebas wrote in log.cpp:46
> No threads in libkscreen. It'll probably blow up in many other cases already.
It doesn't matter if there are threads *in* kscreen.
The question is: Can a kscreen class be used *in* another thread by $app.
>
sebas added inline comments.
INLINE COMMENTS
> bshah wrote in testlog.cpp:88
> nitpick - cAPs. ;-)
It's a test, this way it covers strange capitalization. :)
> davidedmundson wrote in log.cpp:46
> Question:
> What's the threading policy on libkscreen?
>
> This isn't reentrant (which might be
davidedmundson added inline comments.
INLINE COMMENTS
> log.cpp:30
> +Log* Log::sInstance = nullptr;
> +QtMessageHandler sDefaultMessageHandler = nullptr;
> +
why have it separate instead of a member of log?
> log.cpp:35
> +QByteArray localMsg = msg.toLocal8Bit();
> +if
>
bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added a comment.
This revision is now accepted and ready to land.
Apart from d_ed's comment looks good, perhaps you can change to ecm macro in
different revision...
REPOSITORY
rKSCREEN KScreen
BRANCH
sebas/kcmcatlogging
bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> testlog.cpp:88
> +qputenv(KSCREEN_LOGFILE, logfile);
> +qputenv(KSCREEN_LOGGING, QByteArray("faLSe"));
> +
nitpick - cAPs. ;-)
colomar added a comment.
Is the feedback only played when there is no other source playing?
If not, it should be done like that. If you already have something playing,
it's just annoying to play an additional sound, and does not provide any
additional info because you notice how loud
sebas added a comment.
Can we expect canberra to be available everywhere PA is?
It seems that it's just playing a short ticking sound, perhaps we can avoid
the dependency easily?
REPOSITORY
rPLASMAPA Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D2219
sebas added inline comments.
INLINE COMMENTS
> addwidgetsrunner.cpp:126
> +
> +const QPoint cursorPos = QCursor::pos();
> +const QString script = scriptTemplate.arg(QString::number(cursorPos.x()),
Have you tested if this works on Wayland? (It probably won't, which means the
widget ends
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/285/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 28 Jul 2016 09:57:46 +
Build duration: 12 min
CHANGE SET
Revision
mart added reviewers: ivan, garg.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2298
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, ivan, garg
Cc: plasma-devel, jensreuterberg, abetts, sebas
sebas added inline comments.
INLINE COMMENTS
> davidedmundson wrote in debug.h:25
> There's a CMake macro for all this file.
That's how it's done for the other components in this repo as well, so I went
for that same solution here as well.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
davidedmundson added inline comments.
INLINE COMMENTS
> debug.h:25
> +
> +Q_DECLARE_LOGGING_CATEGORY(KSCREEN_KCM)
> +
There's a CMake macro for all this file.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2294
EMAIL PREFERENCES
On donderdag 28 juli 2016 01:18:00 CEST David Kahles wrote:
> I think the problem with this approach is, that most (or even all?) of
> these processes aren't units but simple processes.
> A better approach using the power of journald would be something like:
>
> journalctl -b --user
On woensdag 27 juli 2016 13:45:14 CEST Martin Klapetek wrote:
> On Wed, Jul 27, 2016 at 7:35 AM, Sebastian Kügler wrote:
>
> On dinsdag 26 juli 2016 19:44:11 CEST Martin Klapetek wrote:
> > On Tue, Jul 26, 2016 at 8:03 AM, Sebastian Kügler wrote:
> >
> > What do
On Tue, Jul 26, 2016 at 03:56:21PM +0200, Antonio Larrosa wrote:
> This mean bringing forward some kde release dates and postponing some
> opensuse pre-releases to make everything fit tightly.
>
> 2016-09-01: openSUSE 42.2 Beta 1 (this would include the last Plasma
> release available at that
Ivan a écrit :
The one that stands out for me is one of the Kver's mesh-ups. The one
with a part of the current plasma logo '>' inside two pieces of a
gear.
The reason I find that one interesting is that we could use a part of
it for the launcher icon if we wanted - just the '>'.
We could
Hello,
As you know, a few weeks ago openSUSE kde packagers were delighted to
know that Plasma 5.8 would be a LTS release. Let me begin by saying
that's really important for us that Plasma has a LTS release (and I
don't know if I'm saying that with my KDE hat or my SUSE hat, since I
think it
On Mon, Jul 25, 2016 at 9:01 PM, Raphael Hertzog wrote:
> d = desktops()
>
> for (i in d) {
> d[i].wallpaperPlugin = 'org.kde.image'
> d[i].currentConfigGroup = Array('Wallpaper', 'org.kde.image',
> 'General')
> d[i].writeConfig('Image',
>
Hello Raphael
On Mon, Jul 25, 2016 at 09:01:25PM +0200, Raphael Hertzog wrote:
> Hello,
>
> I'm a Debian developer trying to fix the plasma integration with default
> artwork
> in Debian (https://bugs.debian.org/831730). I noticed recently that a plasma
> install did not have the expected
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97884
---
Ship it!
Ship It!
- Painless Roaster
On Čec. 13, 2016,
47 matches
Mail list logo