[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

sebas updated this revision to Diff 5988. sebas added a comment. - constness REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2465?vs=5987=5988 BRANCH sebas/lidopeninit REVISION DETAIL https://phabricator.kde.org/D2465 AFFECTED FILES

[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

sebas updated this revision to Diff 5987. sebas added a comment. - --unused vars REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2465?vs=5986=5987 BRANCH sebas/lidopeninit REVISION DETAIL https://phabricator.kde.org/D2465 AFFECTED FILES

[Differential] [Request, 109 lines] D2465: [kded] correctly restore lidOpened configuration on startup

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When shutting down the machine (or kded5, really) with the lid closed will leave a config with the laptop

Review Request 128702: Use default weight rather than normal weight

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128702/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

> On Aug. 16, 2016, 7:48 p.m., Marco Martin wrote: > > I like it! > > (btw, the blurred version wouldn't be needed anymore with the new design) I meant to ask because I read something about this, and I can't for the life of me find the blog post about it; Do both the lock screen and the login

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

https://bugs.kde.org/show_bug.cgi?id=366608 --- Comment #10 from Matthias Fauconneau --- 1) Works for me with Brightness Up (F7), Volume Down (F9) and Up (F10). But strangely Brightness Down (F6) still does not repeat. I see no difference between the keys

Re: Help needed - Discussion concerning panels

the panel can expose a size hint, but it's the user that decides what is the wiggle room of it. if on the panel controller you put with the handles a very small minimum size and a big maximum size, then the panel should be able to resize itself within those limits Let's say that the panel is at

Re: Help needed - Discussion concerning panels

On Wednesday 17 August 2016 00:13:08 Michail Vourlakos wrote: > 1. This panel should be able to set its size(width and height) according > to the visual which is shown. I tried, > > Layout.*widths and Layout.*heights to set them in a fixed size but > nothing happened. > > Is it possible to do

Help needed - Discussion concerning panels

Hello everyone, I have some questions concerning plasma panels and I hope you could help. A small brief, I implemented the Now Dock plasmoid which can be found in kdelook. There is a discussion that this should be a panel of its one. In other words not (in panel) but a panel. I changed the

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

https://bugs.kde.org/show_bug.cgi?id=362830 --- Comment #1 from Pascal d'Hermilly --- yes/no ? -- You are receiving this mail because: You are the assignee for the bug.

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/#review98416 --- I like it! (btw, the blurred version wouldn't be needed

Re: [PATCH 6/7] add kirigami icons as resource

did some comments inline but would be better if this was done in phabricator On Tuesday 16 August 2016 20:23:51 Martin Gysel wrote: > alias="icons/document-decrypt.svg">breeze-icons/icons/actions/32/document-d > ecrypt.svg +

Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/ --- Review request for Plasma. Repository: breeze Description --- New

Re: more Kirigami patches

On Tuesday 16 August 2016 20:42:46 Martin Gysel wrote: > Hi Marco > The last time I sent patches, I quickly looked into getting a dev > account but it seemed like quite an effort (in regards to the > contributions I've done so far) and also if I understood it correctly > once I have a dev account

Re: more Kirigami patches

Am 16.08.2016 um 20:28 schrieb Marco Martin: > On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote: >> Hi >> Here are some patches I have in my branch. >> It contains a script to (re)generate the qml file, one the generate a >> resource file with possibly used icons and one to generaste a

Re: more Kirigami patches

On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote: > Hi > Here are some patches I have in my branch. > It contains a script to (re)generate the qml file, one the generate a > resource file with possibly used icons and one to generaste a qmltypes file. > It adds the icon resource to the pri

more Kirigami patches

Hi Here are some patches I have in my branch. It contains a script to (re)generate the qml file, one the generate a resource file with possibly used icons and one to generaste a qmltypes file. It adds the icon resource to the pri file and updates the qml resource file. Furthermore the library

[PATCH 3/7] add script to gen a qmltypes file

--- scripts/gen_qmltypes.sh | 17 + 1 file changed, 17 insertions(+) create mode 100755 scripts/gen_qmltypes.sh diff --git a/scripts/gen_qmltypes.sh b/scripts/gen_qmltypes.sh new file mode 100755 index 000..4ea0bc7 --- /dev/null +++ b/scripts/gen_qmltypes.sh @@ -0,0 +1,17 @@

[PATCH 5/7] fix target/library path in qmake project file

--- kirigami.pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kirigami.pro b/kirigami.pro index f7d6fe6..735376d 100644 --- a/kirigami.pro +++ b/kirigami.pro @@ -7,7 +7,7 @@ SOURCES += $$PWD/src/kirigamiplugin.cpp $$PWD/src/enums.cpp API_VER=1.0 -TARGET =

[PATCH 7/7] update qml resource file

--- kirigami.qrc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kirigami.qrc b/kirigami.qrc index 63d64ac..fe4400f 100644 --- a/kirigami.qrc +++ b/kirigami.qrc @@ -7,12 +7,13 @@ src/controls/AbstractListItem.qml src/controls/SplitDrawer.qml

[PATCH 6/7] add kirigami icons as resource

--- kirigami-icons.qrc | 13 + kirigami.pri | 1 + 2 files changed, 14 insertions(+) create mode 100644 kirigami-icons.qrc diff --git a/kirigami-icons.qrc b/kirigami-icons.qrc new file mode 100644 index 000..7f3ffa9 --- /dev/null +++ b/kirigami-icons.qrc @@ -0,0 +1,13 @@

[PATCH 2/7] add script to find possible used icons in kirigami

--- scripts/gen_icons_qrc.sh | 59 1 file changed, 59 insertions(+) create mode 100755 scripts/gen_icons_qrc.sh diff --git a/scripts/gen_icons_qrc.sh b/scripts/gen_icons_qrc.sh new file mode 100755 index 000..dff68df --- /dev/null +++

[PATCH 4/7] improve kirigami dir detection

--- scripts/gen_icons_qrc.sh | 2 +- scripts/gen_qml_qrc.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gen_icons_qrc.sh b/scripts/gen_icons_qrc.sh index dff68df..164b807 100755 --- a/scripts/gen_icons_qrc.sh +++ b/scripts/gen_icons_qrc.sh @@ -5,7 +5,7 @@

[PATCH 1/7] add simple script to generate a qrc containing all qml files

--- scripts/gen_qml_qrc.sh | 39 +++ 1 file changed, 39 insertions(+) create mode 100755 scripts/gen_qml_qrc.sh diff --git a/scripts/gen_qml_qrc.sh b/scripts/gen_qml_qrc.sh new file mode 100755 index 000..6e1c378 --- /dev/null +++ b/scripts/gen_qml_qrc.sh

[Differential] [Request, 442 lines] D2464: [effects] Add new effect for touch point visualization

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, bshah. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The new effect is based on the mouse click effect and uses

[Differential] [Updated, 1,363 lines] D2449: small utility to create L packages

mart updated this revision to Diff 5983. mart added a comment. - take into account different config key REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2449?vs=5978=5983 BRANCH mart/lookandfeelexplorer REVISION DETAIL

[Differential] [Commented On] D2449: small utility to create L packages

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in lnflogic.cpp:155 > Edit: This kwin saving stuff is *still* wrong. > > In systemCG (kwinrc) it is "TabBox". > However, in the LnF it is "WindowSwitcher." > > You "fixed" the wrong one. > > You are also missing

[Differential] [Requested Changes To] D2449: small utility to create L packages

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidedmundson wrote in lnflogic.cpp:155 > That's the wrong group name. > It should be TabBox. > > (and if this is copy pastad from

Re: Kirigami patches

On Tuesday 16 August 2016, Dirk Hohndel wrote: > > ah, if what you have now works, then that's fine :) > > was something to try if it wasn't working yet :) > > So here are the kirigami patches that I now use. The last one I don't thanks, I'll take a look at all of them > think you want to take.

Re: Kirigami patches

On Tue, Aug 16, 2016 at 03:48:49PM +0200, Marco Martin wrote: > On Tuesday 16 August 2016, Dirk Hohndel wrote: > > Just to make sure I understand this correctly... You are suggesting that I > > shouldn't build Kirigami as a separate library, but that I should include > > the kirigami.pri file from

[Differential] [Accepted] D2449: small utility to create L packages

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK BRANCH mart/lookandfeelexplorer REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Kirigami patches

> On Aug 16, 2016, at 6:48 AM, Marco Martin wrote: > > On Tuesday 16 August 2016, Dirk Hohndel wrote: >> Just to make sure I understand this correctly... You are suggesting that I >> shouldn't build Kirigami as a separate library, but that I should include >> the kirigami.pri

[Differential] [Updated, 372 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 5980. mart added a comment. - prototype for support of per-looknfeel layout - monitor for file creation - delete views and arrays in the proper order - be silent - prototype of JS config dump - more complete config js dumper - generic kconfiggroup

[Differential] [Reopened] D2345: use a separate configuration per look and feel

mart reopened this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: graesslin, davidedmundson, ivan, plasma-devel,

[Differential] [Closed] D2345: use a separate configuration per look and feel

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd2f0ec63c60b: methods to switch lnf (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2345?vs=5927=5979#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES

Re: Kirigami patches

On Tuesday 16 August 2016, Dirk Hohndel wrote: > Just to make sure I understand this correctly... You are suggesting that I > shouldn't build Kirigami as a separate library, but that I should include > the kirigami.pri file from the Subsurface-mobile.pro file? And I assume > that i then don't need

Re: Kirigami patches

-- Sent from my phone On August 16, 2016 5:59:06 AM PDT, Marco Martin wrote: >On Tuesday 16 August 2016, Tomaz Canabrava wrote: >> > > - use the .pri file when directly linking in kirigami into the >(parent) >> > > project (include directive in PROJECT.pro), then the

Binding loop in AppletConfiguration.qml

Hello everyone, there is a binding loop in the AppletConfiguration.qml in org.kde.plasma.desktop/contents/configuration/ and it influences all the configuration dialogs of applets. Is it important? It is found in lines 163,164 --- width: categoriesScroll.viewport.width height:

[Differential] [Updated, 1,361 lines] D2449: small utility to create L packages

mart updated this revision to Diff 5978. mart added a comment. - use deleteLater REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2449?vs=5976=5978 BRANCH mart/lookandfeelexplorer REVISION DETAIL https://phabricator.kde.org/D2449 AFFECTED

Re: Kirigami patches

On Tuesday 16 August 2016, Tomaz Canabrava wrote: > > > - use the .pri file when directly linking in kirigami into the (parent) > > > project (include directive in PROJECT.pro), then the Q_INIT_RESOURCE is > > > not necessary. using qmake this seems to be the easiest way and at > > > least seems

[Differential] [Requested Changes To] D2449: small utility to create L packages

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > lnflogic.cpp:92 > emit messageRequested(ErrorLevel::Error, i18n("Cannot retrieve > the current Plasma layout.")); > +

Re: Kirigami patches

Subsue Em 16 de ago de 2016 04:43, "Marco Martin" escreveu: > > On Tuesday 16 August 2016, Martin Gysel wrote: > > Am 16.08.2016 um 01:55 schrieb Dirk Hohndel: > > > It's pretty clear that no one ever tested the kirigami.pro qmake file. > > > The second patch I'm not 100% sure

[Differential] [Closed] D2450: Add support for touch events in the Effect system

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN6af0cc6ebe67: Add support for touch events in the Effect system (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2450?vs=5934=5977 REVISION

[Differential] [Commented On] D2462: Remove deprecated code in kscreenlocker theme

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in LockScreen.qml:32 > It's in the original commit message that got hidden. > > This code existed in case you ran the new theme with an old plasma. > > Useful for a while but it doesn't make sense to keep that forever. >

[Differential] [Commented On] D2462: Remove deprecated code in kscreenlocker theme

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in LockScreen.qml:32 > this change I don't understand. It's not described in the change. It's in the original commit message that got hidden. This code existed in case you ran the new theme with an old plasma. Useful for

[Differential] [Changed Subscribers] D2462: Remove deprecated code in kscreenlocker theme

mart added inline comments. INLINE COMMENTS > graesslin wrote in LockScreen.qml:32 > this change I don't understand. It's not described in the change. is that a context property? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2462 EMAIL

[Differential] [Commented On] D2455: Use new inline revealpassword action

davidedmundson added a comment. > phabricator closes the review when commits on a relevant branch is done... for no reason Yeah, but Kai's commit is even in a different repository. Makes even less sense. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Commented On] D2455: Use new inline revealpassword action

mart added a comment. In https://phabricator.kde.org/D2455#45873, @davidedmundson wrote: > what on Earth is phab doing? > Kai's commit doesn't close this at all. phabricator closes the review when commits on a relevant branch is done... for no reason REPOSITORY

[Differential] [Updated, 1,361 lines] D2449: small utility to create L packages

mart updated this revision to Diff 5976. mart added a comment. - prototype of basic editor for lookandfeel packages - correctly list look and feel packages - make the theme list a simple list - load theme name in textbox - complete metadata editor - sic creation (of an empty theme)

[Differential] [Reopened] D2449: small utility to create L packages

mart reopened this revision. REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Closed] D2449: small utility to create L packages

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKdbc63d9b5de0: remove some leaks (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2449?vs=5974=5975#toc REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE

[Differential] [Updated, 1,367 lines] D2449: small utility to create L packages

mart updated this revision to Diff 5974. mart added a comment. - remove some leaks REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2449?vs=5953=5974 BRANCH mart/lookandfeelexplorer REVISION DETAIL https://phabricator.kde.org/D2449 AFFECTED

[Differential] [Requested Changes To] D2462: Remove deprecated code in kscreenlocker theme

graesslin requested changes to this revision. graesslin added a reviewer: graesslin. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > LockScreen.qml:32 > property UserSelect userSelect: null > -property int interfaceVersion: >

[Differential] [Commented On] D2449: small utility to create L packages

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.cpp:70 > UncreatableType * 2 I think in this case it's betterthis form, as i don't want to give an url to it, i just want properties of those instances to be readable REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL

[Differential] [Request, 9 lines] D2462: Remove deprecated code in kscreenlocker theme

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove now deprecated logic for lockscreen theme working on old Plasma remove unused

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

> On Aug. 16, 2016, 7:05 vorm., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 51 > > > > > > Well, qt5-webkit and kwebkitpart do still exist. They're just not > > really maintained (but

[Differential] [Requested Changes To] D2449: small utility to create L packages

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > lnflogic.cpp:85 > + > +QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(pcall, > this); > + leaks > lnflogic.cpp:155 > +

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

> On Aug. 16, 2016, 2:27 a.m., Anthony Fieroni wrote: > > Ping. For 5.7.4 > > Martin Gräßlin wrote: > For master the focus in is removed. And I think that's absolutely no > stable branch material. It looks like this is also fixed with Qt 5.6 branch, see commit

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

> On Aug. 16, 2016, 4:27 a.m., Anthony Fieroni wrote: > > Ping. For 5.7.4 For master the focus in is removed. And I think that's absolutely no stable branch material. - Martin --- This is an automatically generated e-mail. To reply,

[Differential] [Closed] D2399: New new SDDM theme

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE2c868c438033: New new SDDM theme (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2399?vs=5818=5968#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Accepted] D2399: New new SDDM theme

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. to me is ok (if is good design-wise for vdg) my only comment is wether is possible to make the faces avoiding the custom shader, but is not super important

Re: Kirigami patches

On Tuesday 16 August 2016, Martin Gysel wrote: > Am 16.08.2016 um 01:55 schrieb Dirk Hohndel: > > It's pretty clear that no one ever tested the kirigami.pro qmake file. > > The second patch I'm not 100% sure about, but it seems to match what the > > documentation tells us SHOULD be done. > >

Re: Kirigami patches

On Tuesday 16 August 2016, Dirk Hohndel wrote: > It's pretty clear that no one ever tested the kirigami.pro qmake file. The > second patch I'm not 100% sure about, but it seems to match what the > documentation tells us SHOULD be done. because with the pro it was supposed to build the dynamic

Re: Review Request 128685: Proofread + update performance kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/#review98410 --- Ship it! Can you move it to kde-baseapps, along with any

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128684/#review98408 --- doc/kcontrol/khtml-general/index.docbook (line 7)

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

dfaure added a comment. Yes, and yes. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2365 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, graesslin, dfaure Cc:

Branch inconsistencies

kde-build-metadata/logical-module-structure points to Plasma/5.7 for kaccounts-mobile and plasma-tests, where that branch doesn't exist. -- Forwarded Message -- Subject: Cron ~/bin/update_kf5.sh Date: lundi 15 août 2016, 12:58:01 CEST From: Cron Daemon

Re: Kirigami patches

Am 16.08.2016 um 01:55 schrieb Dirk Hohndel: > It's pretty clear that no one ever tested the kirigami.pro qmake file. The > second patch I'm not 100% sure about, but it seems to match what the > documentation tells us SHOULD be done. maybe my understanding of the qt build system, tools and