[Differential] [Abandoned] D2306: Make it possible to provide a page header to ScrollablePage

2016-08-23 Thread apol (Aleix Pol Gonzalez)
apol abandoned this revision. apol added a comment. Too specific to Discover. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2306 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel

[Differential] [Updated] D1075: Display mouse image in mouse kcm properly on highdpi screen

2016-08-23 Thread apol (Aleix Pol Gonzalez)
apol added a comment. Should we close this review? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1075 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, broulik, apol Cc: plasma-devel, lesliezhai,

[Differential] [Closed] D2418: Drop the C++ text label implementation.

2016-08-23 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP6c3b01c52f4a: Drop the C++ text label implementation. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2418?vs=5855=6201#toc REPOSITORY rPLASMADESKTOP Plasma

[Differential] [Commented On] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

2016-08-23 Thread hein (Eike Hein)
hein added a comment. After these changes tooltips no longer have consistent heights e.g. between a window group and a single-window tooltip, which together with rendering bugs in the tooltip morphing effect makes for a horrible UX. Can you revisit this? REPOSITORY rPLASMADESKTOP Plasma

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-08-23 Thread Eike Hein
> On July 28, 2016, 6:02 a.m., Painless Roaster wrote: > > Ship It! Do you need someone to commit this for you? - Eike --- This is an automatically generated e-mail. To reply, visit:

Plasma 5.7.4 is out

2016-08-23 Thread David Edmundson
https://www.kde.org/announcements/plasma-5.7.4.php Regards David

Review Request 128741: Update paths docbook

2016-08-23 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128741/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

[Differential] [Closed] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP19368a430cc1: add a preview button and a fullscreen preview (authored by mart). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH phab/preview REVISION DETAIL https://phabricator.kde.org/D2550 EMAIL PREFERENCES

[Differential] [Updated, 53 lines] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread mart (Marco Martin)
mart updated this revision to Diff 6196. mart added a comment. - remove hasdefaultlayoutrole REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2550?vs=6194=6196 BRANCH phab/preview REVISION DETAIL https://phabricator.kde.org/D2550

[Differential] [Commented On] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.h:55 > this seems like a different change ah, right, i dropped the part about HasDefaultLayoutRole, will remove > davidedmundson wrote in main.qml:145 > Why the Plasma one? Everything else is QQC in this file? as

[Differential] [Changed Subscribers] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > kcm.h:55 > +FullScreenPreviewRole, > +HasDefaultLayoutRole, > HasSplashRole, this seems like a different change > main.qml:145 > } > +

[Differential] [Commented On] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread mart (Marco Martin)
mart added a comment. F267238: dadel.png F267240: dadel1.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2550 EMAIL PREFERENCES

[Differential] [Commented On] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread mart (Marco Martin)
mart added a comment. overlaying a theme with preview: http://imgur.com/a/FVXDH preview: http://imgur.com/a/LhBjw REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2550 EMAIL PREFERENCES

[Differential] [Updated] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread mart (Marco Martin)
mart added a reviewer: Plasma. mart added a project: VDG. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 54 lines] D2550: add a preview button and a fullscreen preview

2016-08-23 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY preview button for themes, launches a fullscreen preview for the theme the preview image is shown as big as possible, either 1:1 or scaled

[Differential] [Closed] D2548: [Lock Screen] Drop pointless argument

2016-08-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE607bdc4939ca: [Lock Screen] Drop pointless argument (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2549: Deleting the about dialog when it gets closed

2016-08-23 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3c2604059aec: Deleting the about dialog when it gets closed (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2549: Deleting the about dialog when it gets closed

2016-08-23 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2549 EMAIL PREFERENCES

[Differential] [Accepted] D2548: [Lock Screen] Drop pointless argument

2016-08-23 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2548 EMAIL PREFERENCES

[Differential] [Updated, 44 lines] D2531: Warp the xcb pointer whenever pointer leaves an X11 surface

2016-08-23 Thread Martin Gräßlin
graesslin updated this revision to Diff 6191. graesslin added a comment. Remove the QEXPECT_FAIL from test case REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2531?vs=6190=6191 BRANCH warp-x11-pointer-on-surface-leave REVISION DETAIL

[Differential] [Accepted] D2531: Warp the xcb pointer whenever pointer leaves an X11 surface

2016-08-23 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Has been running it from start of day, and seems to fix the issue.. REPOSITORY rKWIN KWin BRANCH warp-x11-pointer-on-surface-leave REVISION DETAIL https://phabricator.kde.org/D2531

[Differential] [Updated, 43 lines] D2531: Warp the xcb pointer whenever pointer leaves an X11 surface

2016-08-23 Thread Martin Gräßlin
graesslin updated this revision to Diff 6190. graesslin added a comment. Added a version check to only do the warping if we don't have 1.19 REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2531?vs=6151=6190 BRANCH warp-x11-pointer-on-surface-leave REVISION

[Differential] [Request, 1 line] D2549: Deleting the about dialog when it gets closed

2016-08-23 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We are providing the parent if it is a QWidget, but still, there is no need to have this window remain in

[Differential] [Request, 2 lines] D2548: [Lock Screen] Drop pointless argument

2016-08-23 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The function doesn't use

Re: Selecting a Plasma logo

2016-08-23 Thread Clemens Toennies
On Monday 22 August 2016, Thomas Pfeiffer wrote: >/As per the Plasma team's request, I have now created a Wiki page with all />/submissions as presented in the forum, and - where available - how they

Jenkins-kde-ci: khotkeys Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 8 - Failure!

2016-08-23 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 23 Aug 2016 11:33:37 + Build duration: 2 min 12 sec CHANGE SET Revision

[Differential] [Closed] D2535: [Applet Alternatives] Enable LayoutMirroring

2016-08-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP940c2c56e61f: [Applet Alternatives] Enable LayoutMirroring (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2532: [Panel Containment] Fix re-arranging applets in right-to-left mode

2016-08-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPdba7d002d0f2: [Panel Containment] Fix re-arranging applets in right-to-left mode (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2540: [Desktop Toolbox] Enable LayoutMirroring

2016-08-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPdf7f8f636079: [Desktop Toolbox] Enable LayoutMirroring (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2536: [System Tray] Take into account right-to-left layout when placing tooltips

2016-08-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd33ddf1b9977: [System Tray] Take into account right-to-left layout when placing tooltips (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D2500: [Plasmashell] Unload "Scale in Desktop" effect when started

2016-08-23 Thread broulik (Kai Uwe Broulik)
broulik abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2500 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Abandoned] D2487: Simpler KSplash design

2016-08-23 Thread broulik (Kai Uwe Broulik)
broulik abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2487 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: mart, plasma-devel, lesliezhai,

[Differential] [Closed] D2542: Simplify code

2016-08-23 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI892d33e067ba: Simplify code (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2542?vs=6167=6180 REVISION DETAIL

[Differential] [Updated] D2524: New User Switcher

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a project: VDG. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D2523: New lockscreen

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Please tag all diffs with UI changes with VDG to make sure we learn about them. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D2523: New lockscreen

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a project: VDG. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Closed] D2523: New lockscreen

2016-08-23 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEcf87b9a1bf97: Summary: New lockscreen (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2524: New User Switcher

2016-08-23 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE62b77678b1a6: New User Switcher (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2524?vs=6131=6179

[Differential] [Accepted] D2523: New lockscreen

2016-08-23 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH login_refactor2 REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES

[Differential] [Updated, 818 lines] D2523: New lockscreen

2016-08-23 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 6177. davidedmundson added a comment. Fixed comment about linking to Qt bug report Changed keyboard layout button back into click to change I can make it a custom menu afterwards. - Change comment for bug report - Restore click to

[Differential] [Commented On] D2544: Move logic for services autostart from klauncher to ksmserver

2016-08-23 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Seems startplasma (invoked by kwin_wayland) starts it. startplasma:146 kwrapper5 @CMAKE_INSTALL_FULL_BINDIR@/ksmserver $KDEWM $KSMSERVEROPTIONS and even if it does move to someplace else you'd have to move the current code that invokes

[Differential] [Commented On] D2531: Warp the xcb pointer whenever pointer leaves an X11 surface

2016-08-23 Thread Martin Gräßlin
graesslin added a comment. The problem will be fixed in Xwayland 1.19, see https://bugs.freedesktop.org/show_bug.cgi?id=96437 I would suggest to nevertheless integrate it till 1.19 is released. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2531 EMAIL

[Differential] [Commented On] D2544: Move logic for services autostart from klauncher to ksmserver

2016-08-23 Thread mart (Marco Martin)
mart added a comment. wouldn't this need to be done all over again in wayland as there wouldn't be ksmserver anymore? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2544 EMAIL PREFERENCES

[Differential] [Accepted] D2542: Simplify code

2016-08-23 Thread mart (Marco Martin)
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kirigamiplugin.h:85 > { > -#ifdef Q_OS_WIN > -// On Windows, the leading slash does not make sense, so let's snip > that off > -return

Re: Selecting a Plasma logo

2016-08-23 Thread Ivan Čukić
On Tue, Aug 23, 2016 at 1:22 AM, Thomas Pfeiffer > Yes, this is indeed a problem. Originally we were looking for a logo, > but we don't think that a logo which is not visible anywhere in the > desktop itself has much of a chance of actually becoming recognized. I agree. But if we had planned

[Differential] [Request, 316 lines] D2544: Move logic for services autostart from klauncher to ksmserver

2016-08-23 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently ksmserver sends DBus calls to klauncher to autostart services. This patch

[Differential] [Commented On] D2543: Set transientParent window for file dialog

2016-08-23 Thread lepagevalleeemmanuel (Emmanuel Lepage Vallee)
lepagevalleeemmanuel added a comment. This change is working, thanks! REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2543 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: