Re: Review Request 128808: workspace option kcm rename to tooltip

2016-08-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128808/#review98811 --- -1 I was actually planning to add some workspace options

Review Request 128808: workspace option kcm rename to tooltip

2016-08-31 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128808/ --- Review request for Plasma, KDE Usability and Heiko Tietze. Repository:

Re: Review Request 128727: Cursor KCM: fix icon size for the select icon size button

2016-08-31 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128727/ --- (Updated Aug. 31, 2016, 8:44 p.m.) Status -- This change has been

[Breeze] [Bug 368048] Very strange QLineEdit inside QMenu glitch under extreemly specific conditions

2016-08-31 Thread Christoph Feck via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368048 Christoph Feck changed: What|Removed |Added Assignee|plasma-devel@kde.org|hugo.pereira.da.costa@gmail

[Differential] [Request, 23 lines] D2636: Remove non visible internal windows from the x stacking order

2016-08-31 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY KWin always has a few internal windows around which are not

[Differential] [Request, 2 lines] D2635: [Panel Containment] Don't shift contents out of view for vertical panel in right-to-left layout

2016-08-31 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We took into account the

Re: Review Request 128707: Add support for captive portals

2016-08-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98809 --- I just logged into an airport wifi and although I couldn't

[Differential] [Closed] D2543: Set transientParent window for file dialog

2016-08-31 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATION4a50ee3212d7: Set transientParent window for file dialog (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

[Differential] [Updated, 116 lines] D2630: Support highlighting windows through EffectsHandlerImpl

2016-08-31 Thread Martin Gräßlin
graesslin updated this revision to Diff 6388. graesslin added a comment. s/performFeature/perform REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2630?vs=6385=6388 BRANCH highlight-windows-through-effects REVISION DETAIL

[Differential] [Closed] D2627: Set the restore geometry after placing a ShellClient for the first time

2016-08-31 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINd3741bd530cd: Set the restore geometry after placing a ShellClient for the first time (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2630: Support highlighting windows through EffectsHandlerImpl

2016-08-31 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > kwineffects.h:496 > + **/ > +virtual bool performFeature(Feature feature, const QVariantList > ); > + maybe only "perform" (and have the signature fill in the information), but in general a much better solution ;-) REPOSITORY rKWIN

[Differential] [Updated, 116 lines] D2630: Support highlighting windows through EffectsHandlerImpl

2016-08-31 Thread Martin Gräßlin
graesslin updated this revision to Diff 6385. graesslin added a comment. Added a Effect::performFeature(Feature, QVariantList) to not do magic invokation REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2630?vs=6371=6385 BRANCH

[Differential] [Commented On] D2630: Support highlighting windows through EffectsHandlerImpl

2016-08-31 Thread Thomas Lübking
luebking added a comment. You could expose the relevant method index, but looking up the signature is more elegant (and this isn't a hot call) REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2630 EMAIL PREFERENCES

[Differential] [Accepted] D2627: Set the restore geometry after placing a ShellClient for the first time

2016-08-31 Thread Thomas Lübking
luebking accepted this revision. luebking added a reviewer: luebking. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH geometry-restore-after-placement REVISION DETAIL https://phabricator.kde.org/D2627 EMAIL PREFERENCES

[Differential] [Commented On] D2630: Support highlighting windows through EffectsHandlerImpl

2016-08-31 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > luebking wrote in effects.cpp:1560 > Errr... wut? > Any reason to not *demand* some sort of soft API (slot signature) instead of > digging for the next best thing that remotely looks like the right thing? > > Maybe provide hard API like

[Differential] [Updated, 16 lines] D2627: Set the restore geometry after placing a ShellClient for the first time

2016-08-31 Thread Martin Gräßlin
graesslin updated this revision to Diff 6383. graesslin added a comment. Add a ShellClient::placeIn(QRect&) to provide the logic REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2627?vs=6367=6383 BRANCH geometry-restore-after-placement REVISION DETAIL

[Breeze] [Bug 368048] Very strange QLineEdit inside QMenu glitch under extreemly specific conditions

2016-08-31 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368048 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED

[Breeze] [Bug 368048] Very strange QLineEdit inside QMenu glitch under extreemly specific conditions

2016-08-31 Thread Alex Maystrenko via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368048 --- Comment #2 from Alex Maystrenko --- In console I see QXcbConnection: XCB error: 8 (BadMatch) -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 368048] Very strange QLineEdit inside QMenu glitch under extreemly specific conditions

2016-08-31 Thread Alex Maystrenko via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368048 --- Comment #1 from Alex Maystrenko --- Screenshot with a glitch https://github.com/technic/qt5-bug/blob/master/bug.png -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 368048] New: Very strange QLineEdit inside QMenu glitch under extreemly specific conditions

2016-08-31 Thread Alex Maystrenko via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368048 Bug ID: 368048 Summary: Very strange QLineEdit inside QMenu glitch under extreemly specific conditions Product: Breeze Version: 5.7.3 Platform: Archlinux Packages

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-08-31 Thread Painless Roaster
> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? > > Painless Roaster wrote: > I do not have an account on github. > > Eike Hein wrote: > Thanks, I'll see about getting this in next week. > >

Re: Review Request 128802: task bar lines

2016-08-31 Thread Andreas Kainz
> On Aug. 30, 2016, 10:57 nachm., Eike Hein wrote: > > Tech-wise I have no objections, the SVG looks clean. > > > > Design-wise I'm conflicted. Unlike the old implementation of the lines, > > this time no attempt was made to vert-center the content in the remaining > > negative space. This

[ksysguard] [Bug 361281] migrate away from qtwebkit (gui)

2016-08-31 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361281 --- Comment #2 from Martin Gräßlin --- KSysguard is a workspace component. As long as https://bugreports.qt.io/browse/QTBUG-55384 is not fixed we should not port any workspace component to WebEngine. -- You are receiving this mail