[Differential] [Accepted] D2751: Fix interaction between decoration and fullscreen ShellClient

bshah accepted this revision. REPOSITORY rKWIN KWin BRANCH fullscreen-no-deco REVISION DETAIL https://phabricator.kde.org/D2751 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas, bshah, #kwin Cc: plasma-devel, kwin,

[Differential] [Accepted] D2758: Fix updating layer when setting a ShellClient to fullscreen

bshah accepted this revision. REPOSITORY rKWIN KWin BRANCH shell-client-fullscreen-update-layer REVISION DETAIL https://phabricator.kde.org/D2758 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas, bshah, #kwin Cc:

Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128904/ --- Review request for KDE Frameworks and Plasma. Repository:

[Differential] [Request, 26 lines] D2766: More config descriptions

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

> On Sept. 11, 2016, 9:35 p.m., Vishesh Handa wrote: > > This is awesome. Ship it. > > Christoph Cullmann wrote: > Lets hope it is awesome correct. :D - Milian --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128896: Update + proofread Systemsettings docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128896/ --- (Updated Sept. 13, 2016, 9:28 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 332 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/332/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Sep 2016 18:44:21 + Build duration: 25 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 331 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/331/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Sep 2016 18:20:11 + Build duration: 22 min CHANGE SET Revision

[Differential] [Closed] D2764: Use Plasma theme for the system action favorites delegates on the Dash.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP42705743f85e: Use Plasma theme for the system action favorites delegates on the Dash. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2763: Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP72b23f9412e6: Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder… (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2763: Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget.

davidedmundson added inline comments. INLINE COMMENTS > hein wrote in main.xml:81 > I don't know, but if they aren't the tool is not good enough yet since the > XML has the information. they're not currently, but it's something fairly trivial to add that I intend to do now that this has some

[Differential] [Accepted] D2763: Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget.

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2763 EMAIL PREFERENCES

[Differential] [Updated, 81 lines] D2763: Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget.

hein updated this revision to Diff 6705. hein marked 10 inline comments as done. hein added a comment. Various fixes as requested. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2763?vs=6701=6705 BRANCH master REVISION DETAIL

[Differential] [Updated] D2763: Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget.

hein marked 10 inline comments as done. hein added inline comments. INLINE COMMENTS > broulik wrote in main.xml:32 > preferred://, not preview Fixed. > broulik wrote in main.xml:62 > Deppenapostroph ;) This is correct English orthography for pluralizing acronyms and abbreviations, see

[Differential] [Accepted] D2764: Use Plasma theme for the system action favorites delegates on the Dash.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH dashdelegate REVISION DETAIL https://phabricator.kde.org/D2764 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Changed Subscribers] D2763: Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget.

broulik added inline comments. INLINE COMMENTS > main.xml:32 > > + List of general favorites. Supported values are menu id's > (usually .desktop file names), special URLs that expand into default > applications (e.g. preview://browser), document URLs and KPeople contact > URIs. >

[Differential] [Request, 6 lines] D2764: Use Plasma theme for the system action favorites delegates on the Dash.

hein created this revision. hein added reviewers: Plasma, mart. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Matches Kicker menu version. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH dashdelegate REVISION DETAIL

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 330 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/330/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Sep 2016 17:16:37 + Build duration: 22 min CHANGE SET Revision

[Differential] [Closed] D2729: Don't constrain width of Text field on translated text

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf78fbac8ff98: Don't constrain width of Text field on translated text (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2756: Cache system tray applet information

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7cf8115013e6: Cache system tray applet information (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 81 lines] D2763: Config docs for Kicker, Kickoff, Task Manager, Pager, and the Desktop/Folder containment/widget.

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2763 AFFECTED FILES

[Differential] [Accepted] D2756: Cache system tray applet information

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2756 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 329 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/329/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Sep 2016 15:18:11 + Build duration: 34 min CHANGE SET Revision

[Differential] [Updated, 67 lines] D2756: Cache system tray applet information

davidedmundson updated this revision to Diff 6700. davidedmundson added a comment. for REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2756?vs=6684=6700 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2756 AFFECTED

[Differential] [Accepted] D2729: Don't constrain width of Text field on translated text

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2729 EMAIL PREFERENCES

[Differential] [Accepted] D2761: [Window Switcher] Place on the right side for right-to-left languages

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2761 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 128896: Update + proofread Systemsettings docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128896/#review99156 --- Ship it! Ship It! - Marco Martin On Sept. 13, 2016,

[Differential] [Accepted] D2758: Fix updating layer when setting a ShellClient to fullscreen

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH shell-client-fullscreen-update-layer REVISION DETAIL https://phabricator.kde.org/D2758 EMAIL PREFERENCES

[Differential] [Accepted] D2751: Fix interaction between decoration and fullscreen ShellClient

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fullscreen-no-deco REVISION DETAIL https://phabricator.kde.org/D2751 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2748: [effects] Repaint expandedGeometry in HighlightWindowsEffect

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH highlightwindows-proper-repaint REVISION DETAIL https://phabricator.kde.org/D2748 EMAIL PREFERENCES

[Differential] [Accepted] D2743: [server] When replacing the clipboard selection previous DataSource needs to be cancelled

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH cancel-data-source REVISION DETAIL https://phabricator.kde.org/D2743 EMAIL PREFERENCES

[Differential] [Accepted] D2724: Make WindowPixmap::isValid virtual and override in concrete implementation

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH pixmap-valid-override REVISION DETAIL https://phabricator.kde.org/D2724 EMAIL PREFERENCES

[Differential] [Closed] D2742: Simplify Panel lastSpacer + fix crash

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP389aef07d6ad: Simplify Panel lastSpacer + fix crash (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2760: style and high dpi fixes for screen identification OSD

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN535bf03d03a5: style and high dpi fixes for screen identification OSD (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2760?vs=6696=6697

[Differential] [Updated, 69 lines] D2760: style and high dpi fixes for screen identification OSD

sebas updated this revision to Diff 6696. sebas added a comment. - address Kai's comments REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2760?vs=6690=6696 BRANCH sebas/screenid REVISION DETAIL https://phabricator.kde.org/D2760 AFFECTED FILES

[Differential] [Accepted] D2760: style and high dpi fixes for screen identification OSD

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Lgtm. Some nitpicks below. For some reason the right border is smaller than the other ones (has been the case without this patch already), so maybe

[Differential] [Commented On] D2760: style and high dpi fixes for screen identification OSD

sebas added a comment. It would, and I played with it, but: This would need an ARGB window and also fallbacks to opaque components, at that point, we'd be duplicating much of the code in Plasma::Dialog (from plasmaquick). Since this code is hopefully going away for a yet-to-be-designed

Plasma 5.7.5

KDE Plasma 5.7.5 is out with a final set of bug fixes for the 5.7 series https://www.kde.org/announcements/plasma-5.7.5.php https://www.kde.org/announcements/plasma-5.7.4-5.7.5-changelog.php Tars are signed with my new twice as many bits key which was signed by some important KDE people at

[Differential] [Closed] D2584: Introduce a config option whether applications are allowed to block compositing

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN853020336f13: Introduce a config option whether applications are allowed to block compositing (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2584?vs=6680=6693#toc

[Differential] [Closed] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINe8e6e31a876a: [kcmkwin/compositing] Hide config options which don't make sense if Compositing… (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2760: style and high dpi fixes for screen identification OSD

broulik added a comment. Wouldn't a FrameSvg (or even a Plasma Dialog) make this look more plasma-ish? REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2760 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc:

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

graesslin added inline comments. INLINE COMMENTS > sebas wrote in compositing.ui:9 > So your change made the window's minimum width more than 300px wider? That > sounds wrong... > > What I mean is to resize the form in designer to the smallest possible size > before you save it there,

Review Request 128899: xcursor discovery: modernize

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128899/ --- Review request for Plasma. Repository: plasma-desktop Description

[Differential] [Request, 7 lines] D2761: [Window Switcher] Place on the right side for right-to-left languages

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, safaalfulaij. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION

[Differential] [Closed] D2741: [Window Switcher] Cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE49d0e94839f1: [Window Switcher] Cleanup (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2741?vs=6629=6691

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

andreaska added a comment. good idea REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2741 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: andreaska, mart, colomar,

[Differential] [Request, 72 lines] D2760: style and high dpi fixes for screen identification OSD

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - screen identification osd now uses plasma styling, it's workspace thing - simplified the code - made it

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

broulik added a comment. I'd rather not change the fundamental visuals of this thing now. If we were to add a dark gray background to the window thumbnails (which I find a good idea, btw) we should do that consistently everywhere (eg. also in task manager tooltips). As discussed

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/ --- (Updated Sept. 13, 2016, 1:28 p.m.) Status -- This change has been

[Differential] [Closed] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENLOCKER9ab2ce896883: [Screen Locker KCM] Put Wallpaper in a separate tab (authored by broulik). REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/ --- (Updated Sept. 13, 2016, 1:25 p.m.) Review request for Plasma, Aleix Pol

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/#review99153 --- Fix it, then Ship it! Other than that, let's get it in.

Re: Review Request 128897: cursor model: look for cursors in correct place

> On Sept. 13, 2016, 3:05 p.m., Friedrich W. H. Kossebau wrote: > > src/cursorthemesmodel.cpp, line 30 > > > > > > Should these includes not be conditional on whether X11 is found or not? I don't like

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/ --- (Updated Sept. 13, 2016, 1:12 p.m.) Review request for Plasma, Aleix Pol

Re: Review Request 128897: cursor model: look for cursors in correct place

> On Sept. 13, 2016, 12:59 p.m., Aleix Pol Gonzalez wrote: > > src/cursorthemesmodel.cpp, line 53 > > > > > > Xcursor 1.1 seems to be quite old (i.e. more than 10 years), why do we > > need to support it? > >

Re: Review Request 128897: cursor model: look for cursors in correct place

> On Sept. 13, 2016, 1:08 p.m., Aleix Pol Gonzalez wrote: > > src/cursorthemesmodel.cpp, line 47 > > > > > > Why are we calling toSet? to remove duplicates? QStringList has a > > removeDuplicates method that

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/#review99150 --- src/cursorthemesmodel.cpp (line 46)

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/ --- (Updated Sept. 13, 2016, 1:06 p.m.) Review request for Plasma, Aleix Pol

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/#review99149 --- src/cursorthemesmodel.cpp (line 30)

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/#review99147 --- src/cursorthemesmodel.cpp (line 52)

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

luebking added inline comments. INLINE COMMENTS > sebas wrote in compositing.ui:9 > So your change made the window's minimum width more than 300px wider? That > sounds wrong... > > What I mean is to resize the form in designer to the smallest possible size > before you save it there, perhaps

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

andreaska added a comment. F327630: libreoffice.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2741 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

andreaska added a comment. LibreOffice change there background for the document preview from white to gray cause show screenshots from a white paper on a white background, ... the screenshots lose the focus. So is it possible to use the dark background from the dash as background for the

[Differential] [Accepted] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH settings-required-compositing REVISION DETAIL https://phabricator.kde.org/D2586 EMAIL PREFERENCES

[Differential] [Accepted] D2584: Introduce a config option whether applications are allowed to block compositing

sebas accepted this revision. sebas added a reviewer: sebas. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > graesslin wrote in compositing.ui:9 > That is the minimum size ;-) So your change made the window's minimum width more than 300px wider?

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/ --- (Updated Sept. 13, 2016, 12:44 p.m.) Review request for Plasma, Aleix

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 328 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/328/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Sep 2016 10:27:39 + Build duration: 27 min CHANGE SET Revision

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

colomar added a comment. I've just asked the other VDG members for their take on the font size. Since this is not a big issue either way, the patch is fine to go in anyway. If the VDG decides we'd like the font to be smaller, it would be nice if it could be changed in another patch.

[Differential] [Commented On] D2754: Touchpad KDED: fix metadata warning

knambiar added a comment. Thanks for the review, but actually I am not convinced that this gets rid of the warning message. Sifting through the KF5 porting notes, I am not sure how this should be handled -- kded tries to load the plugin with just "name" and if not found it looks for

Re: Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/ --- (Updated Sept. 13, 2016, 12:04 p.m.) Review request for Plasma, Aleix

Review Request 128897: cursor model: look for cursors in correct place

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128897/ --- Review request for Plasma, Aleix Pol Gonzalez and Thomas Pfeiffer.

Re: Plasma 5.8 and look and feel layouts

On 13.09.2016 13:12, Marco Martin wrote: On Tuesday 13 September 2016 11:30:49 Thomas Pfeiffer wrote: On 13.09.2016 11:06, David Edmundson wrote: If we can fix the issues before the release, why hold it back? The first release is in two days. Yes, the beta release, which is there to identify

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

mart added a comment. +1 code looks good, using headings as window titles looks good to me, but ok on whatever vdg decides REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2741 EMAIL PREFERENCES

Re: Plasma 5.8 Errata

On Tuesday, September 13, 2016 12:43:21 PM CEST Thomas Pfeiffer wrote: > On 13.09.2016 12:22, Martin Graesslin wrote: > > Sorry, but I have seen enough bug reports set to critical and priority > > very > > high by the user. As long as users can modify that we will have stupidly > > set up bug

[Differential] [Accepted] D2754: Touchpad KDED: fix metadata warning

mart accepted this revision. mart added a reviewer: mart. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: knambiar, #plasma, davidedmundson, mart Cc:

[Differential] [Accepted] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D2753 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

mart added a comment. In https://phabricator.kde.org/D2753#51252, @colomar wrote: > In https://phabricator.kde.org/D2753#51248, @broulik wrote: > > > Because that's an idea Martin and I had a while ago iirc. And also I don't see how we could make this one scrolling page, since it's a

[Differential] [Accepted] D2754: Touchpad KDED: fix metadata warning

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2754 EMAIL PREFERENCES

[Differential] [Accepted] D2742: Simplify Panel lastSpacer + fix crash

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2742 EMAIL PREFERENCES

Re: Plasma BOF Notes

On 13.09.2016 12:24, David Edmundson wrote: - new LTS every 18 months when the previous one ends While this of course makes sense from Plasma's side, it could be a problem for those who rely on LTS. There is a reason why distros usually have quite some overlap between the support cycles of

Re: Plasma 5.8 and look and feel layouts

On Tuesday 13 September 2016 11:30:49 Thomas Pfeiffer wrote: > On 13.09.2016 11:06, David Edmundson wrote: > > > If we can fix the issues before the release, why hold it back? > > > > The first release is in two days. > > Yes, the beta release, which is there to identify and fix bugs, right? >

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 79 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Sep 2016 10:22:03 + Build duration: 23 min CHANGE SET Revision

Re: Plasma 5.8 and look and feel layouts

On Tuesday 13 September 2016 10:36:18 David Edmundson wrote: > Yes, the beta is there to identify and fix bugs we don't know about. > > If there are bugs we know about, then the feature isn't ready for a beta. > > David said feature is there since 5.0. I'm a bit surprised people are noticing

Re: Plasma 5.8 Errata

On 13.09.2016 12:22, Martin Graesslin wrote: Sorry, but I have seen enough bug reports set to critical and priority very high by the user. As long as users can modify that we will have stupidly set up bug reports. Wait, ordinary users can change the priority field??? That makes literally _no_

Jenkins-kde-ci: khotkeys Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 10 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Sep 2016 10:17:26 + Build duration: 5 min 14 sec CHANGE SET Revision

Plasma BOF Notes

Release Schedule for LTS: - start off as normal (as in the wiki) - then release individual packages as needed on an ad-hoc basis. - new LTS every 18 months when the previous one ends LTS and frameworks: - Officially we encourage people to use latest frameworks, but: - 5.26 can get

Re: Plasma 5.8 Errata

On Tuesday, September 13, 2016 12:09:26 PM CEST Thomas Pfeiffer wrote: > On 13.09.2016 07:52, Martin Graesslin wrote: > > On Monday, September 12, 2016 12:55:22 PM CEST Jonathan Riddell wrote: > >> I've copied over the 5.7 Errata page for 5.8 > >> > >> Do we still have issues with Intel GPUs? >

Re: Plasma 5.8 Errata

On 13.09.2016 07:52, Martin Graesslin wrote: On Monday, September 12, 2016 12:55:22 PM CEST Jonathan Riddell wrote: I've copied over the 5.7 Errata page for 5.8 Do we still have issues with Intel GPUs? Are there still freezes with Qt 5.6? Are the bugs marked critical still critical? I

Re: Plasma 5.8 and look and feel layouts

Yes, the beta is there to identify and fix bugs we don't know about. If there are bugs we know about, then the feature isn't ready for a beta. David

Re: Plasma 5.8 and look and feel layouts

On 13.09.2016 11:06, David Edmundson wrote: > If we can fix the issues before the release, why hold it back? The first release is in two days. Yes, the beta release, which is there to identify and fix bugs, right? Of course the question is: Does the team consider the feature to be stable

Re: Plasma 5.8 and look and feel layouts

> If we can fix the issues before the release, why hold it back? The first release is in two days. David

[Differential] [Changed Subscribers] D2756: Cache system tray applet information

mart added inline comments. INLINE COMMENTS > systemtray.cpp:102 > + > +Q_FOREACH (const auto , > Plasma::PluginLoader::self()->listAppletInfo(QString())) { > +if (!info.isValid() || > info.property(QStringLiteral("X-Plasma-NotificationArea")) != "true") { maybe better not to put

[Differential] [Updated, 67 lines] D2756: Cache system tray applet information

davidedmundson updated this revision to Diff 6684. davidedmundson added a comment. const iterator REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2756?vs=6674=6684 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2756

[Differential] [Updated] D2751: Fix interaction between decoration and fullscreen ShellClient

graesslin added a comment. In https://phabricator.kde.org/D2751#51332, @graesslin wrote: > In https://phabricator.kde.org/D2751#51314, @graesslin wrote: > > > In https://phabricator.kde.org/D2751#51203, @bshah wrote: > > > > > mmm.. still konsole is not fullscreen. :-\ panel still

[Differential] [Request, 4 lines] D2758: Fix updating layer when setting a ShellClient to fullscreen

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, bshah. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The call to update the layer was performed before adjusting

[Differential] [Commented On] D2751: Fix interaction between decoration and fullscreen ShellClient

graesslin added a comment. In https://phabricator.kde.org/D2751#51314, @graesslin wrote: > In https://phabricator.kde.org/D2751#51203, @bshah wrote: > > > mmm.. still konsole is not fullscreen. :-\ panel still visible. > > > somehow I think the stacking order is not getting

[Differential] [Changed Subscribers] D2756: Cache system tray applet information

broulik added inline comments. INLINE COMMENTS > systemtray.cpp:386 > QMap sortedApplets; > -foreach (const KPluginInfo , applets) { > -const QString dbusactivation = > info.property(QStringLiteral("X-Plasma-DBusActivationService")).toString(); > -

[Differential] [Updated, 42 lines] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

graesslin updated this revision to Diff 6681. graesslin added a comment. Adjusted naming as suggested REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2586?vs=6289=6681 BRANCH settings-required-compositing REVISION DETAIL

[Differential] [Updated] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

graesslin marked 2 inline comments as done. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2586 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: sebas, plasma-devel, kwin, lesliezhai,

[Differential] [Updated, 99 lines] D2584: Introduce a config option whether applications are allowed to block compositing

graesslin updated this revision to Diff 6680. graesslin added a comment. Adjusted to suggested: - rewording changes (improvements, window-specific) - renamed all the isWindowsBlockingCompositing to windowsBlockCompositing REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

  1   2   >