Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-09-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: plugins,caches, startup time

2016-09-27 Thread David Edmundson
On Tue, Sep 27, 2016 at 9:32 PM, Eike Hein wrote: > Worth keeping in mind that "it's only 300 msecs" adds up though, > 300 msecs here, 300 msecs there ... also it's a question of "do > we expect this cost point to become worse over time?", i.e. if > nothing it done it might not

[Differential] [Commented On] D2877: Use Plasma::PluginLoader to list applets

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > apol wrote in widgetexplorer.cpp:135 > shouldn't `listAppletInfo` be returning a `QList`? Yes. (especially as there's an added weirdness for some Plasma 5.3 compatibility where it loads the metadata again twice) but it doesn't so

[Differential] [Changed Subscribers] D2877: Use Plasma::PluginLoader to list applets

2016-09-27 Thread apol (Aleix Pol Gonzalez)
apol added inline comments. INLINE COMMENTS > widgetexplorer.cpp:135 > QStringList cats; > -const QList list = > KPackage::PackageLoader::self()->listPackages(QStringLiteral("Plasma/Applet"), > QStringLiteral("plasma/plasmoids")); > +const QList list = >

[Differential] [Updated, 19 lines] D2866: add flag to for per-display scaling

2016-09-27 Thread Sebastian Kügler
sebas updated this revision to Diff 6966. sebas added a comment. - PerDisplayScaling -> PerOutputScaling REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2866?vs=6940=6966 BRANCH sebas/perdisplayscalingflag REVISION DETAIL

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-27 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99601 --- ksysguardd/Linux/Memory.c (line 307)

Re: Review Request 129038: update startup and shutdown system settings group - sddm

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129038/ --- (Updated Sept. 27, 2016, 11:35 p.m.) Status -- This change has been

Re: Review Request 129037: update startup and shutdown system settings group - screenlocker

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129037/ --- (Updated Sept. 27, 2016, 9:34 nachm.) Status -- This change has

Re: Review Request 129039: update startup and shutdown system settings group - others

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129039/ --- (Updated Sept. 27, 2016, 9:34 p.m.) Status -- This change has been

Re: Review Request 129048: Look and Feel -> Global Theme

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129048/ --- (Updated Sept. 27, 2016, 9:23 nachm.) Review request for Plasma.

trash bin icon

2016-09-27 Thread kainz.a
Hi, I get a nice trash bin icon some users want, but I have to add the icon to the plasma breeze theme and I don't know how. How can I add a new icon to the plasma theme that the trash bin plasmoid will use it. the plasmoid use user-trash and user-trash-full thanks Andreas_K

[Differential] [Request, 3 lines] D2877: Use Plasma::PluginLoader to list applets

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY PluginLoader has some additional checks for some obscure config options, such as

Re: plugins,caches, startup time

2016-09-27 Thread Eike Hein
Worth keeping in mind that "it's only 300 msecs" adds up though, 300 msecs here, 300 msecs there ... also it's a question of "do we expect this cost point to become worse over time?", i.e. if nothing it done it might not stay at 300 msecs. Cheers, Eike

[Differential] [Commented On] D2874: Renamed userPrompt to userPromptComponent and add userListComponent id

2016-09-27 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added a comment. Thanks for your comments. I should warn you that this is the second time I touch qml code, so apologies in advance :). INLINE COMMENTS > davidedmundson wrote in SessionManagementScreen.qml:60 > this component is shared with the lockscreen and user switcher, you're

[Differential] [Closed] D2871: Extra validation in auth help parsing

2016-09-27 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rSDDMKCM77670b0aaadd: Extra validation in auth help parsing (authored by davidedmundson). REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2870: Fix deprecated KUser usage warning

2016-09-27 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rSDDMKCM22b8e86f21e0: Fix deprecated KUser usage warning (authored by davidedmundson). REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

Re: A Plasma Vision draft

2016-09-27 Thread Olivier Churlaud
Hi, Le mardi 27 septembre 2016, 18:24:36 CEST Jens Reuterberg a écrit : > This is actually fairly tricky because what is needed is a metric to work > towards: sayiing "fast and stable" is not very exact. > > But you raise fair points - how do we ensure that it doesn't exclude anyone? > To me a

[Differential] [Closed] D2876: If the theme set in the SDDM config is missing, select first possible entry

2016-09-27 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rSDDMKCM9fd15c6e7a35: Merge branch 'Plasma/5.8' (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2876?vs=6956=6960#toc REPOSITORY rSDDMKCM SDDM Configuration Panel

[Differential] [Closed] D2876: If the theme set in the SDDM config is missing, select first possible entry

2016-09-27 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rSDDMKCM645ba842a18b: If the theme set in the SDDM config is missing, select first possible entry (authored by davidedmundson). REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) CHANGES SINCE LAST

[Differential] [Closed] D2869: Validate row exists in UsersModel::data

2016-09-27 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rSDDMKCM774b7f01778a: Validate row exists in UsersModel::data (authored by davidedmundson). REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2876: If the theme set in the SDDM config is missing, select first possible entry

2016-09-27 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D2876 EMAIL PREFERENCES

Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-09-27 Thread Michail Vourlakos
if thisis right, then why the Plasma Panel in not appearing in the widgets list? On 27/09/2016 07:22 μμ, Marco Martin wrote: On Tuesday 27 September 2016, Michail Vourlakos wrote: Can you please confirm me the following? 1. NoDisplay=true , in the metadata.desktop, tells to the panel to not

Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-09-27 Thread Marco Martin
On Tuesday 27 September 2016, Michail Vourlakos wrote: > Can you please confirm me the following? > > 1. NoDisplay=true , in the metadata.desktop, tells to the panel to not > appear in the widgets explorer, but this is a panel so I think it > shouldnt if the user can not add it from there, right?

Re: A Plasma Vision draft

2016-09-27 Thread Jens Reuterberg
This is actually fairly tricky because what is needed is a metric to work towards: sayiing "fast and stable" is not very exact. But you raise fair points - how do we ensure that it doesn't exclude anyone? To me a vision is a statement of intent, but not a boundary beyond practical choices.

[Differential] [Accepted] D2875: index.model()->data(... -> index.data(index,..

2016-09-27 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D2875 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 10 lines] D2876: If the theme set in the SDDM config is missing, select first possible entry

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's possible for the SDDM config to not list a theme, particularly if you're using the

[Differential] [Request, 4 lines] D2875: index.model()->data(... -> index.data(index,..

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's the same thing and less prone to crashing on an invalid index TEST PLAN Opened KCM and

Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-09-27 Thread Michail Vourlakos
Can you please confirm me the following? 1. NoDisplay=true , in the metadata.desktop, tells to the panel to not appear in the widgets explorer, but this is a panel so I think it shouldnt if the user can not add it from there, right? 2. my metadata.desktop was using NoDisplay=true in Plasma

[Differential] [Commented On] D2874: Renamed userPrompt to userPromptComponent and add userListComponent id

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Concept is good, just need to do some code shuffling. INLINE COMMENTS > SessionManagementScreen.qml:60 > property var userListCurrentModelData: userListView.currentItem === null > ? [] : userListView.currentItem.m > +property bool showUserList:

[Differential] [Request, 10 lines] D2874: Renamed userPrompt to userPromptComponent and add userListComponent id

2016-09-27 Thread antlarr (Antonio Larrosa Jimenez)
antlarr created this revision. antlarr added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Renamed userPrompt to userPromptComponent and add an id (userListComponent) to the initialItem Login

Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-09-27 Thread David Edmundson
Ok, there was a change between 5.7 and 5.7.95 that broke this. It was then fixed between the beta and final because of this very reason. latest Plasma/5.8 branch (anything after 79000dab31d4da97f8031275f2cf66395af64fc9 - 20/09/2016) should be fine, as should the final release. David

Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-09-27 Thread Marco Martin
On Tuesday 27 September 2016, Michail Vourlakos wrote: > Hello everyone, > > > I am receiving reports that Now Dock Panel in Plasma 5.8 even though is > installed correctly at the same time is not appearing in the panels list. > > Do you know if there is a change is the plasma codepage and the

[Differential] [Accepted] D2872: use KPluginSelector to enable runners

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH phab/kpluginselector REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2873: kconfig update script for enabled runners

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/krunnerplugins REVISION DETAIL https://phabricator.kde.org/D2873 EMAIL PREFERENCES

Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-09-27 Thread Michail Vourlakos
according to the users, Plasma 5.7.95 (5.8 beta) On 27/09/2016 06:45 μμ, David Edmundson wrote: When you say Plasma 5.8, what exactly do you mean? David On Tue, Sep 27, 2016 at 4:34 PM, Michail Vourlakos > wrote:

[Differential] [Commented On] D2872: use KPluginSelector to enable runners

2016-09-27 Thread mart (Marco Martin)
mart added a comment. with the kconfig update script of https://phabricator.kde.org/D2873 the krunner configuration seems to have proper plugins enabled REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES

[Differential] [Updated] D2873: kconfig update script for enabled runners

2016-09-27 Thread mart (Marco Martin)
mart added a dependency: D2872: use KPluginSelector to enable runners. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2873 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel,

[Differential] [Updated] D2872: use KPluginSelector to enable runners

2016-09-27 Thread mart (Marco Martin)
mart updated the test plan for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, broulik, davidedmundson, #plasma Cc: davidedmundson,

[Differential] [Updated] D2872: use KPluginSelector to enable runners

2016-09-27 Thread mart (Marco Martin)
mart added a dependent revision: D2873: kconfig update script for enabled runners. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, broulik, davidedmundson,

[Differential] [Updated] D2873: kconfig update script for enabled runners

2016-09-27 Thread mart (Marco Martin)
mart updated the test plan for this revision. mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2873 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel,

Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-09-27 Thread David Edmundson
When you say Plasma 5.8, what exactly do you mean? David On Tue, Sep 27, 2016 at 4:34 PM, Michail Vourlakos wrote: > Hello everyone, > > > I am receiving reports that Now Dock Panel in Plasma 5.8 even though is > installed correctly at the same time is not appearing in

[Differential] [Request, 84 lines] D2873: kconfig update script for enabled runners

2016-09-27 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY migrate the enabled runners from enabledCategories to the more classic [Plugins] group the krunner framework supports both, so as long the

Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-09-27 Thread Michail Vourlakos
Hello everyone, I am receiving reports that Now Dock Panel in Plasma 5.8 even though is installed correctly at the same time is not appearing in the panels list. Do you know if there is a change is the plasma codepage and the "Empty Now Dock Panel" must be provided also as a layout?

plugins,caches, startup time

2016-09-27 Thread Marco Martin
Hi all, as there is being some work in plugin caching right now, to see if /what we can save at startup time would be nice if different people on different systems do some tests. on his system, by indexing plugins Sebas saves about 2-300 milliseconds. How did you test that, so that we see

[Differential] [Commented On] D2872: use KPluginSelector to enable runners

2016-09-27 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2872#53355, @davidedmundson wrote: > Worst, krunner framework still reads enabledCategories, so if something was disabled there's no way to enable it. > > Finally this leaves frameworks krunner documentation being wrong. i

[Differential] [Requested Changes To] D2872: use KPluginSelector to enable runners

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. Testing done section should not be blank. Also there's no migration path. So instead of it breaking it on

[Differential] [Updated, 285 lines] D2872: use KPluginSelector to enable runners

2016-09-27 Thread mart (Marco Martin)
mart updated this revision to Diff 6952. mart added a comment. - remove dead code REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2872?vs=6951=6952 BRANCH phab/kpluginselector REVISION DETAIL https://phabricator.kde.org/D2872

[Differential] [Updated] D2872: use KPluginSelector to enable runners

2016-09-27 Thread mart (Marco Martin)
mart added reviewers: Plasma, broulik. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, broulik Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 206 lines] D2872: use KPluginSelector to enable runners

2016-09-27 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY the configuration dialog for enabling runners by category was a neat idea but had several problems, gave by it reinventing the wheel too

Re: Review Request 128089: [Quick Chat] Add context menu for copying text and links

2016-09-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128089/ --- (Updated Sept. 27, 2016, 12:50 p.m.) Status -- This change has been

[Differential] [Request, 5 lines] D2871: Extra validation in auth help parsing

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We don't want a kauth helper to ever be crashable on bad input REPOSITORY rSDDMKCM SDDM

[Differential] [Request, 6 lines] D2870: Fix deprecated KUser usage warning

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Opened KCM, checked names between UID min and max still appeared which shows filter is working as

[Differential] [Accepted] D2869: Validate row exists in UsersModel::data

2016-09-27 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D2869 EMAIL PREFERENCES

[Differential] [Request, 6 lines] D2869: Validate row exists in UsersModel::data

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise if the autologin combo box index points to an invalid index, we crash reading it.

Re: Review Request 129046: Port to KWindowSystem::forceActiveWindow

2016-09-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129046/ --- (Updated Sept. 27, 2016, 11:36 a.m.) Status -- This change has been

Re: Review Request 129049: kcm window decoration

2016-09-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129049/#review99584 --- but are the window decorationS of all windows that you are

Re: Review Request 129037: update startup and shutdown system settings group - screenlocker

2016-09-27 Thread Andreas Kainz
> On Sept. 27, 2016, 11:12 vorm., Marco Martin wrote: > > discussions in telegram really don't count, it must be somewhere inclusive > > to everybody and persistent. > > > > -1 for moving lock screen into startup and shutdown, it has zero to do with > > it, the fact that in your design

Re: Review Request 129039: update startup and shutdown system settings group - others

2016-09-27 Thread Marco Martin
> On Sept. 26, 2016, 10:06 p.m., David Edmundson wrote: > > Weight changes - I think we can improve on that, and it's good that you > > are. +1 > > > > Moving KCMS around again - I'm massively against. > > We've only just moved them round 24 months ago, and whilst it's fine to > > itterate

Re: Review Request 129037: update startup and shutdown system settings group - screenlocker

2016-09-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129037/#review99580 --- discussions in telegram really don't count, it must be

Re: Review Request 129048: Look and Feel -> Global Theme

2016-09-27 Thread Marco Martin
> On Sept. 27, 2016, 10:41 a.m., Thomas Pfeiffer wrote: > > I agree that Look and Feel is not self-explanatory, but it's not an empty > > term either. See https://en.wikipedia.org/wiki/Look_and_feel which > > describes pretty much exactly what we're doing here. > > I'd therefore keep the KCM

Re: System Settings - Network -> Connectivity

2016-09-27 Thread Marco Martin
On Tuesday 27 September 2016, David Edmundson wrote: > On Mon, Sep 26, 2016 at 10:01 PM, kainz.a wrote: > > After some review of the existing System Setting overview page I come up > > that the subgroups for each main group should be at least near the same, > > therefore I'd

Re: Review Request 129033: plural description

2016-09-27 Thread Marco Martin
> On Sept. 27, 2016, 10:50 a.m., Marco Martin wrote: > > as we are in string freeze, Is this in master only right? > > Andreas Kainz wrote: > I only push in master branches. I hope this is correct but if I have > something for backporting, I would ask someone of the plasma team. In >

Re: Review Request 129033: plural description

2016-09-27 Thread Andreas Kainz
> On Sept. 27, 2016, 10:50 vorm., Marco Martin wrote: > > as we are in string freeze, Is this in master only right? I only push in master branches. I hope this is correct but if I have something for backporting, I would ask someone of the plasma team. In LibreOffice I learn that you can push

Re: Review Request 129036: move accessibility kcm to the new subgroup in personalization

2016-09-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129036/#review99573 --- fine, needs 129035 to be fixed beforehand tough - Marco

Re: Review Request 129033: plural description

2016-09-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129033/#review99572 --- as we are in string freeze, Is this in master only right? -

Re: Review Request 129048: Look and Feel -> Global Theme

2016-09-27 Thread Andreas Kainz
> On Sept. 27, 2016, 10:41 vorm., Thomas Pfeiffer wrote: > > I agree that Look and Feel is not self-explanatory, but it's not an empty > > term either. See https://en.wikipedia.org/wiki/Look_and_feel which > > describes pretty much exactly what we're doing here. > > I'd therefore keep the KCM

Re: Review Request 129048: Look and Feel -> Global Theme

2016-09-27 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129048/#review99569 --- I agree that Look and Feel is not self-explanatory, but it's

Re: Review Request 129045: Color kcm for workspace and applications

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129045/ --- (Updated Sept. 27, 2016, 10:35 a.m.) Status -- This change has been

Review Request 129050: kcm gnome

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129050/ --- Review request for Plasma. Repository: kde-gtk-config Description

Re: Review Request 129045: Color kcm for workspace and applications

2016-09-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129045/#review99568 --- Ship it! Ship It! - David Edmundson On Sept. 27, 2016,

Review Request 129049: kcm window decoration

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129049/ --- Review request for Plasma. Repository: kwin Description ---

Review Request 129048: Look and Feel -> Global Theme

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129048/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 129046: Port to KWindowSystem::forceActiveWindow

2016-09-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129046/#review99567 --- Ship it! Ship It! - David Edmundson On Sept. 27, 2016,

Review Request 129046: Port to KWindowSystem::forceActiveWindow

2016-09-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129046/ --- Review request for Plasma and David Edmundson. Repository:

Review Request 129045: Color kcm for workspace and applications

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129045/ --- Review request for Plasma. Repository: plasma-desktop Description

[Differential] [Closed] D2865: Change component shown on selection changes

2016-09-27 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP0797a16b9b11: Change component shown on selection changes (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2865: Change component shown on selection changes

2016-09-27 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2865 EMAIL PREFERENCES

[Differential] [Abandoned] D2858: Fix Plasma discover with the Kirigami it can depend on

2016-09-27 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. REPOSITORY rDISCOVER Discover Software Store REVISION DETAIL https://phabricator.kde.org/D2858 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, lesliezhai,

Re: Review Request 129039: update startup and shutdown system settings group - others

2016-09-27 Thread Andreas Kainz
> On Sept. 26, 2016, 10:06 nachm., David Edmundson wrote: > > Weight changes - I think we can improve on that, and it's good that you > > are. +1 > > > > Moving KCMS around again - I'm massively against. > > We've only just moved them round 24 months ago, and whilst it's fine to > > itterate

Re: Review Request 129035: add the subgroup accessibility to personalization

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129035/ --- (Updated Sept. 27, 2016, 9:39 vorm.) Review request for Plasma.

Plasma 5.8 will need Kirigami 1.1

2016-09-27 Thread Jonathan Riddell
Some final changes to Kirigami and Discover (and some lax release management) mean Plasma 5.8 will need the newly released Kirigami 1.1. https://www.kde.org/announcements/kirigami-1.1.php https://techbase.kde.org/Kirigami Jonathan

Re: Review Request 129035: add the subgroup accessibility to personalization

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129035/ --- (Updated Sept. 27, 2016, 9:34 a.m.) Review request for Plasma. Changes

Re: Review Request 129040: update search sorting

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129040/ --- (Updated Sept. 27, 2016, 9:29 a.m.) Status -- This change has been

Re: Review Request 129041: Launch Feedback is a notification isn't it?

2016-09-27 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129041/ --- (Updated Sept. 27, 2016, 9:14 vorm.) Status -- This change has been

[Differential] [Closed] D2834: Prefer wallpapers with same aspect ratio as screen

2016-09-27 Thread antlarr (Antonio Larrosa Jimenez)
antlarr closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2834 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Changed Subscribers] D2866: add flag to for per-display scaling

2016-09-27 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > config.h:68 > +Writable = 1 << 1, ///< The backend supports setting the config, > it's not read-only. > +PerDisplayScaling = 1 << 2 ///< The backend supports scaling each > output individually. > }; Output instead of

Re: Review Request 129037: update startup and shutdown system settings group - screenlocker

2016-09-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129037/#review99563 --- Was there a discussion or study or something about this? I'm