[Differential] [Request, 4 lines] D2952: Only trigger mod-only-shortcuts if global shortcuts are enabled

2016-10-05 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY KWin supports blocking global shortcuts when a window is active through window specific rules.

[Differential] [Closed] D2940: Add an option to force alphabetic sorting to Kicker/Kickoff.

2016-10-05 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP5945063f0be1: Add an option to force alphabetic sorting to Kicker/Kickoff. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

2016-10-05 Thread hein (Eike Hein)
hein added a comment. Thanks, regression fixed in http://commits.kde.org/plasma-desktop/1e34e1e7aba969a0d4e486ff6845fb1b7bce4522 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

2016-10-05 Thread lbeltrame (Luca Beltrame)
lbeltrame added a comment. F354981: Spectacle.aq5462.png And this is a screenshot. BRANCH master REVISION DETAIL https://phabricator.kde.org/D2932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma,

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

2016-10-05 Thread lbeltrame (Luca Beltrame)
lbeltrame added a comment. I've seen this on both multi and single screen. FV placed on the desktop, BTW. Screenshot coming up soon (because I run with the patch reverted). BRANCH master REVISION DETAIL https://phabricator.kde.org/D2932 EMAIL PREFERENCES

Re: Review Request 129110: Generate the icon into the appstream file

2016-10-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129110/#review99804 --- Ship it! Ship It! - Michael Stemle On Oct. 6, 2016,

Re: Review Request 129101: Port to new plasma-framework API

2016-10-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99802 --- runners/windowedwidgets/windowedwidgetsrunner.cpp (line

[Differential] [Commented On] D2940: Add an option to force alphabetic sorting to Kicker/Kickoff.

2016-10-05 Thread hein (Eike Hein)
hein added a comment. ^ True, I was thinking about that while writing it, too @ QQmlParserStatus. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2940 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2940: Add an option to force alphabetic sorting to Kicker/Kickoff.

2016-10-05 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > appsmodel.cpp:306 > + > +refresh(); > + at some point you should look into adding a

Re: Review Request 129110: Generate the icon into the appstream file

2016-10-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129110/#review99800 --- +1 - Michael Stemle On Oct. 6, 2016, 12:54 a.m., Aleix

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

2016-10-05 Thread hein (Eike Hein)
hein added a comment. Luca, can you give me more details? Which use case of Folder View, containment, desktop widget, panel widget? Screenshot? Multiscreen, single screen? I tested the FV/Desktop/single case and it's fine here. BRANCH master REVISION DETAIL

Review Request 129110: Generate the icon into the appstream file

2016-10-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129110/ --- Review request for KDE Frameworks, Plasma and Matthias Klumpp.

Re: Plasma Sprint in Stuttgart?

2016-10-05 Thread Sebastian Kügler
On Wednesday, October 5, 2016 10:34:31 AM UTC Kai Uwe Broulik wrote: > with Plasma 5.8 out the door I think it's time to start planning the next > annual Plasma Sprint early next year. > > My company would be happy to be hosting that event, providing office space > for +/- 10 people and WiFi for

KDE Neon Developer Stable - Missing Kickoff Icons - Wrong kdeconnect Version

2016-10-05 Thread Railway Coder
Hello, I'm using KDE Neon Developer Stable (currently up to date from the repo). Since a few weeks I'm missing the History and Leave Icon in Kickoff (See screenshot below) ​ I've a system running KDE Neon User Edition and there is everything fine. I think something is wrong with my packages

Re: Review Request 129098: Add keyboard icons for kimpanel

2016-10-05 Thread Yunhe Guo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129098/ --- (Updated 十月 5, 2016, 5:09 p.m.) Review request for Plasma. Repository:

Re: Review Request 129098: Add keyboard icons for kimpanel

2016-10-05 Thread Yunhe Guo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129098/ --- (Updated 十月 5, 2016, 5:06 p.m.) Review request for Plasma. Changes

[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Looks like a bug in the notification service, at least looking at the code it should reuse the notification. :/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2942 EMAIL PREFERENCES

[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

2016-10-05 Thread Till Schäfer
tillschafer added a comment. another minor issue: the notification symbol/icon is blurred and the old one from KDE 4 times. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2942 EMAIL PREFERENCES

[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

2016-10-05 Thread Till Schäfer
tillschafer added a comment. i have applied that patch atop of plasma 5.8.0 and see the following problem: When using the shortcut multiple times, the messages get grouped, i.e. shown in a single popup. This causes the most relevant text to be hidden and you need to scroll down to actually

lookandfeel and dependencies (and potentially all kde-store related stuff)

2016-10-05 Thread Marco Martin
Hi all, in plasma 5.8 a new option to download look and feel packages from the kde store appeared. since it's possible for a look and feel package to depend from external stuff (for instance, 3rd party icon theme and whatnot) how to manage that? I was thinking about kpackage metadata file

Re: Plasma Sprint in Stuttgart?

2016-10-05 Thread Marco Martin
On Wednesday 05 October 2016 10:34:31 Kai Uwe Broulik wrote: > The nextcloud office is located just down the street, so we could perhaps > invite them for a day to drive our collaboration forward and talk technical > details. Also, might make sense to have somebody from Munich drive over for > a

[Differential] [Closed] D2887: Fix kcminit phase 1 and 2

2016-10-05 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEeb6223bbe650: Fix kcminit phase 1 and 2 (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2938: Set explicit minimum size on panelSpacer so that AppletContainer doesn't set one

2016-10-05 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd3fc0c187871: Set explicit minimum size on panelSpacer so that AppletContainer doesn't set one (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE

[Differential] [Accepted] D2946: make sure allTimezones is set

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. So they changed the behavior of QQmlPropertyMap when a property is inserted that previously didn't exist? INLINE COMMENTS > main.qml:45 > +

[Differential] [Abandoned] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik abandoned this revision. broulik added a comment. Some Kwin/Qt event handling issue, wheeling outside the tabbox window actually works. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2944 EMAIL PREFERENCES

[Differential] [Accepted] D2941: Only repeat one key

2016-10-05 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH repeat-one-key-5.8 REVISION DETAIL https://phabricator.kde.org/D2941 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 18 lines] D2946: make sure allTimezones is set

2016-10-05 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY on Qt 5.6/5.7 changed signal was emitted at startup as well, triggering

[Differential] [Request, 19 lines] D2945: Workaround xkbcommon behavior concerning consumed modifiers

2016-10-05 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY If a key could be turned into a keysym with a modifier xkbcommon

[Differential] [Closed] D2922: [Digital Clock] Silence warning

2016-10-05 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE27274d4c913d: [Digital Clock] Silence warning (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Plasma Workspace Wallpapers] [Bug 365761] Get Hot New Stuff for Wallpaper not working

2016-10-05 Thread Thomas Pfeiffer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365761 Thomas Pfeiffer changed: What|Removed |Added Version Fixed In||KF5 5.24

[Differential] [Accepted] D2887: Fix kcminit phase 1 and 2

2016-10-05 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2887 EMAIL PREFERENCES

Plasma 5.9 Kickoff Meeting

2016-10-05 Thread Jonathan Riddell
What was good about 5.8? What would you like to see in 5.9? Come to the Kickoff meeting to discuss the future of our favourite desktop. To schedule the meeting please mark when you're free on this Doodle poll and I'll pick the most popular time. Please suggest items for the meeting agenda.

[Differential] [Commented On] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread Martin Gräßlin
graesslin added a comment. Also I just tried on Wayland (as I'm on Wayland right now) and there mouse wheel works correctly. So no change needed. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2944 EMAIL PREFERENCES

[Differential] [Updated, 139 lines] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 7114. broulik added a comment. Let mouse wheel wrap around REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2944?vs=7113=7114 REVISION DETAIL https://phabricator.kde.org/D2944 AFFECTED FILES

[Differential] [Requested Changes To] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision now requires changes to proceed. KWin internally already handles mouse wheel. See kwin/tabbox/tabbox.cpp method Tabbox::handleMouseEvent REPOSITORY rPLASMAWORKSPACE

krunner threads kservice

2016-10-05 Thread Harald Sitter
Hellos whilest investigating a memleak I noticed that krunner threadweaves its runners. those runners sometimes use kservice to do queries (e.g. servicerunner). for servicerunner specifically this seems to run into fairly unprotected code paths (I know appstreamrunner will run into the same

[Differential] [Commented On] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Behavior sounds sensible, wrapping around would make sense, though. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2944 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

2016-10-05 Thread lbeltrame (Luca Beltrame)
lbeltrame added a comment. This breaks Folder View in a spectacular way: icons overflow out of the applet, and even the title is displayed out of the frame. In some situations I've also seen icons "dancing" continuously (but always overflowing). Reverting this commit fixes the issue

[Differential] [Updated] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik updated the summary for this revision. broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2944 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

More tilling options for larger resolutions?

2016-10-05 Thread Provatta
Hello! I use a 55" UHD display as a monitor and the current tilling corners are not enough for me. I would like to have something like this drawing: http://i.imgur.com/F2g4mD0.png Is there any way to accomplish something like that, please? It would improve my workflow a lot. Currently, I use

Re: Review Request 128761: Fix crash on exit

2016-10-05 Thread Hugo Pereira Da Costa
On 10/04/2016 10:53 PM, Peter Wu wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/ On August 27th, 2016, 12:25 p.m. CEST, *Hugo Pereira Da Costa* wrote: Ship It! Congratulations with the release of Plasma 5.8! It

Re: Plasma Sprint in Stuttgart?

2016-10-05 Thread David Edmundson
+1000 David

[Differential] [Request, 134 lines] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG:

[Differential] [Commented On] D2940: Add an option to force alphabetic sorting to Kicker/Kickoff.

2016-10-05 Thread starbuck (Star Buck)
starbuck added a comment. note: it was overall discussed and agreed that this optional sort is providing a solution in certain cases without changing anything when not making it "default on", which was never requested to do. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

Re: Review Request 129101: Port to new plasma-framework API

2016-10-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 12:54 p.m.) Review request for Plasma.

Re: Review Request 129101: Port to new plasma-framework API

2016-10-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 12:54 p.m.) Review request for Plasma. Bugs:

Re: Review Request 129104: Remove unused member var

2016-10-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129104/#review99794 --- Ship it! - Aleix Pol Gonzalez On Oct. 5, 2016, 2:59

[Differential] [Commented On] D2943: Support LEDs in Xkb and libinput

2016-10-05 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D2943#54642, @broulik wrote: > If that goes through xkb, does that honor the "Miscellaneous compatibility options → Numeric keyboard keys always enter digits" in keyboard settings? I hate that stupid numlock LED so I use that

[Differential] [Commented On] D2943: Support LEDs in Xkb and libinput

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik added a comment. If that goes through xkb, does that honor the "Miscellaneous compatibility options → Numeric keyboard keys always enter digits" in keyboard settings? I hate that stupid numlock LED so I use that option to turn the light off while still having numpad enabled.

[Differential] [Request, 87 lines] D2943: Support LEDs in Xkb and libinput

2016-10-05 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The Xkb implementation starts to track the state of the LEDs in the

[Differential] [Changed Subscribers] D2936: always connect to "Local" source

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > main.qml:77 > engine: "time" > -connectedSources: plasmoid.configuration.selectedTimeZones > +connectedSources: allTimezones > interval: plasmoid.configuration.showSeconds ? 1000 : 6 Can't you just bind that

[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

2016-10-05 Thread broulik (Kai Uwe Broulik)
broulik added a comment. If there isn't an option for that already (haven't checked) might make sense to turn that notification into a proper notifyrc event, so the user can turn the notification off. (separate to this patch, obviously) INLINE COMMENTS > klipper.cpp:239 > +

Plasma Sprint in Stuttgart?

2016-10-05 Thread Kai Uwe Broulik
Hi all, with Plasma 5.8 out the door I think it's time to start planning the next annual Plasma Sprint early next year. My company would be happy to be hosting that event, providing office space for +/- 10 people and WiFi for a week for us to use. What does second week of February (Monday, 6

Re: Review Request 129101: Port to new plasma-framework API

2016-10-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99792 --- Fix it, then Ship it! applets/systemtray/systemtray.cpp

[Differential] [Closed] D2936: always connect to "Local" source

2016-10-05 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEa925224e40c6: always connect to "Local" source (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2936?vs=7095=7108

[Differential] [Request, 35 lines] D2942: [klipper] Move notification from tray to Klipper

2016-10-05 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Klipper shows a notification when the shortcuts next/prev history item gets triggered. This

[Differential] [Request, 49 lines] D2941: Only repeat one key

2016-10-05 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY So far KWin tried to repeat all pressed keys which should repeat.