[Differential] [Changed Subscribers] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

subdiff added inline comments. INLINE COMMENTS > plasma-shell.xml:373 > + > + > + Use another name instead of "skip" (copy paste from set_skip_taskbar) ? > plasmashell_interface.cpp:90 > static void panelAutoHideShowCallback(wl_client *client, wl_resource > *resource); >

Re: Review Request 129187: Fix dangling pointer in KPackageJob

> On Oct. 15, 2016, 4:50 a.m., Anthony Fieroni wrote: > > src/kpackage/package.cpp, line 66 > > > > > > emit? ah yes, please :) - Marco --- This is an

Re: Review Request 129187: Fix dangling pointer in KPackageJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129187/#review100027 --- Ship it! Ship It! - Marco Martin On Oct. 14, 2016,

[Differential] [Abandoned] D3065: Port away from KDELibs4Support

davidk abandoned this revision. davidk added a comment. Sorry for the noise, I have some problems with phabricator. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3065 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 125 lines] D3065: Port away from KDELibs4Support

davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3065 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt

[Differential] [Commented On] D3055: Small polishing changes to the lockscreen lookandfeel package

eliasp added a comment. In https://phabricator.kde.org/D3055#56708, @subdiff wrote: > But I wouldn't add it to this diff, since it can be done independently of this diff. Rather someone (you? me?) should create a new diff in the future regarding this feature. I agree - this

[Differential] [Request, 161 lines] D3064: Port away from KDELibs4Support

davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Bring back the usericon region selection Also improve error checking. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION

[Differential] [Commented On] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff added a comment. In https://phabricator.kde.org/D3055#56705, @eliasp wrote: > What about hiding the password input field (or at least providing the required property) as long as the password grace period hasn't expired? > > So as long as no password is required to hide the

[Differential] [Commented On] D3049: Support passing generic QIcon through PlasmaWindow interface

graesslin added inline comments. INLINE COMMENTS > apol wrote in plasmawindowmanagement_interface.cpp:386 > maybe worth adding a `if (m_icon == icon) return;` in theory yes, in practice: operator== doesn't exist for QIcon so all you get is a compile error :-( REPOSITORY rKWAYLAND KWayland

System Settings KCM cleanup (KIO)

Hi, there are some KCM's the default user didn't need, some of them are also broken. It need some time to realize that the KCM's are from KIO. connectivity -> Samba Shares (didn't work) some kcm's are available but only needed if you install a kde browser. So please activate this KCM's not by

[Differential] [Commented On] D3055: Small polishing changes to the lockscreen lookandfeel package

eliasp added a comment. What about hiding the password input field (or at least providing the required property) as long as the password grace period hasn't expired? So as long as no password is required to hide the lockscreen, show no input field. REPOSITORY rPLASMAWORKSPACE Plasma