[Differential] [Commented On] D2687: WIP: [Icon Widget] Bring back properties dialog

dfaure added inline comments. INLINE COMMENTS > iconapplet.cpp:57 > +if (destroyed()) { > +QFile(m_localPath).remove(); > +} QFile::remove is enough, no need for a QFile instance. > iconapplet.cpp:78 > +if (!m_url.isValid()) { > +// invalid url, use dummy data ("nk

Re: Split the kioslaves out of plasma-workspace?

On 04.11.2016 19:20, kainz.a wrote: Radical different idea: what about moving Dolphin from Applications to Plasma? If this mean the plasma team take care about Dolphin +1000 history of the contributors, a boost would help dolphin. https://github.com/KDE/dolphin/graphs/contributors The aim

Re: Split the kioslaves out of plasma-workspace?

On 05/11/16 01:52, Elvis Angelaccio wrote: > Hi > plasma-workspace currently ships the remote:/, applications:/ and > desktop:/ kioslaves. The remote:/ one is also used by Dolphin, so > currently the dolphin package has an (optional) dependency on > plasma-workspace. > > As discussed in [1], they

Re: Split the kioslaves out of plasma-workspace?

> > Radical different idea: what about moving Dolphin from Applications to > Plasma? > If this mean the plasma team take care about Dolphin +1000 history of the contributors, a boost would help dolphin. https://github.com/KDE/dolphin/graphs/contributors

Re: Split the kioslaves out of plasma-workspace?

Am 2016-11-04 15:52, schrieb Elvis Angelaccio: Hi plasma-workspace currently ships the remote:/, applications:/ and desktop:/ kioslaves. The remote:/ one is also used by Dolphin, so currently the dolphin package has an (optional) dependency on plasma-workspace. As discussed in [1], they are

Re: Review Request 128957: Make KF5Baloo optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128957/ --- (Updated Nov. 4, 2016, 9:01 p.m.) Status -- This change has been

[Differential] [Commented On] D3265: Make it possible for 5.8 to compile against the last AppStreamQt

apol added a comment. See https://github.com/ximion/appstream/pull/86 REPOSITORY rDISCOVER Discover Software Store REVISION DETAIL https://phabricator.kde.org/D3265 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, rdieter Cc:

[Differential] [Request, 62 lines] D3265: Make it possible for 5.8 to compile against the last AppStreamQt

apol created this revision. apol added reviewers: Plasma, rdieter. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Builds, works. Needs patch in appstream, see pull request REPOSITORY rDISCOVER Discover Software Store

[Differential] [Commented On] D3264: [libinput] Load/store device configuration

strobach added a comment. Works for me. [Libinput][1133][50184][Logitech USB Trackball] MiddleButtonEmulation=true ScrollButton=275 [Libinput][1739][30171][DLL0675:00 06CB:75DB Touchpad] TapToClick=true REPOSITORY rKWIN KWin REVISION DETAIL

[Powerdevil] [Bug 372080] New: Resuming from suspend while using docking station hangs the desktop

https://bugs.kde.org/show_bug.cgi?id=372080 Bug ID: 372080 Summary: Resuming from suspend while using docking station hangs the desktop Product: Powerdevil Version: 5.8.3 Platform: Neon Packages OS: Linux

Review Request 129329: Fix SVG icon ID prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129329/ --- Review request for Plasma. Repository: plasma-framework Description

[Differential] [Updated, 595 lines] D3264: [libinput] Load/store device configuration

graesslin updated this revision to Diff 7906. graesslin added a comment. Added name as additional config group argument REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3264?vs=7905=7906 BRANCH libinput-device-load-config REVISION DETAIL

[Differential] [Commented On] D3264: [libinput] Load/store device configuration

graesslin added a comment. In https://phabricator.kde.org/D3264#60695, @strobach wrote: > It's funny (is it?) that I'm just doing the same. I should have told you I guess :) > Your solution is simpler anyway. My solution involves inputdevice.kcfg. I also wanted to use kcfg in

[Differential] [Commented On] D3264: [libinput] Load/store device configuration

graesslin added a comment. And tested on real hardware. Seems to work :-) REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3264 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel,

[Differential] [Commented On] D3264: [libinput] Load/store device configuration

strobach added a comment. It's funny (is it?) that I'm just doing the same. I should have told you I guess :) Your solution is simpler anyway. My solution involves inputdevice.kcfg. I don't think the [vendor][product] key is sufficient. I have two DELL devices here with the same product

Re: Split the kioslaves out of plasma-workspace?

On Fri, Nov 4, 2016 at 3:59 PM, Marco Martin wrote: > On Friday 04 November 2016 15:52:12 Elvis Angelaccio wrote: >> Pro: >> - plasma-workspace 5.9 could hard-depend on this new repo (they would >> have the same release schedule) >> - dolphin would have a much smaller

Re: Plasma Mobile: Nexus 5 / Multirom

Thanks for the answer. I tried again using the new guide. On installing cm-stripped.zip, I got a lot of errors (XX=number) - it can't boot from the secondary rom. > Error opening: '/data/lxc/containers/system/rootfs/dev/{ram,loop}XX' (Not a directory) What I did earlier was: ~ $ git

[Differential] [Request, 595 lines] D3264: [libinput] Load/store device configuration

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Device gets a KConfigGroup injected and supports loading

Re: Split the kioslaves out of plasma-workspace?

On Friday 04 November 2016 15:52:12 Elvis Angelaccio wrote: > Pro: > - plasma-workspace 5.9 could hard-depend on this new repo (they would > have the same release schedule) > - dolphin would have a much smaller dependency > > Cons: ? hmm, don't know how to feel about it, as to me looks a bit of

Split the kioslaves out of plasma-workspace?

Hi plasma-workspace currently ships the remote:/, applications:/ and desktop:/ kioslaves. The remote:/ one is also used by Dolphin, so currently the dolphin package has an (optional) dependency on plasma-workspace. As discussed in [1], they are 'core' kioslaves (and thus doesn't make sense to

[Differential] [Closed] D3263: fix behavior of scrollable systray popups

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEae658c33c8a6: fix behavior of scrollable systray popups (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3263?vs=7903=7904#toc REPOSITORY rPLASMAWORKSPACE

[Differential] [Accepted] D3263: fix behavior of scrollable systray popups

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. add some comment in AbstractItem. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/wheel REVISION DETAIL

[Differential] [Request, 6 lines] D3263: fix behavior of scrollable systray popups

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it's very rare that the icon list in the hidden area of the systray is long enough to get a scrollbar, but

[Differential] [Request, 42 lines] D3262: Get .desktop file name for launcher URL and activities string from KWindowInfo.

hein created this revision. hein added reviewers: Plasma, graesslin. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY The former depends on https://git.reviewboard.kde.org/r/129327/ The latter is a thematically related cleanup I did

Re: Review Request 129298: RFC: supporting dependencies on KPackage

> On Oct. 31, 2016, 5:19 p.m., Marco Martin wrote: > > autotests/data/testpackagesdep/metadata.json, line 14 > > > > > > if kns ends up using ids, maybe the server should be specified as well, > > as the id

[Differential] [Closed] D3257: Close the system tray on escape - system tray

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE926a7f71df80: Close the system tray on escape - system tray (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3259: Don't handle closing the popup ourselves

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE8b5d70f70a7e: Don't handle closing the popup ourselves (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3250: Use Plasma tooling for installing plasmoids

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP385fef3abdec: Use Plasma tooling for installing plasmoids (authored by apol). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3249: Use our tooling for installing plasmoids

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS96211d07b193: Use our tooling for installing plasmoids (authored by apol). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 451 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/451/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Nov 2016 11:12:17 + Build duration: 5 min 40 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 451 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/451/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Nov 2016 11:12:17 + Build duration: 5 min 40 sec CHANGE SET Revision

[Differential] [Closed] D3256: Close popups on escape

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP02674a356340: Close popups on escape (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3256?vs=7884=7893

[Differential] [Abandoned] D3166: make sure containment actions config is up to date

mart abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3166 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: davidedmundson, plasma-devel, lesliezhai,

[Differential] [Accepted] D3209: [Notification Applet] Position dialog before showing it

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. tested locally on x11, it seems to still work correctly INLINE COMMENTS > notificationshelper.cpp:150 > > -QTimer::singleShot(300, popup, ::show); > +

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

mart added a comment. any news on this? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. In https://phabricator.kde.org/D3210#60493, @colomar wrote: > If I understood it correctly (that there is only a checkbox "Only show full scrollbar on mouse over" added to the config) then that is exactly what I had in mind. in this latest version there are

[Differential] [Closed] D3243: [kioslave/remote] Port away from kdelibs4support

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE72e39f083a10: [kioslave/remote] Port away from kdelibs4support (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3243?vs=7853=7890#toc REPOSITORY

[Differential] [Accepted] D3231: [Lock Screen] Show "Switch User" button only if allowed

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3231 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3228: [helpers/killer] Force to platform XCB

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH killer-force-xcb-5.8 REVISION DETAIL https://phabricator.kde.org/D3228 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3243: [kioslave/remote] Port away from kdelibs4support

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH port-remote REVISION DETAIL https://phabricator.kde.org/D3243 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 450 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/450/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Nov 2016 09:49:34 + Build duration: 2 min 19 sec CHANGE SET Revision

[Differential] [Accepted] D3249: Use our tooling for installing plasmoids

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3249 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma,

[Differential] [Accepted] D3250: Use Plasma tooling for installing plasmoids

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3250 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart

[Differential] [Closed] D3253: [desktopgrid] Don't manipulate virtual desktop of desktop window

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN3c6371390d69: [desktopgrid] Don't manipulate virtual desktop of desktop window (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3257: Close the system tray on escape - system tray

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3257 EMAIL PREFERENCES

[Differential] [Accepted] D3259: Don't handle closing the popup ourselves

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3259 EMAIL PREFERENCES

[Differential] [Accepted] D3204: [KSMServer] Turn user switcher into a separate binary

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3204 EMAIL PREFERENCES

[Differential] [Commented On] D3204: [KSMServer] Turn user switcher into a separate binary

mart added a comment. +1 from me, other opinions? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3204 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, plasma-devel, lesliezhai,

[Differential] [Commented On] D3257: Close the system tray on escape - system tray

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in PlasmoidPopupsContainer.qml:30 > wouldn't this break keyboard navigation in an item if supported? (like going > up and down in the device list in the device notifier) It shouldn't. See paragraph 4 of description. However,

[Differential] [Accepted] D3253: [desktopgrid] Don't manipulate virtual desktop of desktop window

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. having desktop windows not on all desktops i guess historically is for the old feature of different wallpapers for each desktop REPOSITORY rKWIN KWin BRANCH

[Differential] [Changed Subscribers] D3257: Close the system tray on escape - system tray

mart added inline comments. INLINE COMMENTS > PlasmoidPopupsContainer.qml:30 > focus: true > -Keys.forwardTo: [currentItem] > wouldn't this break keyboard navigation in an item if supported? (like going up and down in the device list in the device notifier) REPOSITORY

[Differential] [Commented On] D3256: Close popups on escape

mart added a comment. In https://phabricator.kde.org/D3256#60552, @mart wrote: > speaking of which, i'm noticing the systray has its own popup and no esc, so adding the same thing there right now ah, seen now your other rr for the tray, nevermind :) REPOSITORY rPLASMADESKTOP

[Differential] [Request, 6 lines] D3259: Don't handle closing the popup ourselves

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Had text in text edit pressed escape twice. First pressed cleared, second closed as before (but

[Differential] [Commented On] D3256: Close popups on escape

mart added a comment. speaking of which, i'm noticing the systray has its own popup and no esc, so adding the same thing there right now REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH arcpatch-D3200 REVISION DETAIL https://phabricator.kde.org/D3256 EMAIL PREFERENCES

[Differential] [Accepted] D3256: Close popups on escape

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH arcpatch-D3200 REVISION DETAIL https://phabricator.kde.org/D3256 EMAIL PREFERENCES

[Differential] [Request, 7 lines] D3257: Close the system tray on escape - system tray

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A lot of applets have independent handling making escape close the expanded representation.

[Differential] [Request, 8 lines] D3256: Close popups on escape

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A lot of applets have independent handling making escape close the expanded representation.

Re: Review Request 128957: Make KF5Baloo optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128957/#review100555 --- Ship it! Ship It! - David Edmundson On Oct. 20, 2016,

[Differential] [Request, 3 lines] D3253: [desktopgrid] Don't manipulate virtual desktop of desktop window

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Desktop Grid has a feature that right or middle clicking a window toggles the on all desktop

[Differential] [Closed] D3247: Invert the scroll direction for wheel events on internal windows

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINda0ba7632483: Invert the scroll direction for wheel events on internal windows (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3244: Internal windows cannot be minimized

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINdb58c421eb1b: Internal windows cannot be minimized (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3244?vs=7855=7879 REVISION DETAIL

[Differential] [Changed Subscribers] D3222: Correctly set i18n suffix in mousemark spinbox.

shumski added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > KIO > +TextWidgets > NewStuff > Note, "new" dependency was already linked implicitly in other kwin, but we > need to add it for this KCM. For completeness sake, ktextwidgets devel files where not present in